[GitHub] [flink] ashangit commented on pull request #22415: [FLINK-31812][api] Transform savepoint path to null if empty in body

2023-04-26 Thread via GitHub
ashangit commented on PR #22415: URL: https://github.com/apache/flink/pull/22415#issuecomment-1522901411 @czy006 could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [flink] fredia commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-26 Thread via GitHub
fredia commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1522912405 My local CI https://dev.azure.com/fredia/flink/_build/results?buildId=518&view=results has passed. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gaborgsomogyi commented on code in PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576#discussion_r1177452047 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestUtils.java: ## @@ -397,5 +398,10 @@ public ManagedDependentRe

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gaborgsomogyi commented on PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1522918007 Looks good, but CI is failing so restarted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (FLINK-27018) timestamp missing end zero when outputing to kafka

2023-04-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-27018: -- Assignee: Yao Zhang > timestamp missing end zero when outputing to kafka > -

[GitHub] [flink-connector-jdbc] matriv commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-04-26 Thread via GitHub
matriv commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1522922001 @eskabetxe Could you take a look to finish up this PR please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Closed] (FLINK-31939) ClassNotFoundException on org.apache.beam.runners.flink.translation.wrappers.SourceInputFormat when running Flink 1.14 and up with Beam 2.46.0

2023-04-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31939. -- Resolution: Invalid I would recommend to first reach out to the Beam community; this most like

[jira] [Created] (FLINK-31944) Protobuf format throw com.google.protobuf.InvalidProtocolBufferException

2023-04-26 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-31944: -- Summary: Protobuf format throw com.google.protobuf.InvalidProtocolBufferException Key: FLINK-31944 URL: https://issues.apache.org/jira/browse/FLINK-31944 Project: Flink

[GitHub] [flink] zentol merged pull request #22486: [FLINK-31935] Register handlers for resource requirements endpoints i…

2023-04-26 Thread via GitHub
zentol merged PR #22486: URL: https://github.com/apache/flink/pull/22486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-31935) The new resource requirements REST API is only available for session clusters

2023-04-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-31935. Fix Version/s: 1.18.0 Resolution: Fixed master: 3acb76dcf450f9136dec150124db901d1a9

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gaborgsomogyi commented on PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1522955983 ``` 2023-04-26T07:40:21.5290369Z Please generate the java doc via 'mvn clean install -DskipTests -Pgenerate-docs' again ``` -- This is an automated mess

[GitHub] [flink-connector-aws] vahmed-hamdy commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-04-26 Thread via GitHub
vahmed-hamdy commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1177447977 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java: ## @@ -0,0 +1,148 @@ +/* + * Lic

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-04-26 Thread via GitHub
dannycranmer commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177501504 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ## @@ -144,6 +150,8 @@

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-04-26 Thread via GitHub
dannycranmer commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177504112 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ## @@ -144,6 +150,8 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gyfora commented on code in PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576#discussion_r1177506567 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestUtils.java: ## @@ -397,5 +398,10 @@ public ManagedDependentResourceC

[GitHub] [flink-connector-aws] vahmed-hamdy commented on a diff in pull request #70: [FLINK-31772] Adjusting Kinesis Ratelimiting strategy to fix performance regression

2023-04-26 Thread via GitHub
vahmed-hamdy commented on code in PR #70: URL: https://github.com/apache/flink-connector-aws/pull/70#discussion_r1177508026 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java: ## @@ -144,6 +150,8 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #567: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-04-26 Thread via GitHub
gyfora commented on PR #567: URL: https://github.com/apache/flink-kubernetes-operator/pull/567#issuecomment-1522982917 Can you please also update the [NOTICE](https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/src/main/resources/META-INF/NOTICE) file ac

[GitHub] [flink] luoyuxia opened a new pull request, #22488: [FLINK-31882][sql-client] Fix sql client can't show result for DELETE statement when delete is pushed down

2023-04-26 Thread via GitHub
luoyuxia opened a new pull request, #22488: URL: https://github.com/apache/flink/pull/22488 ## What is the purpose of the change To fix sql client can't show result for DELETE statement when delete is pushed down ## Brief change log Check the `ModifyOperation` is `De

[GitHub] [flink] luoyuxia commented on pull request #22488: [FLINK-31882][sql-client] Fix sql client can't show result for DELETE statement when delete is pushed down

2023-04-26 Thread via GitHub
luoyuxia commented on PR #22488: URL: https://github.com/apache/flink/pull/22488#issuecomment-1522987980 cc @fsk119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Updated] (FLINK-31882) SqlGateway will throw exception when executing DeleteFromFilterOperation

2023-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31882: --- Labels: pull-request-available (was: ) > SqlGateway will throw exception when executing Del

[GitHub] [flink] flinkbot commented on pull request #22488: [FLINK-31882][sql-client] Fix sql client can't show result for DELETE statement when delete is pushed down

2023-04-26 Thread via GitHub
flinkbot commented on PR #22488: URL: https://github.com/apache/flink/pull/22488#issuecomment-1522995005 ## CI report: * 615ede03c4665684e774fc0d1f753e90d81cfc88 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Zouxxyy commented on pull request #18309: [FLINK-25582] [TABLE SQL / API] flink sql kafka source cannot special custom parallelism

2023-04-26 Thread via GitHub
Zouxxyy commented on PR #18309: URL: https://github.com/apache/flink/pull/18309#issuecomment-1523004866 @springMoon @lmagic233 Hi, does Kafka now support config source parallelism? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-26 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1177535915 ## flink-test-utils-parent/flink-migration-test-utils/src/main/java/org/apache/flink/test/migration/MigrationTestsSnapshotGenerator.java: ## @@ -0,0 +1,253 @@ +/* +

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #33: [FLINK-27429] Add Vertica JDBC dialect

2023-04-26 Thread via GitHub
eskabetxe commented on code in PR #33: URL: https://github.com/apache/flink-connector-jdbc/pull/33#discussion_r1177531154 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/vertica/VerticaDialect.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apac

[GitHub] [flink] novakov-alexey opened a new pull request, #22489: [hotfix][docs] Fix link to Ververica Platform

2023-04-26 Thread via GitHub
novakov-alexey opened a new pull request, #22489: URL: https://github.com/apache/flink/pull/22489 ## What is the purpose of the change this PR is fixing broken link for [Ververica platform](https://www.ververica.com/platform). ## Verifying this change Please make

[GitHub] [flink] flinkbot commented on pull request #22489: [hotfix][docs] Fix link to Ververica Platform

2023-04-26 Thread via GitHub
flinkbot commented on PR #22489: URL: https://github.com/apache/flink/pull/22489#issuecomment-1523029805 ## CI report: * 8dda76e9f810047eb44dfb4ad2e997315cf7c8c0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-kubernetes-operator] gaborgsomogyi merged pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gaborgsomogyi merged PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gyfora commented on PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1523042788 > Thanks, using this to verify @gaborgsomogyi's committership privileges. 😏 let's gooo 🚢 -- This is an automated message from the Apache Git Service. To respond t

[jira] [Closed] (FLINK-31886) Upgrade to fabric8 6.5.1 and JOSDK 4.3.0

2023-04-26 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-31886. - Resolution: Fixed d9b3437 on main. > Upgrade to fabric8 6.5.1 and JOSDK 4.3.0 > ---

[GitHub] [flink] pnowojski commented on a diff in pull request #22432: [FLINK-18808][runtime] Include side outputs in numRecordsOut metric

2023-04-26 Thread via GitHub
pnowojski commented on code in PR #22432: URL: https://github.com/apache/flink/pull/22432#discussion_r1177575706 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/BroadcastingOutputCollector.java: ## @@ -17,52 +17,77 @@ package org.apache.flink.st

[jira] [Created] (FLINK-31945) Table of contents in the blogs of the project website is missing some titles

2023-04-26 Thread Zhilong Hong (Jira)
Zhilong Hong created FLINK-31945: Summary: Table of contents in the blogs of the project website is missing some titles Key: FLINK-31945 URL: https://issues.apache.org/jira/browse/FLINK-31945 Project:

[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version

2023-04-26 Thread via GitHub
gaborgsomogyi commented on PR #576: URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1523061956 :shipit: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] reswqa commented on pull request #22445: [FLINK-31876][QS] Migrate flink-queryable-state-client tests to JUnit5

2023-04-26 Thread via GitHub
reswqa commented on PR #22445: URL: https://github.com/apache/flink/pull/22445#issuecomment-1523068717 > My local CI https://dev.azure.com/fredia/flink/_build/results?buildId=518&view=results has passed. I have squashed and rebased this to origin/master to see if it can pass CI. --

[GitHub] [flink-kubernetes-operator] mxm merged pull request #573: [FLINK-31866] Start metric window with timestamp of first observation

2023-04-26 Thread via GitHub
mxm merged PR #573: URL: https://github.com/apache/flink-kubernetes-operator/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (FLINK-26974) Python EmbeddedThreadDependencyTests.test_add_python_file failed on azure

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716625#comment-17716625 ] Sergey Nuyanzin commented on FLINK-26974: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716628#comment-17716628 ] Sergey Nuyanzin commented on FLINK-26515: - master(1.18): https://dev.azure.com/

[jira] [Updated] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-26515: Affects Version/s: 1.18.0 > RetryingExecutorTest. testDiscardOnTimeout failed on azure > -

[GitHub] [flink-training] San-ctuary opened a new pull request, #58: [hotfix] fix link bug

2023-04-26 Thread via GitHub
San-ctuary opened a new pull request, #58: URL: https://github.com/apache/flink-training/pull/58 fix the link error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[jira] [Commented] (FLINK-31168) JobManagerHAProcessFailureRecoveryITCase failed due to job not being found

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716630#comment-17716630 ] Sergey Nuyanzin commented on FLINK-31168: - master(1.18): https://dev.azure.com/

[jira] [Updated] (FLINK-31168) JobManagerHAProcessFailureRecoveryITCase failed due to job not being found

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-31168: Affects Version/s: 1.18.0 > JobManagerHAProcessFailureRecoveryITCase failed due to job not

[jira] [Updated] (FLINK-30141) MinioTestContainerTest failed due to IllegalStateException in container startup

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-30141: Affects Version/s: 1.18.0 > MinioTestContainerTest failed due to IllegalStateException in

[jira] [Commented] (FLINK-30141) MinioTestContainerTest failed due to IllegalStateException in container startup

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716636#comment-17716636 ] Sergey Nuyanzin commented on FLINK-30141: - https://dev.azure.com/apache-flink/ap

[GitHub] [flink] LadyForest commented on pull request #22478: [FLINK-31917][table-planner] Fix the idempotence lost in JsonSerDe round trip for AggregateCall and RexNode

2023-04-26 Thread via GitHub
LadyForest commented on PR #22478: URL: https://github.com/apache/flink/pull/22478#issuecomment-1523115946 @godfreyhe, would you mind sparing some time to review the fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716638#comment-17716638 ] Sergey Nuyanzin commented on FLINK-25343: - https://dev.azure.com/apache-flink/ap

[jira] [Updated] (FLINK-25343) HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

2023-04-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-25343: Affects Version/s: 1.17.1 > HBaseConnectorITCase.testTableSourceSinkWithDDL fail on azure

[jira] [Commented] (FLINK-31944) Protobuf format throw com.google.protobuf.InvalidProtocolBufferException

2023-04-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716663#comment-17716663 ] Benchao Li commented on FLINK-31944: CC [~maosuhan] > Protobuf format throw com.goo

[jira] [Assigned] (FLINK-31883) StreamSQLExample.Order has nullability issues

2023-04-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-31883: -- Assignee: chenyu > StreamSQLExample.Order has nullability issues > --

[GitHub] [flink] TanYuxin-tyx commented on pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager

2023-04-26 Thread via GitHub
TanYuxin-tyx commented on PR #22352: URL: https://github.com/apache/flink/pull/22352#issuecomment-1523266865 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [flink] luoyuxia commented on a diff in pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-04-26 Thread via GitHub
luoyuxia commented on code in PR #22166: URL: https://github.com/apache/flink/pull/22166#discussion_r1177746826 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java: ## @@ -331,20 +333,48 @@ public Operati

[GitHub] [flink] luoyuxia commented on pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-04-26 Thread via GitHub
luoyuxia commented on PR #22166: URL: https://github.com/apache/flink/pull/22166#issuecomment-1523271352 > Thank you for the update. I think this is in good shape. During reviewing the code, I find the methods of `CatalogRegistry` are not smooth to use. For example, > > 1. the `Resol

[GitHub] [flink] luoyuxia commented on pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-04-26 Thread via GitHub
luoyuxia commented on PR #22166: URL: https://github.com/apache/flink/pull/22166#issuecomment-1523276120 @wuchong Thanks for your review. I have addressed your comments in [9e508a](https://github.com/apache/flink/pull/22166/commits/9e508ab847053ae91f65afa5bca929a079a76e79), [9a5350](http

[GitHub] [flink] libenchao commented on pull request #22362: [FLINK-31544][jdbc-driver] Introduce database metadata for jdbc driver

2023-04-26 Thread via GitHub
libenchao commented on PR #22362: URL: https://github.com/apache/flink/pull/22362#issuecomment-1523277660 @FangYongs The CI fails now, could you fix that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] libenchao closed pull request #22417: [FLINK-31543][jdbc-driver] Introduce statement for flink jdbc driver

2023-04-26 Thread via GitHub
libenchao closed pull request #22417: [FLINK-31543][jdbc-driver] Introduce statement for flink jdbc driver URL: https://github.com/apache/flink/pull/22417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Closed] (FLINK-31543) Introduce FlinkStatement for jdbc driver

2023-04-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-31543. -- Fix Version/s: 1.18.0 Resolution: Fixed Fixed via https://github.com/apache/flink/commit/63166

[GitHub] [flink] TanYuxin-tyx commented on pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5

2023-04-26 Thread via GitHub
TanYuxin-tyx commented on PR #22427: URL: https://github.com/apache/flink/pull/22427#issuecomment-1523290741 @JunRuiLee Thanks for joining the review. Considering that the two base classes have many table-related and Scala-related subclasses, it is indeed necessary to upgrade all the subcla

[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-04-26 Thread via GitHub
z3d1k commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1177831924 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/HashShardAssigner.java: ## @@ -0,0 +1,36 @@ +/* + * Lic

[GitHub] [flink] ericxiao251 commented on a diff in pull request #22438: [FLINK-31873] Add method setMaxParallelism to DataStreamSink.

2023-04-26 Thread via GitHub
ericxiao251 commented on code in PR #22438: URL: https://github.com/apache/flink/pull/22438#discussion_r1177962682 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -283,6 +283,25 @@ public void testTransformati

[jira] [Updated] (FLINK-31873) Add setMaxParallelism to the DataStreamSink Class

2023-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31873: --- Labels: pull-request-available (was: ) > Add setMaxParallelism to the DataStreamSink Class

[GitHub] [flink-connector-aws] dannycranmer merged pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x

2023-04-26 Thread via GitHub
dannycranmer merged PR #67: URL: https://github.com/apache/flink-connector-aws/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #67: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 3.x

2023-04-26 Thread via GitHub
boring-cyborg[bot] commented on PR #67: URL: https://github.com/apache/flink-connector-aws/pull/67#issuecomment-1523521621 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-connector-aws] dannycranmer merged pull request #68: [FLINK-31675][Connectors/AWS] Update AWS SDKv2 to v2.20.32 for 4.x

2023-04-26 Thread via GitHub
dannycranmer merged PR #68: URL: https://github.com/apache/flink-connector-aws/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (FLINK-31675) Deadlock in AWS Connectors following content-length AWS SDK exception

2023-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716752#comment-17716752 ] Danny Cranmer commented on FLINK-31675: --- Merged commit [{{9a51b52}}|https://githu

[jira] [Updated] (FLINK-31675) Deadlock in AWS Connectors following content-length AWS SDK exception

2023-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-31675: -- Fix Version/s: (was: 1.15.5) > Deadlock in AWS Connectors following content-length AWS SDK

[jira] [Commented] (FLINK-31675) Deadlock in AWS Connectors following content-length AWS SDK exception

2023-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716753#comment-17716753 ] Danny Cranmer commented on FLINK-31675: --- Dropping from 1.15.5 since 1.15.x is no l

[jira] [Resolved] (FLINK-31675) Deadlock in AWS Connectors following content-length AWS SDK exception

2023-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-31675. --- Resolution: Fixed > Deadlock in AWS Connectors following content-length AWS SDK exception >

[GitHub] [flink] ericxiao251 commented on a diff in pull request #22438: [FLINK-31873] Add method setMaxParallelism to DataStreamSink.

2023-04-26 Thread via GitHub
ericxiao251 commented on code in PR #22438: URL: https://github.com/apache/flink/pull/22438#discussion_r1177975477 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -283,6 +283,25 @@ public void testTransformati

[jira] [Reopened] (FLINK-28786) Cannot run PyFlink 1.16 on MacOS with M1 chip

2023-04-26 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reopened FLINK-28786: - Reopen it as one user reported an issue related to Mac M1 (https://apache-flink.slack.com/archives/C03G7LJT

[jira] [Comment Edited] (FLINK-28786) Cannot run PyFlink 1.16 on MacOS with M1 chip

2023-04-26 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716757#comment-17716757 ] Dian Fu edited comment on FLINK-28786 at 4/26/23 2:41 PM: -- Reop

[GitHub] [flink] dianfu opened a new pull request, #22490: [FLINK-28786][python] Check if cython could be enabled in only one place

2023-04-26 Thread via GitHub
dianfu opened a new pull request, #22490: URL: https://github.com/apache/flink/pull/22490 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[GitHub] [flink] ericxiao251 commented on a diff in pull request #22438: [FLINK-31873] Add method setMaxParallelism to DataStreamSink.

2023-04-26 Thread via GitHub
ericxiao251 commented on code in PR #22438: URL: https://github.com/apache/flink/pull/22438#discussion_r1177975477 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -283,6 +283,25 @@ public void testTransformati

[GitHub] [flink] ericxiao251 commented on pull request #22438: [FLINK-31873] Add method setMaxParallelism to DataStreamSink.

2023-04-26 Thread via GitHub
ericxiao251 commented on PR #22438: URL: https://github.com/apache/flink/pull/22438#issuecomment-1523579845 > Oh, I notice that the jira id in PR title and commit message is wrong, it should be [FLINK-31873](https://issues.apache.org/jira/browse/FLINK-31873) Ah thanks for pointing thi

[GitHub] [flink] flinkbot commented on pull request #22490: [FLINK-28786][python] Check if cython could be enabled in only one place

2023-04-26 Thread via GitHub
flinkbot commented on PR #22490: URL: https://github.com/apache/flink/pull/22490#issuecomment-1523582514 ## CI report: * bf1692c3acee22135bd81e5a96ce5158f1892ae1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-26 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1178099467 ## flink-test-utils-parent/flink-migration-test-utils/src/main/java/org/apache/flink/test/migration/SnapshotGeneratorUtils.java: ## @@ -0,0 +1,178 @@ +/* + * License

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-26 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1178126387 ## flink-test-utils-parent/flink-migration-test-utils/README.md: ## @@ -0,0 +1,103 @@ +# Add State Migration Tests + +This module collects tools that help to generat

[jira] [Created] (FLINK-31946) DynamoDB Sink Allow Multiple Item Writes

2023-04-26 Thread Curtis Jensen (Jira)
Curtis Jensen created FLINK-31946: - Summary: DynamoDB Sink Allow Multiple Item Writes Key: FLINK-31946 URL: https://issues.apache.org/jira/browse/FLINK-31946 Project: Flink Issue Type: Improv

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #577: [FLINK-31860] Ignore Event creation errors during cleanup

2023-04-26 Thread via GitHub
gyfora opened a new pull request, #577: URL: https://github.com/apache/flink-kubernetes-operator/pull/577 ## What is the purpose of the change The current logic tries to create Kubernetes events even during cleanup steps, failing to create them leads to a retry loop and a stuck delete

[jira] [Updated] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31860: --- Labels: pull-request-available (was: ) > FlinkDeployments never finalize when namespace is

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #577: [FLINK-31860] Ignore Event creation errors during cleanup

2023-04-26 Thread via GitHub
gyfora commented on PR #577: URL: https://github.com/apache/flink-kubernetes-operator/pull/577#issuecomment-1523730777 I still need to test this on minikube and make sure that ignoring event errors is enough during namespace deletion or whether we also need to handle status updates the sam

[jira] [Commented] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716805#comment-17716805 ] Gyula Fora commented on FLINK-31860: [~isugimpy] , the PR is ready, please help revi

[jira] [Commented] (FLINK-31946) DynamoDB Sink Allow Multiple Item Writes

2023-04-26 Thread Curtis Jensen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716811#comment-17716811 ] Curtis Jensen commented on FLINK-31946: --- I attempted to fork the flink-connector-a

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-26 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1178143564 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java: ## @@ -20,15 +20,14

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-26 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1178144717 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java: ## @@ -52,9 +51,6 @

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-26 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1178144717 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java: ## @@ -52,9 +51,6 @

[jira] [Created] (FLINK-31947) Enable stdout redirect in flink-console.sh

2023-04-26 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-31947: - Summary: Enable stdout redirect in flink-console.sh Key: FLINK-31947 URL: https://issues.apache.org/jira/browse/FLINK-31947 Project: Flink Issue Type: Impr

[GitHub] [flink] HuangZhenQiu opened a new pull request, #22491: [FLINK-31947] enable stdout for flink-console.sh

2023-04-26 Thread via GitHub
HuangZhenQiu opened a new pull request, #22491: URL: https://github.com/apache/flink/pull/22491 ## What is the purpose of the change Add stdout redirection in flink-console.sh, so that flink Kubernetes applications can fetch the stdout log in web ui. ## Brief change log

[jira] [Updated] (FLINK-31947) Enable stdout redirect in flink-console.sh

2023-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31947: --- Labels: pull-request-available (was: ) > Enable stdout redirect in flink-console.sh > -

[GitHub] [flink] flinkbot commented on pull request #22491: [FLINK-31947] enable stdout for flink-console.sh

2023-04-26 Thread via GitHub
flinkbot commented on PR #22491: URL: https://github.com/apache/flink/pull/22491#issuecomment-1523787348 ## CI report: * f9df33cd1266ffd00208dc98d2661c9226f00c8c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-26 Thread Jayme Howard (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716832#comment-17716832 ] Jayme Howard commented on FLINK-31860: -- This looks very reasonable to me as written

[jira] [Updated] (FLINK-31780) Allow users to disable "Ensemble tracking" for ZooKeeper

2023-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-31780: Description: In Apache Curator an option to skip ensemble tracking was added since

[GitHub] [flink-connector-jdbc] jredzepovic commented on a diff in pull request #33: [FLINK-27429] Add Vertica JDBC dialect

2023-04-26 Thread via GitHub
jredzepovic commented on code in PR #33: URL: https://github.com/apache/flink-connector-jdbc/pull/33#discussion_r1178197426 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/vertica/VerticaDatabase.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the

[GitHub] [flink-connector-jdbc] jredzepovic commented on a diff in pull request #33: [FLINK-27429] Add Vertica JDBC dialect

2023-04-26 Thread via GitHub
jredzepovic commented on code in PR #33: URL: https://github.com/apache/flink-connector-jdbc/pull/33#discussion_r1178198860 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/vertica/VerticaDialect.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Ap

[GitHub] [flink-connector-jdbc] jredzepovic commented on a diff in pull request #33: [FLINK-27429] Add Vertica JDBC dialect

2023-04-26 Thread via GitHub
jredzepovic commented on code in PR #33: URL: https://github.com/apache/flink-connector-jdbc/pull/33#discussion_r1178199595 ## docs/content.zh/docs/connectors/table/jdbc.md: ## @@ -663,20 +668,22 @@ Flink 支持连接到多个使用方言(dialect)的数据库,如 MySQL、O BIGINT BIGSERIAL

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-04-26 Thread SwathiChandrashekar (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716845#comment-17716845 ] SwathiChandrashekar commented on FLINK-31135: - I missed your previous commen

[GitHub] [flink-connector-jdbc] jredzepovic commented on pull request #33: [FLINK-27429] Add Vertica JDBC dialect

2023-04-26 Thread via GitHub
jredzepovic commented on PR #33: URL: https://github.com/apache/flink-connector-jdbc/pull/33#issuecomment-1523870058 Hi @eskabetxe, thank you for your review! I went through the open pull requests to check if there is a common format for the PR description and ended up copying yours

[GitHub] [flink-connector-kafka] mas-chen opened a new pull request, #25: [FLINK-30859] Sync flink sql client test

2023-04-26 Thread via GitHub
mas-chen opened a new pull request, #25: URL: https://github.com/apache/flink-connector-kafka/pull/25 final code to move, before Kafka code can be deleted from master branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] nateab commented on a diff in pull request #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-04-26 Thread via GitHub
nateab commented on code in PR #22359: URL: https://github.com/apache/flink/pull/22359#discussion_r1178509636 ## flink-table/flink-table-planner-loader/pom.xml: ## @@ -44,13 +44,11 @@ flink-table-api-bridge-base ${project.version}

[GitHub] [flink] nateab commented on pull request #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-04-26 Thread via GitHub
nateab commented on PR #22359: URL: https://github.com/apache/flink/pull/22359#issuecomment-1524274234 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] luoyuxia commented on pull request #22488: [FLINK-31882][sql-client] Fix sql client can't show result for DELETE statement when delete is pushed down

2023-04-26 Thread via GitHub
luoyuxia commented on PR #22488: URL: https://github.com/apache/flink/pull/22488#issuecomment-1524413630 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] luoyuxia closed pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-04-26 Thread via GitHub
luoyuxia closed pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces URL: https://github.com/apache/flink/pull/22166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FLINK-31948) Supports triggering CI manually

2023-04-26 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-31948: - Summary: Supports triggering CI manually Key: FLINK-31948 URL: https://issues.apache.org/jira/browse/FLINK-31948 Project: Flink Issue Type: Improvement C

  1   2   >