[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

2023-05-03 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719153#comment-17719153 ] Weijie Guo commented on FLINK-31495: > IMHO this is not a problem, if you mouseover the selection,

[jira] [Closed] (FLINK-20257) Flink web-ui metrics page add metrics selector Can't see the full name of the metics

2023-05-03 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-20257. -- Resolution: Duplicate > Flink web-ui metrics page add metrics selector Can't see the full name of >

[jira] [Closed] (FLINK-16570) Difficulties to select correct metric with long name in dropdown of Flink UI task menu

2023-05-03 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-16570. -- Resolution: Duplicate > Difficulties to select correct metric with long name in dropdown of Flink UI

[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

2023-05-03 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719152#comment-17719152 ] Weijie Guo commented on FLINK-31495: Thanks [~haoyan.zhang] and [~netvl] for the reply. I'm a bit

[GitHub] [flink-connector-jdbc] reswqa commented on pull request #45: [hotfix] Fix incorrect sql_url in jdbc.yml.

2023-05-03 Thread via GitHub
reswqa commented on PR #45: URL: https://github.com/apache/flink-connector-jdbc/pull/45#issuecomment-1534099697 @leonardBang would you mind taking a look at this? Thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-connector-jdbc] reswqa commented on a diff in pull request #45: [hotfix] Fix incorrect sql_url in jdbc.yml.

2023-05-03 Thread via GitHub
reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-jdbc/pull/45#discussion_r1184544224 ## docs/data/jdbc.yml: ## @@ -18,4 +18,4 @@ variants: - maven: flink-connector-jdbc -sql_url:

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-05-03 Thread SwathiChandrashekar (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719148#comment-17719148 ] SwathiChandrashekar commented on FLINK-31135: - That's great [~zhihaochen] :) [~zhihaochen]

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-05-03 Thread Zhihao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719145#comment-17719145 ] Zhihao Chen commented on FLINK-31135: - It's working as expected now after we fixed our S3 deletion

[jira] [Created] (FLINK-31994) Update copyright in NOTICE files of flink-shaded

2023-05-03 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-31994: -- Summary: Update copyright in NOTICE files of flink-shaded Key: FLINK-31994 URL: https://issues.apache.org/jira/browse/FLINK-31994 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719144#comment-17719144 ] Weijie Guo commented on FLINK-31974: Thanks Xintong for the analysis and proposal, It makes sense to

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-31759) Update some external connectors to use sql_connector_download_table and connector_artifact shortcode

2023-05-03 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719142#comment-17719142 ] Weijie Guo commented on FLINK-31759: Thanks [~leonard], good catch. Maybe we only need to modify

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-web] leonardBang commented on a diff in pull request #637: Add GCP Pubsub v3.0.1 for Flink 1.16.x and Flink 1.17.x

2023-05-03 Thread via GitHub
leonardBang commented on code in PR #637: URL: https://github.com/apache/flink-web/pull/637#discussion_r1184519299 ## docs/data/release_archive.yml: ## @@ -428,6 +428,16 @@ release_archive: version: 1.0.0 release_date: 2022-12-21 filename: "opensearch" +

[GitHub] [flink-web] leonardBang commented on a diff in pull request #638: Add JDBC v3.1.0 for Flink 1.16.x and Flink 1.17.x

2023-05-03 Thread via GitHub
leonardBang commented on code in PR #638: URL: https://github.com/apache/flink-web/pull/638#discussion_r1184517275 ## docs/data/release_archive.yml: ## @@ -428,6 +428,11 @@ release_archive: version: 1.0.0 release_date: 2022-12-21 filename: "opensearch" +

[jira] [Reopened] (FLINK-31759) Update some external connectors to use sql_connector_download_table and connector_artifact shortcode

2023-05-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reopened FLINK-31759: JDBC connector has not sql jar, the link is wrong, reopen this issue to fix

[jira] [Commented] (FLINK-31110) Web UI shows "User Configuration" preserving lines and whitespaces

2023-05-03 Thread Junhan Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719135#comment-17719135 ] Junhan Yang commented on FLINK-31110: - master: 246c17b8aeb75e66057d3d663d0c1a127108bc2e > Web UI

[jira] [Resolved] (FLINK-31110) Web UI shows "User Configuration" preserving lines and whitespaces

2023-05-03 Thread Junhan Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang resolved FLINK-31110. - Assignee: Mingliang Liu Resolution: Fixed > Web UI shows "User Configuration" preserving

[GitHub] [flink] masteryhx commented on a diff in pull request #21140: [FLINK-25909][runtime][security] Add HBaseDelegationTokenProvider

2023-05-03 Thread via GitHub
masteryhx commented on code in PR #21140: URL: https://github.com/apache/flink/pull/21140#discussion_r1184513048 ## flink-runtime/src/main/resources/META-INF/services/org.apache.flink.runtime.security.token.DelegationTokenProvider: ## @@ -14,3 +14,4 @@ # limitations under the

[GitHub] [flink] masteryhx commented on a diff in pull request #21140: [FLINK-25909][runtime][security] Add HBaseDelegationTokenProvider

2023-05-03 Thread via GitHub
masteryhx commented on code in PR #21140: URL: https://github.com/apache/flink/pull/21140#discussion_r1184513048 ## flink-runtime/src/main/resources/META-INF/services/org.apache.flink.runtime.security.token.DelegationTokenProvider: ## @@ -14,3 +14,4 @@ # limitations under the

[GitHub] [flink] yangjunhan merged pull request #21954: [FLINK-31110][web] Show "User Configuration" preserving lines and whitespaces

2023-05-03 Thread via GitHub
yangjunhan merged PR #21954: URL: https://github.com/apache/flink/pull/21954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pgaref commented on a diff in pull request #22481: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184510094 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/PhysicalWriterImpl.java: ## @@ -1,398 +0,0 @@ -/* - * Licensed to the Apache Software Foundation

[GitHub] [flink-kubernetes-operator] yangjf2019 closed pull request #578: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-05-03 Thread via GitHub
yangjf2019 closed pull request #578: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency URL: https://github.com/apache/flink-kubernetes-operator/pull/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #578: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-05-03 Thread via GitHub
yangjf2019 commented on PR #578: URL: https://github.com/apache/flink-kubernetes-operator/pull/578#issuecomment-1534036478 Okay,Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #22516: [FLINK-31993][runtime] Initialize and pass down JobMaster FailureEnrichers

2023-05-03 Thread via GitHub
flinkbot commented on PR #22516: URL: https://github.com/apache/flink/pull/22516#issuecomment-1534029801 ## CI report: * 01337b1d8951dfccb8212e0d19d8d5b690cb37c5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-web] leonardBang commented on a diff in pull request #633: Add Pulsar v4.0.0 for Flink 1.17.x

2023-05-03 Thread via GitHub
leonardBang commented on code in PR #633: URL: https://github.com/apache/flink-web/pull/633#discussion_r1184496847 ## docs/data/flink_connectors.yml: ## @@ -57,12 +57,19 @@ opensearch: source_release_sha512_url:

[jira] [Updated] (FLINK-31993) Initialize and pass down JobMaster FailureEnrichers

2023-05-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31993: --- Labels: pull-request-available (was: ) > Initialize and pass down JobMaster

[GitHub] [flink] pgaref opened a new pull request, #22516: [FLINK-31993][runtime] Initialize and pass down JobMaster FailureEnrichers

2023-05-03 Thread via GitHub
pgaref opened a new pull request, #22516: URL: https://github.com/apache/flink/pull/22516 https://issues.apache.org/jira/browse/FLINK-31993 Initialize valid failure enrichers as part of the ClusterEndpoint (to avoid performing the same task per JM initialization). The set of

[GitHub] [flink] fredia commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-05-03 Thread via GitHub
fredia commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1184493394 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -394,18 +394,14 @@ public void confirm(SequenceNumber from,

[GitHub] [flink-web] leonardBang commented on a diff in pull request #639: Add RabbitMQ v3.0.1 for Flink 1.16.x and Flink 1.17.x

2023-05-03 Thread via GitHub
leonardBang commented on code in PR #639: URL: https://github.com/apache/flink-web/pull/639#discussion_r1184487003 ## docs/data/release_archive.yml: ## @@ -428,6 +428,10 @@ release_archive: version: 1.0.0 release_date: 2022-12-21 filename: "opensearch" +

[jira] [Updated] (FLINK-31993) Initialize and pass down JobMaster FailureEnrichers

2023-05-03 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31993: --- Summary: Initialize and pass down JobMaster FailureEnrichers (was:

[jira] [Updated] (FLINK-31993) Initialize JobMaster FailureEnricher configuration

2023-05-03 Thread Panagiotis Garefalakis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Panagiotis Garefalakis updated FLINK-31993: --- Summary: Initialize JobMaster FailureEnricher configuration (was:

[GitHub] [flink] flinkbot commented on pull request #22515: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan.

2023-05-03 Thread via GitHub
flinkbot commented on PR #22515: URL: https://github.com/apache/flink/pull/22515#issuecomment-1533999828 ## CI report: * 4c5daa9907351d96f9d82bb0dc96d50cf51a7686 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31917) Loss of Idempotence in JsonSerDe Round Trip for AggregateCall and RexNode

2023-05-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719123#comment-17719123 ] Shengkai Fang commented on FLINK-31917: --- Merged into master:

[GitHub] [flink] fsk119 merged pull request #22478: [FLINK-31917][table-planner] Fix the idempotence lost in JsonSerDe round trip for AggregateCall and RexNode

2023-05-03 Thread via GitHub
fsk119 merged PR #22478: URL: https://github.com/apache/flink/pull/22478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] xishuaidelin opened a new pull request, #22515: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan.

2023-05-03 Thread via GitHub
xishuaidelin opened a new pull request, #22515: URL: https://github.com/apache/flink/pull/22515 ## What is the purpose of the change * This pull request support 'EXPLAIN' statement for CompiledPlan which contributes to the FLINK-31791 ## Brief change log -

[GitHub] [flink] chenyu-opensource commented on pull request #22456: [FLINK-31883] Using the unboxed types that prevent nullability issues

2023-05-03 Thread via GitHub
chenyu-opensource commented on PR #22456: URL: https://github.com/apache/flink/pull/22456#issuecomment-1533991732 @MartijnVisser please review,thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (FLINK-31495) Improve metrics tab on flink ui

2023-05-03 Thread zhang haoyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhang haoyan closed FLINK-31495. Resolution: Duplicate > Improve metrics tab on flink ui > --- > >

[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

2023-05-03 Thread zhang haoyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719118#comment-17719118 ] zhang haoyan commented on FLINK-31495: -- so sad,  closed since it is duplicated > Improve metrics

[GitHub] [flink] xishuaidelin closed pull request #22514: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan.

2023-05-03 Thread via GitHub
xishuaidelin closed pull request #22514: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan. URL: https://github.com/apache/flink/pull/22514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719116#comment-17719116 ] Xintong Song commented on FLINK-31974: -- Thanks [~sergiosp] for reporting, and thanks [~mapohl] for

[GitHub] [flink] flinkbot commented on pull request #22514: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan.

2023-05-03 Thread via GitHub
flinkbot commented on PR #22514: URL: https://github.com/apache/flink/pull/22514#issuecomment-1533955747 ## CI report: * 87c03fb0404077e8cfa4c90af14535217fb55fad UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22513: Bump engine.io and socket.io in /flink-runtime-web/web-dashboard

2023-05-03 Thread via GitHub
flinkbot commented on PR #22513: URL: https://github.com/apache/flink/pull/22513#issuecomment-1533955623 ## CI report: * 3ddc08ff9c5482d89dcb490dfa1b486a5c4991d1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] xishuaidelin opened a new pull request, #22514: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan.

2023-05-03 Thread via GitHub
xishuaidelin opened a new pull request, #22514: URL: https://github.com/apache/flink/pull/22514 ## What is the purpose of the change * This pull request support 'EXPLAIN' statement for CompiledPlan which contributes to the FLINK-31791 ## Brief change log -

[GitHub] [flink] dependabot[bot] opened a new pull request, #22513: Bump engine.io and socket.io in /flink-runtime-web/web-dashboard

2023-05-03 Thread via GitHub
dependabot[bot] opened a new pull request, #22513: URL: https://github.com/apache/flink/pull/22513 Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `engine.io` from

[GitHub] [flink] xishuaidelin closed pull request #22497: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan.

2023-05-03 Thread via GitHub
xishuaidelin closed pull request #22497: [FLINK-31952][table] Support 'EXPLAIN' statement for CompiledPlan. URL: https://github.com/apache/flink/pull/22497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1184449298 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobMasterServiceFactory.java: ## @@ -122,6 +123,7 @@ private JobMasterService

[GitHub] [flink] pgaref commented on pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-03 Thread via GitHub
pgaref commented on PR #22506: URL: https://github.com/apache/flink/pull/22506#issuecomment-1533945842 > Thanks for the PR @pgaref; this already looks pretty good. I've left a couple of comments. My biggest concern is not having a dedicated test in the JobMaster test suite. Thanks

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1184450001 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/exceptionhistory/ExceptionHistoryEntryMatcher.java: ## @@ -87,6 +107,18 @@ protected boolean

[GitHub] [flink] pgaref commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-03 Thread via GitHub
pgaref commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1184449298 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/factories/DefaultJobMasterServiceFactory.java: ## @@ -122,6 +123,7 @@ private JobMasterService

[jira] [Created] (FLINK-31993) Introduce JobMaster FailureEnricher configuration

2023-05-03 Thread Panagiotis Garefalakis (Jira)
Panagiotis Garefalakis created FLINK-31993: -- Summary: Introduce JobMaster FailureEnricher configuration Key: FLINK-31993 URL: https://issues.apache.org/jira/browse/FLINK-31993 Project: Flink

[jira] [Commented] (FLINK-31135) ConfigMap DataSize went > 1 MB and cluster stopped working

2023-05-03 Thread Zhihao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719102#comment-17719102 ] Zhihao Chen commented on FLINK-31135: - [~Swathi Chandrashekar] thank you for pointing it out! I

[GitHub] [flink] tzulitai commented on a diff in pull request #22481: [FLINK-27805] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
tzulitai commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184399791 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/PhysicalWriterImpl.java: ## @@ -1,398 +0,0 @@ -/* - * Licensed to the Apache Software Foundation

[GitHub] [flink] tzulitai commented on a diff in pull request #22481: [FLINK-27805] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
tzulitai commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184398560 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] gaoyunhaii commented on pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-05-03 Thread via GitHub
gaoyunhaii commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1533865944 Hi @XComp sorry for failing the Ci previously, the CI is now passed, could you have another look? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] nateab commented on a diff in pull request #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-05-03 Thread via GitHub
nateab commented on code in PR #22359: URL: https://github.com/apache/flink/pull/22359#discussion_r1184383181 ## flink-table/flink-table-planner/pom.xml: ## @@ -301,6 +301,11 @@ under the License. ${project.version} test

[GitHub] [flink] nateab commented on a diff in pull request #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-05-03 Thread via GitHub
nateab commented on code in PR #22359: URL: https://github.com/apache/flink/pull/22359#discussion_r1184382143 ## flink-table/flink-table-planner/pom.xml: ## @@ -392,6 +397,8 @@ under the License.

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-03 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1184309760 ## flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java: ## @@ -61,6 +61,9 @@ class YARNSessionFIFOITCase extends YarnTestBase {

[GitHub] [flink] architgyl commented on a diff in pull request #22509: [FLINK-31983] Add yarn Acls capability to Flink containers

2023-05-03 Thread via GitHub
architgyl commented on code in PR #22509: URL: https://github.com/apache/flink/pull/22509#discussion_r1184308688 ## flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java: ## @@ -620,4 +623,30 @@ public static YarnConfiguration getYarnConfiguration( return

[jira] [Commented] (FLINK-23752) Add document for using HiveSource API

2023-05-03 Thread Bikash Adhikari (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719030#comment-17719030 ] Bikash Adhikari commented on FLINK-23752: - I would like to work on it. Where should the

[GitHub] [flink] zentol commented on a diff in pull request #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-05-03 Thread via GitHub
zentol commented on code in PR #22359: URL: https://github.com/apache/flink/pull/22359#discussion_r1183893561 ## flink-table/flink-table-planner/pom.xml: ## @@ -392,6 +397,8 @@ under the License.

[jira] [Updated] (FLINK-31992) FlinkKafkaConsumer API is suggested as part of documentation, when that API is deprecated for flink version 1.14

2023-05-03 Thread Sandesh Mendan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandesh Mendan updated FLINK-31992: --- Summary: FlinkKafkaConsumer API is suggested as part of documentation, when that API is

[jira] [Updated] (FLINK-31992) FlinkKafkaConsumer API is suggested to use as part of documentation, when that API is deprecated for flink version 1.14

2023-05-03 Thread Sandesh Mendan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandesh Mendan updated FLINK-31992: --- Summary: FlinkKafkaConsumer API is suggested to use as part of documentation, when that API

[jira] [Created] (FLINK-31992) FlinkKafkaConsumer API is suggested as part of documentation, when that API is deprecated for that flink version

2023-05-03 Thread Sandesh Mendan (Jira)
Sandesh Mendan created FLINK-31992: -- Summary: FlinkKafkaConsumer API is suggested as part of documentation, when that API is deprecated for that flink version Key: FLINK-31992 URL:

[jira] [Closed] (FLINK-31976) Once marked as an inefficient scale-up, further scaling may not happen forever

2023-05-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31976. -- Fix Version/s: kubernetes-operator-1.5.0 Resolution: Fixed merged to main

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #579: [FLINK-31976] Apply trimming logic to getScalingHistory

2023-05-03 Thread via GitHub
gyfora merged PR #579: URL: https://github.com/apache/flink-kubernetes-operator/pull/579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dongjoon-hyun commented on pull request #22481: [FLINK-27805] bump orc version to 1.7.8

2023-05-03 Thread via GitHub
dongjoon-hyun commented on PR #22481: URL: https://github.com/apache/flink/pull/22481#issuecomment-1533273430 Thank you, @pgaref and @dmvk . cc @williamhyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #580: [FLINK-31815] Bump jackson version to eliminate snakeyaml vulnerability

2023-05-03 Thread via GitHub
gyfora commented on PR #580: URL: https://github.com/apache/flink-kubernetes-operator/pull/580#issuecomment-1533272321 > Thanks, @gyfora. Is there a ticket for bumping this in Flink then? I will open a followup ticket to update the fabric8 version in Flink. That is a prerequisite

[jira] [Closed] (FLINK-31991) Update Autoscaler doc to reflect the changes brought by the new source scaling logic

2023-05-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-31991. -- Fix Version/s: kubernetes-operator-1.5.0 Resolution: Fixed > Update Autoscaler

[GitHub] [flink-kubernetes-operator] mxm merged pull request #582: [FLINK-31991] Update autoscaler doc to reflect the changes brought by the new consolidated source scaling logic

2023-05-03 Thread via GitHub
mxm merged PR #582: URL: https://github.com/apache/flink-kubernetes-operator/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-31795) Add Config to enable/disable savepoint cleanup

2023-05-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31795. -- Resolution: Fixed merged to main 6df91ae17873c274b2b993ab7bef30f1297e5c3e > Add Config to

[jira] [Updated] (FLINK-31795) Add Config to enable/disable savepoint cleanup

2023-05-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-31795: --- Fix Version/s: kubernetes-operator-1.5.0 (was: kubernetes-operator-1.4.0) >

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #565: [FLINK-31795] Add config to disable savepoint cleanup

2023-05-03 Thread via GitHub
gyfora merged PR #565: URL: https://github.com/apache/flink-kubernetes-operator/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #565: [FLINK-31795] Add config to disable savepoint cleanup

2023-05-03 Thread via GitHub
gyfora commented on PR #565: URL: https://github.com/apache/flink-kubernetes-operator/pull/565#issuecomment-1533265334 Looks great! Thank you @darenwkt :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #579: [FLINK-31976] Apply trimming logic to getScalingHistory

2023-05-03 Thread via GitHub
gyfora commented on PR #579: URL: https://github.com/apache/flink-kubernetes-operator/pull/579#issuecomment-1533252976 > Do we need a separate unit test for GET trims? Passing the `testHistorySizeConfigs` test now means that trimming works correctly for `add` as well as `get` operations.

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-03 Thread via GitHub
XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1183460705 ## tools/ci/flink-ci-tools/src/main/java/org/apache/flink/tools/ci/optional/ShadeOptionalChecker.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-03 Thread via GitHub
XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1183614145 ## flink-python/pom.xml: ## Review Comment: I assumed that we would have to add the optional flag to the dependencies under `` as well? ...at least, we did this in

[GitHub] [flink] XComp commented on a diff in pull request #21349: [FLINK-28203] Support Maven 3.3+

2023-05-03 Thread via GitHub
XComp commented on code in PR #21349: URL: https://github.com/apache/flink/pull/21349#discussion_r1183847811 ## flink-dist/pom.xml: ## Review Comment: This one is answered already: `flink-dist` bundles all the dependencies and, therefore, needs to annotate all

[GitHub] [flink-kubernetes-operator] tankim commented on pull request #579: [FLINK-31976] Apply trimming logic to getScalingHistory

2023-05-03 Thread via GitHub
tankim commented on PR #579: URL: https://github.com/apache/flink-kubernetes-operator/pull/579#issuecomment-1533239071 Do we need a separate unit test for GET trims? Passing the `testHistorySizeConfigs` test now means that trimming works correctly for `add` as well as `get` operations.

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718964#comment-17718964 ] Matthias Pohl commented on FLINK-31974: --- I'm still wondering what the desired behavior in that

[jira] [Updated] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31974: -- Description: When resource quota limit is reached JobManager will throw  

[jira] [Comment Edited] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718958#comment-17718958 ] Matthias Pohl edited comment on FLINK-31974 at 5/3/23 3:14 PM: --- Thanks for

[jira] [Comment Edited] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718958#comment-17718958 ] Matthias Pohl edited comment on FLINK-31974 at 5/3/23 3:08 PM: --- Thanks for

[GitHub] [flink-web] echauchot merged pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-05-03 Thread via GitHub
echauchot merged PR #641: URL: https://github.com/apache/flink-web/pull/641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718958#comment-17718958 ] Matthias Pohl commented on FLINK-31974: --- Thanks for reporting. This is caused by the changes that

[jira] [Assigned] (FLINK-31991) Update Autoscaler doc to reflect the changes brought by the new source scaling logic

2023-05-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reassigned FLINK-31991: -- Assignee: Zhanghao Chen (was: Maximilian Michels) > Update Autoscaler doc

[jira] [Assigned] (FLINK-31991) Update Autoscaler doc to reflect the changes brought by the new source scaling logic

2023-05-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reassigned FLINK-31991: -- Assignee: Maximilian Michels > Update Autoscaler doc to reflect the changes

[jira] [Commented] (FLINK-31991) Update Autoscaler doc to reflect the changes brought by the new source scaling logic

2023-05-03 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718954#comment-17718954 ] Maximilian Michels commented on FLINK-31991: Thanks for raising this issue. > Update

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-03 Thread via GitHub
gyfora commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1183792060 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-03 Thread via GitHub
gyfora commented on PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#issuecomment-1533155741 Don't forget to regenerate the docs with `mvn clean install -Pgenerate-docs` -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-30975) migrate aws sdk from v1 to v2

2023-05-03 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-30975: --- Summary: migrate aws sdk from v1 to v2 (was: Upgrade aws sdk to v2) > migrate aws sdk from v1 to

[jira] [Updated] (FLINK-30975) Migrate aws sdk from v1 to v2

2023-05-03 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-30975: --- Summary: Migrate aws sdk from v1 to v2 (was: migrate aws sdk from v1 to v2) > Migrate aws sdk from

[GitHub] [flink-web] echauchot commented on pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-05-03 Thread via GitHub
echauchot commented on PR #641: URL: https://github.com/apache/flink-web/pull/641#issuecomment-1533105847 Addressed all the comments, PR is approved, self-merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-web] echauchot commented on a diff in pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-05-03 Thread via GitHub
echauchot commented on code in PR #641: URL: https://github.com/apache/flink-web/pull/641#discussion_r1183743685 ## docs/content/posts/2023-04-13-howto-create-batch-source.md: ## @@ -0,0 +1,221 @@ +--- +title: "Howto create a batch source with the new Source framework" +date:

[GitHub] [flink] XComp commented on a diff in pull request #22394: [FLINK-31780][component=Runtime/Coordination] Allow users to disable 'Ensemble tracking' feature for ZooKeeper Curator framework

2023-05-03 Thread via GitHub
XComp commented on code in PR #22394: URL: https://github.com/apache/flink/pull/22394#discussion_r1183708820 ## flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java: ## @@ -199,6 +199,23 @@ public class HighAvailabilityOptions {

[GitHub] [flink] dmvk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-03 Thread via GitHub
dmvk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1182229885 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java: ## @@ -74,6 +83,11 @@ public ErrorInfo(@Nonnull Throwable exception, long

  1   2   >