[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1212587682 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1212587682 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] libenchao commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-31 Thread via GitHub
libenchao commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1571344991 @snuyanzin I don't have further comments. There is one thing we can do is to create a Jira about the translation for newly added docs about CrateDB. -- This is an automated

[jira] [Updated] (FLINK-32232) Supports parse truncate table statement

2023-05-31 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-32232: - Summary: Supports parse truncate table statement (was: Supports parse support truncate table

[jira] [Created] (FLINK-32234) Support execute truncate table statement

2023-05-31 Thread luoyuxia (Jira)
luoyuxia created FLINK-32234: Summary: Support execute truncate table statement Key: FLINK-32234 URL: https://issues.apache.org/jira/browse/FLINK-32234 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32233) Introduce SupportsTruncate interface

2023-05-31 Thread luoyuxia (Jira)
luoyuxia created FLINK-32233: Summary: Introduce SupportsTruncate interface Key: FLINK-32233 URL: https://issues.apache.org/jira/browse/FLINK-32233 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32232) Supports parse support truncate table statement

2023-05-31 Thread luoyuxia (Jira)
luoyuxia created FLINK-32232: Summary: Supports parse support truncate table statement Key: FLINK-32232 URL: https://issues.apache.org/jira/browse/FLINK-32232 Project: Flink Issue Type: Sub-task

[GitHub] [flink] xintongsong commented on a diff in pull request #22652: [FLINK-31640][network] Write the accumulated buffers to the right storage tier

2023-05-31 Thread via GitHub
xintongsong commented on code in PR #22652: URL: https://github.com/apache/flink/pull/22652#discussion_r1212515884 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageProducerClient.java: ## @@ -119,7 +149,60 @@

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-31 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1212512978 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java: ## @@ -324,7 +325,7 @@ public void

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-31 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1212507940 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18

[GitHub] [flink] flinkbot commented on pull request #22690: [FLINK-30660][hive] add e2e test for hive for hive3

2023-05-31 Thread via GitHub
flinkbot commented on PR #22690: URL: https://github.com/apache/flink/pull/22690#issuecomment-1571218124 ## CI report: * 18fdc7329ebb72e8892d654d06670271e5d3931b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #22690: [FLINK-30660][hive] add e2e test for hive for hive3

2023-05-31 Thread via GitHub
luoyuxia opened a new pull request, #22690: URL: https://github.com/apache/flink/pull/22690 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] pgaref commented on pull request #22643: [FLINK-31894][runtime] ExceptionHistory and REST API failure label integration

2023-05-31 Thread via GitHub
pgaref commented on PR #22643: URL: https://github.com/apache/flink/pull/22643#issuecomment-1571174198 > The biggest question I have is whether the filters are supposed to be ANDed or ORed 樂 Right now if a single filter matches we keep the exception. Changed this to ANDed filter

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-31 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1212450869 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java: ## @@ -324,7 +325,7 @@ public void

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-31 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1212449390 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java: ## @@ -361,9 +362,10 @@ IncrementalRemoteKeyedStateHandle

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-31 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1212449200 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandleTest.java: ## @@ -243,6 +244,60 @@ public void

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-31 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1212443717 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18

[jira] [Assigned] (FLINK-32231) libssl not found when running CI

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-32231: --- Assignee: Sergey Nuyanzin > libssl not found when running CI >

[jira] [Commented] (FLINK-32231) libssl not found when running CI

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728172#comment-17728172 ] Sergey Nuyanzin commented on FLINK-32231: - Merged as: master:

[jira] [Resolved] (FLINK-32231) libssl not found when running CI

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32231. - Resolution: Fixed > libssl not found when running CI >

[jira] [Updated] (FLINK-32231) libssl not found when running CI

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32231: Fix Version/s: 1.18.0 1.16.3 1.17.2 > libssl not

[GitHub] [flink-web] JingGe commented on a diff in pull request #655: Add Pulsar v3.0.1 for Flink 1.16.x

2023-05-31 Thread via GitHub
JingGe commented on code in PR #655: URL: https://github.com/apache/flink-web/pull/655#discussion_r1212412905 ## docs/data/release_archive.yml: ## @@ -490,6 +490,11 @@ release_archive: version: 3.0.1 release_date: 2023-05-09 filename: "gcp-pubsub" +-

[GitHub] [flink-web] JingGe commented on a diff in pull request #655: Add Pulsar v3.0.1 for Flink 1.16.x

2023-05-31 Thread via GitHub
JingGe commented on code in PR #655: URL: https://github.com/apache/flink-web/pull/655#discussion_r1212412905 ## docs/data/release_archive.yml: ## @@ -490,6 +490,11 @@ release_archive: version: 3.0.1 release_date: 2023-05-09 filename: "gcp-pubsub" +-

[GitHub] [flink] snuyanzin merged pull request #22689: [BP-1.17][FLINK-32231][Build System] Update libssl to 5.13, which is needed fo…

2023-05-31 Thread via GitHub
snuyanzin merged PR #22689: URL: https://github.com/apache/flink/pull/22689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] snuyanzin merged pull request #22688: [BP-1.16][FLINK-32231][Build System] Update libssl to 5.13, which is needed fo…

2023-05-31 Thread via GitHub
snuyanzin merged PR #22688: URL: https://github.com/apache/flink/pull/22688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22689: [BP-1.17][FLINK-32231][Build System] Update libssl to 5.13, which is needed fo…

2023-05-31 Thread via GitHub
flinkbot commented on PR #22689: URL: https://github.com/apache/flink/pull/22689#issuecomment-1571086981 ## CI report: * 0f4c0d73eafc5f55b82630208660bf8be969c9d7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22688: [BP-1.16][FLINK-32231][Build System] Update libssl to 5.13, which is needed fo…

2023-05-31 Thread via GitHub
flinkbot commented on PR #22688: URL: https://github.com/apache/flink/pull/22688#issuecomment-1571083958 ## CI report: * f4bef5c26c9df758e643699771ee63dc035fff74 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-opensearch] snuyanzin opened a new pull request, #25: [FLINK-32228] Bump testcontainers to 1.18.2

2023-05-31 Thread via GitHub
snuyanzin opened a new pull request, #25: URL: https://github.com/apache/flink-connector-opensearch/pull/25 Besides bumping testcontainers it also removes redundant tag in pom -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #24: [FLINK-31856] Add support for Opensearch Connector REST client customization

2023-05-31 Thread via GitHub
reta commented on code in PR #24: URL: https://github.com/apache/flink-connector-opensearch/pull/24#discussion_r1212331005 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/RestClientFactory.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [flink-connector-opensearch] snuyanzin commented on a diff in pull request #24: [FLINK-31856] Add support for Opensearch Connector REST client customization

2023-05-31 Thread via GitHub
snuyanzin commented on code in PR #24: URL: https://github.com/apache/flink-connector-opensearch/pull/24#discussion_r1212308420 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/RestClientFactory.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #22687: [FLINK-32231][Build System] Update libssl to 5.13, which is needed for all E2E tests

2023-05-31 Thread via GitHub
flinkbot commented on PR #22687: URL: https://github.com/apache/flink/pull/22687#issuecomment-1570921234 ## CI report: * 0a5203f2ebb0715923fb54eae7072c815bf13789 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32231) libssl not found when running CI

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32231: --- Labels: pull-request-available (was: ) > libssl not found when running CI >

[GitHub] [flink] snuyanzin opened a new pull request, #22687: [FLINK-32231][Build System] Update libssl to 5.13, which is needed for all E2E tests

2023-05-31 Thread via GitHub
snuyanzin opened a new pull request, #22687: URL: https://github.com/apache/flink/pull/22687 ## What is the purpose of the change Update of libssl version required for E2E tests ## Verifying this change This change is a trivial rework / code cleanup without any test

[jira] [Created] (FLINK-32231) libssl not found when running CI

2023-05-31 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32231: --- Summary: libssl not found when running CI Key: FLINK-32231 URL: https://issues.apache.org/jira/browse/FLINK-32231 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-32228) Bump testcontainers to 1.18.2

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32228: Fix Version/s: jdbc-3.2.0 > Bump testcontainers to 1.18.2 > -

[jira] [Commented] (FLINK-32228) Bump testcontainers to 1.18.2

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728119#comment-17728119 ] Sergey Nuyanzin commented on FLINK-32228: - Merged to flink-connector-jdbc:  

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
eskabetxe commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1212195434 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[jira] [Updated] (FLINK-32228) Bump testcontainers to 1.18.2

2023-05-31 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32228: Summary: Bump testcontainers to 1.18.2 (was: Bump testcontainers) > Bump testcontainers

[GitHub] [flink-connector-jdbc] snuyanzin merged pull request #51: [FLINK-32228] Bump testcontainers version

2023-05-31 Thread via GitHub
snuyanzin merged PR #51: URL: https://github.com/apache/flink-connector-jdbc/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] MartijnVisser commented on pull request #22531: [FLINK-28853] Document the split level watermark alignment feature an…

2023-05-31 Thread via GitHub
MartijnVisser commented on PR #22531: URL: https://github.com/apache/flink/pull/22531#issuecomment-1570706544 > @MartijnVisser got it. I'll submit a PR and may need your help getting it in since Max is out No worries, just ping me -- This is an automated message from the Apache

[GitHub] [flink] mas-chen commented on pull request #22531: [FLINK-28853] Document the split level watermark alignment feature an…

2023-05-31 Thread via GitHub
mas-chen commented on PR #22531: URL: https://github.com/apache/flink/pull/22531#issuecomment-1570596478 @MartijnVisser got it. I'll submit a PR and may need your help getting it in since Max is out -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22685: [FLINK-32226][client] Cleanup jobgraph file on submission failure

2023-05-31 Thread via GitHub
rkhachatryan commented on code in PR #22685: URL: https://github.com/apache/flink/pull/22685#discussion_r1212026911 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java: ## @@ -434,16 +460,19 @@ public CompletableFuture submitJob(@Nonnull

[jira] [Updated] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-31 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-31974: --- Affects Version/s: 1.18.0 > JobManager crashes after KubernetesClientException exception with >

[GitHub] [flink] rbowen commented on pull request #22508: trivial word dedup

2023-05-31 Thread via GitHub
rbowen commented on PR #22508: URL: https://github.com/apache/flink/pull/22508#issuecomment-1570464863 Oops. Sorry, missed the earlier note. Taking care of it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] pgaref commented on a diff in pull request #22643: [FLINK-31894][runtime] ExceptionHistory and REST API failure label integration

2023-05-31 Thread via GitHub
pgaref commented on code in PR #22643: URL: https://github.com/apache/flink/pull/22643#discussion_r1211881090 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -3303,6 +3321,16 @@ components: properties: request-id: $ref:

[GitHub] [flink] pgaref commented on a diff in pull request #22516: [FLINK-31993][runtime] Initialize and pass down FailureEnrichers

2023-05-31 Thread via GitHub
pgaref commented on code in PR #22516: URL: https://github.com/apache/flink/pull/22516#discussion_r1211872357 ## flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java: ## @@ -561,6 +561,7 @@ private void setupDispatcherResourceManagerComponents(

[GitHub] [flink] echauchot commented on pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-05-31 Thread via GitHub
echauchot commented on PR #22667: URL: https://github.com/apache/flink/pull/22667#issuecomment-1570403781 I don't get how the centralized flink-architecture-tests-production work. The [azure

[GitHub] [flink-connector-elasticsearch] StefanXiepj commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
StefanXiepj commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1570393677 I try to compile your code, but throwing follow errors: ``` [INFO] There are 69 errors reported by Checkstyle 8.14 with /tools/maven/checkstyle.xml

[jira] [Updated] (FLINK-31856) Add support for Opensearch Connector REST client customization

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31856: --- Labels: pull-request-available (was: ) > Add support for Opensearch Connector REST client

[GitHub] [flink] flinkbot commented on pull request #22686: [FLINK-32225][Runtime] Merge some task deployment related fields to auxiliary class.

2023-05-31 Thread via GitHub
flinkbot commented on PR #22686: URL: https://github.com/apache/flink/pull/22686#issuecomment-1570331163 ## CI report: * 47353b5f3c6d272149febf8b29d0ed97c87088ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32225) merge task deployment related fields into a new configuration

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32225: --- Labels: pull-request-available (was: ) > merge task deployment related fields into a new

[GitHub] [flink] huwh opened a new pull request, #22686: [FLINK-32225][Runtime] Merge some task deployment related fields to auxiliary class.

2023-05-31 Thread via GitHub
huwh opened a new pull request, #22686: URL: https://github.com/apache/flink/pull/22686 ## What is the purpose of the change TaskDeploymentDescriptorFactory#fromExecution needs to retrieve several fields from the ExecutionGraphAccessor. We could introduce a new

[GitHub] [flink-connector-jdbc] snuyanzin commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-31 Thread via GitHub
snuyanzin commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1570287422 Thanks for addressing comments it looks ok from my side Thanks for review @eskabetxe @libenchao, please add anything if you have something not covered -- This is

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211758453 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/OperationSerializer.java: ## @@ -0,0 +1,60 @@ +/* + * + *

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211757737 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/OperationSerializer.java: ## @@ -0,0 +1,60 @@ +/* + * + *

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #51: [FLINK-32228] Bump testcontainers version

2023-05-31 Thread via GitHub
eskabetxe commented on code in PR #51: URL: https://github.com/apache/flink-connector-jdbc/pull/51#discussion_r1211757666 ## pom.xml: ## @@ -53,7 +53,7 @@ under the License. 4.13.2 5.9.1 3.23.1 -1.17.2 +1.18.1 Review Comment:

[GitHub] [flink] echauchot commented on pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-05-31 Thread via GitHub
echauchot commented on PR #22667: URL: https://github.com/apache/flink/pull/22667#issuecomment-1570282806 > > No, it did not work because the rule was conceptually wrong: see the review comment I have put on line 50 > > I don't see any comment; did you submit the review? My bad,

[GitHub] [flink] echauchot commented on a diff in pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-05-31 Thread via GitHub
echauchot commented on code in PR #22667: URL: https://github.com/apache/flink/pull/22667#discussion_r1206798251 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -41,16 +39,14 @@ public

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211756809 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/OperationSerializer.java: ## @@ -0,0 +1,60 @@ +/* + * + *

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #51: [FLINK-32228] Bump testcontainers version

2023-05-31 Thread via GitHub
eskabetxe commented on code in PR #51: URL: https://github.com/apache/flink-connector-jdbc/pull/51#discussion_r1211755364 ## pom.xml: ## @@ -53,7 +53,7 @@ under the License. 4.13.2 5.9.1 3.23.1 -1.17.2 +1.18.1 Review Comment: I

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211695458 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java: ## @@ -0,0 +1,70 @@ +/* + * + * Licensed

[GitHub] [flink-connector-jdbc] MartijnVisser commented on a diff in pull request #51: [FLINK-32228] Bump testcontainers version

2023-05-31 Thread via GitHub
MartijnVisser commented on code in PR #51: URL: https://github.com/apache/flink-connector-jdbc/pull/51#discussion_r1211750800 ## pom.xml: ## @@ -53,7 +53,7 @@ under the License. 4.13.2 5.9.1 3.23.1 -1.17.2 +1.18.1 Review Comment:

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #51: [FLINK-32228] Bump testcontainers version

2023-05-31 Thread via GitHub
eskabetxe commented on PR #51: URL: https://github.com/apache/flink-connector-jdbc/pull/51#issuecomment-1570271983 @MartijnVisser could you check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (FLINK-32230) Deadlock in AWS Kinesis Data Streams AsyncSink connector

2023-05-31 Thread Antonio Vespoli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Vespoli updated FLINK-32230: Description: Connector calls to AWS Kinesis Data Streams can hang indefinitely without

[jira] [Updated] (FLINK-32230) Deadlock in AWS Kinesis Data Streams AsyncSink connector

2023-05-31 Thread Antonio Vespoli (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Vespoli updated FLINK-32230: Summary: Deadlock in AWS Kinesis Data Streams AsyncSink connector (was: Deadlock in AWS

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211729913 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/INetworkConfigFactory.java: ## @@ -0,0 +1,29 @@ +/* + * +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1570248521 compile_and_test (1.18-SNAPSHOT) fail, It doesn't seem like the problem was caused by my submission -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] zentol commented on a diff in pull request #22685: [FLINK-32226][client] Cleanup jobgraph file on submission failure

2023-05-31 Thread via GitHub
zentol commented on code in PR #22685: URL: https://github.com/apache/flink/pull/22685#discussion_r1211727353 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java: ## @@ -333,7 +359,7 @@ public CompletableFuture submitJob(@Nonnull JobGraph

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211723597 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java: ## @@ -322,6 +325,9 @@ void testBatchSink()

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211722856 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8Writer.java: ## @@ -0,0 +1,134 @@ +/* + * +

[GitHub] [flink] dmvk commented on a diff in pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels

2023-05-31 Thread via GitHub
dmvk commented on code in PR #22646: URL: https://github.com/apache/flink/pull/22646#discussion_r1211718191 ## flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.html: ## @@ -53,6 +54,9 @@ {{

[jira] [Updated] (FLINK-31896) Extend web interface to support failure labels

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31896: --- Labels: pull-request-available (was: ) > Extend web interface to support failure labels >

[GitHub] [flink] dmvk commented on pull request #22646: [FLINK-31896][runtime] Extend web interface to support failure labels

2023-05-31 Thread via GitHub
dmvk commented on PR #22646: URL: https://github.com/apache/flink/pull/22646#issuecomment-1570232063 do you have a screenshot of how the result looks like? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211712860 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java: ## @@ -0,0 +1,70 @@ +/* + * + * Licensed

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211711218 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java: ## @@ -0,0 +1,70 @@ +/* + * + * Licensed

[GitHub] [flink] dmvk commented on a diff in pull request #22643: [FLINK-31894][runtime] ExceptionHistory and REST API failure label integration

2023-05-31 Thread via GitHub
dmvk commented on code in PR #22643: URL: https://github.com/apache/flink/pull/22643#discussion_r1211711142 ## docs/static/generated/rest_v1_dispatcher.yml: ## @@ -3303,6 +3321,16 @@ components: properties: request-id: $ref:

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22685: [FLINK-32226][client] Cleanup jobgraph file on submission failure

2023-05-31 Thread via GitHub
rkhachatryan commented on code in PR #22685: URL: https://github.com/apache/flink/pull/22685#discussion_r1211710597 ## flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java: ## @@ -333,7 +359,7 @@ public CompletableFuture submitJob(@Nonnull

[jira] [Updated] (FLINK-31894) ExceptionHistory and REST API failure label integration

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31894: --- Labels: pull-request-available (was: ) > ExceptionHistory and REST API failure label

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211695458 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Operation.java: ## @@ -0,0 +1,70 @@ +/* + * + * Licensed

[GitHub] [flink-connector-elasticsearch] reta commented on a diff in pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-05-31 Thread via GitHub
reta commented on code in PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#discussion_r1211676310 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8Sink.java: ## @@ -0,0 +1,119 @@ +/* + * + *

[jira] [Created] (FLINK-32230) Deadlock in AWS Kinesis Data Streams connector

2023-05-31 Thread Antonio Vespoli (Jira)
Antonio Vespoli created FLINK-32230: --- Summary: Deadlock in AWS Kinesis Data Streams connector Key: FLINK-32230 URL: https://issues.apache.org/jira/browse/FLINK-32230 Project: Flink Issue

[GitHub] [flink-connector-jdbc] matriv commented on a diff in pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-31 Thread via GitHub
matriv commented on code in PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1211652966 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java: ## @@ -49,7 +51,12 @@ public static AbstractJdbcCatalog

[GitHub] [flink-connector-jdbc] matriv commented on a diff in pull request #29: [FLINK-31551] Add support for CrateDB

2023-05-31 Thread via GitHub
matriv commented on code in PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1211652966 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalogUtils.java: ## @@ -49,7 +51,12 @@ public static AbstractJdbcCatalog

[GitHub] [flink-connector-aws] hlteoh37 commented on pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-05-31 Thread via GitHub
hlteoh37 commented on PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#issuecomment-1570155052 Thanks @PatrickRen. Thats a great callout. I've created a separate subtask to track that, as well as logging. https://issues.apache.org/jira/browse/FLINK-32229 -- This is an

[jira] [Updated] (FLINK-32229) Implement metrics and logging for Initial implementation

2023-05-31 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-32229: Description: Add/Ensure Kinesis specific metrics for MillisBehindLatest/numRecordsIn are

[jira] [Created] (FLINK-32229) Implement metrics and logging for Initial implementation

2023-05-31 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-32229: --- Summary: Implement metrics and logging for Initial implementation Key: FLINK-32229 URL: https://issues.apache.org/jira/browse/FLINK-32229 Project: Flink

[jira] [Updated] (FLINK-32228) Bump testcontainers

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32228: --- Labels: pull-request-available (was: ) > Bump testcontainers > --- > >

[GitHub] [flink-connector-jdbc] eskabetxe opened a new pull request, #51: [FLINK-32228] Bump testcontainers version

2023-05-31 Thread via GitHub
eskabetxe opened a new pull request, #51: URL: https://github.com/apache/flink-connector-jdbc/pull/51 Bump testcontainers version to last one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FLINK-32228) Bump testcontainers

2023-05-31 Thread Jira
João Boto created FLINK-32228: - Summary: Bump testcontainers Key: FLINK-32228 URL: https://issues.apache.org/jira/browse/FLINK-32228 Project: Flink Issue Type: Improvement Components:

[jira] [Commented] (FLINK-31810) RocksDBException: Bad table magic number on checkpoint rescale

2023-05-31 Thread David Artiga (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727924#comment-17727924 ] David Artiga commented on FLINK-31810: -- We are using GCP Storage buckets for both checkpoints and

[GitHub] [flink] flinkbot commented on pull request #22685: [FLINK-32226][client] Cleanup jobgraph file on submission failure

2023-05-31 Thread via GitHub
flinkbot commented on PR #22685: URL: https://github.com/apache/flink/pull/22685#issuecomment-1570052117 ## CI report: * a936eb3ff14e1351e3c57a304c327a81a024d5d0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32226) RestClusterClient leaks jobgraph file if submission fails

2023-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32226: --- Labels: pull-request-available (was: ) > RestClusterClient leaks jobgraph file if

[GitHub] [flink] zentol opened a new pull request, #22685: [FLINK-32226][client] Cleanup jobgraph file on submission failure

2023-05-31 Thread via GitHub
zentol opened a new pull request, #22685: URL: https://github.com/apache/flink/pull/22685 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211584622 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211582778 ## flink-connector-jdbc/pom.xml: ## @@ -194,6 +194,22 @@ under the License. test + +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on a diff in pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-05-31 Thread via GitHub
WenDing-Y commented on code in PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#discussion_r1211581006 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java: ## @@ -322,6 +325,9 @@ void testBatchSink()

[jira] [Updated] (FLINK-32227) Optimize code styles

2023-05-31 Thread zhihao song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhihao song updated FLINK-32227: Summary: Optimize code styles (was: Correct some grammar errors and optimize some code styles)

[jira] [Updated] (FLINK-32227) Correct some grammar errors and optimize some code styles

2023-05-31 Thread zhihao song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhihao song updated FLINK-32227: Description: (was: When I was reading the latest version of Flink's Checkpoint logic, I found

[jira] [Created] (FLINK-32227) Correct some grammar errors and optimize some code styles

2023-05-31 Thread zhihao song (Jira)
zhihao song created FLINK-32227: --- Summary: Correct some grammar errors and optimize some code styles Key: FLINK-32227 URL: https://issues.apache.org/jira/browse/FLINK-32227 Project: Flink

[jira] [Updated] (FLINK-32226) RestClusterClient leaks jobgraph file if submission fails

2023-05-31 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32226: - Priority: Minor (was: Major) > RestClusterClient leaks jobgraph file if submission

  1   2   >