LadyForest commented on code in PR #24271:
URL: https://github.com/apache/flink/pull/24271#discussion_r1501360520
##
docs/setup_docs.sh:
##
@@ -36,24 +36,33 @@ function integrate_connector_docs {
}
+SKIP_INTEGRATE_CONNECTOR_DOCS=false
+for arg in "$@"; do
+ if [ "$arg" ==
[
https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820276#comment-17820276
]
Gyula Fora commented on FLINK-34451:
I will definitely try this on Monday , I was just curious if
[
https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820275#comment-17820275
]
Alex Hoffer commented on FLINK-34451:
-
You’re the expert, I’m merely a user!:D I’d be curious if you
[
https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820272#comment-17820272
]
Gyula Fora commented on FLINK-34451:
To me the logs are not very surprising. The way it is currently
zhengzhili333 commented on PR #23782:
URL: https://github.com/apache/flink/pull/23782#issuecomment-1962234620
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-31205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820262#comment-17820262
]
WenJun Min commented on FLINK-31205:
[~tjbanghart] I have not prepare a PR for this ticket. In my
[
https://issues.apache.org/jira/browse/FLINK-31205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820259#comment-17820259
]
TJ Banghart commented on FLINK-31205:
-
I happened upon this ticket looking for issues related to
1996fanrui commented on PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#issuecomment-196948
Hi @gyfora , thank you for the quick review!
I have addressed all you comments. For the string shipStrategy, I extracted
a `ShipStrategy` enum to refactor it.
GOODBOY008 commented on PR #23960:
URL: https://github.com/apache/flink/pull/23960#issuecomment-1962221940
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820233#comment-17820233
]
Alex Hoffer commented on FLINK-34451:
-
The clue seems to be in the logs. The operator thinks it is
gyfora merged PR #784:
URL: https://github.com/apache/flink-kubernetes-operator/pull/784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820209#comment-17820209
]
Gyula Fora commented on FLINK-34451:
That's a good catch, if this is a bug related to adaptive
[ https://issues.apache.org/jira/browse/FLINK-34490 ]
Aleksandr Pilipenko deleted comment on FLINK-34490:
-
was (Author: a.pilipenko):
Currently, AWS connectors don't support extracting credentials from
configuration files
[
https://issues.apache.org/jira/browse/FLINK-34490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820207#comment-17820207
]
Aleksandr Pilipenko edited comment on FLINK-34490 at 2/23/24 9:16 PM:
[
https://issues.apache.org/jira/browse/FLINK-34490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820207#comment-17820207
]
Aleksandr Pilipenko commented on FLINK-34490:
-
Currently, AWS connectors don't support
hanyuzheng7 closed pull request #23055: historgram
URL: https://github.com/apache/flink/pull/23055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bvarghese1 commented on code in PR #24219:
URL: https://github.com/apache/flink/pull/24219#discussion_r1501042004
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestCompleteness.java:
##
@@ -0,0 +1,130 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820151#comment-17820151
]
Alex Hoffer commented on FLINK-34451:
-
[~gyfora] I can recreate on basic-checkpoint-ha by adding
gyfora commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1500903357
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##
@@ -225,10 +227,14 @@ Map computeScalingSummary(
gyfora commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r150088
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##
@@ -280,11 +283,14 @@ protected static int scale(
//
dependabot[bot] commented on PR #780:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/780#issuecomment-1961616235
OK, I won't notify you about version 42.x.x again, unless you re-open this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the
1996fanrui commented on PR #780:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/780#issuecomment-1961616134
@dependabot ignore this major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/FLINK-29696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820125#comment-17820125
]
Domenic Bove commented on FLINK-29696:
--
Great idea [~gyfora] - here's my PR if you can review:
dependabot[bot] commented on PR #780:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/780#issuecomment-1961614279
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or
1996fanrui closed pull request #780: Bump org.postgresql:postgresql from 42.5.4
to 42.5.5 in /flink-autoscaler-plugin-jdbc
URL: https://github.com/apache/flink-kubernetes-operator/pull/780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
domenicbove opened a new pull request, #784:
URL: https://github.com/apache/flink-kubernetes-operator/pull/784
Helm docs do not mention the chart repo, which will be useful for anyone who
doesnt want to download the source code or is using argocd/terraform
## What is the
1996fanrui commented on code in PR #783:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/783#discussion_r1500874435
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##
@@ -280,11 +283,14 @@ protected static int scale(
[
https://issues.apache.org/jira/browse/FLINK-34502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan resolved FLINK-34502.
-
Resolution: Fixed
> Support calculating network memory for forward and rescale edge
>
[
https://issues.apache.org/jira/browse/FLINK-34502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820108#comment-17820108
]
Rui Fan commented on FLINK-34502:
-
Merged via main(1.8.0) via : 304fca82ccc153c0745c468893a8930e9b9be806
1996fanrui merged PR #782:
URL: https://github.com/apache/flink-kubernetes-operator/pull/782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Lorenzo Affetti created FLINK-34509:
---
Summary: Docs: Fix Debezium JSON/AVRO opts in examples
Key: FLINK-34509
URL: https://issues.apache.org/jira/browse/FLINK-34509
Project: Flink
Issue
1996fanrui commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500809280
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##
@@ -277,6 +286,32 @@ private static MemorySize
mxm commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500801841
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##
@@ -277,6 +286,32 @@ private static MemorySize
mxm commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500793618
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##
@@ -243,28 +244,36 @@ private static MemorySize
mxm commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500791117
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/VertexInfo.java:
##
@@ -22,17 +22,19 @@
import lombok.Data;
-import
grafino commented on PR #22026:
URL: https://github.com/apache/flink/pull/22026#issuecomment-1961429975
Any update on this? Still found this happening in 1.18.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820056#comment-17820056
]
Rui Fan commented on FLINK-34471:
-
Merged to main(1.8.0) via: 6a8606517fb9f38f3a486c022f925368c9b4d9ae
[
https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan resolved FLINK-34471.
-
Fix Version/s: kubernetes-operator-1.8.0
Resolution: Fixed
> Tune network memory as part of
Matthias Pohl created FLINK-34508:
-
Summary: Migrate S3-related ITCases and e2e tests to Minio
Key: FLINK-34508
URL: https://issues.apache.org/jira/browse/FLINK-34508
Project: Flink
Issue
1996fanrui commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500641728
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##
@@ -277,6 +286,32 @@ private static MemorySize
dawidwys closed pull request #24316: array_except_error
URL: https://github.com/apache/flink/pull/24316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dawidwys closed pull request #23118: [FLINK-32815][table] Add HASHCODE
function.
URL: https://github.com/apache/flink/pull/23118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dawidwys commented on PR #23118:
URL: https://github.com/apache/flink/pull/23118#issuecomment-1961293615
subsumed by https://github.com/apache/flink/pull/24070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/FLINK-34118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz closed FLINK-34118.
Fix Version/s: 1.20.0
Resolution: Implemented
Implemented in
dawidwys merged PR #24109:
URL: https://github.com/apache/flink/pull/24109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500604384
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##
@@ -277,6 +286,32 @@ private static MemorySize
zentol commented on code in PR #24318:
URL: https://github.com/apache/flink/pull/24318#discussion_r1500608696
##
.github/workflows/ci.yml:
##
@@ -20,6 +20,8 @@ name: "Flink CI (beta)"
on:
push:
+paths-ignore:
+ - 'docs/**'
Review Comment:
this is too broad
GOODBOY008 commented on PR #23960:
URL: https://github.com/apache/flink/pull/23960#issuecomment-1961263603
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820034#comment-17820034
]
Gabor Somogyi commented on FLINK-20090:
---
I'm working on this and planning to open a PR beginning
[
https://issues.apache.org/jira/browse/FLINK-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Somogyi reassigned FLINK-20090:
-
Assignee: Gabor Somogyi
> Expose SlotId / SlotSharingGroup in Rest API
>
mxm commented on code in PR #782:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/782#discussion_r1500530308
##
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java:
##
@@ -277,6 +286,32 @@ private static MemorySize
[
https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820026#comment-17820026
]
Matthias Pohl commented on FLINK-26644:
---
[
https://issues.apache.org/jira/browse/FLINK-22040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820024#comment-17820024
]
Matthias Pohl commented on FLINK-22040:
---
[
https://issues.apache.org/jira/browse/FLINK-34449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820023#comment-17820023
]
Matthias Pohl commented on FLINK-34449:
---
xuzhiwen1255 commented on PR #22010:
URL: https://github.com/apache/flink/pull/22010#issuecomment-1961151386
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/FLINK-34274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820022#comment-17820022
]
Matthias Pohl commented on FLINK-34274:
---
Zakelly commented on PR #24368:
URL: https://github.com/apache/flink/pull/24368#issuecomment-1961150522
@fredia @masteryhx Thanks for your review! I've addressed your comments
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Zakelly commented on code in PR #24368:
URL: https://github.com/apache/flink/pull/24368#discussion_r1500524842
##
flink-core/src/main/java/org/apache/flink/configuration/StateRecoveryOptions.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Dawid Wysakowicz created FLINK-34507:
Summary: JSON functions have wrong operand checker
Key: FLINK-34507
URL: https://issues.apache.org/jira/browse/FLINK-34507
Project: Flink
Issue
mxm merged PR #781:
URL: https://github.com/apache/flink-kubernetes-operator/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Ferenc Csaky created FLINK-34506:
Summary: Do not copy "file://" schemed artifact in standalone
application modes
Key: FLINK-34506
URL: https://issues.apache.org/jira/browse/FLINK-34506
Project:
liuyongvs commented on code in PR #24373:
URL: https://github.com/apache/flink/pull/24373#discussion_r1500411569
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinDeriveNullFilterRule.java:
##
@@ -59,7 +59,7 @@ public class
flinkbot commented on PR #24375:
URL: https://github.com/apache/flink/pull/24375#issuecomment-1960997302
## CI report:
* 197c1a1d82d3a7f09195b9d5594ae707b182a592 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-34496:
-
Fix Version/s: (was: 1.20.0)
> Classloading deadlock between ExecNodeMetadataUtil
[
https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-34496.
Resolution: Fixed
master:
2d78c10211272a264712e86192c4dfc59c6a5521
[
https://issues.apache.org/jira/browse/FLINK-34505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-34505:
---
Labels: pull-request-available (was: )
> Migrate WindowGroupReorderRule
>
liuyongvs opened a new pull request, #24375:
URL: https://github.com/apache/flink/pull/24375
## What is the purpose of the change
The PR migrates WindowGroupReorderRule to java
it doesn't touch WindowGroupReorderRuleTest to be sure that java version
continues passing it
##
Jacky Lau created FLINK-34505:
-
Summary: Migrate WindowGroupReorderRule
Key: FLINK-34505
URL: https://issues.apache.org/jira/browse/FLINK-34505
Project: Flink
Issue Type: Sub-task
zentol merged PR #24371:
URL: https://github.com/apache/flink/pull/24371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
masteryhx commented on code in PR #24368:
URL: https://github.com/apache/flink/pull/24368#discussion_r1500393293
##
flink-core/src/main/java/org/apache/flink/configuration/StateRecoveryOptions.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
pnowojski commented on PR #24211:
URL: https://github.com/apache/flink/pull/24211#issuecomment-1960948515
> Do we know if watermarkInterval == 0 is a valid case where we are sure we
need to periodically emit WatermarkStatus? My interpretation when first reading
this code was that a zero
[
https://issues.apache.org/jira/browse/FLINK-34181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qingsheng Ren reassigned FLINK-34181:
-
Assignee: Qingsheng Ren
> Migrate repo from ververica to apache
>
[
https://issues.apache.org/jira/browse/FLINK-34181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819977#comment-17819977
]
Qingsheng Ren commented on FLINK-34181:
---
Opened ticket INFRA-25534 and waiting for response from
echauchot commented on code in PR #38:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1500367076
##
_utils.sh:
##
@@ -68,4 +68,15 @@ function set_pom_version {
new_version=$1
${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set
fredia commented on code in PR #24368:
URL: https://github.com/apache/flink/pull/24368#discussion_r1500360274
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java:
##
@@ -250,6 +251,10 @@ public class
[
https://issues.apache.org/jira/browse/FLINK-34504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-34504:
---
Labels: pull-request-available (was: )
> Avoid the parallelism adjustment when the
1996fanrui opened a new pull request, #783:
URL: https://github.com/apache/flink-kubernetes-operator/pull/783
## What is the purpose of the change
JobVertexScaler#scale has a optimization: Try to adjust the parallelism such
that it divides the number of key groups without a remainder
[
https://issues.apache.org/jira/browse/FLINK-34504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan updated FLINK-34504:
Summary: Avoid the parallelism adjustment when the upstream shuffle type
doesn't have keyBy (was: Avoid
[
https://issues.apache.org/jira/browse/FLINK-34504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan updated FLINK-34504:
Description:
JobVertexScaler#scale has a optimization: Try to adjust the parallelism such
that it
[
https://issues.apache.org/jira/browse/FLINK-34504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan updated FLINK-34504:
Summary: Avoid the parallelism adjustment when the upstream shuffle type
doesn't has keyBy (was: Avoid
Rui Fan created FLINK-34504:
---
Summary: Avoid the parallelism adjutment when the upstream shuffle
type doesn't has keyBy
Key: FLINK-34504
URL: https://issues.apache.org/jira/browse/FLINK-34504
Project:
Zakelly commented on code in PR #24368:
URL: https://github.com/apache/flink/pull/24368#discussion_r1500320132
##
flink-core/src/main/java/org/apache/flink/configuration/StateRecoveryOptions.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Zakelly commented on code in PR #24368:
URL: https://github.com/apache/flink/pull/24368#discussion_r1500320132
##
flink-core/src/main/java/org/apache/flink/configuration/StateRecoveryOptions.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Zakelly commented on code in PR #24368:
URL: https://github.com/apache/flink/pull/24368#discussion_r1500316226
##
flink-core/src/main/java/org/apache/flink/configuration/StateRecoveryOptions.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
84 matches
Mail list logo