Re: [PR] [cdc-common] add field of defaultValue to Column. [flink-cdc]

2024-06-13 Thread via GitHub
yuxiqian commented on code in PR #2944: URL: https://github.com/apache/flink-cdc/pull/2944#discussion_r1639295066 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/PhysicalColumnSerializer.java: ## Review Comment: Seems this is a breaking

[jira] [Updated] (FLINK-35600) Data read duplication during the full-to-incremental conversion phase

2024-06-13 Thread Di Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Di Wu updated FLINK-35600: -- Description: Assume that the table has been split into 3 Chunks Timeline t1: chunk1 is read t2: a piece of

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
1996fanrui commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167246199 > @1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests have stucked for hours, As the code is about to be frozen, could you help cancel some tasks? For

[jira] [Updated] (FLINK-35600) Data read duplication during the full-to-incremental conversion phase

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35600: --- Labels: pull-request-available (was: ) > Data read duplication during the

[jira] [Created] (FLINK-35600) Data read duplication during the full-to-incremental conversion phase

2024-06-13 Thread Di Wu (Jira)
Di Wu created FLINK-35600: - Summary: Data read duplication during the full-to-incremental conversion phase Key: FLINK-35600 URL: https://issues.apache.org/jira/browse/FLINK-35600 Project: Flink

[jira] [Commented] (FLINK-35564) The topic cannot be distributed on subtask when calculatePartitionOwner returns -1

2024-06-13 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854929#comment-17854929 ] Yufan Sheng commented on FLINK-35564: - Hi, thanks for mention this. I think this bug has been fixed

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167237003 @1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests have stucked for hours, As the code is about to be frozen, could you help cancel some tasks? For example,

[jira] [Updated] (FLINK-35593) Apache Kubernetes Operator Docker image does not contain Apache LICENSE

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35593: --- Labels: pull-request-available (was: ) > Apache Kubernetes Operator Docker image does not

[PR] [FLINK-35593][Kubernetes Operator] Add Apache 2 License to docker image [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
anupamaggarwal opened a new pull request, #839: URL: https://github.com/apache/flink-kubernetes-operator/pull/839 ## What is the purpose of the change Adds Apache 2 LICENSE to Apache Kubernetes Operator Docker image ## Brief change log - Adds LICENSE file to docker stage image

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639245472 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java: ## @@ -367,14 +368,28 @@ void testCatalogStore() throws

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639245307 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -295,31 +295,42 @@ public DataTypeFactory

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639244971 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateCatalogConverter.java: ## @@ -41,6 +43,10 @@ public

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639244453 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogOperation.java: ## @@ -39,10 +41,18 @@ public class

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639243865 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java: ## @@ -48,18 +55,34 @@ public Configuration

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639240721 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateCatalog.java: ## @@ -45,11 +48,18 @@ public class SqlCreateCatalog extends

Re: [PR] Out of use [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun closed pull request #3318: Out of use URL: https://github.com/apache/flink-cdc/pull/3318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-06-13 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-35121. Assignee: yux Resolution: Implemented Implemented by flink-cdc master:

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun commented on PR #3412: URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2167182112 Closed by #3382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun closed pull request #3412: [FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide ability to verify requiredOptions and optionalOptions URL: https://github.com/apache/flink-cdc/pull/3412 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun merged PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-35599) Add JDBC Sink Plugin to Flink-CDC-Pipeline

2024-06-13 Thread ZhengJunZhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhengJunZhou updated FLINK-35599: - Component/s: Flink CDC Affects Version/s: cdc-3.2.0 Description: TODO

Re: [PR] [FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [flink]

2024-06-13 Thread via GitHub
wzx140 commented on PR #24937: URL: https://github.com/apache/flink/pull/24937#issuecomment-2167176948 @1996fanrui Could you please review it? Really thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (FLINK-35599) test

2024-06-13 Thread ZhengJunZhou (Jira)
ZhengJunZhou created FLINK-35599: Summary: test Key: FLINK-35599 URL: https://issues.apache.org/jira/browse/FLINK-35599 Project: Flink Issue Type: Bug Reporter: ZhengJunZhou

[jira] [Updated] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35598: --- Labels: pull-request-available pull_request_available (was: pull_request_available) > Fix

Re: [PR] [FLINK-35598] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [flink]

2024-06-13 Thread via GitHub
flinkbot commented on PR #24937: URL: https://github.com/apache/flink/pull/24937#issuecomment-2167173883 ## CI report: * 0438cd927e430131c07b0555265696e34e1606a0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35598: --- Labels: pull-request-available (was: ) > Fix error comparison type

[jira] [Updated] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread Frank Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Wong updated FLINK-35598: --- Labels: pull_request_available (was: pull-request-available) > Fix error comparison type

[jira] [Created] (FLINK-35598) Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

2024-06-13 Thread Frank Wong (Jira)
Frank Wong created FLINK-35598: -- Summary: Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep Key: FLINK-35598 URL: https://issues.apache.org/jira/browse/FLINK-35598 Project: Flink

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639192510 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-35543][HIVE] Upgrade Hive 2.3 connector to version 2.3.10 [flink]

2024-06-13 Thread via GitHub
pan3793 commented on PR #24905: URL: https://github.com/apache/flink/pull/24905#issuecomment-2167155520 thank you, @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32091][checkpoint] Add file size metrics for file-merging [flink]

2024-06-13 Thread via GitHub
fredia commented on PR #24922: URL: https://github.com/apache/flink/pull/24922#issuecomment-2167153534 > Thanks for the PR! Overall LGTM. How about adding some docs under `docs/ops/metrics#checkpointing`? @Zakelly Thanks for the review, added into `docs/ops/metrics#checkpointing`

[jira] [Commented] (FLINK-35543) Upgrade Hive 2.3 connector to version 2.3.10

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854919#comment-17854919 ] Rui Fan commented on FLINK-35543: - Merged to master(1.20.0) via :

[jira] [Resolved] (FLINK-35543) Upgrade Hive 2.3 connector to version 2.3.10

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-35543. - Fix Version/s: 1.20.0 Resolution: Fixed > Upgrade Hive 2.3 connector to version 2.3.10 >

[jira] [Assigned] (FLINK-35543) Upgrade Hive 2.3 connector to version 2.3.10

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-35543: --- Assignee: Cheng Pan > Upgrade Hive 2.3 connector to version 2.3.10 >

Re: [PR] [FLINK-35543][HIVE] Upgrade Hive 2.3 connector to version 2.3.10 [flink]

2024-06-13 Thread via GitHub
1996fanrui merged PR #24905: URL: https://github.com/apache/flink/pull/24905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639176999 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-06-13 Thread via GitHub
lvyanquan commented on code in PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639176999 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
LadyForest commented on code in PR #24934: URL: https://github.com/apache/flink/pull/24934#discussion_r1639160703 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogOperation.java: ## @@ -39,10 +41,18 @@ public class

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
caicancai commented on PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2167139959 @1996fanrui @RocMarshal Thank you for your review and patient reply -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639174241 ##

[jira] [Resolved] (FLINK-35448) Translate pod templates documentation into Chinese

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-35448. - Fix Version/s: kubernetes-operator-1.9.0 Assignee: Caican Cai Resolution: Fixed >

[jira] [Commented] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2024-06-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854916#comment-17854916 ] RocMarshal commented on FLINK-33463: Hi, [~fanrui] [~eskabetxe]  Should we split the Jira as a

[jira] [Commented] (FLINK-35448) Translate pod templates documentation into Chinese

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854915#comment-17854915 ] Rui Fan commented on FLINK-35448: - Merged to main(1.9.0) via: d920a235a3357311b96e3c087d5918d83da27853

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui merged PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread elon_X (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854914#comment-17854914 ] elon_X commented on FLINK-35157: [~fanrui] Sure, I will backport this fix to 1.17, 1.18, and 1.19. Thank

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-06-13 Thread via GitHub
dingxin-tech commented on code in PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639171927 ##

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-13 Thread via GitHub
yuanoOo commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639167796 ## docs/content/docs/connectors/pipeline-connectors/oceanbase.md: ## @@ -0,0 +1,343 @@ +--- +title: "OceanBase" +weight: 7 +type: docs +aliases: +-

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
GOODBOY008 commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167128712 @1996fanrui It's indeed my mistake. @liyubin117 Great catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-06-13 Thread via GitHub
RocMarshal commented on PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119#issuecomment-2167128684  Thank you @1996fanrui @eskabetxe very much for your review and attention for the feature ! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
caicancai commented on PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2167127192 @1996fanrui cli fail, but it doesn't seem to be caused by my pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-35237) Allow Sink to Choose HashFunction in PrePartitionOperator

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35237: --- Labels: pull-request-available (was: ) > Allow Sink to Choose HashFunction in

[jira] [Comment Edited] (FLINK-34914) FLIP-436: Introduce Catalog-related Syntax

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854911#comment-17854911 ] Weijie Guo edited comment on FLINK-34914 at 6/14/24 2:16 AM: - I'm glad to

[jira] [Commented] (FLINK-34914) FLIP-436: Introduce Catalog-related Syntax

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854911#comment-17854911 ] Weijie Guo commented on FLINK-34914: I'm glad to hear that, but with a friendly remind: The feature

[jira] [Updated] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubin Li updated FLINK-35597: - Description: To ensure at least one fraction of hosts to be local, it should be

[jira] [Commented] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854910#comment-17854910 ] Jane Chan commented on FLINK-35597: ---

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639121989 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1:

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-06-13 Thread via GitHub
whhe commented on code in PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639119977 ## docs/content/docs/connectors/pipeline-connectors/oceanbase.md: ## @@ -0,0 +1,343 @@ +--- +title: "OceanBase" +weight: 7 +type: docs +aliases: +-

[jira] [Closed] (FLINK-35591) Azure Pipelines not running for master since c9def981

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35591. -- Fix Version/s: 1.20.0 Resolution: Fixed > Azure Pipelines not running for master since

[jira] [Commented] (FLINK-35591) Azure Pipelines not running for master since c9def981

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854907#comment-17854907 ] Weijie Guo commented on FLINK-35591: Thanks [~lorenzo.affetti]! I have checked it works now. >

[jira] [Assigned] (FLINK-35591) Azure Pipelines not running for master since c9def981

2024-06-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35591: -- Assignee: Lorenzo Affetti > Azure Pipelines not running for master since c9def981 >

Re: [PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
flinkbot commented on PR #24936: URL: https://github.com/apache/flink/pull/24936#issuecomment-2167073330 ## CI report: * 971edbe445dc16987a149bda399cf235f2ed5554 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33461) Support streaming related semantics for the new JDBC source

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854906#comment-17854906 ] Rui Fan commented on FLINK-33461: - Merged to main(jdbc-3.3.0) via

[jira] [Resolved] (FLINK-33461) Support streaming related semantics for the new JDBC source

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33461. - Fix Version/s: jdbc-3.3.0 Resolution: Fixed > Support streaming related semantics for the new

[jira] [Commented] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854905#comment-17854905 ] Rui Fan commented on FLINK-33462: - Merged to main(jdbc-3.3.0) via

[jira] [Updated] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33462: Fix Version/s: jdbc-3.3.0 > Sort out the document page about the new Jdbc source. >

[jira] [Resolved] (FLINK-33462) Sort out the document page about the new Jdbc source.

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33462. - Resolution: Fixed > Sort out the document page about the new Jdbc source. >

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-13 Thread via GitHub
HuangXingBo commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1639115041 ## .github/workflows/nightly.yml: ## @@ -28,69 +28,131 @@ jobs: name: "Pre-compile Checks" uses: ./.github/workflows/template.pre-compile-checks.yml -

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-06-13 Thread via GitHub
1996fanrui merged PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-06-13 Thread via GitHub
HuangXingBo commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2167064115 Thanks @morazow for the update. I downloaded the wheel package and found that the wheel package after repair is manylinux_2_5. It may be related to not using

[jira] [Updated] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35597: --- Labels: pull-request-available (was: ) > Fix unstable >

[PR] [FLINK-35597][test] Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts [flink]

2024-06-13 Thread via GitHub
liyubin117 opened a new pull request, #24936: URL: https://github.com/apache/flink/pull/24936 ## Brief change log * it should be ia.getNumberOfLocalAssignments() as before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1639108698 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/definition/PipelineValidationTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639108031 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1:

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639106337 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
1996fanrui commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639106337 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink

[jira] [Created] (FLINK-35597) Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts

2024-06-13 Thread Yubin Li (Jira)
Yubin Li created FLINK-35597: Summary: Fix unstable LocatableSplitAssignerTest#testConcurrentSplitAssignmentForMultipleHosts Key: FLINK-35597 URL: https://issues.apache.org/jira/browse/FLINK-35597

[jira] [Updated] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35157: Fix Version/s: 1.20.0 > Sources with watermark alignment get stuck once some subtasks finish >

[jira] [Commented] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854902#comment-17854902 ] Rui Fan commented on FLINK-35157: - Hi [~elon] , would you mind backporting this fix to 1.17, 1.18 and

[jira] [Commented] (FLINK-35157) Sources with watermark alignment get stuck once some subtasks finish

2024-06-13 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854901#comment-17854901 ] Rui Fan commented on FLINK-35157: - Merged to master(1.20.0) via:

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-13 Thread via GitHub
1996fanrui merged PR #24757: URL: https://github.com/apache/flink/pull/24757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FLINK-35596: Make DescriptionElement serializable [flink]

2024-06-13 Thread via GitHub
flinkbot commented on PR #24935: URL: https://github.com/apache/flink/pull/24935#issuecomment-2167007574 ## CI report: * 8c396c54eeda5bc8f8f656847a372b3421c25a7f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] FLINK-35596: Make DescriptionElement serializable [flink]

2024-06-13 Thread via GitHub
venkata91 commented on PR #24935: URL: https://github.com/apache/flink/pull/24935#issuecomment-2167003430 cc @becketqin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (FLINK-35596) Flink application fails with The implementation of the BlockElement is not serializable

2024-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35596: --- Labels: pull-request-available (was: ) > Flink application fails with The implementation

[PR] FLINK-35596: Make DescriptionElement serializable [flink]

2024-06-13 Thread via GitHub
venkata91 opened a new pull request, #24935: URL: https://github.com/apache/flink/pull/24935 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-35596) Flink application fails with The implementation of the BlockElement is not serializable

2024-06-13 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854896#comment-17854896 ] Venkata krishnan Sowrirajan commented on FLINK-35596: - Most likely the

[jira] [Updated] (FLINK-35596) Flink application fails with The implementation of the BlockElement is not serializable

2024-06-13 Thread Venkata krishnan Sowrirajan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venkata krishnan Sowrirajan updated FLINK-35596: Affects Version/s: 1.19.0 > Flink application fails with The

[jira] [Created] (FLINK-35596) Flink application fails with The implementation of the BlockElement is not serializable

2024-06-13 Thread Venkata krishnan Sowrirajan (Jira)
Venkata krishnan Sowrirajan created FLINK-35596: --- Summary: Flink application fails with The implementation of the BlockElement is not serializable Key: FLINK-35596 URL:

Re: [PR] [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
mattayes commented on PR #838: URL: https://github.com/apache/flink-kubernetes-operator/pull/838#issuecomment-2166971750 @gyfora Here's a rework of #837. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [hotfix] [docs] reference.md: Add missing FlinkSessionJob CRD [flink-kubernetes-operator]

2024-06-13 Thread via GitHub
mattayes opened a new pull request, #838: URL: https://github.com/apache/flink-kubernetes-operator/pull/838 ## What is the purpose of the change Add missing documentation for `FlinkSessionJob` CRD. ## Brief change log Add docs for `FlinkSessionJob` CRD.

[jira] [Commented] (FLINK-35485) JobMaster failed with "the job xx has not been finished"

2024-06-13 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854891#comment-17854891 ] Xingcan Cui commented on FLINK-35485: - Hi [~mapohl], I hit the exception again today and it caused

[jira] [Created] (FLINK-35595) MailboxProcessor#processMailsWhenDefaultActionUnavailable is allocation intensive

2024-06-13 Thread David Schlosnagle (Jira)
David Schlosnagle created FLINK-35595: - Summary: MailboxProcessor#processMailsWhenDefaultActionUnavailable is allocation intensive Key: FLINK-35595 URL: https://issues.apache.org/jira/browse/FLINK-35595

Re: [PR] [FLINK-35165][runtime/coordination] AdaptiveBatch Scheduler should not restrict the default source parall… [flink]

2024-06-13 Thread via GitHub
venkata91 commented on code in PR #24736: URL: https://github.com/apache/flink/pull/24736#discussion_r1638672737 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## Review Comment: Addressed it. -- This is

[jira] [Closed] (FLINK-35594) Downscaling doesn't release TaskManagers.

2024-06-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-35594. -- Resolution: Duplicate > Downscaling doesn't release TaskManagers. >

[jira] [Updated] (FLINK-33977) Adaptive scheduler may not minimize the number of TMs during downscaling

2024-06-13 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-33977: --- Affects Version/s: 1.19.0 1.20.0 > Adaptive scheduler may not minimize the

Re: [PR] [FLINK-35165][runtime/coordination] AdaptiveBatch Scheduler should not restrict the default source parall… [flink]

2024-06-13 Thread via GitHub
venkata91 commented on PR #24736: URL: https://github.com/apache/flink/pull/24736#issuecomment-2166456519 > > > Thanks, @venkata91, for your contribution! After reviewing this PR, I'm concerned that it entirely removes limit that source parallelism should lower than source jobVertex's max

[PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
liyubin117 opened a new pull request, #24934: URL: https://github.com/apache/flink/pull/24934 ## What is the purpose of the change Introduce comment for CatalogStore and Support enhanced `CREATE CATALOG` syntax ## Brief change log * add comment instance in

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-13 Thread via GitHub
jnh5y commented on code in PR #24929: URL: https://github.com/apache/flink/pull/24929#discussion_r1638447342 ## docs/content/docs/dev/table/sql/create.md: ## @@ -406,6 +413,14 @@ Flink will assume correctness of the primary key by assuming that the columns nu Partition the

Re: [PR] [FLINK-35585] Add documentation for distribution [flink]

2024-06-13 Thread via GitHub
jnh5y commented on code in PR #24929: URL: https://github.com/apache/flink/pull/24929#discussion_r1638444015 ## docs/content/docs/dev/table/sql/create.md: ## @@ -465,6 +480,7 @@ You can control the merging behavior of: * GENERATED - computed columns * METADATA - metadata

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support `ALTER CATALOG COMMENT` syntax [flink]

2024-06-13 Thread via GitHub
LadyForest commented on code in PR #24932: URL: https://github.com/apache/flink/pull/24932#discussion_r1638477886 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -327,11 +328,15 @@ public void createCatalog(String

Re: [PR] [FLINK-34918][table] Introduce comment for CatalogStore & Support enhanced `CREATE CATALOG` syntax [flink]

2024-06-13 Thread via GitHub
flinkbot commented on PR #24934: URL: https://github.com/apache/flink/pull/24934#issuecomment-2166393201 ## CI report: * d31c5b45069430fcdd04727df1aebde7dd111d97 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   >