GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5455
[FLINK-7711][flip6] Port JarListHandler
## What is the purpose of the change
*Port JarListHandler.*
cc: @tillrohrmann
PR is based on #5442
## Brief change log
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167430276
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167429820
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167429671
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167429608
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java
---
@@ -100,6 +107,16 @@ public DispatcherRestEndpoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167250379
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167249950
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167249729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167249371
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadResponseBody.java
---
@@ -0,0 +1,58
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167249285
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5442
[FLINK-7713][flip6] Implement JarUploadHandler
## What is the purpose of the change
*Allow uploading jars through HTTP to enable job submissions from the web
ui.*
cc: @tillrohrmann
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5422
[FLINK-8575][runtime] BackPressureStatsTrackerITCase unstable
## What is the purpose of the change
*This fixes BackPressureStatsTrackerITCase unstability.*
## Brief change log
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4809#discussion_r166001086
--- Diff: docs/ops/state/savepoints.md ---
@@ -120,6 +120,10 @@ This will atomically trigger a savepoint for the job
with ID `:jobid` and cancel
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5334
I have a usability concern.
It's possible to run
```
FLINK_MODE=flip6 bin/start-cluster.sh
```
This will start a cluster in flilp6 mode.
However,
```
FLINK_MODE=flip6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5353#discussion_r165972923
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/AbstractTaskManagerFileHandler.java
---
@@ -0,0 +1,236
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5353#discussion_r165950588
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -285,11 +287,22 @@ private static String createMessageHtmlEntry
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5353#discussion_r165962518
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCache.java
---
@@ -222,7 +221,13 @@ public File getStorageLocation(@Nullable
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5341#discussion_r165941154
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -473,10 +476,55 @@ public WebMonitorEndpoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5341#discussion_r165942186
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -473,10 +476,55 @@ public WebMonitorEndpoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835719
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -305,6 +311,84 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835514
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -305,6 +311,84 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835488
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -358,6 +361,18 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835486
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -313,6 +325,13 @@ public JobMaster
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835482
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobVertexBackPressureInfo.java
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835483
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -867,6 +889,25 @@ public void heartbeatFromResourceManager(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165835481
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -305,6 +311,84 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165666773
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java
---
@@ -75,6 +76,17 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165298568
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -305,6 +311,84 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165296204
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobVertexBackPressureInfo.java
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165296332
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -358,6 +361,18 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165155912
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTracker.java
---
@@ -74,7 +74,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165155639
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobVertexBackPressureInfo.java
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5397#discussion_r165155368
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java
---
@@ -75,6 +76,17 @@ public void
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5397
[FLINK-7856][flip6] WIP
WIP
PR is based on #4893
@tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5353#discussion_r164992599
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
---
@@ -175,4 +177,13 @@
final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5354#discussion_r164438991
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -485,7 +477,10 @@ protected TaskManagerSlot
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5354#discussion_r164434005
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -388,6 +378,8 @@ public boolean
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5312
Thanks man ð
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5310
ð
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r164087390
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStore.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5310
No, I only had hard crashes in mind. One could do a directory listing and
delete old files.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164075001
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -258,89 +312,96 @@ public String cancelWithSavepoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164074804
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -258,89 +312,96 @@ public String cancelWithSavepoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164074612
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java
---
@@ -19,60 +19,73 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164074572
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientConfigurationTest.java
---
@@ -0,0 +1,51
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164074605
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java
---
@@ -19,60 +19,73 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164074562
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -41,4 +41,34 @@
public static final ConfigOption REST_PORT
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r164074500
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestClientTest.java
---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5310
Is it acceptable behavior that sometimes Graphs don't get deleted from disk?
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5311#discussion_r163923585
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -100,8 +97,6 @@
private final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163919241
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java
---
@@ -0,0 +1,319
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163918048
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java
---
@@ -0,0 +1,319
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163915273
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStore.java
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163911570
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -486,11 +510,22 @@ private void onFatalError(Throwable
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163921620
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/concurrent/ManuallyTriggeredScheduledExecutor.java
---
@@ -0,0 +1,167
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163922121
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java
---
@@ -0,0 +1,319
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163919921
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java
---
@@ -0,0 +1,319
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5309#discussion_r163571196
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -228,10 +246,10 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5309#discussion_r163570275
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -199,12 +212,17 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5309#discussion_r163546199
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -30,62 +30,69 @@
import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5309#discussion_r163549462
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -331,13 +331,13 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5308#discussion_r163538231
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -752,16 +751,21 @@ public Executor getFutureExecutor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5308#discussion_r163536073
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/accumulators/AccumulatorHelper.java
---
@@ -173,4 +173,23 @@ public static String
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5308#discussion_r163540049
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -1701,40 +1705,4 @@ void notifyExecutionChange
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5308#discussion_r163544619
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerMockTest.java
---
@@ -250,19 +255,15 @@ public void
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5309
This PR is based on #5308
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5342
Could it be that the ticket in the title of the PR is wrong?
https://issues.apache.org/jira/browse/FLINK-8470 seems to be about something
else.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5339
ui
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163227450
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -596,11 +596,11 @@ public int run(String[] args) throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163161066
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java
---
@@ -132,4 +137,23 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163161003
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -327,13 +376,14 @@ public T getClusterId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160938
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160802
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160900
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -61,46 +69,77 @@
import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160849
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -327,13 +376,14 @@ public T getClusterId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160791
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160703
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java
---
@@ -30,49 +28,20 @@
*/
public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r163160672
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -144,6 +154,15 @@ public WebMonitorEndpoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162893190
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/LeaderHolder.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5318#discussion_r162865803
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -717,15 +717,14 @@ private void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5318#discussion_r162867279
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -1337,11 +1340,16 @@ public void reportPayload(ResourceID
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5318#discussion_r162867968
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1425,4 +1440,137 @@ public void
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5319
ð¯
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162715070
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162714906
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -61,46 +69,77 @@
import
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162714628
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4979#discussion_r162632757
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -138,7 +138,9
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162581631
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -376,4 +430,99 @@ public GetClusterStatusResponse
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5315
[hotfix][docs] Put HADOOP_CONF_DIR in tag
See title.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink hotfix-hadoop-conf-dir
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162416324
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -327,13 +376,14 @@ public T getClusterId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162414419
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionService.java
---
@@ -412,4 +413,11 @@ protected void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162412277
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -596,11 +596,11 @@ public int run(String[] args) throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162413303
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -251,6 +245,12 @@ protected void channelRead0(ChannelHandlerContext
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5312#discussion_r162412749
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java
---
@@ -132,4 +137,23 @@ public
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5312
cc: @tillrohrmann
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5312
[FLINK-8344][WIP] Add support for HA to RestClusterClient
WIP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink rest-cluster-client-ha
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5305
Thanks for your contribution, @nicktoker. Unfortunately with your pull
request you are trying to merge the `release-1.3` branch into the `master`. You
probably want to create a feature branch from
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161368455
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -0,0 +1,337
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242333
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java
---
@@ -0,0 +1,277
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5223#discussion_r161242312
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/savepoints/SavepointInfoTest.java
---
@@ -0,0 +1,52
301 - 400 of 690 matches
Mail list logo
