Github user stefanobaghino commented on the issue:
https://github.com/apache/flink/pull/2187
Awesome, thanks for addressing the issue @mxm! I noticed you added a
couple of environment variables, could it make sense to document them?
---
If your project is set up for it, you can
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-205288351
It's been a pleasure, thanks for the patience and for guiding me through
the iterations. :smiley:
---
If your project is set up for it, you can reply
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-205236293
Ok, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-205235613
You're right, sorry. I can fix this right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-205234947
@StephanEwen Thanks for the feedback, I've addressed the points you
highlighted and took the time to add some missing Scaladoc to the `DataStream`
extension
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1837#issuecomment-204405759
Thanks! Hope it will make it to 1.0.1. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-204334976
Note on the tests of the streaming extensions: I couldn't find a more
specific class than `SingleOutputStreamOperator[_]`, thus assertion may not be
very
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1837#issuecomment-204301276
I think this is ready.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1837#discussion_r57986135
--- Diff: docs/setup/config.md ---
@@ -275,6 +275,10 @@ For example when running Flink on YARN on an
environment with a restrictive fire
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1837#discussion_r57913426
--- Diff: docs/setup/config.md ---
@@ -275,6 +275,10 @@ For example when running Flink on YARN on an
environment with a restrictive fire
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1837
[FLINK-3678] Make Flink logs directory configurable
* Edit config.sh
* Document the newly defined log directory configuration key
You can merge this pull request into a Git repository
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-201325574
@tillrohrmann I moved forward on the batch extensions: I added support for
anonymous partial functions on `where` and `equalsTo` for joins and co-group
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r57452214
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/extensions/package.scala
---
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1836
[hotfix][docs] Fix a couple of typos in YARN documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radicalbit/flink hotfix-docs
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1828
[FLINK-3653] recovery.zookeeper.storageDir is not documented on the
configuration page
Also: minor _hotfix_ to the `state.backend.fs.checkpointdir` option
description (punctuation, casing
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-199837531
A quick status update: unfortunately I have had no time to work on this in
the past week, I plan to get back to the fixes on Thursday or Friday
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1803#discussion_r56365211
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java
---
@@ -38,7 +38,8
Github user stefanobaghino closed the pull request at:
https://github.com/apache/flink/pull/1803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1812
[hotfix] Fix typo 'JobManger'
Occurrences of JobManger replaced with JobManager.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user stefanobaghino closed the pull request at:
https://github.com/apache/flink/pull/1804
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1804
[hotfix][docs] fs.hdfs.hadoopconf typo
teh -> the (third word from the end of the line)
You can merge this pull request into a Git repository by running:
$ git pull https://github.
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1803
[hotfix][examples] Add zookeeper.connect to usage line
Follow-up to [this
thread](http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Unable-to-Read-from-Kafka-zookeeper
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-196321443
@tillrohrmann I just have one minor concern regarding the tests: would
`isInstanceOf[StreamMap[Int, Int]]` work? Wouldn't the generic type parameters
(the two
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-196320836
@tillrohrmann Thanks! Outstanding review, it's great to have some guidance
when approaching a new project; thank you for the tips on testing as well, it
turned
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r56000181
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/extensions/acceptPartialFunctions/OnWindowedStream.scala
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r55996335
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/extensions/acceptPartialFunctions/OnDataSet.scala
---
@@ -0,0 +1,104
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r55995777
--- Diff: docs/apis/scala_api_extensions.md ---
@@ -0,0 +1,392 @@
+---
+title: "Scala API Extensions"
+# Top-level navigation
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r55995517
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/extensions/package.scala
---
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-195818369
Thanks for the feedback. Basically the tests so far have been a carbon copy
of the ones run on the operators I delegate to from the extensions. I agree
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-195290267
@tillrohrmann The tests failure seem to be flaky, I've re-run them all on
our fork and they're all green now (after a couple of retries).
---
If your project
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-192259307
@tillrohrmann Yes, I've already fixed them locally, thanks for the notice
and for pinging me. I'm working on the documentation, sorry if it's taking me a
little
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1718
[FLINK-3518] Stale docs for quickstart setup
* Fix the usage line
* Explicitly state to stop the local environment
* _Doesn't fix_ the broken download link (no release yet)
You can
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188790808
@StephanEwen I had to restore some of the context bounds on `ClassTag` to
make it compile, apparently the delegated methods use them; I've rebased
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188409068
This should cover the missing implementations. I also included the tests I
used to test the functionality, let me know if you prefer a wider coverage.
I'll
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188352497
@tillrohrmann I got mixed up reading your proposal and just got what you
meant with the `extensions.acceptPartialFunctions` implicit conversion, thanks
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188343795
:+1: @StephanEwen I started working on the extension before the removal,
will fix this as well, thanks for the feedback.
---
If your project is set up
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188325067
Just the streaming guide? Not on both the streaming and batch?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1704#issuecomment-188301093
Thanks @tillrohrmann, I'll fix the errors in the comments and add the
missing methods and extensions.
Regarding the import mode, I agree with you. I
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r53950863
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/extensions/acceptPartialFunctions/package.scala
---
@@ -0,0
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1704#discussion_r53950747
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/extensions/acceptPartialFunctions/package.scala
---
@@ -0,0 +1,174
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1704
[FLINK-1159] Case style anonymous functions not supported by Scala API
The proposed API extension methods would allow developers to pass a pattern
matching anonymous function so
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-187764378
@rmetzger Thanks, it's been a nice starter, thanks to both you and @fhueske
for the help!
---
If your project is set up for it, you can reply to this email
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-187248829
Running the test locally with the same `PROFILE` as the failing tests do
not yield the same results (i.e. all tests pass). Is there a way to determine
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-187221864
Was this a hiccup in the build or an issue related to my changes? I really
can't tell from the error message.
---
If your project is set up for it, you can
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-185772362
Three build configurations passes, one is currently running, the other
fails and I've spotted this stacktrace:
```
[ERROR] error: error while loading
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1665#issuecomment-185756748
I'm going into the direction proposed by @StephanEwen, the change looks
trivial.
---
If your project is set up for it, you can reply to this email and have your
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1665
[FLINK-3438] ExternalProcessRunner fails to detect ClassNotFound exception
because of locale settings
This should be regarded as a temporary solution to this issue in
particular. See
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-185200365
I see there's a conflict, perhaps due to my minor fix in
`YARNSessionFIFOITCase.java`, can I help fix this one? At this point I'm pretty
sure it's the last thing
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184850520
Thanks for the tip, I'll try to replicate the S3 setup on our fork as well,
it'll probably come in handy for similar cases.
---
If your project is set up
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184753539
@rmetzger I'm looking at the logs as well but I couldn't find that
stacktrace in particular. I've looked for `ParameterTool.fromArgs` (that is
present
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184747590
Thanks for digging up the tests, I missed that exception in particular,
I'll fix it right away.
---
If your project is set up for it, you can reply
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184589232
I think this should do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-183181049
@fhueske If this is what you had in mind I can go on and apply it to the
rest of the examples.
---
If your project is set up for it, you can reply to this email
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-182520553
That's absolutely not a problem @fhueske, your remarks are reasonable and I
do appreciate the care you all take in making sure Flink turns out great. It's
my
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-180985129
I'm not sure of why some tests keep failing. I've also noticed that the
build of our fork failed differently. They don't seem to affect
`flink-batch-examples
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1598
[FLINK-3353] CSV-related tests may fail depending on locale
As the results are hard-coded, it makes sense to explicitly pass the US
locale to render the results as strings. Should close
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1592
[hotfix] [docs] Fixed typo in process model illustration
YARM -> YARN
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radicalbit/fl
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-180329011
Oh, ok, I obviously got it wrong, thanks for the explanation. Fine with me,
I'll fix it along the other issues of the PR.
---
If your project is set up
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1581#discussion_r51875652
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java
---
@@ -62,18 +63,32 @@
public
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-179949096
Following your suggestions, thanks.
* squash: should I squash the commits coming from the review as well?
* tests: I thought it was about some Travis
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-179225452
Branch recreated to remove merge commits, now opened as #1581.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1581
[FLINK-2021] Rework examples to use ParameterTool
This should fix [FLINK-2021]. I was unable to run a full build because of
permission issues but it should be ready to merged, after any
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-177954808
Since it looks like I've gathered enough feedback, I'm closing the PR so
that I can keep working on it and not burden on the CI system. Sorry for the
WIP PR
Github user stefanobaghino closed the pull request at:
https://github.com/apache/flink/pull/1536
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-176700143
It works, I'll be pushing the code in a few minutes. If everything looks
good I can move on to the other examples. Thank you all the precious feedback
provided
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174960226
I'll edit the code so that we can all read the result and maybe discuss
about the pros and cons of this approach. Again, thank you both for the
feedback
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174966751
This can be a starting point for further discussion. The only weak point I
see (but maybe I'm wrong) is that right now we're reading `Tuple`s and then
converting
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174951427
Maybe I can rework the example so that secondary needs (like parameter
parsing and source reading) are encapsulated in functions kept at the bottom,
while
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174950384
Good, I'll keep on working on the PR with the other examples, thank you for
the feedback and for the guidance provided so far. :smiley:
---
If your project
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1550
[FLINK-3289] References to flink-contrib merged
Closes FLINK-3289.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radicalbit/flink 3289
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/commit/dd4e278545182f0d4cbf403911f550c1badde125#commitcomment-15677128
I can further improve the examples using `case classes` in the Scala
example. Doing it while retaining the usage
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-173871987
It seems like your improvements have had a positive feedback from the ML.
Shall I proceed replicating those on other examples as well?
---
If your project
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-173876414
I'll take some time. I've spotted another possible issue in the docs, I'll
look into it as we gain more feedback from the mailing list. Thank you!
---
If your
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50399418
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50402286
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50399628
--- Diff:
flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala
---
@@ -104,36 +105,52 @@ object
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1536
[FLINK-2021] Rework examples to use ParameterTool (K-Means)
I've reworked the K-Means examples in Java and Scala to get a feeling of
what it would mean on the whole examples code base. Just
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50400122
--- Diff:
flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala
---
@@ -104,36 +105,52 @@ object
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50406845
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public
79 matches
Mail list logo
