[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r574522921 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,56 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r574523861 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java ## @@ -600,6 +616,171 @@ public void testSubmitWithUnknown

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r574568680 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,56 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r574569882 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java ## @@ -600,6 +616,171 @@ public void testSubmitWithUnknown

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r574578211 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,56 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r575043953 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,56 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r575246034 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +625,414 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576239135 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,57 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576239135 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,57 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576241481 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +625,414 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576278350 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,57 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576278350 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,57 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576615862 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +624,289 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576616131 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +624,289 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576616131 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +624,289 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576617075 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -817,6 +818,126 @@ public void testStopWithSa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r576628701 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -817,6 +818,126 @@ public void testStopWithSa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r577147425 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,57 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r577148145 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +624,289 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r577152942 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +625,414 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r577157152 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,38 +909,57 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r577158379 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -605,6 +624,289 @@ public void abortPendingChe

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578561800 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -835,8 +837,15 @@ public void updateAccumulators(fina

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578567121 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -817,6 +818,126 @@ public void testStopWithSa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578567820 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -817,6 +818,126 @@ public void testStopWithSa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578568213 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,49 +909,38 @@ public void reportCheckpointMetric

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578581053 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578580800 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578581744 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointOperations.java ## @@ -0,0 +1,54 @@ +/* + * Licensed to the A

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578582587 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578584067 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578584522 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579292914 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImplTest.java ## @@ -0,0 +1,330 @@ +/* + *

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579298421 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,258 @@ +/* + * Lice

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579663983 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,258 @@ +/* + * Lice

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579664565 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,258 @@ +/* + * Lice

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r579664779 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,258 @@ +/* + * Lice

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r580511819 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImplTest.java ## @@ -0,0

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r580518051 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r580520576 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r580523907 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r580542102 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r580901980 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r581376284 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r581941734 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -541,6 +544,59 @@ public void handleGlobalFail

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r581945379 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r581982820 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -835,8 +840,21 @@ public void updateAccumulators(fina

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r581982820 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -835,8 +840,21 @@ public void updateAccumulators(fina

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582029660 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -835,8 +840,21 @@ public void updateAccumulators(fina

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582989152 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointTerminationHandlerImpl.java ## @@ -0,0 +1,2

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582990665 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582991307 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582991828 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582992549 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apa

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r582996083 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apa