[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082600527 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionChe

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-20 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1082365656 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -280,4 +280,13 @@ public class ExecutionChe

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-19 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1081119337 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -107,49 +119,78 @@ void run() {

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2023-01-19 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1081118070 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class ChannelStateWriteRe

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-19 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1052418421 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class ChannelStateWriteRe

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-19 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1052319366 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java: ## @@ -286,27 +277,32 @@ private void runWithChecks(Runn

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-19 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1052295272 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java: ## @@ -18,280 +18,265 @@ package org.apache.flink.runti

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-14 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1048286114 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateCheckpointWriter.java: ## @@ -18,280 +18,265 @@ package org.apache.flink.runti

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-12-14 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1048154979 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java: ## @@ -252,4 +252,13 @@ public class ExecutionChe

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

2022-10-20 Thread GitBox
pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1000549678 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequest.java: ## @@ -205,9 +207,17 @@ public CheckpointStorageLocationRefe