[GitHub] flink pull request #6419: [FLINK-9949][tests] Kill Flink processes in DB/tea...

2018-07-25 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/6419 [FLINK-9949][tests] Kill Flink processes in DB/teardown ## What is the purpose of the change *Not killing Flink processes at the end of a test, can cause interference with subsequent test runs.

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205110205 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/DataSetAllroundTestProgram.java --- @@ -66,14 +61,2

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205106925 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/DataSetAllroundTestProgram.java --- @@ -66,14 +61,21

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205108213 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/Generator.java --- @@ -0,0 +1,147 @@ +/* + *

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205108561 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/Generator.java --- @@ -0,0 +1,147 @@ +/* + *

[GitHub] flink pull request #6396: [FLINK-9806][docs] Add canonical link element to d...

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6396 ---

[GitHub] flink pull request #6407: [FLINK-9877][docs] Add documentation page for diff...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6407#discussion_r205097411 --- Diff: docs/dev/stream/operators/joining.md --- @@ -0,0 +1,286 @@ +--- +title: "Joining" +nav-id: streaming_joins +nav-show_overview: true

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205087147 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205084257 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +###

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205084180 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +###

[GitHub] flink pull request #6418: [FLINK-9939][runtime] Mesos: Not setting TMP dirs ...

2018-07-25 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/6418 [FLINK-9939][runtime] Mesos: Not setting TMP dirs causes NPE ## What is the purpose of the change *This fixes a possible NPE when deploying on Mesos.* ## Brief change log - *

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205082457 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +###

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205081350 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205080760 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +###

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205078058 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205076492 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +###

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205069073 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/DataSetAllroundTestProgram.java --- @@ -66,14 +59,21

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070681 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070467 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070430 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205072007 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070024 --- Diff: flink-end-to-end-tests/flink-dataset-allround-test/src/main/java/org/apache/flink/batch/tests/Generator.java --- @@ -0,0 +1,166 @@ +/* + *

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205071341 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6415#discussion_r205070634 --- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh --- @@ -0,0 +1,139 @@ +#!/usr/bin/env bash +#

[GitHub] flink pull request #6417: [FLINK-9913][runtime] Improve output serialization...

2018-07-25 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/6417 [FLINK-9913][runtime] Improve output serialization only once in RecordWriter ## What is the purpose of the change *This pull request improves the output serialization only once for multi

[GitHub] flink pull request #6416: [FLINK-9942][rest] Guard handlers against null fie...

2018-07-25 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/6416 [FLINK-9942][rest] Guard handlers against null fields ## What is the purpose of the change This PR fixes prevents some NPEs that could arise if fields in the request are set to null or are o

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread cjolif
Github user cjolif commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205051308 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/Elasticsearch6ApiCallBridge.java ---

[GitHub] flink pull request #6414: [hotfix] Enrich exception message

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6414 ---

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205037835 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/resources/log4j-test.properties --- @@ -0,0 +1,27 @@ +#

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205037795 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch6/examples/ElasticsearchSinkExample.j

[GitHub] flink pull request #6388: [FLINK-6222] Allow passing env variables to start ...

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6388 ---

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205031956 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/EmbeddedElasticsearchNodeEnvironment

[GitHub] flink pull request #6372: [Flink-9353] Tests running per job standalone clus...

2018-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/6372#discussion_r205030130 --- Diff: flink-end-to-end-tests/README.md --- @@ -31,6 +31,12 @@ You can also run tests individually via $ FLINK_DIR= flink-end-to-end-tests/run-single

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r205029480 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -96,6 +96,7 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR

[GitHub] flink pull request #6415: [FLINK-8974] Run all-round DataSet job with failur...

2018-07-25 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/6415 [FLINK-8974] Run all-round DataSet job with failures in HA mode Added all-round DataSet end-to-end test that runs in HA mode. It verifies the job is restarted correctly after job manager failure.

[GitHub] flink pull request #6392: [FLINK-9694][table] Fix NPE in CRowSerializerConfi...

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6392 ---

[GitHub] flink pull request #6414: [hotfix] Enrich exception message

2018-07-25 Thread TisonKun
GitHub user TisonKun opened a pull request: https://github.com/apache/flink/pull/6414 [hotfix] Enrich exception message ## What is the purpose of the change There is a time I got fail on ExecutionGraphTestUtils#waitUntilJobStatus, it throws `TimeoutException` without detail

[GitHub] flink pull request #6372: [Flink 9353] Tests running per job standalone clus...

2018-07-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/6372#discussion_r205014402 --- Diff: flink-end-to-end-tests/README.md --- @@ -31,6 +31,12 @@ You can also run tests individually via $ FLINK_DIR= flink-end-to-end-tests/run-single

[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...

2018-07-25 Thread Lemonjing
GitHub user Lemonjing reopened a pull request: https://github.com/apache/flink/pull/6411 [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ## What is the purpose of the change This pull request update scala api `ScalaCsvOutputFormat` to

[GitHub] flink pull request #6413: [FLINK-8993] [tests] Let general purpose DataStrea...

2018-07-25 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/6413 [FLINK-8993] [tests] Let general purpose DataStream job uses KryoSerializer via type extraction ## What is the purpose of the change The general purpose DataStream job previously only uses

[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...

2018-07-25 Thread Lemonjing
Github user Lemonjing closed the pull request at: https://github.com/apache/flink/pull/6411 ---

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204756208 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204999073 --- Diff: flink-end-to-end-tests/run-nightly-tests.sh --- @@ -96,6 +96,7 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204991878 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/EmbeddedElasticsearchNodeEnvironmentI

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204758828 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java ---

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204758434 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204993234 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSinkITCase.java ---

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204994308 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/resources/log4j-test.properties --- @@ -0,0 +1,27 @@ +##

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204990734 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java --- @@ -

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204775927 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java --- @@ -

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204992515 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSinkITCase.java ---

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204991006 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java --- @@ -

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204993809 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch6/examples/ElasticsearchSinkExample.ja

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204991076 --- Diff: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java --- @@ -

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204757871 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204750192 --- Diff: docs/dev/connectors/elasticsearch.md --- @@ -138,6 +143,31 @@ input.addSink(new ElasticsearchSink<>(config, transportAddresses, new Elasticsea

[GitHub] flink pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6...

2018-07-24 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6391#discussion_r204752713 --- Diff: docs/dev/connectors/elasticsearch.md --- @@ -190,9 +220,30 @@ input.addSink(new ElasticsearchSink(config, transportAddresses, new Elasticsearc

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204999405 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204996330 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink pull request #6231: [FLINK-9694] Potentially NPE in CompositeTypeSeria...

2018-07-24 Thread yanghua
Github user yanghua closed the pull request at: https://github.com/apache/flink/pull/6231 ---

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-24 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204998677 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink pull request #6412: [FLINK-9941] Flush in ScalaCsvOutputFormat before ...

2018-07-24 Thread buptljy
Github user buptljy closed the pull request at: https://github.com/apache/flink/pull/6412 ---

[GitHub] flink pull request #6412: [FLINK-9941] Flush in ScalaCsvOutputFormat before ...

2018-07-24 Thread buptljy
GitHub user buptljy opened a pull request: https://github.com/apache/flink/pull/6412 [FLINK-9941] Flush in ScalaCsvOutputFormat before close ## What is the purpose of the change - Flush in ScalaCsvOutputFormat before close.We've already finished it in org.apache.flink.api.java.i

[GitHub] flink pull request #6403: [FLINK-9934] [table] Fix invalid field mapping by ...

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6403 ---

[GitHub] flink pull request #3124: [FLINK-5281] Extend KafkaJsonTableSources to suppo...

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3124 ---

[GitHub] flink pull request #6411: [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputForm...

2018-07-24 Thread Lemonjing
GitHub user Lemonjing opened a pull request: https://github.com/apache/flink/pull/6411 [FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to ensure CI stability ## What is the purpose of the change This pull request update scala api `ScalaCsvOutputFormat` to in

[GitHub] flink pull request #6410: Release 1.6

2018-07-24 Thread uang520
Github user uang520 closed the pull request at: https://github.com/apache/flink/pull/6410 ---

[GitHub] flink pull request #6410: Release 1.6

2018-07-24 Thread uang520
GitHub user uang520 opened a pull request: https://github.com/apache/flink/pull/6410 Release 1.6 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, ple

[GitHub] flink pull request #6401: [hotfix]fix typo for variable name dynamicProperti...

2018-07-24 Thread rileyli
Github user rileyli closed the pull request at: https://github.com/apache/flink/pull/6401 ---

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-24 Thread glaksh100
Github user glaksh100 commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204942574 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26

[GitHub] flink pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive read...

2018-07-24 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/flink/pull/6408#discussion_r204922265 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -233,26 +2

[GitHub] flink pull request #6409: Flink 9899.kinesis connector metrics

2018-07-24 Thread glaksh100
GitHub user glaksh100 opened a pull request: https://github.com/apache/flink/pull/6409 Flink 9899.kinesis connector metrics ## What is the purpose of the change The purpose of this change is to add metrics to the `ShardConsumer` to get more observability into the performanc

[GitHub] flink pull request #6408: [FLINK-9897] Make adaptive reads depend on run loo...

2018-07-24 Thread glaksh100
GitHub user glaksh100 opened a pull request: https://github.com/apache/flink/pull/6408 [FLINK-9897] Make adaptive reads depend on run loop time instead of fetchintervalmillis ## What is the purpose of the change [FLINK-9692](https://github.com/apache/flink/pull/6300) introduced

[GitHub] flink pull request #6407: [FLINK-8478][docs] Add documentation page for diff...

2018-07-24 Thread florianschmidt1994
GitHub user florianschmidt1994 opened a pull request: https://github.com/apache/flink/pull/6407 [FLINK-8478][docs] Add documentation page for different datastream joins ## What is the purpose of the change Add a documentation page under Application Development / Streaming /

[GitHub] flink pull request #6406: [FLINK-9159][runtime] Sanity check default timeout...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6406#discussion_r204820593 --- Diff: flink-docs/README.md --- @@ -28,7 +28,7 @@ The `RestAPIDocGenerator` can be used to generate a full reference of the REST A To integrate a new

[GitHub] flink pull request #6406: [FLINK-9159][runtime] Sanity check default timeout...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6406#discussion_r204819304 --- Diff: flink-docs/README.md --- @@ -28,7 +28,7 @@ The `RestAPIDocGenerator` can be used to generate a full reference of the REST A To integrate a new

[GitHub] flink pull request #6406: [FLINK-9159][runtime] Sanity check default timeout...

2018-07-24 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/6406 [FLINK-9159][runtime] Sanity check default timeout values ## What is the purpose of the change *Set the default timeouts for resource release to sane values. Consolidate config keys and documen

[GitHub] flink pull request #6398: [FLINK-9923][tests] Harden OneInputStreamTaskTest#...

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6398 ---

[GitHub] flink pull request #6405: [FLINK-8439] Add Flink shading to AWS credential p...

2018-07-24 Thread azagrebin
GitHub user azagrebin opened a pull request: https://github.com/apache/flink/pull/6405 [FLINK-8439] Add Flink shading to AWS credential provider s3 hadoop c… ## What is the purpose of the change This PR refactors S3 Hadoop and Presto file systems and adds Flink shading to

[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6400#discussion_r204758822 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java --- @@ -28,15 +35,21 @@ * {@cod

[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6400#discussion_r204757730 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java --- @@ -57,4 +70,77 @@ public JobVert

[GitHub] flink pull request #6400: [FLINK-9931][ui] watermark display bug.

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6400#discussion_r204759313 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java --- @@ -28,15 +35,21 @@ * {@cod

[GitHub] flink pull request #6388: [FLINK-6222] Allow passing env variables to start ...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6388#discussion_r204750473 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -96,6 +96,8 @@ DEFAULT_ENV_JAVA_OPTS=""# Optional JVM args DEFAU

[GitHub] flink pull request #6393: [FLINK-9296] [table] Add support for non-windowed ...

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6393 ---

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720999 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -297,7 +300,13 @@ public void testFailingDataSinkTask()

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721547 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java --- @@ -45,33 +46,30 @@ public class DataSourceTa

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721015 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -337,7 +345,13 @@ public void testFailingSortingDataSin

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721035 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -363,7 +376,9 @@ public void testCancelDataSinkTask() t

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720914 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -79,12 +75,11 @@ public void testDataSinkTask() {

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721046 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -419,7 +432,13 @@ public void testCancelSortingDataSink

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204721390 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSourceTaskTest.java --- @@ -45,33 +46,30 @@ public class DataSourceTa

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720983 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -225,7 +224,13 @@ public void testSortingDataSinkTask()

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204718919 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java --- @@ -4

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204722139 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -240,36 +205,19 @@ public void testOnlyLevel2NestedDir

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204719730 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorITCase.java --- @@ -127,7 +132,7 @@ public void testSlotAllocation()

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720974 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -141,7 +136,13 @@ public void testUnionDataSinkTask() {

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204719565 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java --- @@ -218,7 +224,7 @@ public void TestAnonymousClass() throws I

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720758 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/DataSinkTaskTest.java --- @@ -49,22 +50,17 @@ import static org.junit.Assert.as

[GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J...

2018-07-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204720065 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -338,22 +279,11 @@ public void testGetStatisticsMultip

[GitHub] flink pull request #6341: [FLINK-5750] Incorrect translation of n-ary Union

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6341 ---

  1   2   3   4   5   6   7   8   9   10   >