Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1941
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-220133396
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-220094095
Thanks for the update. Looks good. Will merge it later :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63703304
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -102,58 +116,62 @@ public void t
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-220028713
Thanks for the update @fpompermaier. Just had a few minor comments. After
that this PR should be good to merge.
---
If your project is set up for it, you can reply to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63703169
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -102,58 +116,62 @@ public void t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63702355
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -48,17 +49,53 @@
/**
* Inp
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63702313
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -48,17 +49,53 @@
/**
* Inp
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63680024
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -156,88 +63,97 @@ public vo
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-219961812
Hi @fpompermaier, I added one more comment. I'm not sure if you noticed the
other two comments I made a fews day back to `JDBCFullTest` and
`JdbcInputFormat.nextRecord()
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63664643
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -156,88 +63,97 @@ public void te
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63174853
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63173122
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java
---
@@ -0,0 +1,91 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63162186
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -94,31 +94,106 @@ private void estab
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63161970
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -94,31 +94,106 @@ private void estab
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63161244
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
---
@@ -0,0 +1,182 @@
+/**
+ * Licensed
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62854701
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java
---
@@ -0,0 +1,91 @@
+/*
+
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62852662
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolea
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62850239
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
---
@@ -0,0 +1,182 @@
+/**
+ * Lic
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62847383
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void co
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-218438515
Thanks for the update @fpompermaier. Overall the PR looks good. I added a
few comments and suggestions. Thanks, Fabian
---
If your project is set up for it, you can rep
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62834635
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java
---
@@ -0,0 +1,91 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62834552
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -19,135 +19,42 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62834121
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
---
@@ -0,0 +1,182 @@
+/**
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833701
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -19,180 +19,224 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833691
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -19,180 +19,224 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833637
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -19,180 +19,224 @@
package o
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833518
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/ParameterValuesProvider.java
---
@@ -15,17 +15,21 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833327
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
---
@@ -0,0 +1,70 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833293
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
---
@@ -0,0 +1,70 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833230
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -95,32 +95,32 @@ private void establ
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833149
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -95,32 +95,32 @@ private void establ
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833050
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -352,6 +318,10 @@ public JDBCInputFor
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62833018
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -314,6 +279,7 @@ public static JDBCIn
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832955
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832846
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832789
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832683
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -113,19 +192,7 @@ public void close()
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832699
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -113,19 +192,7 @@ public void close()
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832588
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832479
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832266
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -19,59 +19,112 @@
package org.ap
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832299
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -19,59 +19,112 @@
package org.ap
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832218
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +134,51 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62024853
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/GenericSplitsGenerator.java
---
@@ -0,0 +1,41 @@
+/**
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62022375
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +203,25 @@ public boolea
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62021965
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +203,25 @@ public boolean reac
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62021375
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +203,25 @@ public boolea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019090
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -139,12 +184,13 @@ public void close(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019194
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -95,32 +95,32 @@ private void establ
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019420
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericColumnSplitsGenerator.java
---
@@ -0,0 +1,63 @@
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-216825461
Thanks for the update @fpompermaier. I added a few comments and suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019523
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +203,25 @@ public boolea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019142
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -314,7 +262,8 @@ public static JDBCIn
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019506
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/example/JDBCFullTest.java
---
@@ -0,0 +1,93 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62019163
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -95,32 +95,32 @@ private void establ
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018585
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +203,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018617
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +203,25 @@ public boolean rea
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018432
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -139,12 +184,13 @@ public void close(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018300
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +127,36 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018256
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -81,25 +127,36 @@ public void configu
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018227
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -21,57 +21,103 @@
import java.io
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018169
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/JDBCInputSplitsGenerator.java
---
@@ -15,17 +15,14 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018058
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/JDBCInputSplitsGenerator.java
---
@@ -15,17 +15,14 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62017855
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/QueryParamInputSplit.java
---
@@ -0,0 +1,53 @@
+/*
+ * License
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1941#issuecomment-216232502
Thanks for the PR @fpompermaier.
I think the new format is a bit too much tailored towards certain query
templates (`BETWEEN` predicate on integer column). Also modif
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r61736272
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -26,52 +26,69 @@
import jav
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r61735803
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/GenericRow.java
---
@@ -0,0 +1,123 @@
+package org.apache.flink.ap
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r61735690
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -352,6 +294,13 @@ public JDBCInputFor
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r61735650
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -26,52 +26,69 @@
import java.sql
GitHub user fpompermaier opened a pull request:
https://github.com/apache/flink/pull/1941
Flink 3750 fixed
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items i
71 matches
Mail list logo
