Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69145972
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69127489
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69107628
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69093616
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68984285
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68983836
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68974303
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68973636
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68931182
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1235,7 +1234,7 @@ class JobManager(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68914059
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1235,7 +1234,7 @@ class JobManager(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68913433
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/stats/SimpleCheckpointStatsTracker.java
---
@@ -106,10 +108,12 @@
* The
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68909752
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1235,7 +1234,7 @@ class JobManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68909550
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1235,7 +1234,7 @@ class JobManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68908870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/stats/SimpleCheckpointStatsTracker.java
---
@@ -106,10 +108,12 @@
*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68744357
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -663,6 +677,9 @@ public boolean
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68741425
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager(
//
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68734570
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68733223
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68732963
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager(
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68732049
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager(
//
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68731503
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68729588
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager(
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68729523
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -30,6 +30,7 @@
import org.slf4j.Logger;
import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68729084
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68728603
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager(
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68728510
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -2325,55 +2326,65 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68726957
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -204,6 +219,12 @@ class JobManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68726906
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,16 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68204004
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68203613
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -78,6 +82,7 @@ import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68203446
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68199369
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager(
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68198979
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68198869
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -78,6 +82,7 @@ import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68198766
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68090624
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68072122
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager(
//
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68071928
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager(
//
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68071458
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -270,6 +284,17 @@ class JobManager(
// shut down
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68071264
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r6807
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070903
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -78,6 +82,7 @@ import
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070632
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070694
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -66,23 +68,44 @@
// Scope Variables
//
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070738
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -240,7 +305,7 @@ public OperatorScopeFormat(String format,
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070204
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68069551
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68062127
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager(
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68060662
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -270,6 +284,17 @@ class JobManager(
// shut
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68062041
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager(
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68059122
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68058991
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68058143
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68056706
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -78,6 +82,7 @@ import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68054269
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -240,7 +305,7 @@ public OperatorScopeFormat(String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68053080
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68053983
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -66,23 +68,44 @@
// Scope Variables
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68052027
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68051176
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68050729
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68047271
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerJobMetricGroup.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2146
[FLINK-1550/FLINK-4057] Add JobManager Metrics
This PR relies on #2145.
This PR exposes several Metrics on the JobManager.
The first change made was the separation of the
63 matches
Mail list logo
