[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r139596400 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -183,18 +214,40 @@ void

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r139590215 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -100,7 +122,16 @@ public

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-18 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r139589040 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138918917 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -100,7 +122,16 @@ public

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138922984 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -183,18 +214,40 @@ void

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138915958 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138915417 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138915141 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r136056661 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138923001 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -183,18 +214,40 @@ void

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r136056467 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138916859 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -72,6 +79,21 @@ */

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r138909210 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -64,7 +63,7 @@ * Buffer availability

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-09-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4499#discussion_r136027041 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -281,6 +284,67 @@ public void

[GitHub] flink pull request #4499: [FLINK-7394][core] Implement basic InputChannel fo...

2017-08-09 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/4499 [FLINK-7394][core] Implement basic InputChannel for credit-based logic ## What is the purpose of the change This pull request prepares the basic works for credit-based interaction with