Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-16 Thread via GitHub
snuyanzin merged PR #23917: URL: https://github.com/apache/flink/pull/23917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-16 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1858772184 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428571302 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428571302 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
Jiabao-Sun commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428219337 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
Jiabao-Sun commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428209269 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428204897 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428204897 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428199378 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
Jiabao-Sun commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428188735 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
Jiabao-Sun commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1427932231 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ## @@ -68,8 +69,8 @@ class

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-15 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1857613116 @Jiabao-Sun can you please have a look one more time PS. I started to use ```scala val baseCheckpointPath = Files.createTempDirectory(getClass.getCanonicalName)

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1854237160 interesting, retry of successful build does not work... will sumbit same commit with different comment -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1854127737 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-12 Thread via GitHub
TanYuxin-tyx commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1853158768 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-12 Thread via GitHub
flinkbot commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1853042178 ## CI report: * 3247f8b2702cf14cde943067c8eaab53bd5dd2b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-12 Thread via GitHub
snuyanzin opened a new pull request, #23917: URL: https://github.com/apache/flink/pull/23917 ## What is the purpose of the change Bump junit to 5.10.1 This could improve logging for https://github.com/apache/flink/pull/23914#pullrequestreview-1777970575 since it was