mas-chen commented on PR #24564:
URL: https://github.com/apache/flink/pull/24564#issuecomment-2073437811
Thanks for the review @afedulov @mxm @ruanhang1993!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mas-chen merged PR #24564:
URL: https://github.com/apache/flink/pull/24564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1576557353
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##
@@ -538,19 +557,19 @@ public TaskMetricStore
ruanhang1993 commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1576478281
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##
@@ -538,19 +557,19 @@ public TaskMetricStore
ruanhang1993 commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1576478281
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##
@@ -538,19 +557,19 @@ public TaskMetricStore
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1575521871
##
docs/layouts/shortcodes/generated/rest_v1_dispatcher.html:
##
@@ -1277,6 +1277,9 @@
"parallelism" : {
"type" : "integer"
},
+
mas-chen commented on PR #24564:
URL: https://github.com/apache/flink/pull/24564#issuecomment-2071218991
@ruanhang1993 I'm inclined to merge this in the next few days after the
thorough feedback from Alex. Let me know if you have any concerns
--
This is an automated message from the
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1575497962
##
docs/layouts/shortcodes/generated/rest_v1_dispatcher.html:
##
@@ -1277,6 +1277,9 @@
"parallelism" : {
"type" : "integer"
},
+
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1571313741
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##
@@ -184,6 +184,21 @@ public synchronized ComponentMetricStore
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1572305374
##
docs/layouts/shortcodes/generated/rest_v1_dispatcher.html:
##
@@ -1277,6 +1277,9 @@
"parallelism" : {
"type" : "integer"
},
+
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1571313741
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##
@@ -184,6 +184,21 @@ public synchronized ComponentMetricStore
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1568653505
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1570041925
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1570041925
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1570041925
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1568653505
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1568653505
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1568044466
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1568044466
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1567286518
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1566845916
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1562500243
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1556250658
##
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java:
##
@@ -277,11 +277,12 @@ public static Configuration forReporter(Configuration
mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1556248651
##
docs/static/generated/rest_v1_dispatcher.yml:
##
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref:
afedulov commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1543334446
##
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java:
##
@@ -277,11 +277,12 @@ public static Configuration forReporter(Configuration
mxm commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1541043451
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##
@@ -538,19 +556,19 @@ public TaskMetricStore
mxm commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1541028016
##
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java:
##
@@ -277,11 +277,12 @@ public static Configuration forReporter(Configuration
flinkbot commented on PR #24564:
URL: https://github.com/apache/flink/pull/24564#issuecomment-2018770217
## CI report:
* e9242629510a491852239ece44a546d3ffbffd85 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
mas-chen commented on PR #24564:
URL: https://github.com/apache/flink/pull/24564#issuecomment-2018765151
cc: @ruanhang1993 @afedulov @mxm would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mas-chen opened a new pull request, #24564:
URL: https://github.com/apache/flink/pull/24564
## What is the purpose of the change
Expose JobmanagerOperatorMetrics via REST API:
30 matches
Mail list logo
