[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-02-04 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279423#comment-17279423 ] Jane Chan commented on FLINK-21045: --- Hi [~nicholasjiang], "Extend Core Table System with Pluggable

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-02-04 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278794#comment-17278794 ] Nicholas Jiang commented on FLINK-21045: [~qingyue], I think that the title of this issue could

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-02-03 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278059#comment-17278059 ] Jark Wu commented on FLINK-21045: - +1 to create subtasks. > Support 'load module' and 'unload module'

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277903#comment-17277903 ] Jane Chan commented on FLINK-21045: --- Hi everyone, since the discussion result is far beyond the

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277867#comment-17277867 ] Jane Chan commented on FLINK-21045: --- Hi everyone,  I did a summary since the discussion has achieved

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276088#comment-17276088 ] Jark Wu commented on FLINK-21045: - Thanks [~qingyue] for the nice summary. Let's continue the discussion

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-29 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275216#comment-17275216 ] Jane Chan commented on FLINK-21045: --- Hi everyone, thanks for the discussion and the opinions, and I'm

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273476#comment-17273476 ] Jark Wu commented on FLINK-21045: - +1 to leave out the `type/module` property. This is really a

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-28 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273456#comment-17273456 ] Timo Walther commented on FLINK-21045: -- +1 for another mailing list discussion. I'm not against

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273295#comment-17273295 ] Jark Wu commented on FLINK-21045: - It seems that we still have many different thoughts on this topic.

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273292#comment-17273292 ] Jark Wu commented on FLINK-21045: - Good points [~lirui], I also found it's really hard to use "load" +

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-27 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273285#comment-17273285 ] Rui Li commented on FLINK-21045: Thanks for looping me in. I don't have a strong opinion regarding

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272898#comment-17272898 ] Jark Wu commented on FLINK-21045: - Thanks for your reply [~twalthr]. I don't have strong opinion on

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-27 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272878#comment-17272878 ] Timo Walther commented on FLINK-21045: -- Thanks for discussing this topic again. I quickly scanned

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272757#comment-17272757 ] Jark Wu commented on FLINK-21045: - I thought about this again, and maybe [~nicholasjiang] proposed a

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-26 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272055#comment-17272055 ] Jark Wu commented on FLINK-21045: - Hi [~nicholasjiang], this may complex the design, because currently

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-25 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271910#comment-17271910 ] Nicholas Jiang commented on FLINK-21045: [~qingyue][~jark], IMO, the WITH is more suitable to

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-25 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271805#comment-17271805 ] Jark Wu commented on FLINK-21045: - Thanks [~qingyue] for the investigation. 1) Is "WITH" necessary? I

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-25 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271508#comment-17271508 ] Jane Chan commented on FLINK-21045: --- Hi [~jark], [~nicholasjiang], I apologized for the late reply. 

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269376#comment-17269376 ] Jark Wu commented on FLINK-21045: - Btw, please support this syntax in {{TableEnvironment#executeSql()}}

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-21 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269304#comment-17269304 ] Nicholas Jiang commented on FLINK-21045: [~jark], I think [~qingyue] could work for this issue

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269125#comment-17269125 ] Jark Wu commented on FLINK-21045: - [~qingyue] good catch! That's great this is an approved SQL syntax.

[jira] [Commented] (FLINK-21045) Support 'load module' and 'unload module' SQL syntax

2021-01-21 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269107#comment-17269107 ] Jane Chan commented on FLINK-21045: --- Hi [~jark], [~nicholasjiang], I quickly went through