[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178004#comment-16178004 ] ASF GitHub Bot commented on FLINK-7446: --- GitHub user fhueske opened a pull request:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178107#comment-16178107 ] ASF GitHub Bot commented on FLINK-7446: --- Github user haohui commented on the issue:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179067#comment-16179067 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179068#comment-16179068 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179064#comment-16179064 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179062#comment-16179062 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179069#comment-16179069 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179066#comment-16179066 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179070#comment-16179070 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179071#comment-16179071 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179063#comment-16179063 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179065#comment-16179065 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179072#comment-16179072 ] ASF GitHub Bot commented on FLINK-7446: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181172#comment-16181172 ] ASF GitHub Bot commented on FLINK-7446: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181204#comment-16181204 ] ASF GitHub Bot commented on FLINK-7446: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181224#comment-16181224 ] ASF GitHub Bot commented on FLINK-7446: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182840#comment-16182840 ] ASF GitHub Bot commented on FLINK-7446: --- Github user wuchong commented on the issue:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192067#comment-16192067 ] ASF GitHub Bot commented on FLINK-7446: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192542#comment-16192542 ] ASF GitHub Bot commented on FLINK-7446: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131261#comment-16131261 ] Fabian Hueske commented on FLINK-7446: -- I think the existing {{DefinedRowtimeAttribut

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131616#comment-16131616 ] Jark Wu commented on FLINK-7446: [~fhueske] Great! I will make a pull request in the next

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131629#comment-16131629 ] Xingcan Cui commented on FLINK-7446: Now that the rowtime field is an existing one in

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-17 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131805#comment-16131805 ] Fabian Hueske commented on FLINK-7446: -- That's in fact a good question. In principle

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-18 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133050#comment-16133050 ] Xingcan Cui commented on FLINK-7446: Thanks for the response, [~fhueske]. From my pers

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134448#comment-16134448 ] Jark Wu commented on FLINK-7446: >From my perspective, I think TableSource should provide

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-22 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137358#comment-16137358 ] Fabian Hueske commented on FLINK-7446: -- I agree that the watermark generation for Tab

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-22 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137794#comment-16137794 ] Jark Wu commented on FLINK-7446: In the long run, we can provide a new interface called {{

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143517#comment-16143517 ] Fabian Hueske commented on FLINK-7446: -- I think that's a good plan [~jark]. However,

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144662#comment-16144662 ] Jark Wu commented on FLINK-7446: [~fhueske] yes, I created FLINK-7548 to discuss this. >

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-08 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158910#comment-16158910 ] Fabian Hueske commented on FLINK-7446: -- Hi [~jark], did you start to work on this iss

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-09-10 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160671#comment-16160671 ] Jark Wu commented on FLINK-7446: Hi [~fhueske] , feel free to take this, I didn't start ye