Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101000141
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r100989660
--- Diff: docs/dev/connectors/kafka.md ---
@@ -161,6 +161,46 @@ For convenience, Flink provides the following schemas:
The KeyValue objectNode
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101047374
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseMigrationTest.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101045081
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@ -438,6
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101048002
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseMigrationTest.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101074257
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101075446
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101075570
--- Diff: docs/dev/connectors/kafka.md ---
@@ -161,6 +161,46 @@ For convenience, Flink provides the following schemas:
The KeyValue objectNode
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3149
I think its fine to change the JVM settings for the hbase module. Other
modules such as elasticsearch are also doing that.
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2509
I've tested the change locally and with great success. So once my comments
are addressed, the change is good to be merged
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r101231413
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@ -633,7
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3308
Nice, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2509
@tzulitai how does this fit your timeline. Are there PRs depending this or
is this PR blocking your in any way?
If so, I would propose that we merge it right away.
---
If your project is set
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/3344
FLINK-5731 Spilt up tests into three disjoint groups
We were running into build timeouts again recently on travis.
That's why I've split the tests into three groups (inst
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3362
Thank you for opening a PR.
Can you provide a screenshot of the change. Also, the PR is conflicting
with the current master, so we can not just merge it:
 This needs a more thorough check
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3369
Thank you for opening a pull request addressing the issue.
I know it is out of scope of the JIRA, but since you are working on it
already, I was wondering if we can improve the optics of
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3369
Cool, very nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102178621
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102178460
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102177099
--- Diff: docs/dev/connectors/elasticsearch.md ---
@@ -272,9 +308,115 @@ input.addSink(new ElasticsearchSink(config, new
ElasticsearchSinkFunction[String
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102180098
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102177012
--- Diff: docs/dev/connectors/elasticsearch.md ---
@@ -272,9 +308,115 @@ input.addSink(new ElasticsearchSink(config, new
ElasticsearchSinkFunction[String
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102179118
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102177573
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102181691
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102181294
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102203605
--- Diff: docs/dev/connectors/elasticsearch.md ---
@@ -272,9 +308,115 @@ input.addSink(new ElasticsearchSink(config, new
ElasticsearchSinkFunction[String
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102204385
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102204579
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102204839
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3344
Thank you for your feedback. The feedback seems to be clearer than expected.
If there are no objections within the next days, I'll merge the change.
---
If your project is set up for it
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3358
I finished checking the code.
The only thing I'm missing from the change is a test case ensuring that the
implementation works.
I think we can build a test similar to what we did
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2487
Cool, than you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r102542018
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102544239
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102545769
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102546521
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/util
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3344
Since this is so easy to undo, I'll merge it for now. Lets see if people
start complaining
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3358
+1 to merge.
Thank you for answering all my comments so detailed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3358#discussion_r102905100
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3410
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3413
I would like to discuss the implementation approach in the
[JIRA](https://issues.apache.org/jira/browse/FLINK-5668) before reviewing this
pull request.
---
If your project is set up for it, you
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3378#discussion_r103196367
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -330,8
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3378#discussion_r103197252
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r103405663
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/RichKeyedDeserializationSchema.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3314
@StephanEwen and I just had an offline discussion about the change, and we
came up with the following thoughts:
Using an `ArrayList` for buffering elements is an "anti-pattern"
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3314
Thanks a lot for your understanding @haohui.
Let us know once you've updated the PR so that we can review and merge it.
---
If your project is set up for it, you can reply to this emai
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3469
Good change. +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3270
Hi @mylog00, thanks a lot for your contribution.
I wonder if it makes more sense to just upgrade the existing Kafka examples
to use Kafka 0.9 instead of having two examples that are almost
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2804
Looks good to merge.
I'm currently verifying the change, then, I'll merge it:
https://travis-ci.org/rmetzger/flink/builds/207494237
---
If your project is set up for it, you ca
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3352
Changes look good in my opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3438
I looked over the changes and didn't find anything critical. The only thing
that made me thinking was the boxed `Long` type for the timestamp(). I assume
you decided for this approach to s
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2767
I closed the PR manually using another commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3314#discussion_r104227652
--- Diff: docs/dev/connectors/kafka.md ---
@@ -146,6 +146,10 @@ The Flink Kafka Consumer needs to know how to turn the
binary data in Kafka into
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3314
The change looks good to merge in my opinion.
@tzulitai can you also have a quick look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3438
In addition to throwing an exception, we should also expose
`element.hasTimestamp()` to offer our users a clean way of checking for
timestamps.
Lets see what @uce or other reviewers think about
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3344
I agree that we have this issue again.
If you want faster feedback on your pull requests, I recommend setting up
travis for your flink fork. Then, every time you push to your repo, you&#x
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3036#discussion_r93814607
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
@@ -208,13
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3055
Thanks a lot for providing a fix for the issue.
I'll test it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2664
@greghogan I guess this PR is invalid by now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3029
I guess this PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3056
Thank you for looking into the issue. Before I'm merging it, I'd also like
to test drive the change on a real cluster :)
---
If your project is set up for it, you can reply to this emai
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3056#discussion_r94634138
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -347,43 +351,88 @@ public static String
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3055
I tested the changes and they worked on my YARN cluster.
Thank you for quickly fixing the issue.
I'll merge the fix to master and the release-1.2 branch.
---
If your project is set u
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3055
I forgot to close the PR while merging. Could you manually close it?
Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3056#discussion_r94954355
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -347,43 +351,88 @@ public static String
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3042
Very nice change!
I would love to merge it to 1.2 as well, its so helpful!
One very minor thing: I would suggest to round the percentages shown for
the completion. I had an instance
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3042
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2767
Sounds good. Thank you for taking care of this @tzulitai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3100
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3112
Thanks a lot for opening a pull request for this.
It looks like some of the tests are failing on travis. Does ES5 support
Java 7 ?
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3112
Using maven build profiles, you can probably include the es5 connector in
java8 builds only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95969879
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95969123
--- Diff: docs/dev/connectors/elasticsearch2.md ---
@@ -1,173 +0,0 @@
-title: "Elasticsearch 2.x Connector"
-nav-title: Elastic
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95972131
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95972955
--- Diff:
flink-connectors/flink-connector-elasticsearch5/src/test/java/org/apache/flink/streaming/connectors/elasticsearch5/ElasticsearchSinkITCase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95972691
--- Diff:
flink-connectors/flink-connector-elasticsearch5/src/test/resources/log4j2.properties
---
@@ -0,0 +1,27
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95969031
--- Diff: docs/dev/connectors/elasticsearch2.md ---
@@ -1,173 +0,0 @@
--- End diff --
Can you replace the es2 page with a redirect to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95974130
--- Diff:
flink-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSinkITCase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95973065
--- Diff:
flink-connectors/flink-connector-elasticsearch5/src/main/java/org/apache/flink/streaming/connectors/elasticsearch5/ElasticsearchClientFactoryImpl.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95973995
--- Diff: flink-connectors/flink-connector-elasticsearch5/pom.xml ---
@@ -0,0 +1,121 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95968855
--- Diff: docs/dev/connectors/elasticsearch.md ---
@@ -23,158 +23,284 @@ specific language governing permissions and
limitations
under the License
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95979032
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95979234
--- Diff:
flink-connectors/flink-connector-elasticsearch2/src/test/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSinkITCase.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95979634
--- Diff: flink-connectors/pom.xml ---
@@ -85,6 +86,17 @@ under the License.
flink-connector-kinesis
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r95979696
--- Diff: .travis.yml ---
@@ -16,14 +16,14 @@ matrix:
include:
# Always run test groups A and B together
- jdk: "oracl
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3056
+1 to merge. The cluster test was successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3103
While testing this PR, I found that the jobmanager.log is now full with
exceptions like this one:
```
java.io.EOFException
at java.io.DataInputStream.readInt
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3068
+1 to merge
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3123
Good change. Thank you.
I'll merge it right away
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3112
Gordon and I had a quick offline chat about this and decided the following:
1. We'll use the `ServiceResourceTransformer` because that's the correct
way of solving the problem
2.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3109
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3122
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3112#discussion_r96274454
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3068
Mh, I just realized that the streaming APIs multichaining is leading to
some ugly side effects.
In below screenshot, you see that the number of outgoing records is
reported as 247. These
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3068
Yes, its some fancy multi-chaining of the streaming API.
Then lets merge it as is :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3132
I think its fine (as long as we are not merging it to the 1.2 release
branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
501 - 600 of 2433 matches
Mail list logo
