Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39172874
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -124,6 +138,13 @@ else if(arg.startsWith
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39173008
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -124,6 +138,13 @@ else if(arg.startsWith
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39173169
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -124,6 +138,13 @@ else if(arg.startsWith
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39173067
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -136,15 +157,35 @@ public static ParameterTool
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39173366
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -234,6 +295,10 @@ public long getLong(String key
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1116#discussion_r39173419
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -245,13 +310,20 @@ public long getLong(String key, long
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1116#issuecomment-139280931
Thanks a lot for adding the Javadocs to the class. Good work!
I have some comments in the diff.
---
If your project is set up for it, you can reply to this email
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1117
[FLINK-2656] Fix behavior of FlinkKafkaConsumer for out of range offsets
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1117#discussion_r39251890
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1117#issuecomment-139491178
Sorry Henry. I've updated the description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1117#issuecomment-139529893
Thank you for the review. I'll merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1125#issuecomment-140029908
The pull request should also update the documentation. In particular these
configuration values affect the documentation in many places.
---
If your project is set up
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1128#issuecomment-140153585
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-140663091
Big change, but I didn't spot anything suspicious.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1135#discussion_r39624182
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140730955
There is a test failure
```
StormWrapperSetupHelperTest.testCreateTopologyContext:190 û ClassCast
class su...
```
---
If your project is set up for it
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-140731019
I agree. We need to use the script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1084#discussion_r39624668
--- Diff: .travis.yml ---
@@ -19,9 +19,9 @@ matrix:
- jdk: "oraclejdk7" # this will also deploy a uberjar to s3 at some
point
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1084#issuecomment-140732373
I think the pull request has grown quite a lot. I think we should merge it
now and then improve it from there.
---
If your project is set up for it, you can reply to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1132#issuecomment-140748694
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1084#discussion_r39640862
--- Diff: .travis.yml ---
@@ -19,9 +19,9 @@ matrix:
- jdk: "oraclejdk7" # this will also deploy a uberjar to s3 at some
point
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1121#issuecomment-141016403
Sorry for the late response, I didn't see this new pull request.
The failed test is okay. The test is known for being unstable.
---
If your project is s
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1139#issuecomment-141018736
Very nice.
I tried the new interface locally, and it seems to work.
I suspect these values are still test values? http://i.imgur.com/d9ZRR7g.png
There
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1121#discussion_r39725184
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -130,6 +130,15 @@ state.backend: jobmanager
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1121#discussion_r39725238
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -111,6 +111,20 @@ public void testClientStartup
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1121#issuecomment-141019208
For others who follow this PR, there was already some discussion on this
change here: https://github.com/apache/flink/pull/1107
---
If your project is set up for it
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1139#issuecomment-141035558
I agree with this approach, so +1 to merge ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1139#issuecomment-141050563
Another follow-up todo is adding support for yarn:
```
11:31:01,955 ERROR org.apache.flink.runtime.jobmanager.JobManager
- WebServer could
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1134#issuecomment-141167625
Hey @rxin, I'm really sorry that this happened. Max told me that he stopped
the application on AppEngine as soon as he learned that the tool is not working
as exp
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1136#issuecomment-141168778
Hi @srowen, thank you for notifying us. We were trying out
https://github.com/databricks/spark-pr-dashboard on Google App Engine (because
we are also getting more and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1142#issuecomment-141385220
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141401714
@nikste, since you need to change the pull request again, can you also fix
the directory name of the classes
`flink-staging/flink-scala-shell/src/main/scala
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141404870
I would suggest to change the scope of this pull request to enable
deploying a `_2.11` artifact for each module with the nightly snapshot builds.
You can test the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-141425832
Sure, I don't have time over the weekend to work on this anyways ;)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1144#issuecomment-141443252
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-141457169
Do you mean the 0.10-milestone-1 release? or the final 0.10 release?
Fabian is managing the 0.10-milestone-1 release, as far as I know he has
not started with
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1146#issuecomment-141470722
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1156#issuecomment-141967992
The commit history needs a cleanup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-141983001
I agree. Lets wait until https://github.com/apache/flink/pull/858 is
merged. As far as I understood Stephan, this PR depends on #858.
---
If your project is set up for
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1159
[FLINK-2722] Use InetAddress.getLocalHost() as first approach when
detecting the TMs own ip/hostname
A user reported a connection issue with Netty being unable to connect to a
TaskManager to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1159#discussion_r40058785
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/NetUtils.java ---
@@ -189,9 +191,17 @@ public static InetAddress
findConnectingAddress
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1159#issuecomment-142221347
Thank you for the thorough review @tillrohrmann. I removed the
`resolveAddress()` method. It had a lot of duplicates with
`findConnectingAddress()` and was only used
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1162#issuecomment-14352
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r40068488
--- Diff: flink-dist/pom.xml ---
@@ -305,6 +305,7 @@ under the License
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r40068542
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
---
@@ -96,7 +96,7 @@ under the License
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-142230271
Thanks a lot for working on this @chiwanpark.
I'll check out your pull request and try to integrate it with our nightly
deployment to the snapshot repos
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1159#issuecomment-142281622
okay, I'm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-142331659
I think the implementation of `stopExecution()` is fine. You are executing
the call in a separate thread and you are logging exceptions. A blocking stop()
method
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-142527214
https://github.com/apache/flink/pull/858 is merged, so we can try to get
consensus here
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/593#discussion_r40179781
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -47,6 +47,11 @@
"Class wit
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/593#discussion_r40180582
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -51,12 +50,25 @@ public void
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-142527730
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-142547078
-1
I was not able to get this feature working as expected, with the following
job:
```java
public class URLClassloader {
public
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1164#issuecomment-142547175
Thank you for this great feature!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1172#issuecomment-142580785
Thank you for looking into it.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1174#issuecomment-142700908
Let me check the implications tomorrow: I've put a comment there which
explicitly says that putting netty there is dangerous ;)
`
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1174#issuecomment-142704120
I agree. The build is working, for all hadoop versions, so I seems to work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1175#discussion_r40295722
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1175#issuecomment-142856852
Can you also update the documentation to reflect the new windowing API
there?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-142857451
I'll soon review this pull request. Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-142857639
Can you add tests for the methods? I think there is already a class with
tests for all methods.
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1168#issuecomment-143020279
Great, thank you.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/593#discussion_r40493024
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
---
@@ -51,12 +50,25 @@ public void
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-143427388
Just to defent @twalthr and @aalexandrov here a bit: The JIRA and PR were
both created before we asked for more extensive descriptions.
---
If your project is set up
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1185#issuecomment-143433645
Remember to assign the JIRA to yourself ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40674158
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
com.google.guava
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/948#issuecomment-144074252
Thank you for the update @ankurcha. I'm trying to review your PR in the
next few days.
Sorry for the delay.
---
If your project is set up for it, you can rep
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1194
[FLINK-2703] Prepare Flink for using it with Logback.
i was talking to a user recently who asked for using Logback instead of
Log4j.
This pull request is adding a section in the "
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1194#discussion_r40764829
--- Diff: flink-dist/src/main/assemblies/bin.xml ---
@@ -40,6 +40,9 @@ under the License
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144433941
Thank you for your contribution.
You can also check whether the build is passing by executing `mvn clean
verify` locally.
Speaking about tests: is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144434371
Which connector has the examples in `src/main/resources` ? I think its okay
to put the examples into the src/main/java folder.
---
If your project is set up for it
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1194#issuecomment-144459509
Thank you for the review. I'm merging this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144461907
Okay, I see. I think it is fine to merge the Nifi connector without a test
if there is no infrastructure for automated testing available.
---
If your project is set
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1197#issuecomment-144660508
@nikste, can you quickly review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144688632
I followed the tutorial for Nifi that you posted into the pull request.
Thanks a lot for the good instructions. I was able to start it and get it to
run in a few
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899137
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899210
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899230
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899178
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899251
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899297
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899307
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1198#discussion_r40899440
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-nifi/pom.xml
---
@@ -0,0 +1,94 @@
+
+
+http
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-144745094
+1 The change looks good to merge. (maybe we should add the JIRA id when
merging)
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-144747629
No, I didn't try it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144762615
Thank you for looking into it.
Your analysis was right: I've accidentally put the port into the host
parameter `nifi.remote.input.socket.host=9081`.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1206#issuecomment-144764416
-1. Build fails
```
Results :
Failed tests:
AccumulatorErrorITCase.testFaultyAccumulator:97 Root cause should be:
Tests in error
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1121#issuecomment-144765643
@willmiao: What is the status of this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144960807
Great. Thank you for your answers. I think its fine to let users deal with
cases when multiple systems want to consume data from a NiFi flow.
Once my in-code
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-144961452
Ah, you've addressed my feedback. I should refresh my browser before
commenting ;)
So +1, good to merge
---
If your project is set up for it, you can
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1210
[hotfix] Execute YARN integration tests only upon request
...by activating the 'include-yarn-tests' profile
The default Hadoop version set in Flink (2.3.0) is causing the
MiniY
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145320562
Thank you for resolving the issue so quickly.
I think its good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1222
[FLINK-2798] Serve static files for the new web frontend from the
classloader
This pull request is based on https://github.com/apache/flink/pull/1202.
In order to make the new web
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1198#issuecomment-145400455
I'm going to merge this PR ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1210#issuecomment-145400579
Thank you for the feedback. Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1213#issuecomment-145404233
I've looked a bit over the code and it all looks like good changes.
I've tested the code on a Hadoop 2.6.0 cluster and the YARN session was
restartin
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1213#issuecomment-145577205
I killed the AM using "kill" from the command line, and all the
Taskmanagers were shutting down
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1223#issuecomment-145708133
Thanks a lot for your contribution to Flink!
Sorry for not giving you feedback earlier. Many committers are currently
busy preparing the next Flink release
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1197#issuecomment-145708723
Thank you for the review @nikste!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1222#issuecomment-145733149
Thank you for the review. I'm trying to update the PR within the next 24
hours
Sorry for not explaining why I changed all the request URLs to relative
paths:
801 - 900 of 2433 matches
Mail list logo
