Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1426#issuecomment-161056518
Okay, I'll reopen two new PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1427
[FLINK-3093] Introduce annotations for interface stability in flink-core
Please see https://github.com/apache/flink/pull/1426
You can merge this pull request into a Git repository by running
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1428
[FLINK-3093] Introduce annotations for interface stability in remaining
modules
Please see https://github.com/apache/flink/pull/1426
This pull request depends on https://github.com/apache
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1311#issuecomment-161058586
Thank you for the contribution. To me it seems that the pull request so far
consists only of unrelated changes.
Did you make any progress on resolving the issue
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1437
[FLINK-3102] Allow reading from multiple topics with one FlinkKafkaConsumer
* I added a new constructor to the Kafka source, accepting a List
of topics.
* the deserialization schema will get
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1427#discussion_r46756747
--- Diff: flink-core/src/main/java/org/apache/flink/types/Pair.java ---
@@ -33,6 +34,7 @@
* @param Type of the pair's first element.
* @
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1434#issuecomment-162168898
Awesome change! I think its a feature many users are asking for because its
crucial for production use!
I'll try to review it soon.
---
If your project is s
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1409#issuecomment-162174050
Thanks for the review. I'll merge it soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-162333939
Tested the change on a cluster
---
If your project
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r46773662
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
---
@@ -63,6 +67,10 @@ public String
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1338#issuecomment-162334327
I've tested the change again on a cluster, works nicely!
val longIt: Iterator[Long] = ...
val
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-169668035
I like this change because the current restart behavior is not flexible
enough. Resolving this issue should be really easy with your change in:
https
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1476#issuecomment-169671136
This change needs to be merged by a Flink committer.
I've just put the "good to merge" comment so that the other committers know
the code has been
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1460#discussion_r49074918
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
@@ -438,7 +617,7 @@ public
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1489#issuecomment-170103132
There are some build instabilities with the new Kafka 0.9 code. I'll look
into it soon.
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1492#issuecomment-170840541
I moved the following modules out of "flink-staging":
flink-tez (to flink-contrib)
flink-ml (to flink-libraries)
flink-table (to flink-libraries)
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1432#issuecomment-170849507
Well, in practice, even with PR's, there is not much QA going on for Python.
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1499#issuecomment-170926819
Thank you for improving the documentation.
I think we can entirely remove the "Docker Connector" section (which is, in
the current documentati
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1492#issuecomment-171596184
Thank you for the reviews ... I'll merge the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1489#issuecomment-171903718
Okay, I'll rename the consumers and producers to include the version.
(FlinkKafkaConsumer08 and so on.)
---
If your project is set up for it, you can reply to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1512#discussion_r49876047
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/FoldWindowFunctionTest.java
---
@@ -66,10 +72,27 @@ public Integer
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1515#issuecomment-172527568
-1 breaks build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1513#issuecomment-172533529
I think the documentation hasn't been adopted to the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/commit/1bc48e0855df803c65344d836092dcf6393ad3f2#commitcomment-15535103
In
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
In
flink-core/src/main/java/org/apache
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/commit/1bc48e0855df803c65344d836092dcf6393ad3f2#commitcomment-15535215
Did you IDE autoformat the code? That's something which makes reviewing the
PRs much harder.
You didn't update
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1489#issuecomment-172932775
Thank you all for the comments. I renamed the Consumers again to include
the version, I added deprecated 081 and 092 consumers.
Do you think we should also add a
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1515#issuecomment-173214575
+1 looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-173217454
Seems that `pdsh` is available in all Ubuntu versions. So I guess the tool
is popular enough to be present for some of our users.
I think some tests on a
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-173215668
I filed a JIRA for the failed test case:
https://issues.apache.org/jira/browse/FLINK-3265
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1489#issuecomment-173243638
I addressed all concerns and rebased to master.
Once the tests have passed, I'll merge the change.
---
If your project is set up for it, you can reply to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-173511286
Cool, thank you.
I'll rebase the PR, and go over the APIs again as well
---
If your project is set up for it, you can reply to this email and have your
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1533
[FLINK-3270] Add Kafka example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3270
Alternatively you can review and
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1534
[FLINK-3265] Make RabbitMQ source threadsafe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3265
Alternatively you can
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50401269
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public Centroid
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1536#discussion_r50401470
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
---
@@ -291,31 +297,54 @@ public Centroid
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-173607167
I have quickly checked out your branch and came up with another variant for
reworking the KMeans example with the `ParameterTool`:
https://github.com/rmetzger/flink
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1541
[FLINK-3274] Make accumulator names of Kafka connector unique
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3274
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-173874750
mh, I understand that you are motivated to move on with this task. I think
most likely other Flink committers agree to the change, but it might also
happen that the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1537#issuecomment-174446152
I tested this as well. A Kafka test was previously failing, now its passing.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-174450252
Whats the status of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1545#issuecomment-174510830
awesome, thank you. I'll merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1546#discussion_r50694061
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
---
@@ -60,6 +60,7 @@ public static
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1541#issuecomment-174539785
This PR also addresses https://issues.apache.org/jira/browse/FLINK-3280
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174946246
Okay, since nobody objected on the mailing list, we can start changing all
examples.
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1529#issuecomment-174948935
I think we should also update the documentation along with the change!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174950736
I think its important that users also see how to read data from sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174953115
I don't really see the points of encapsulating parts of the examples into
methods: Usually, methods are used when functionality is used in different
places. In
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-175544829
I understand that argument, and I would be strongly against adding examples
for each connector.
The pull request is moving the example away from the Kafka
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1554#issuecomment-176079663
To squash commits, you have to call "git rebase -i HEAD~10" (its called
interactive rebase). Then, put "fixup" or "squash" instead of &quo
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1555
[FLINK-3295][Kafka 0.8] Improve ZK error behavior
This PR changes the behavior of the Kafka 0.8 source if there is an error
while getting the initial offsets from ZK.
Instead of failing, the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1555#issuecomment-176230855
Yes, curator is retrying using an exponential backoff retry.
I've addressed your comments.
---
If your project is set up for it, you can reply to this
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1563
[FLINK-3296] Remove 'flushing' behavior of the OutputFormat in DataStream
API
I removed the `FileSinkFunctionByMillis` and removed all the `millis`
arguments on the writing
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1569#discussion_r51432473
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
---
@@ -219,7
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1573
[FLINK-3287][FLINK-3247] Fix curator shading for Kafka connector
Some maven versions are not properly evaluating star * excludes. Therefore,
I've manually listed our shaded artifac
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1573#issuecomment-178527480
There is one issue I need to figure out, then, I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1576
[hotfix][yarn] Shutdown JVM when Flink-on-yarn is shutting down
With this change, we call System.exit() when the YARN session is shutting
down.
On some Linux distributions, YARN is not
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1577#issuecomment-178683735
Good catch & fix!
+1 to merge asap (too many tests are failing on this one right now)
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1582#issuecomment-179365564
I think the change is good to merge when travis has passed.
I tried it on GCE:
```
17:36:55,084 INFO org.apache.flink.yarn.YarnTaskManager
901 - 1000 of 2433 matches
Mail list logo
