[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix HAWQ make install with DES...

2017-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hawq/pull/1184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread paul-guo-
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 OK, so +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 They are all generated by 'pg_config', they should not be relative PATH. # Extension makefiles should set PG_CONFIG, but older ones might not ifndef PG_CONFIG

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread paul-guo-
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 If you can make sure all of the later paths are absolute path, it will be fine, e.g. ${DESTDIR}${docdir} ${DESTDIR}$(bindir) ${DESTDIR}${libdir} $(DESTDIR)${sysconfdir}

[GitHub] incubator-hawq issue #1180: HAWQ-1396. Fix the bug when query hcatalog via P...

2017-03-22 Thread zhangh43
Github user zhangh43 commented on the issue: https://github.com/apache/incubator-hawq/pull/1180 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-hawq pull request #1183: HAWQ-1400. An improvement in SQL Util des...

2017-03-22 Thread jiny2
Github user jiny2 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 @paul-guo- I don't think the --prefix option can set a relative path, so there is definitely no need to add a '/' between DESTDIR and PREFIX-DIR. --- If your project is set up for

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread paul-guo-
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 Cool work! I just have one concern. I saw a lot of fix like this, however is is possible the later one is a relative path while DESTDIR has not a tailing / and this could lead to

[GitHub] incubator-hawq issue #1181: HAWQ-1398. Fixing invalid references in log stat...

2017-03-22 Thread paul-guo-
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/1181 elog supports formatting just like standard c function printf, etc. When I fixed a QD bug I modified some QD logs to use __func__. I think it will be a huge work to modify all, so I

[jira] [Commented] (HAWQ-1402) Update pxf-profiles.xml config file comments for all Hive-related profiles

2017-03-22 Thread Lisa Owen (JIRA)
[ https://issues.apache.org/jira/browse/HAWQ-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937204#comment-15937204 ] Lisa Owen commented on HAWQ-1402: - i assume this change is for the pxf-profiles.xml that is installed when

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

2017-03-22 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1185#discussion_r107498956 --- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml --- @@ -46,6 +46,7 @@ under the License. This

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

2017-03-22 Thread denalex
Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1185#discussion_r107498808 --- Diff: pxf/pxf-service/src/main/resources/pxf-profiles-default.xml --- @@ -46,6 +46,7 @@ under the License. This

[GitHub] incubator-hawq pull request #1185: HAWQ-1402. Updated comments for Hive-rela...

2017-03-22 Thread sansanichfb
GitHub user sansanichfb opened a pull request: https://github.com/apache/incubator-hawq/pull/1185 HAWQ-1402. Updated comments for Hive-related profiles. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sansanichfb/incubator-hawq

[jira] [Updated] (HAWQ-1402) Update pxf-profiles.xml config file comments for all Hive-related profiles

2017-03-22 Thread Oleksandr Diachenko (JIRA)
[ https://issues.apache.org/jira/browse/HAWQ-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Diachenko updated HAWQ-1402: -- Description: Some performance-related statements are obsolete for Hive profiles. >

[jira] [Updated] (HAWQ-1402) Update pxf-profiles.xml config file comments for all Hive-related profiles

2017-03-22 Thread Oleksandr Diachenko (JIRA)
[ https://issues.apache.org/jira/browse/HAWQ-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Diachenko updated HAWQ-1402: -- Fix Version/s: 2.2.0.0-incubating > Update pxf-profiles.xml config file comments for all

[jira] [Commented] (HAWQ-304) Support update and delete on non-heap tables

2017-03-22 Thread Christian Tzolov (JIRA)
[ https://issues.apache.org/jira/browse/HAWQ-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936618#comment-15936618 ] Christian Tzolov commented on HAWQ-304: --- Glad to hear it works [~hongxu ma]! We are still working

[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...

2017-03-22 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1183 +1 for the fix. The clarification looks better to have root cause --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix HAWQ make install with DES...

2017-03-22 Thread radarwave
Github user radarwave commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1184#discussion_r107420381 --- Diff: tools/bin/pythonSrc/PyGreSQL-4.0/setup.py --- @@ -62,6 +62,11 @@ def pg_config(s): raise Exception("pg_config tool is not

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 Great to have the fix for build. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix HAWQ make install with DES...

2017-03-22 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1184#discussion_r107409405 --- Diff: tools/bin/pythonSrc/PyGreSQL-4.0/setup.py --- @@ -62,6 +62,11 @@ def pg_config(s): raise Exception("pg_config tool is not

[GitHub] incubator-hawq pull request #1184: HAWQ-1401. Fix python modules install wit...

2017-03-22 Thread radarwave
GitHub user radarwave opened a pull request: https://github.com/apache/incubator-hawq/pull/1184 HAWQ-1401. Fix python modules install with DESTDIR. Need to handle pygresql install as it depend on the pre-installed hawq components. You can merge this pull request into a Git

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 @edespino @paul-guo- @huor @xunzhang Please help to review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If