Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
OK, so +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
They are all generated by 'pg_config', they should not be relative PATH.
# Extension makefiles should set PG_CONFIG, but older ones might not
ifndef PG_CONFIG
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
If you can make sure all of the later paths are absolute path, it will be
fine, e.g.
${DESTDIR}${docdir}
${DESTDIR}$(bindir)
${DESTDIR}${libdir}
$(DESTDIR)${sysconfdir}
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
@paul-guo-
I don't think the --prefix option can set a relative path, so there is
definitely no need to add a '/' between DESTDIR and PREFIX-DIR.
---
If your project is set up for
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
Cool work! I just have one concern.
I saw a lot of fix like this, however is is possible the later one is a
relative path while DESTDIR has not a tailing / and this could lead to
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
Great to have the fix for build. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
@edespino @paul-guo- @huor @xunzhang
Please help to review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
