[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695154#comment-15695154 ] Anoop Sam John commented on HBASE-17048: +1 for doing it with out any additional

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695110#comment-15695110 ] ramkrishna.s.vasudevan commented on HBASE-17048: Actually we already use

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695107#comment-15695107 ] ramkrishna.s.vasudevan commented on HBASE-17012: Ok. I think some recent

[jira] [Commented] (HBASE-17049) Find out why AsyncFSWAL issues much more syncs than FSHLog

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695104#comment-15695104 ] ramkrishna.s.vasudevan commented on HBASE-17049: When we try with multiWA

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695092#comment-15695092 ] Anoop Sam John commented on HBASE-17012: To RB pls.. better to see diff and add c

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695086#comment-15695086 ] Anoop Sam John commented on HBASE-17048: bq.We already know what length we want.

[jira] [Updated] (HBASE-16561) Add metrics about read/write/scan queue length and active read/write/scan handler count

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-16561: --- Description: Now there are only metrics about total queue length and active rpc handler coun

[jira] [Updated] (HBASE-17140) Throw RegionOfflineException directly when request for a disabled table

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-17140: --- Description: Now when request for a disabled table, it need 3 rpc calls before fail. 1. get r

[jira] [Commented] (HBASE-17140) Throw RegionOfflineException directly when request for a disabled table

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695062#comment-15695062 ] Guanghao Zhang commented on HBASE-17140: The failed ut passed local. > Throw Reg

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695058#comment-15695058 ] Hadoop QA commented on HBASE-17012: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Updated] (HBASE-17127) Locate region should fail fast if underlying Connection already closed

2016-11-24 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-17127: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Locate region should fail fast if underlyi

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695043#comment-15695043 ] ramkrishna.s.vasudevan commented on HBASE-17048: bq.If so, bb.remaining()

[jira] [Commented] (HBASE-17127) Locate region should fail fast if underlying Connection already closed

2016-11-24 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695040#comment-15695040 ] Yu Li commented on HBASE-17127: --- Ok, will commit the change in HBASE-17175 to branch-1.3 af

[jira] [Created] (HBASE-17175) backport HBASE-17127 to 1.3.1

2016-11-24 Thread Yu Li (JIRA)
Yu Li created HBASE-17175: - Summary: backport HBASE-17127 to 1.3.1 Key: HBASE-17175 URL: https://issues.apache.org/jira/browse/HBASE-17175 Project: HBase Issue Type: Bug Affects Versions: 1.3.0

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695024#comment-15695024 ] ramkrishna.s.vasudevan commented on HBASE-17048: bq. If so, bb.remaining(

[jira] [Comment Edited] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695011#comment-15695011 ] ramkrishna.s.vasudevan edited comment on HBASE-17012 at 11/25/16 6:50 AM: -

[jira] [Updated] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17012: --- Attachment: HBASE-17012_3.patch SecureWALCellCodec now works with DOS just be

[jira] [Updated] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17012: --- Status: Patch Available (was: Open) > Handle Offheap cells in CompressedKvEn

[jira] [Updated] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17012: --- Status: Open (was: Patch Available) > Handle Offheap cells in CompressedKvEn

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694995#comment-15694995 ] Anoop Sam John commented on HBASE-17048: {code} buf.writeBytes(bb); 338 t

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Attachment: HBASE-17174.v3.patch v3 addresses comment from [~yuzhih...@gmail.com], and v3 have

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Status: Patch Available (was: Open) > Use shared threadpool in BufferedMutatorImpl > -

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Status: Open (was: Patch Available) > Use shared threadpool in BufferedMutatorImpl > -

[jira] [Updated] (HBASE-16561) Add metrics about read/write/scan queue length and active read/write/scan handler count

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-16561: --- Attachment: HBASE-16561.patch > Add metrics about read/write/scan queue length and active rea

[jira] [Updated] (HBASE-16561) Add metrics about read/write/scan queue length and active read/write/scan handler count

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-16561: --- Assignee: Guanghao Zhang Status: Patch Available (was: Open) > Add metrics about read/

[jira] [Updated] (HBASE-16561) Add metrics about read/write/scan queue length and active read/write/scan handler count

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-16561: --- Summary: Add metrics about read/write/scan queue length and active read/write/scan handler co

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694971#comment-15694971 ] ChiaPing Tsai commented on HBASE-17174: --- hi [~jinghe], [~anoop.hbase] I refactor/cl

[jira] [Commented] (HBASE-14417) Incremental backup and bulk loading

2016-11-24 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694965#comment-15694965 ] Ashish Singhi commented on HBASE-14417: --- Can you upload the patch on RB. It will be

[jira] [Updated] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17048: --- Status: Patch Available (was: Open) > Introduce a helper class to calcuate s

[jira] [Updated] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17048: --- Attachment: HBASE-17048_1.patch I named the patch with a wrong JIRA id. > In

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694922#comment-15694922 ] ChiaPing Tsai commented on HBASE-17174: --- copy that. > Use shared threadpool in Buf

[jira] [Commented] (HBASE-17140) Throw RegionOfflineException directly when request for a disabled table

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694919#comment-15694919 ] Hadoop QA commented on HBASE-17140: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694913#comment-15694913 ] Anoop Sam John commented on HBASE-17174: Seems there are many unrelated changes h

[jira] [Updated] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17048: --- Attachment: HBASE-17012_3.patch Updated patch that initializes to 4K and incr

[jira] [Updated] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-17048: --- Status: Open (was: Patch Available) > Introduce a helper class to calcuate s

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694909#comment-15694909 ] Anoop Sam John commented on HBASE-17110: It is private marked.. So we can break t

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694904#comment-15694904 ] ChiaPing Tsai commented on HBASE-17174: --- The v2++ patch makes BufferedMutatorImpl h

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694901#comment-15694901 ] Ashish Singhi commented on HBASE-17110: --- LB is an interface and it may break client

[jira] [Comment Edited] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694890#comment-15694890 ] Yu Li edited comment on HBASE-17110 at 11/25/16 5:36 AM: - I concu

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694890#comment-15694890 ] Yu Li commented on HBASE-17110: --- I concur to add the {{balanceCluster}} interface to LB. Fr

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694854#comment-15694854 ] ramkrishna.s.vasudevan commented on HBASE-17174: Valid point. Good commen

[jira] [Updated] (HBASE-17140) Throw RegionOfflineException directly when request for a disabled table

2016-11-24 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-17140: --- Attachment: HBASE-17140-v4.patch Add a v4 patch. When upgrade cluster, master need rebuild th

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694660#comment-15694660 ] Jerry He commented on HBASE-17174: -- BufferedMutator should not close an external Executo

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Charlie Qiangeng Xu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694615#comment-15694615 ] Charlie Qiangeng Xu commented on HBASE-17110: - Good suggestion! Should I ad

[jira] [Commented] (HBASE-16489) Configuration parsing

2016-11-24 Thread Sudeep Sunthankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694576#comment-15694576 ] Sudeep Sunthankar commented on HBASE-16489: --- Thanks [~enis], {quote} This stil

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694447#comment-15694447 ] Ted Yu commented on HBASE-17174: lgtm {code} 77 * non-final so can be overridden

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694216#comment-15694216 ] Hadoop QA commented on HBASE-17174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17172) Optimize major mob compaction with _del files

2016-11-24 Thread huaxiang sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694193#comment-15694193 ] huaxiang sun commented on HBASE-17172: -- {code} Hmm. If the .del is not a performance

[jira] [Commented] (HBASE-15786) Create DBB backed MSLAB pool

2016-11-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694081#comment-15694081 ] Hudson commented on HBASE-15786: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Status: Patch Available (was: Open) > Use shared threadpool in BufferedMutatorImpl > -

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Attachment: HBASE-17174.v2.patch v2 addresses the comment from [~anoop.hbase] > Use shared thr

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Status: Open (was: Patch Available) > Use shared threadpool in BufferedMutatorImpl > -

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693969#comment-15693969 ] ChiaPing Tsai commented on HBASE-17174: --- You inspire me. I will address your commen

[jira] [Comment Edited] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693948#comment-15693948 ] Anoop Sam John edited comment on HBASE-17174 at 11/24/16 6:16 PM: -

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693948#comment-15693948 ] Anoop Sam John commented on HBASE-17174: That is a wrong expectation itself IMO.

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693936#comment-15693936 ] ChiaPing Tsai commented on HBASE-17174: --- It is a good idea, but it may can't deal w

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693900#comment-15693900 ] ChiaPing Tsai commented on HBASE-17174: --- bq. How about calling pool.shutdowNow() in

[jira] [Commented] (HBASE-16984) Implement getScanner

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693894#comment-15693894 ] Hadoop QA commented on HBASE-16984: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693866#comment-15693866 ] Anoop Sam John commented on HBASE-17174: So BufferedMutator can be created using

[jira] [Commented] (HBASE-17170) HBase is also retrying DoNotRetryIOException because of class loader differences.

2016-11-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693852#comment-15693852 ] Andrew Purtell commented on HBASE-17170: bq. HBaseRemoteWithExtrasException(exten

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693814#comment-15693814 ] Ted Yu commented on HBASE-17174: {code} 204 terminated = this.pool.awaitTer

[jira] [Commented] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693802#comment-15693802 ] Andrew Purtell commented on HBASE-13096: Thanks. A WARN message makes sense. >

[jira] [Commented] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693796#comment-15693796 ] Anoop Sam John commented on HBASE-13096: Sorry if I was not clear.. I dont mean w

[jira] [Commented] (HBASE-15616) CheckAndMutate will encouter NPE if qualifier to check is null

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693785#comment-15693785 ] Anoop Sam John commented on HBASE-15616: Ya empty qualifier is legal. table.check

[jira] [Commented] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693780#comment-15693780 ] Andrew Purtell commented on HBASE-13096: I don't think we should allow it because

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693735#comment-15693735 ] Hadoop QA commented on HBASE-17174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693725#comment-15693725 ] Anoop Sam John commented on HBASE-17012: Should be min addition in CellUtil and n

[jira] [Commented] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693720#comment-15693720 ] Anoop Sam John commented on HBASE-13096: Ya I asked that Q in Phoenix jira.. Sho

[jira] [Commented] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693670#comment-15693670 ] Andrew Purtell commented on HBASE-13096: This should be resolved as Won't Fix.

[jira] [Commented] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693668#comment-15693668 ] Andrew Purtell commented on HBASE-13096: This is not a bug unfortunately. The sec

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693659#comment-15693659 ] ramkrishna.s.vasudevan commented on HBASE-17012: I think better not to ad

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693652#comment-15693652 ] ramkrishna.s.vasudevan commented on HBASE-17012: Changing to DataOS is fi

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693574#comment-15693574 ] Anoop Sam John commented on HBASE-17110: Thanks Ted. Ya we should be able to do r

[jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693567#comment-15693567 ] Anoop Sam John commented on HBASE-17012: Did not read the patch fully.. First le

[jira] [Updated] (HBASE-15786) Create DBB backed MSLAB pool

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-15786: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master. Thanks f

[jira] [Updated] (HBASE-16984) Implement getScanner

2016-11-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16984: -- Attachment: HBASE-16984-v5.patch Fix a bug for flow control. Add a scan method for AsyncTable. > Imple

[jira] [Updated] (HBASE-15786) Create DBB backed MSLAB pool

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-15786: --- Release Note: Added a new config hbase.regionserver.offheap.global.memstore.size using which

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Status: Patch Available (was: Open) > Use shared threadpool in BufferedMutatorImpl > -

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Attachment: HBASE-17174.v1.patch fix the possible null values > Use shared threadpool in Buffe

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Assignee: ChiaPing Tsai Status: Open (was: Patch Available) > Use shared threadpool in B

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693389#comment-15693389 ] Hadoop QA commented on HBASE-17174: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-15786) Create DBB backed MSLAB pool

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693354#comment-15693354 ] Hadoop QA commented on HBASE-15786: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693320#comment-15693320 ] Ted Yu commented on HBASE-17110: w.r.t. dropping 'this.balancer instanceof SimpleLoadBala

[jira] [Issue Comment Deleted] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Charlie Qiangeng Xu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charlie Qiangeng Xu updated HBASE-17110: Comment: was deleted (was: Hi Anoop, ideal I shouldn't add extra for SLB, but only

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693301#comment-15693301 ] Anoop Sam John commented on HBASE-17110: Am not very sure abt the code flow in LB

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693296#comment-15693296 ] Hadoop QA commented on HBASE-17048: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Charlie Qiangeng Xu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693274#comment-15693274 ] Charlie Qiangeng Xu commented on HBASE-17110: - Hi Anoop, ideal I shouldn't ad

[jira] [Commented] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Charlie Qiangeng Xu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693275#comment-15693275 ] Charlie Qiangeng Xu commented on HBASE-17110: - Hi Anoop, ideal I shouldn't ad

[jira] [Issue Comment Deleted] (HBASE-17110) Add an "Overall Strategy" option(balanced both on table level and server level) to SimpleLoadBalancer

2016-11-24 Thread Charlie Qiangeng Xu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charlie Qiangeng Xu updated HBASE-17110: Comment: was deleted (was: Hi Anoop, ideal I shouldn't add extra for SLB, but only

[jira] [Commented] (HBASE-17049) Find out why AsyncFSWAL issues much more syncs than FSHLog

2016-11-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693165#comment-15693165 ] Duo Zhang commented on HBASE-17049: --- Fine. I think you could try multiwal and set {{hb

[jira] [Commented] (HBASE-17172) Optimize major mob compaction with _del files

2016-11-24 Thread Jingcheng Du (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693154#comment-15693154 ] Jingcheng Du commented on HBASE-17172: -- bq. So when we have _del files, we will prom

[jira] [Commented] (HBASE-17049) Find out why AsyncFSWAL issues much more syncs than FSHLog

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693150#comment-15693150 ] ramkrishna.s.vasudevan commented on HBASE-17049: I meant to ask WAL per r

[jira] [Commented] (HBASE-17049) Find out why AsyncFSWAL issues much more syncs than FSHLog

2016-11-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693114#comment-15693114 ] Duo Zhang commented on HBASE-17049: --- {quote} Do you mean multiWAL per region? {quote}

[jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper

2016-11-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693108#comment-15693108 ] Duo Zhang commented on HBASE-17048: --- I think usually the initial size should be 4KB or

[jira] [Commented] (HBASE-17144) Possible offheap read ByteBuffers leak

2016-11-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693080#comment-15693080 ] Hudson commented on HBASE-17144: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-17172) Optimize major mob compaction with _del files

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693053#comment-15693053 ] Anoop Sam John commented on HBASE-17172: So when we have _del files, we will prom

[jira] [Reopened] (HBASE-13096) NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL encryption and Phoenix secondary indexes

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John reopened HBASE-13096: > NPE from SecureWALCellCodec$EncryptedKvEncoder#write when using WAL > encryption and Phoenix

[jira] [Updated] (HBASE-15786) Create DBB backed MSLAB pool

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-15786: --- Attachment: HBASE-15786_V6.patch > Create DBB backed MSLAB pool > ---

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Fix Version/s: 2.0.0 Affects Version/s: 2.0.0 Status: Patch Available (w

[jira] [Updated] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaPing Tsai updated HBASE-17174: -- Attachment: HBASE-17174.v0.patch > Use shared threadpool in BufferedMutatorImpl > -

  1   2   >