[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread AK97 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995456#comment-16995456 ] AK97 commented on HBASE-22607: -- I am using the command " mvn test -Dtest=TestExportSnapshot

[jira] [Comment Edited] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread AK97 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995456#comment-16995456 ] AK97 edited comment on HBASE-22607 at 12/13/19 8:30 AM: I am usi

[jira] [Comment Edited] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread AK97 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995456#comment-16995456 ] AK97 edited comment on HBASE-22607 at 12/13/19 8:31 AM: I am usi

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-12-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995484#comment-16995484 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #209 on

[jira] [Commented] (HBASE-23286) Improve MTTR: Split WAL to HFile

2019-12-13 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995486#comment-16995486 ] Guanghao Zhang commented on HBASE-23286: {quote}how/whether that affects?  {quot

[jira] [Commented] (HBASE-23286) Improve MTTR: Split WAL to HFile

2019-12-13 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995492#comment-16995492 ] Guanghao Zhang commented on HBASE-23286: Test the patch in a cluster which has 5

[jira] [Commented] (HBASE-23286) Improve MTTR: Split WAL to HFile

2019-12-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995501#comment-16995501 ] Duo Zhang commented on HBASE-23286: --- Why the split time for hfile=false reduces a lot

[jira] [Commented] (HBASE-23286) Improve MTTR: Split WAL to HFile

2019-12-13 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995515#comment-16995515 ] Guanghao Zhang commented on HBASE-23286: {quote}Why the split time for hfile=fal

[jira] [Commented] (HBASE-23286) Improve MTTR: Split WAL to HFile

2019-12-13 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995517#comment-16995517 ] Guanghao Zhang commented on HBASE-23286: In big cluster, the split WAL task was

[GitHub] [hbase] ramkrish86 commented on issue #935: HBASE-23066 Allow cache on write during compactions when prefetching …

2019-12-13 Thread GitBox
ramkrish86 commented on issue #935: HBASE-23066 Allow cache on write during compactions when prefetching … URL: https://github.com/apache/hbase/pull/935#issuecomment-565395529 Fixed checkstyle issues and the test failures here are not related. Reran them and confirmed. ---

[GitHub] [hbase] virajjasani opened a new pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
virajjasani opened a new pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939 …rs reset This is an automated message from the Apache Git Servi

[GitHub] [hbase] virajjasani commented on issue #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
virajjasani commented on issue #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939#issuecomment-565406910 Please review @apurtell @anoopsjohn @ramkrish86 @saintstack

[GitHub] [hbase-connectors] petersomogyi merged pull request #53: HBASE-23565 Execute tests in hbase-connectors precommit

2019-12-13 Thread GitBox
petersomogyi merged pull request #53: HBASE-23565 Execute tests in hbase-connectors precommit URL: https://github.com/apache/hbase-connectors/pull/53 This is an automated message from the Apache Git Service. To respond to th

[jira] [Work started] (HBASE-23349) Reader lock on compacted store files preventing archival of compacted files

2019-12-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23349 started by Viraj Jasani. > Reader lock on compacted store files preventing archival of compacted files >

[jira] [Resolved] (HBASE-23565) Execute tests in hbase-connectors precommit

2019-12-13 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-23565. --- Resolution: Fixed Merged PR to master. Thanks for the review [~meszibalu]! > Execute tests

[jira] [Updated] (HBASE-23349) Reader lock on compacted store files preventing archival of compacted files

2019-12-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23349: - Status: Patch Available (was: In Progress) > Reader lock on compacted store files preventing ar

[jira] [Commented] (HBASE-23349) Reader lock on compacted store files preventing archival of compacted files

2019-12-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995554#comment-16995554 ] Viraj Jasani commented on HBASE-23349: -- Please review: [https://github.com/apache/h

[GitHub] [hbase] Apache-HBase commented on issue #934: HBASE-23568: Improve Threading of Replication

2019-12-13 Thread GitBox
Apache-HBase commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565429259 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[jira] [Commented] (HBASE-23568) Improve Threading of Replication

2019-12-13 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995590#comment-16995590 ] HBase QA commented on HBASE-23568: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] busbey commented on issue #934: HBASE-23568: Improve Threading of Replication

2019-12-13 Thread GitBox
busbey commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565447706 Have you gotten to try this out on a cluster? I don't think we have a PerfEval equivalent for replication.

[jira] [Commented] (HBASE-23570) Point users to the async-profiler home page if diagrams are coming up blank

2019-12-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995648#comment-16995648 ] Hudson commented on HBASE-23570: Results for branch master [build #1566 on buil

[jira] [Commented] (HBASE-23566) Fix package/packet terminology problem in chaos monkeys

2019-12-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995647#comment-16995647 ] Hudson commented on HBASE-23566: Results for branch master [build #1566 on buil

[GitHub] [hbase] busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-13 Thread GitBox
busbey commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r357663478 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -227,12 +232,8 @@ public s

[GitHub] [hbase] busbey commented on issue #935: HBASE-23066 Allow cache on write during compactions when prefetching …

2019-12-13 Thread GitBox
busbey commented on issue #935: HBASE-23066 Allow cache on write during compactions when prefetching … URL: https://github.com/apache/hbase/pull/935#issuecomment-565458508 please make sure you're testing `TestCacheOnWrite` manually because it's in the [current exclusion list](https://buil

[GitHub] [hbase] busbey commented on issue #929: HBASE-23305: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
busbey commented on issue #929: HBASE-23305: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565459912 > Yes, I was planning to use the same jira ID for registry implementation. Just curious, why is there 1-1 commit-jira ID mapping? I thought it'

[GitHub] [hbase] busbey edited a comment on issue #929: HBASE-23305: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
busbey edited a comment on issue #929: HBASE-23305: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565459912 > Yes, I was planning to use the same jira ID for registry implementation. Just curious, why is there 1-1 commit-jira ID mapping? I tho

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357681577 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357666106 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357673815 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357683978 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357677851 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357675978 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #931: HBASE-22285 A normalizer which merges small size regions with adjacen… URL: https://github.com/apache/hbase/pull/931#discussion_r357677851 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/Merg

[GitHub] [hbase] Apache-HBase commented on issue #820: HBASE-23286 Improve MTTR: Split WAL to HFile

2019-12-13 Thread GitBox
Apache-HBase commented on issue #820: HBASE-23286 Improve MTTR: Split WAL to HFile URL: https://github.com/apache/hbase/pull/820#issuecomment-565476667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:--

[GitHub] [hbase] Apache-HBase commented on issue #935: HBASE-23066 Allow cache on write during compactions when prefetching …

2019-12-13 Thread GitBox
Apache-HBase commented on issue #935: HBASE-23066 Allow cache on write during compactions when prefetching … URL: https://github.com/apache/hbase/pull/935#issuecomment-565504076 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939#discussion_r357731432 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScann

[GitHub] [hbase] anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939#discussion_r357721085 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChangedRea

[GitHub] [hbase] anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939#discussion_r357731263 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScann

[jira] [Commented] (HBASE-22978) Online slow response log

2019-12-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995759#comment-16995759 ] Viraj Jasani commented on HBASE-22978: -- Please review the patch, it's been a while

[GitHub] [hbase] belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication

2019-12-13 Thread GitBox
belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565517137 Nah. My intention here was not to improve performance, just trying to get the code "up to code" by using JDK and Guava facilities to bet

[GitHub] [hbase] belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication

2019-12-13 Thread GitBox
belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565519990 Also, after incubating overnight, I do want to make a change. In the `terminate` method, it should loop through the workers stored in th

[GitHub] [hbase] saintstack commented on issue #938: HBASE-23572 In 'HBCK Report', distringush between live, dead, and unk…

2019-12-13 Thread GitBox
saintstack commented on issue #938: HBASE-23572 In 'HBCK Report', distringush between live, dead, and unk… URL: https://github.com/apache/hbase/pull/938#issuecomment-565520485 Thanks for review @busbey . Trying it out on cluster first before committing in case I messed it up (hard to test.

[GitHub] [hbase] virajjasani commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
virajjasani commented on a change in pull request #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939#discussion_r357749459 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScan

[jira] [Created] (HBASE-23575) Remove dead code from AsyncRegistry interface

2019-12-13 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-23575: Summary: Remove dead code from AsyncRegistry interface Key: HBASE-23575 URL: https://issues.apache.org/jira/browse/HBASE-23575 Project: HBase

[jira] [Updated] (HBASE-23575) Remove dead code from AsyncRegistry interface

2019-12-13 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-23575: - Status: Patch Available (was: Open) > Remove dead code from AsyncRegistry inter

[GitHub] [hbase] busbey commented on issue #934: HBASE-23568: Improve Threading of Replication

2019-12-13 Thread GitBox
busbey commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565533892 I'm not looking for a performance improvement, just that we don't degrade or further beat up HDFS. In deployments that have high number

[GitHub] [hbase] bharathv commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
bharathv commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565534317 Cool. I updated the jira ID. This is an automated message from the Apache Gi

[GitHub] [hbase] belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication

2019-12-13 Thread GitBox
belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565536352 Well, maybe that's something I can take a look at. With this threadpool introduced in this PR, perhaps the number of worker threads can

[GitHub] [hbase] Apache-HBase commented on issue #939: HBASE-23349 : Force archive compacted storefiles after current scanne…

2019-12-13 Thread GitBox
Apache-HBase commented on issue #939: HBASE-23349 : Force archive compacted storefiles after current scanne… URL: https://github.com/apache/hbase/pull/939#issuecomment-565536782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase-operator-tools] wchevreuil commented on issue #46: HBASE-23562 [operator tools] Add a RegionsMerge tool that allows for …

2019-12-13 Thread GitBox
wchevreuil commented on issue #46: HBASE-23562 [operator tools] Add a RegionsMerge tool that allows for … URL: https://github.com/apache/hbase-operator-tools/pull/46#issuecomment-565554222 Ok, new commit adding UT and README. Mind give another round of review, @z-york ? -

[GitHub] [hbase-operator-tools] asf-ci commented on issue #46: HBASE-23562 [operator tools] Add a RegionsMerge tool that allows for …

2019-12-13 Thread GitBox
asf-ci commented on issue #46: HBASE-23562 [operator tools] Add a RegionsMerge tool that allows for … URL: https://github.com/apache/hbase-operator-tools/pull/46#issuecomment-565558834 Refer to this link for build results (access rights to CI server needed): https://builds.apache.o

[jira] [Updated] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-22607: -- Attachment: HBASE-22607.addendum.001.patch > TestExportSnapshotNoCluster::testSnapshotWithRefs

[jira] [Commented] (HBASE-22607) TestExportSnapshotNoCluster::testSnapshotWithRefsExportFileSystemState() fails intermittently

2019-12-13 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995824#comment-16995824 ] Mingliang Liu commented on HBASE-22607: --- [~AK2019] Thanks for providing more conte

[GitHub] [hbase] busbey commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
busbey commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565576283 (merge in progress) This is an automated message from the Apache Git Service.

[GitHub] [hbase] bharathv commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
bharathv commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565589132 Thanks Sean. Once you are done with the merge, can you please rebase the feature branch (HBASE-18095/client-locate-meta-no-zookeeper) against

[GitHub] [hbase] busbey commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
busbey commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565590596 @bharathv can you make a branch-2 specific version of this? there's a nontrivial number of gaps backporting. -

[GitHub] [hbase] busbey commented on issue #932: bug: can not guarantee consistency

2019-12-13 Thread GitBox
busbey commented on issue #932: bug: can not guarantee consistency URL: https://github.com/apache/hbase/pull/932#issuecomment-565603969 conversation on https://issues.apache.org/jira/browse/HBASE-23573 This is an automated mes

[GitHub] [hbase] bharathv opened a new pull request #940: HBASE-23575 Remove dead code in AsyncRegistry (#929)

2019-12-13 Thread GitBox
bharathv opened a new pull request #940: HBASE-23575 Remove dead code in AsyncRegistry (#929) URL: https://github.com/apache/hbase/pull/940 Removes a bunch of dead code and fixes some checkstyle nits. Signed-off-by: Viraj Jasani Signed-off-by: Sean Busbey (cherry picked from

[GitHub] [hbase] bharathv commented on issue #940: HBASE-23575 Remove dead code in AsyncRegistry (#929)

2019-12-13 Thread GitBox
bharathv commented on issue #940: HBASE-23575 Remove dead code in AsyncRegistry (#929) URL: https://github.com/apache/hbase/pull/940#issuecomment-565609425 @busbey for branch-2, FYI. This is an automated message from the Apac

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357837870 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestMobCompaction.java ## @@ -0,0

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357838177 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestMobCompaction.java ## @@ -0,0

[jira] [Commented] (HBASE-23573) can not guarantee consistency.

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995932#comment-16995932 ] Sean Busbey commented on HBASE-23573: - Edits to the WAL each have a monotonically in

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357839420 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1309,14 +1308,

[GitHub] [hbase] busbey commented on issue #940: HBASE-23575 Remove dead code in AsyncRegistry (#929)

2019-12-13 Thread GitBox
busbey commented on issue #940: HBASE-23575 Remove dead code in AsyncRegistry (#929) URL: https://github.com/apache/hbase/pull/940#issuecomment-565616412 thanks for the quick turn around @bharathv! This is an automated messag

[GitHub] [hbase] busbey commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
busbey commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565621172 further backports off of #940 This is an automated message from the Apache Gi

[GitHub] [hbase] busbey closed pull request #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
busbey closed pull request #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357852784 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -1749

[GitHub] [hbase] busbey closed pull request #907: HBASE-23375 Backport HBASE-22441 to branch-1

2019-12-13 Thread GitBox
busbey closed pull request #907: HBASE-23375 Backport HBASE-22441 to branch-1 URL: https://github.com/apache/hbase/pull/907 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] busbey commented on issue #907: HBASE-23375 Backport HBASE-22441 to branch-1

2019-12-13 Thread GitBox
busbey commented on issue #907: HBASE-23375 Backport HBASE-22441 to branch-1 URL: https://github.com/apache/hbase/pull/907#issuecomment-565628347 pushed to branch-1 and branch-1.4 thanks folks! This is an automated message fro

[jira] [Resolved] (HBASE-23375) Backport HBASE-22441 to branch-1

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-23375. - Fix Version/s: 1.4.13 1.6.0 Resolution: Fixed thanks for chasing this

[jira] [Updated] (HBASE-23375) Backport HBASE-22441 to branch-1

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23375: Component/s: (was: BlockCache) BucketCache > Backport HBASE-22441 to branch-1

[jira] [Updated] (HBASE-23375) Backport HBASE-22441 to branch-1

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23375: Component/s: BlockCache > Backport HBASE-22441 to branch-1 > > >

[jira] [Updated] (HBASE-22441) BucketCache NullPointerException in cacheBlock

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-22441: Fix Version/s: 1.4.13 1.6.0 > BucketCache NullPointerException in cacheBlock >

[GitHub] [hbase] busbey commented on a change in pull request #910: HBASE-23378: Clean Up FSUtil setClusterId

2019-12-13 Thread GitBox
busbey commented on a change in pull request #910: HBASE-23378: Clean Up FSUtil setClusterId URL: https://github.com/apache/hbase/pull/910#discussion_r357854662 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ## @@ -635,53 +636,55 @@ priv

[jira] [Updated] (HBASE-23380) General Cleanup of FSUtil

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-23380: Component/s: Filesystem Integration > General Cleanup of FSUtil > - > >

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357855755 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestMobCompaction.java ## @@ -0,0

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357856749 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357857417 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357857535 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357859551 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357860681 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357861240 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] saintstack commented on issue #930: HBASE-23564 RegionStates may has some expired serverinfo and make reg…

2019-12-13 Thread GitBox
saintstack commented on issue #930: HBASE-23564 RegionStates may has some expired serverinfo and make reg… URL: https://github.com/apache/hbase/pull/930#issuecomment-565640008 I have run into this issue. Thanks for digging in. One concern I have is why the deviation between serverManager

[jira] [Commented] (HBASE-23575) Remove dead code from AsyncRegistry interface

2019-12-13 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995990#comment-16995990 ] HBase QA commented on HBASE-23575: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] Apache-HBase commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry

2019-12-13 Thread GitBox
Apache-HBase commented on issue #929: HBASE-23575: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565640394 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:-

[GitHub] [hbase] Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#issuecomment-565640696 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357864305 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[jira] [Commented] (HBASE-22749) Distributed MOB compactions

2019-12-13 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995992#comment-16995992 ] HBase QA commented on HBASE-22749: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client

2019-12-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995994#comment-16995994 ] Hudson commented on HBASE-18095: Results for branch HBASE-18095/client-locate-meta-no-zo

[GitHub] [hbase] busbey commented on issue #912: HBASE-23380: General Cleanup of FSUtil

2019-12-13 Thread GitBox
busbey commented on issue #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#issuecomment-565642677 thanks! This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hbase] busbey closed pull request #912: HBASE-23380: General Cleanup of FSUtil

2019-12-13 Thread GitBox
busbey closed pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Resolved] (HBASE-23380) General Cleanup of FSUtil

2019-12-13 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-23380. - Fix Version/s: 2.1.9 2.2.3 2.3.0 3.0.0

[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2019-12-13 Thread GitBox
VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r357867591 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MobFileCleanerChore.java ## @@ -0,

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r356801045 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/m

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r356801604 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/m

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r357866250 ## File path: hbase-procedure/src/test/java/org/apache/hadoop/hbas

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r356800731 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/m

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r357866822 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/m

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r357866768 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/m

[GitHub] [hbase] saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2019-12-13 Thread GitBox
saintstack commented on a change in pull request #917: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/917#discussion_r356801303 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/m

  1   2   >