[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019908#comment-17019908 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #248 on

[jira] [Commented] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-20 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019876#comment-17019876 ] Bharath Vissapragada commented on HBASE-23647: -- [~andrew.purt...@gmail.com]

[jira] [Updated] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-20 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-23647: - Status: Patch Available (was: In Progress) > Make MasterRegistry the default re

[GitHub] [hbase] virajjasani commented on a change in pull request #1077: HBASE-23710 - Priority configuration for system coprocessors

2020-01-20 Thread GitBox
virajjasani commented on a change in pull request #1077: HBASE-23710 - Priority configuration for system coprocessors URL: https://github.com/apache/hbase/pull/1077#discussion_r368823636 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.ja

[jira] [Updated] (HBASE-23710) Priority configuration for system coprocessors

2020-01-20 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated HBASE-23710: Status: Patch Available (was: Open) > Priority configuration for system coprocessors > --

[jira] [Updated] (HBASE-23710) Priority configuration for system coprocessors

2020-01-20 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated HBASE-23710: Attachment: HBASE-23710-master.v01.patch > Priority configuration for system coprocessors

[jira] [Commented] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-20 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019849#comment-17019849 ] HBase QA commented on HBASE-23647: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] Apache-HBase commented on issue #1039: HBASE-23647: Make MasterRegistry the default impl.

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1039: HBASE-23647: Make MasterRegistry the default impl. URL: https://github.com/apache/hbase/pull/1039#issuecomment-576514772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[GitHub] [hbase] Apache-HBase commented on issue #1077: HBASE-23710 - Priority configuration for system coprocessors

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1077: HBASE-23710 - Priority configuration for system coprocessors URL: https://github.com/apache/hbase/pull/1077#issuecomment-576511756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[GitHub] [hbase] thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368803882 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regio

[GitHub] [hbase] Yiran-wu commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic

2020-01-20 Thread GitBox
Yiran-wu commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#discussion_r368800553 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3699

[GitHub] [hbase] Yiran-wu commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic

2020-01-20 Thread GitBox
Yiran-wu commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#discussion_r368799499 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java ## @@

[GitHub] [hbase] thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368797626 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regio

[GitHub] [hbase] thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368797626 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regio

[jira] [Commented] (HBASE-23156) start-hbase.sh failed with ClassNotFoundException when build with hadoop3

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019787#comment-17019787 ] Hudson commented on HBASE-23156: Results for branch branch-2 [build #2422 on bu

[GitHub] [hbase] gjacoby126 opened a new pull request #1077: HBASE-23710 - Priority configuration for system coprocessors

2020-01-20 Thread GitBox
gjacoby126 opened a new pull request #1077: HBASE-23710 - Priority configuration for system coprocessors URL: https://github.com/apache/hbase/pull/1077 This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on issue #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests URL: https://github.com/apache/hbase/pull/1075#issuecomment-576459557 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest URL: https://github.com/apache/hbase/pull/1046#issuecomment-576452737 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[jira] [Created] (HBASE-23713) Upgrade checkstyle and plugin versions for hbase-operator-tools

2020-01-20 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-23713: - Summary: Upgrade checkstyle and plugin versions for hbase-operator-tools Key: HBASE-23713 URL: https://issues.apache.org/jira/browse/HBASE-23713 Project: HBase

[jira] [Created] (HBASE-23712) Upgrade checkstyle and plugin versions for hbase-connectors

2020-01-20 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-23712: - Summary: Upgrade checkstyle and plugin versions for hbase-connectors Key: HBASE-23712 URL: https://issues.apache.org/jira/browse/HBASE-23712 Project: HBase

[jira] [Created] (HBASE-23711) Add test for MinVersions and KeepDeletedCells TTL

2020-01-20 Thread Geoffrey Jacoby (Jira)
Geoffrey Jacoby created HBASE-23711: --- Summary: Add test for MinVersions and KeepDeletedCells TTL Key: HBASE-23711 URL: https://issues.apache.org/jira/browse/HBASE-23711 Project: HBase Issue

[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019749#comment-17019749 ] Hudson commented on HBASE-18095: Results for branch HBASE-18095/client-locate-meta-no-zo

[jira] [Updated] (HBASE-23625) Reduce number of Checkstyle violations in hbase-common

2020-01-20 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-23625: -- Fix Version/s: 2.3.0 > Reduce number of Checkstyle violations in hbase-common > --

[jira] [Commented] (HBASE-23625) Reduce number of Checkstyle violations in hbase-common

2020-01-20 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019748#comment-17019748 ] Jan Hentschel commented on HBASE-23625: --- Pushed to branch-2. > Reduce number of C

[GitHub] [hbase] HorizonNet merged pull request #1076: HBASE-23625 Reduced number of Checkstyle violations in hbase-common

2020-01-20 Thread GitBox
HorizonNet merged pull request #1076: HBASE-23625 Reduced number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1076 This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (HBASE-23646) Fix remaining Checkstyle violations in tests of hbase-rest

2020-01-20 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-23646: -- Fix Version/s: 1.6.0 Hadoop Flags: Reviewed Resolution: Fixed Status: Re

[GitHub] [hbase] HorizonNet merged pull request #1025: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest

2020-01-20 Thread GitBox
HorizonNet merged pull request #1025: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest URL: https://github.com/apache/hbase/pull/1025 This is an automated message from the Apache Git Service. To re

[jira] [Comment Edited] (HBASE-23678) Literate builder API for version management in schema

2020-01-20 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019285#comment-17019285 ] Viraj Jasani edited comment on HBASE-23678 at 1/20/20 9:09 PM: ---

[GitHub] [hbase] virajjasani commented on issue #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
virajjasani commented on issue #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#issuecomment-576428335 Test case failures seem relevant This

[GitHub] [hbase] virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368721998 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Cac

[GitHub] [hbase] virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368722533 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Cac

[GitHub] [hbase] virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
virajjasani commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368722943 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver

[GitHub] [hbase] Apache-HBase commented on issue #792: HBASE-23254 Release replication buffer quota correctly, when batch includes bulk loaded hfiles

2020-01-20 Thread GitBox
Apache-HBase commented on issue #792: HBASE-23254 Release replication buffer quota correctly, when batch includes bulk loaded hfiles URL: https://github.com/apache/hbase/pull/792#issuecomment-576416548 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime |

[jira] [Updated] (HBASE-23710) Priority configuration for system coprocessors

2020-01-20 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated HBASE-23710: Description: Currenty HBase allows operators to set system region coprocessors via hbase-

[jira] [Created] (HBASE-23710) Priority configuration for system coprocessors

2020-01-20 Thread Geoffrey Jacoby (Jira)
Geoffrey Jacoby created HBASE-23710: --- Summary: Priority configuration for system coprocessors Key: HBASE-23710 URL: https://issues.apache.org/jira/browse/HBASE-23710 Project: HBase Issue Ty

[GitHub] [hbase] bharathv commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…

2020-01-20 Thread GitBox
bharathv commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible… URL: https://github.com/apache/hbase/pull/1047#issuecomment-576388632 > The checkstyle import order complaint doesn't look correct. Try moving "import org.apache.hbase.thirdpart

[jira] [Commented] (HBASE-21065) Try ROW_INDEX_V1 encoding on meta table (fix bloomfilters on meta while we are at it)

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019677#comment-17019677 ] Michael Stack commented on HBASE-21065: --- HBASE-23705 is about fixing our cellcompa

[jira] [Updated] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20623: -- Fix Version/s: (was: 2.3.0) (was: 3.0.0) Unscheduling until update.

[jira] [Commented] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019675#comment-17019675 ] Michael Stack commented on HBASE-20623: --- [~maoling] This looks like a nice improve

[jira] [Resolved] (HBASE-20682) MoveProcedure can be subtask of ModifyTableProcedure/ReopenTableRegionsProcedure; ensure all kosher.

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-20682. --- Resolution: Later Resolving. Doesn't apply to branch-2.2+ since Assign/Unassign Procedures

[jira] [Updated] (HBASE-22705) IllegalArgumentException exception occured during MobFileCache eviction

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-22705: -- Fix Version/s: (was: 2.3.0) > IllegalArgumentException exception occured during MobFileCac

[jira] [Commented] (HBASE-22705) IllegalArgumentException exception occured during MobFileCache eviction

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019672#comment-17019672 ] Michael Stack commented on HBASE-22705: --- Unscheduling. No update. Looks like real

[GitHub] [hbase] wchevreuil commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…

2020-01-20 Thread GitBox
wchevreuil commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible… URL: https://github.com/apache/hbase/pull/1047#issuecomment-576385542 The checkstyle import order complaint doesn't look correct.

[jira] [Commented] (HBASE-20657) Retrying RPC call for ModifyTableProcedure may get stuck

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019671#comment-17019671 ] Michael Stack commented on HBASE-20657: --- Unscheduling until updates. > Retrying R

[jira] [Updated] (HBASE-20657) Retrying RPC call for ModifyTableProcedure may get stuck

2020-01-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20657: -- Fix Version/s: (was: 2.3.0) (was: 3.0.0) > Retrying RPC call for Mo

[GitHub] [hbase] wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368672423 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regi

[GitHub] [hbase] Apache-HBase commented on issue #1065: HBASE-23627 Resolved remaining Checkstyle violations in hbase-thrift

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1065: HBASE-23627 Resolved remaining Checkstyle violations in hbase-thrift URL: https://github.com/apache/hbase/pull/1065#issuecomment-576372591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hbase] Apache-HBase commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible… URL: https://github.com/apache/hbase/pull/1047#issuecomment-576371153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] Apache-HBase commented on issue #1016: HBASE-23656 [MERGETOOL] HBASE Support Merge region by pattern

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1016: HBASE-23656 [MERGETOOL] HBASE Support Merge region by pattern URL: https://github.com/apache/hbase/pull/1016#issuecomment-576370260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368657940 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368654722 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Cach

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368654059 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Cach

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
anoopsjohn commented on a change in pull request #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#discussion_r368657370 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368657173 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#discussion_r368655764 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#discussion_r368655213 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -36

[GitHub] [hbase] saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#discussion_r368655470 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -36

[GitHub] [hbase] wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368656118 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regi

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368653450 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java ##

[GitHub] [hbase] saintstack commented on issue #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
saintstack commented on issue #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#issuecomment-576361990 Just to be explicit, this issue needs @wchevreuil approval too before can be merged (I like his comme

[GitHub] [hbase] saintstack commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368651213 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regi

[GitHub] [hbase] saintstack commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368652400 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regi

[GitHub] [hbase] Apache-HBase commented on issue #1076: HBASE-23625 Reduced number of Checkstyle violations in hbase-common

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1076: HBASE-23625 Reduced number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1076#issuecomment-576359552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hbase] Apache-HBase commented on issue #1025: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1025: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest URL: https://github.com/apache/hbase/pull/1025#issuecomment-576358269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:---

[GitHub] [hbase] HorizonNet commented on issue #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests

2020-01-20 Thread GitBox
HorizonNet commented on issue #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests URL: https://github.com/apache/hbase/pull/1075#issuecomment-576356150 @saintstack It is related to [HBASE-22732](https://issues.apache.org/jira/browse/HBASE-22732). We get it on ev

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368643872 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java #

[GitHub] [hbase] saintstack commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration

2020-01-20 Thread GitBox
saintstack commented on issue #1064: HBASE-23707 Add IntelliJ check style plugin configuration URL: https://github.com/apache/hbase/pull/1064#issuecomment-576353135 I tried the patch. Before applying, I was getting the below when I sync'd the checkstyle versions between hbase and intellij.

[GitHub] [hbase] thangTang commented on issue #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
thangTang commented on issue #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#issuecomment-576352379 > This seems to solve the main issue, which is the parent and its interim daughters been wiped off. How

[GitHub] [hbase] saintstack commented on a change in pull request #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests URL: https://github.com/apache/hbase/pull/1075#discussion_r368638361 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/TestTimeout.java ###

[GitHub] [hbase] saintstack commented on a change in pull request #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests URL: https://github.com/apache/hbase/pull/1075#discussion_r368638455 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/Waiter.java

[GitHub] [hbase] saintstack commented on issue #1043: HBASE-23055 Alter hbase:meta

2020-01-20 Thread GitBox
saintstack commented on issue #1043: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/1043#issuecomment-576347362 WIll push this in next day or so unless objection. Review appreciated. This is an automate

[GitHub] [hbase] thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368633701 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regio

[GitHub] [hbase] thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
thangTang commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368631873 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regio

[GitHub] [hbase] saintstack commented on issue #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on issue #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#issuecomment-576339559 @ramkrish86 and @anoopsjohn Thanks for the reviews. Helps. You object to the reshuffle suggesting that the encoder keep its comparator

[GitHub] [hbase] HorizonNet opened a new pull request #1076: HBASE-23625 Reduced number of Checkstyle violations in hbase-common

2020-01-20 Thread GitBox
HorizonNet opened a new pull request #1076: HBASE-23625 Reduced number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1076 Backport of #971 to branch-2. This is an automated message from th

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368618259 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java ## @@ -377,

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368615564 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileInfo.java ## @@ -380,

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368615350 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368615118 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368613369 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java ## @@ -319,7 +3

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368612232 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java ## @

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368611582 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java ## @@ -387,

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368610567 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java ##

[GitHub] [hbase] saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext

2020-01-20 Thread GitBox
saintstack commented on a change in pull request #1062: HBASE-23705 Add CellComparator to HFileContext URL: https://github.com/apache/hbase/pull/1062#discussion_r368604999 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java ## @@ -80,6 +83

[GitHub] [hbase] Apache-HBase commented on issue #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests URL: https://github.com/apache/hbase/pull/1075#issuecomment-576295723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] Apache-HBase commented on issue #1060: HBASE-23347 Allow custom authentication methods for RPCs; addendum

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1060: HBASE-23347 Allow custom authentication methods for RPCs; addendum URL: https://github.com/apache/hbase/pull/1060#issuecomment-576292902 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|-

[GitHub] [hbase] wchevreuil commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible…

2020-01-20 Thread GitBox
wchevreuil commented on issue #1047: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible… URL: https://github.com/apache/hbase/pull/1047#issuecomment-576291074 Thanks for the suggestions, @bharathv , had addressed it on last commit. @joshelser @binlijin , would you guys t

[GitHub] [hbase] Apache-HBase commented on issue #767: HBASE-22710 Wrong result in one case of scan that use raw and version…

2020-01-20 Thread GitBox
Apache-HBase commented on issue #767: HBASE-22710 Wrong result in one case of scan that use raw and version… URL: https://github.com/apache/hbase/pull/767#issuecomment-576290318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[jira] [Commented] (HBASE-23686) Revert binary incompatible change and remove reflection

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019470#comment-17019470 ] Hudson commented on HBASE-23686: Results for branch master [build #1603 on buil

[jira] [Commented] (HBASE-23156) start-hbase.sh failed with ClassNotFoundException when build with hadoop3

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019471#comment-17019471 ] Hudson commented on HBASE-23156: Results for branch master [build #1603 on buil

[GitHub] [hbase] HorizonNet opened a new pull request #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests

2020-01-20 Thread GitBox
HorizonNet opened a new pull request #1075: HBASE-23645 Fixed remaining Checkstyle violations in hbase-common tests URL: https://github.com/apache/hbase/pull/1075 Backport of #989 to branch-1. This is an automated message fro

[GitHub] [hbase] Apache-HBase commented on issue #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold URL: https://github.com/apache/hbase/pull/1074#issuecomment-576271863 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:

[GitHub] [hbase] Apache-HBase commented on issue #1016: HBASE-23656 [MERGETOOL] HBASE Support Merge region by pattern

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1016: HBASE-23656 [MERGETOOL] HBASE Support Merge region by pattern URL: https://github.com/apache/hbase/pull/1016#issuecomment-576267509 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:

[GitHub] [hbase] Apache-HBase commented on issue #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#issuecomment-576257277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-20 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019447#comment-17019447 ] HBase QA commented on HBASE-23647: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[GitHub] [hbase] Apache-HBase commented on issue #1039: HBASE-23647: Make MasterRegistry the default impl.

2020-01-20 Thread GitBox
Apache-HBase commented on issue #1039: HBASE-23647: Make MasterRegistry the default impl. URL: https://github.com/apache/hbase/pull/1039#issuecomment-576253994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|

[GitHub] [hbase] wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368496967 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regi

[GitHub] [hbase] wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign

2020-01-20 Thread GitBox
wchevreuil commented on a change in pull request #1071: HBASE-23693 Split failure may cause region hole and data loss when use zk assign URL: https://github.com/apache/hbase/pull/1071#discussion_r368520037 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/Regi

[jira] [Commented] (HBASE-23622) Reduce number of Checkstyle violations in hbase-common

2020-01-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019429#comment-17019429 ] Hudson commented on HBASE-23622: Results for branch branch-1 [build #1206 on bu

[GitHub] [hbase] petersomogyi commented on issue #1060: HBASE-23347 Allow custom authentication methods for RPCs; addendum

2020-01-20 Thread GitBox
petersomogyi commented on issue #1060: HBASE-23347 Allow custom authentication methods for RPCs; addendum URL: https://github.com/apache/hbase/pull/1060#issuecomment-576203449 The test fails to instantiate the 2 provider classes: `java.lang.NoSuchMethodException: org.apache.hadoop.hbase

  1   2   >