[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638385363 Testing with #1833 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434772239 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java ## @@ -93,12 +94,17 @@ public void setConf(f

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434769865 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java ## @@ -383,25 +385,38 @@ public static Snapshot

[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-03 Thread GitBox
saintstack commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r434763752 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638372347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 27

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r434758421 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,543 @@ +/* + * + * Licensed to the Apache Soft

[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638365179 PTAL @joshelser @stoty This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [hbase] ndimiduk opened a new pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1847: URL: https://github.com/apache/hbase/pull/1847 Looks like we have two different environments with two sets of environment variables. Yetus talks about that target branch as `BRANCH_NAME`, but GitHub + Jenkins refer to it as `CHANGE_TARGET`, so we n

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
anoopsjohn commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r434750284 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,543 @@ +/* + * + * Licensed to the Apache Softw

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125169#comment-17125169 ] Nick Dimiduk commented on HBASE-24280: -- Oh, I see. The variable {{BRANCH_NAME}} is

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434744701 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -148,15 +156,37 @@ public void tes

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434744521 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotHFileCleaner.java ## @@ -137,8 +138,15 @@ public void test

[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-03 Thread GitBox
saintstack commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r434743949 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[jira] [Reopened] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24280: -- > Hadoop2 and Hadoop3 profiles being activated simultaneously causing test > failures > -

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125164#comment-17125164 ] Nick Dimiduk commented on HBASE-24280: -- For example, https://builds.apache.org/job

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125162#comment-17125162 ] Nick Dimiduk commented on HBASE-24280: -- Hadoop3 profile is not being activated on b

[GitHub] [hbase] saintstack commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
saintstack commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638346107 bq. should a simple fact of deserialization have such a side effect on tasks... No. That is wonky. For this reason alone we should apply this patch. Will wait

[GitHub] [hbase] Apache-HBase commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1552: URL: https://github.com/apache/hbase/pull/1552#issuecomment-638345369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638345198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[jira] [Resolved] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24309. -- Resolution: Fixed Pushed addendums to branch-2 and branch-2.3. > Avoid introducing log4j and

[GitHub] [hbase] Apache-HBase commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1552: URL: https://github.com/apache/hbase/pull/1552#issuecomment-638341617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] ndimiduk merged pull request #1846: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
ndimiduk merged pull request #1846: URL: https://github.com/apache/hbase/pull/1846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] ndimiduk opened a new pull request #1846: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1846: URL: https://github.com/apache/hbase/pull/1846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-06-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125153#comment-17125153 ] Istvan Toth commented on HBASE-24252: - Don't worry about it [~elserj], there's no ne

[GitHub] [hbase] Apache-HBase commented on pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1845: URL: https://github.com/apache/hbase/pull/1845#issuecomment-638338450 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] Apache-HBase commented on pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1845: URL: https://github.com/apache/hbase/pull/1845#issuecomment-638338358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] ndimiduk merged pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
ndimiduk merged pull request #1845: URL: https://github.com/apache/hbase/pull/1845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] ndimiduk opened a new pull request #1845: HBASE-24309 ADDENDUM remove redundant dependency

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1845: URL: https://github.com/apache/hbase/pull/1845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Reopened] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24309: -- Looks like this one is cause of a new compiler warning. Reopening for addendum. {noformat} [INFO]

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-638330509 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43

[jira] [Updated] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24503: - Fix Version/s: 2.2.6 2.1.10 2.3.1 > Backport HBASE-24492 t

[jira] [Assigned] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24503: Assignee: Viraj Jasani > Backport HBASE-24492 to all 2.x branch > ---

[jira] [Created] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-06-03 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-24503: Summary: Backport HBASE-24492 to all 2.x branch Key: HBASE-24503 URL: https://issues.apache.org/jira/browse/HBASE-24503 Project: HBase Issue Type: Sub-task

[jira] [Updated] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24492: - Fix Version/s: 1.7.0 Hadoop Flags: Reviewed Resolution: Fixed Status: Reso

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638321971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36

[GitHub] [hbase] joshelser commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
joshelser commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434713054 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configu

[jira] [Created] (HBASE-24502) hbase hfile command logs exception message at WARN level.

2020-06-03 Thread Rushabh Shah (Jira)
Rushabh Shah created HBASE-24502: Summary: hbase hfile command logs exception message at WARN level. Key: HBASE-24502 URL: https://issues.apache.org/jira/browse/HBASE-24502 Project: HBase Iss

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-638317257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-638316749 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125119#comment-17125119 ] Viraj Jasani commented on HBASE-24492: -- I just looked at branch-1 and this is appli

[jira] [Assigned] (HBASE-24495) ExportSnapshot which does not honor the case that working dir/root dir are from different filesystem

2020-06-03 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-24495: Assignee: Huaxiang Sun > ExportSnapshot which does not honor the case that working dir/ro

[jira] [Assigned] (HBASE-23927) hbck2 assigns command should accept a file containing a list of region names

2020-06-03 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-23927: Assignee: Clara Xiong (was: Huaxiang Sun) > hbck2 assigns command should accept a file c

[GitHub] [hbase] ndimiduk opened a new pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1844: URL: https://github.com/apache/hbase/pull/1844 * Add a section calling out our categorical lack of support for non-LTS Java versions. * Provide clarification as to the meaning of the 'red x' in our support matrix. * Transpose the supp

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638310608 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16

[jira] [Commented] (HBASE-24488) Update docs re: ZooKeeper compatibility of 2.3.x release

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125101#comment-17125101 ] Hudson commented on HBASE-24488: Results for branch master [build #1746 on buil

[jira] [Commented] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125104#comment-17125104 ] Hudson commented on HBASE-22738: Results for branch master [build #1746 on buil

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125106#comment-17125106 ] Hudson commented on HBASE-24492: Results for branch master [build #1746 on buil

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125105#comment-17125105 ] Hudson commented on HBASE-24412: Results for branch master [build #1746 on buil

[jira] [Commented] (HBASE-24418) Consolidate Normalizer implementations

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125103#comment-17125103 ] Hudson commented on HBASE-24418: Results for branch master [build #1746 on buil

[jira] [Commented] (HBASE-24486) Remove the unused method online in admin.rb

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125102#comment-17125102 ] Hudson commented on HBASE-24486: Results for branch master [build #1746 on buil

[jira] [Updated] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24499: - Fix Version/s: (was: 2.3.0) 2.4.0 > Use a client property for SaslConnect

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125098#comment-17125098 ] Viraj Jasani commented on HBASE-24492: -- Yup, it's committed to master and branch-2

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638305314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125094#comment-17125094 ] Michael Stack commented on HBASE-24492: --- [~vjasani] put it on branch-2? > Protobu

[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125093#comment-17125093 ] Andrew Kyle Purtell commented on HBASE-24499: - Sounds good > Use a client p

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125088#comment-17125088 ] Viraj Jasani commented on HBASE-24492: -- No worries. Although I am quite certain tha

[jira] [Assigned] (HBASE-24494) Wrap long lines in `_chapters/configuration.adoc`

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-24494: Assignee: Nick Dimiduk > Wrap long lines in `_chapters/configuration.adoc` >

[jira] [Resolved] (HBASE-24494) Wrap long lines in `_chapters/configuration.adoc`

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24494. -- Resolution: Fixed > Wrap long lines in `_chapters/configuration.adoc` > --

[GitHub] [hbase] ndimiduk commented on pull request #1836: HBASE-24494 Wrap long lines in `_chapters/configuration.adoc`

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1836: URL: https://github.com/apache/hbase/pull/1836#issuecomment-638299274 Thanks for the review. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hbase] ndimiduk merged pull request #1836: HBASE-24494 Wrap long lines in `_chapters/configuration.adoc`

2020-06-03 Thread GitBox
ndimiduk merged pull request #1836: URL: https://github.com/apache/hbase/pull/1836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125076#comment-17125076 ] Nick Dimiduk commented on HBASE-24492: -- Yeah please keep exclude from 2.3, let's av

[GitHub] [hbase] Apache-HBase commented on pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1834: URL: https://github.com/apache/hbase/pull/1834#issuecomment-638291490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638290697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53

[GitHub] [hbase] Apache-HBase commented on pull request #1842: HBASE-24501 Backport to branch-1 HBASE-15785 Unnecessary lock in Byte…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1842: URL: https://github.com/apache/hbase/pull/1842#issuecomment-638286450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 44

[GitHub] [hbase] Apache-HBase commented on pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1843: URL: https://github.com/apache/hbase/pull/1843#issuecomment-638282280 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23

[GitHub] [hbase] Apache-HBase commented on pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1843: URL: https://github.com/apache/hbase/pull/1843#issuecomment-638278488 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 48

[jira] [Commented] (HBASE-24252) Implement proxyuser/doAs mechanism for hbase-http

2020-06-03 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125056#comment-17125056 ] Josh Elser commented on HBASE-24252: I just realized that I applied this commit with

[GitHub] [hbase] Apache-HBase commented on pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1843: URL: https://github.com/apache/hbase/pull/1843#issuecomment-638274230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638270685 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] sguggilam commented on pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-03 Thread GitBox
sguggilam commented on pull request #1835: URL: https://github.com/apache/hbase/pull/1835#issuecomment-638270583 @apurtell This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] sguggilam commented on pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-03 Thread GitBox
sguggilam commented on pull request #1828: URL: https://github.com/apache/hbase/pull/1828#issuecomment-638270416 @apurtell This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638267481 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125032#comment-17125032 ] Michael Stack commented on HBASE-24205: --- bq. except that a new metric along wi

[GitHub] [hbase] Apache-HBase commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1552: URL: https://github.com/apache/hbase/pull/1552#issuecomment-638265477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2020-06-03 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21406: - Resolution: Fixed Status: Resolved (was: Patch Available) Had pushed to

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2020-06-03 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21406: - Fix Version/s: 2.3.0 > "status 'replication'" should not show SINK if the cluste

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638256596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125027#comment-17125027 ] Michael Stack commented on HBASE-24492: --- Thanks [~vjasani]for the helpful clea

[GitHub] [hbase] richardantal opened a new pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-06-03 Thread GitBox
richardantal opened a new pull request #1843: URL: https://github.com/apache/hbase/pull/1843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638249306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s

[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638244596 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s

[GitHub] [hbase] Apache-HBase commented on pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1834: URL: https://github.com/apache/hbase/pull/1834#issuecomment-638243983 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s

[GitHub] [hbase] virajjasani commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
virajjasani commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638234399 @Apache9 @anoopsjohn I have done changes as per your latest suggestions. Please take a look. This is an autom

[GitHub] [hbase] virajjasani commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r434607393 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -573,6 +574,7 @@ public synchronized long expireServer

[GitHub] [hbase] Apache-HBase commented on pull request #1842: HBASE-24501 Backport to branch-1 HBASE-15785 Unnecessary lock in Byte…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1842: URL: https://github.com/apache/hbase/pull/1842#issuecomment-638232266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 34s

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-03 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124990#comment-17124990 ] ramkrishna.s.vasudevan commented on HBASE-24205: bq.Then I wonder if the

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-06-03 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434598232 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java ## @@ -0,0 +1,60 @@ +/** + * Licen

[GitHub] [hbase] Apache-HBase commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638215152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s

[jira] [Reopened] (HBASE-24184) listSnapshots returns empty when just use simple acl but not use authentication

2020-06-03 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianhang tang reopened HBASE-24184: --- Wish to fix this bug in branch-1 > listSnapshots returns empty when just use simple acl but not

[GitHub] [hbase] thangTang opened a new pull request #1842: HBASE-24501 Backport to branch-1 HBASE-15785 Unnecessary lock in Byte…

2020-06-03 Thread GitBox
thangTang opened a new pull request #1842: URL: https://github.com/apache/hbase/pull/1842 …BufferArray This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638194591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35

[jira] [Updated] (HBASE-24501) Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray

2020-06-03 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tianhang tang updated HBASE-24501: -- Summary: Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray (was: Backport

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124946#comment-17124946 ] Hudson commented on HBASE-24412: Results for branch branch-2.3 [build #120 on b

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638183534 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[jira] [Work started] (HBASE-24501) Backport to branch-1 Unnecessary lock in ByteBufferArray

2020-06-03 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24501 started by tianhang tang. - > Backport to branch-1 Unnecessary lock in ByteBufferArray >

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638170492 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s

[jira] [Created] (HBASE-24501) Backport to branch-1 Unnecessary lock in ByteBufferArray

2020-06-03 Thread tianhang tang (Jira)
tianhang tang created HBASE-24501: - Summary: Backport to branch-1 Unnecessary lock in ByteBufferArray Key: HBASE-24501 URL: https://issues.apache.org/jira/browse/HBASE-24501 Project: HBase Is

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638162320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 46

<    1   2   3   >