[GitHub] [hbase] virajjasani commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
virajjasani commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435036433 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDecommissionStopAdminApi.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the

[GitHub] [hbase] virajjasani commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
virajjasani commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435032424 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDecommissionStopAdminApi.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638656169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] bsglz commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-04 Thread GitBox
bsglz commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r435043753 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile, Canc

[jira] [Commented] (HBASE-22263) Master creates duplicate ServerCrashProcedure on initialization, leading to assignment hanging in region-dense clusters

2020-06-04 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125622#comment-17125622 ] Bo Cui commented on HBASE-22263: can I submit the add-patch? [~busbey] > Master creates

[GitHub] [hbase] bsglz commented on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp

2020-06-04 Thread GitBox
bsglz commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638668416 @clarax PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [hbase] Apache-HBase commented on pull request #1823: HBASE-24485 Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1823: URL: https://github.com/apache/hbase/pull/1823#issuecomment-638673620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28

[GitHub] [hbase] bsglz edited a comment on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp

2020-06-04 Thread GitBox
bsglz edited a comment on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638668416 @clarax PTAL Thanks. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] thangTang commented on pull request #1823: HBASE-24485 Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-04 Thread GitBox
thangTang commented on pull request #1823: URL: https://github.com/apache/hbase/pull/1823#issuecomment-638686409 solved conflicts and repushed. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hbase] Apache-HBase commented on pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1722: URL: https://github.com/apache/hbase/pull/1722#issuecomment-638703998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] infraio commented on a change in pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
infraio commented on a change in pull request #1850: URL: https://github.com/apache/hbase/pull/1850#discussion_r435117368 ## File path: hbase-protocol-shaded/src/main/protobuf/HBase.proto ## @@ -79,7 +79,6 @@ message RegionInfo { optional bool offline = 5; optional bool s

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638742670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s

[GitHub] [hbase] gkanade commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
gkanade commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435129795 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDecommissionStopAdminApi.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apac

[GitHub] [hbase] gkanade commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
gkanade commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435129638 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDecommissionStopAdminApi.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apac

[GitHub] [hbase] gkanade commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
gkanade commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435129975 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDecommissionStopAdminApi.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apac

[GitHub] [hbase] gkanade commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
gkanade commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435129882 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestDecommissionStopAdminApi.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apac

[GitHub] [hbase] Apache-HBase commented on pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1722: URL: https://github.com/apache/hbase/pull/1722#issuecomment-638745170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638746087 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s

[GitHub] [hbase] infraio merged pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-04 Thread GitBox
infraio merged pull request #1722: URL: https://github.com/apache/hbase/pull/1722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24359: --- Issue Type: New Feature (was: Improvement) > Optionally ignore edits for deleted CFs for re

[jira] [Commented] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125768#comment-17125768 ] Guanghao Zhang commented on HBASE-24359: [~Ddupg] The patch cannot apply to bran

[jira] [Updated] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24359: --- Issue Type: Improvement (was: New Feature) > Optionally ignore edits for deleted CFs for re

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125772#comment-17125772 ] Hudson commented on HBASE-21905: Results for branch branch-2 [build #2690 on bu

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125770#comment-17125770 ] Hudson commented on HBASE-24280: Results for branch branch-2 [build #2690 on bu

[jira] [Commented] (HBASE-24418) Consolidate Normalizer implementations

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125771#comment-17125771 ] Hudson commented on HBASE-24418: Results for branch branch-2 [build #2690 on bu

[jira] [Commented] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125776#comment-17125776 ] Hudson commented on HBASE-21406: Results for branch branch-2.3 [build #121 on b

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125781#comment-17125781 ] Hudson commented on HBASE-21905: Results for branch branch-2.3 [build #121 on b

[jira] [Commented] (HBASE-24418) Consolidate Normalizer implementations

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125779#comment-17125779 ] Hudson commented on HBASE-24418: Results for branch branch-2.3 [build #121 on b

[jira] [Commented] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125778#comment-17125778 ] Hudson commented on HBASE-24280: Results for branch branch-2.3 [build #121 on b

[jira] [Commented] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125777#comment-17125777 ] Hudson commented on HBASE-24309: Results for branch branch-2.3 [build #121 on b

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638756152 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s

[jira] [Created] (HBASE-24504) refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread niuyulin (Jira)
niuyulin created HBASE-24504: Summary: refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat Key: HBASE-24504 URL: https://issues.apache.org/jira/browse/HBASE-24504 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638758933 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638761139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638769598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s

[jira] [Updated] (HBASE-24447) Contribute a Test class that shows some examples for using the Async Client API

2020-06-04 Thread kangkang.guo (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangkang.guo updated HBASE-24447: - Description: 类似于  [https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125809#comment-17125809 ] Hudson commented on HBASE-21905: Results for branch branch-1 [build #1308 on bu

[jira] [Commented] (HBASE-24501) Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125810#comment-17125810 ] Hudson commented on HBASE-24501: Results for branch branch-1 [build #1308 on bu

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125808#comment-17125808 ] Hudson commented on HBASE-24492: Results for branch branch-1 [build #1308 on bu

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638772601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s

[jira] [Commented] (HBASE-15785) Unnecessary lock in ByteBufferArray

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125811#comment-17125811 ] Hudson commented on HBASE-15785: Results for branch branch-1 [build #1308 on bu

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125813#comment-17125813 ] Duo Zhang commented on HBASE-23313: --- OK, the RegionInfo proto is also used in SetRegio

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638774506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42s

[GitHub] [hbase] virajjasani merged pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-04 Thread GitBox
virajjasani merged pull request #1818: URL: https://github.com/apache/hbase/pull/1818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-06-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24456: - Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125835#comment-17125835 ] Duo Zhang commented on HBASE-23313: --- OK, I checked the code in HBCK2. https://github.

[jira] [Updated] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

2020-06-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24499: - Component/s: security > Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcod

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-638805489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42

[jira] [Created] (HBASE-24505) Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24505: - Summary: Reimplement Hbck.setRegionStateInMeta Key: HBASE-24505 URL: https://issues.apache.org/jira/browse/HBASE-24505 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638809598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638812564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638813746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s

[GitHub] [hbase] nyl3532016 opened a new pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
nyl3532016 opened a new pull request #1851: URL: https://github.com/apache/hbase/pull/1851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125899#comment-17125899 ] Viraj Jasani commented on HBASE-24380: -- Although HBASE-23037 is not relevant, since

[GitHub] [hbase] Apache9 opened a new pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache9 opened a new pull request #1852: URL: https://github.com/apache/hbase/pull/1852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-638836207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-638839307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-638840353 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[jira] [Commented] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125928#comment-17125928 ] Viraj Jasani commented on HBASE-24380: -- Tried adding some recovered edit write info

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-638865762 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[jira] [Resolved] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-04 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin resolved HBASE-24412. -- Resolution: Fixed > Canary support check only one column family per RegionTask > -

[jira] [Updated] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-04 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24412: - Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 > Canary support check on

[GitHub] [hbase] nyl3532016 commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
nyl3532016 commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-638877579 @HorizonNet @infraio mind help review this PR? This is an automated message from the Apache Git Service. To res

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-638879451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125956#comment-17125956 ] Wellington Chevreuil commented on HBASE-23313: -- {quote}For me, I do not thi

[GitHub] [hbase] joshelser commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
joshelser commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r435309158 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system configu

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125981#comment-17125981 ] Duo Zhang commented on HBASE-23313: --- Mind take a look at the sub task? Where I reimple

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-638909166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-638910982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125996#comment-17125996 ] Wellington Chevreuil commented on HBASE-23313: -- {quote}Mind take a look at

[GitHub] [hbase] wchevreuil commented on a change in pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
wchevreuil commented on a change in pull request #1852: URL: https://github.com/apache/hbase/pull/1852#discussion_r435336931 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -2500,31 +2502,39 @@ public GetTableStateResponse

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126010#comment-17126010 ] Wellington Chevreuil commented on HBASE-23313: -- {quote}And this has not bee

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-638944169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638958405 Hi @ndimiduk, can you review the latest patch to see if there is anything missing? Thanks! This is an automat

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-638958544 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [hbase] HorizonNet commented on a change in pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
HorizonNet commented on a change in pull request #1851: URL: https://github.com/apache/hbase/pull/1851#discussion_r435390748 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java ## @@ -200,7 +199,6 @@ public void testI

[GitHub] [hbase] HorizonNet commented on a change in pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-04 Thread GitBox
HorizonNet commented on a change in pull request #1830: URL: https://github.com/apache/hbase/pull/1830#discussion_r435411310 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java ## @@ -766,15 +766,14 @@ private int getSca

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-638991364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-638994161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126091#comment-17126091 ] Hudson commented on HBASE-24500: Results for branch branch-2.3 [build #122 on b

[jira] [Comment Edited] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125928#comment-17125928 ] Viraj Jasani edited comment on HBASE-24380 at 6/4/20, 5:35 PM: ---

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126112#comment-17126112 ] Hudson commented on HBASE-21905: Results for branch master [build #1747 on buil

[jira] [Commented] (HBASE-24494) Wrap long lines in `_chapters/configuration.adoc`

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126111#comment-17126111 ] Hudson commented on HBASE-24494: Results for branch master [build #1747 on buil

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126113#comment-17126113 ] Hudson commented on HBASE-24500: Results for branch master [build #1747 on buil

[GitHub] [hbase] timoha commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-04 Thread GitBox
timoha commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-639009293 I'll let others also comment before submitting a patch. I personally prefer for de-serialize to not have side effects all the way to what shows in the UI and also like removing cod

[GitHub] [hbase] virajjasani commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
virajjasani commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435445974 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin4.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] [hbase] virajjasani commented on a change in pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
virajjasani commented on a change in pull request #1835: URL: https://github.com/apache/hbase/pull/1835#discussion_r435449031 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -78,13 +75,18 @@ import org.apache.hadoop.hbase.regio

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-639019472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37

[GitHub] [hbase] ndimiduk commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
ndimiduk commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639042818 Rebased, and attempted to address all comments. Please take another look. This is an automated message from the A

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639051450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639052541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 16

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639060302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-639090140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36

[jira] [Commented] (HBASE-24227) [JDK11] shell fails to launch

2020-06-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126172#comment-17126172 ] Nick Dimiduk commented on HBASE-24227: -- Thanks for trying it out [~adityakishore].

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-639118651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17

[GitHub] [hbase] ndimiduk commented on a change in pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-04 Thread GitBox
ndimiduk commented on a change in pull request #1749: URL: https://github.com/apache/hbase/pull/1749#discussion_r435562854 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java ## @@ -183,18 +176,21 @@ public void run() { if (LOG.isInfoEna

[GitHub] [hbase] bharathv opened a new pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
bharathv opened a new pull request #1853: URL: https://github.com/apache/hbase/pull/1853 Implements `ClusterManager` that relies on the new `ShellExecEndpointCoprocessor` for remote shell command execution. Signed-off-by: Bharath Vissapragada

[jira] [Commented] (HBASE-24260) Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126204#comment-17126204 ] Bharath Vissapragada commented on HBASE-24260: -- I was playing around with c

[GitHub] [hbase] bharathv commented on pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
bharathv commented on pull request #1853: URL: https://github.com/apache/hbase/pull/1853#issuecomment-639141901 > This is useful to your teams as well? Yes. Nice idea :-). This is an automated message from the

[GitHub] [hbase] ndimiduk commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
ndimiduk commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435577323 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java ## @@ -85,32 +106,34 @@ public void cleanupFil

  1   2   >