[GitHub] [hbase] busbey commented on a change in pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-04 Thread GitBox
busbey commented on a change in pull request #1814: URL: https://github.com/apache/hbase/pull/1814#discussion_r435690908 ## File path: hbase-http/src/main/java/org/apache/hadoop/hbase/http/prom/PrometheusMetricsSink.java ## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-639269139 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] gkanade commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
gkanade commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435697745 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin4.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software

[GitHub] [hbase] rvaleti opened a new pull request #1854: HBASE-24499 Use a client property for SaslConnection MAX_ATTEMPTS

2020-06-04 Thread GitBox
rvaleti opened a new pull request #1854: URL: https://github.com/apache/hbase/pull/1854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] bharathv merged pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
bharathv merged pull request #1853: URL: https://github.com/apache/hbase/pull/1853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-639260517 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-639260680 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1853: URL: https://github.com/apache/hbase/pull/1853#issuecomment-639259140 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-19455) Try to re-enable a disabled BucketCache after a set timeout

2020-06-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126386#comment-17126386 ] Anoop Sam John commented on HBASE-19455: Thanks [~zyork].. My colleague will work on this. >

[jira] [Assigned] (HBASE-19455) Try to re-enable a disabled BucketCache after a set timeout

2020-06-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John reassigned HBASE-19455: -- Assignee: Shawna Wei (was: Zach York) > Try to re-enable a disabled BucketCache

[GitHub] [hbase] Apache9 commented on a change in pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache9 commented on a change in pull request #1850: URL: https://github.com/apache/hbase/pull/1850#discussion_r435680524 ## File path: hbase-protocol-shaded/src/main/protobuf/HBase.proto ## @@ -79,7 +79,6 @@ message RegionInfo { optional bool offline = 5; optional bool

[jira] [Updated] (HBASE-19455) Try to re-enable a disabled BucketCache after a set timeout

2020-06-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19455: --- Issue Type: Improvement (was: Bug) > Try to re-enable a disabled BucketCache after a set

[jira] [Updated] (HBASE-19455) Try to re-enable a disabled BucketCache after a set timeout

2020-06-04 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-19455: --- Description: This JIRA is a follow-up to HBASE-19435. Currently, if the BucketCache is

[jira] [Comment Edited] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2020-06-04 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126359#comment-17126359 ] Sean Busbey edited comment on HBASE-20904 at 6/5/20, 4:01 AM: -- [~mmpataki]

[jira] [Commented] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2020-06-04 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126359#comment-17126359 ] Sean Busbey commented on HBASE-20904: - @mmpataki I've added you to the contributor group in jira so

[GitHub] [hbase] busbey commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-04 Thread GitBox
busbey commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-639243878 I should also note here that each change gets feedback currently from 3 different precommit checks (depending on the target branch) and different tests happen in them so it is

[GitHub] [hbase] busbey commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

2020-06-04 Thread GitBox
busbey commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-639242656 please target PRs to the master branch unless the change is only applicable to older branches. This is an

[jira] [Commented] (HBASE-24485) Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126350#comment-17126350 ] Guanghao Zhang commented on HBASE-24485: Pushed to branch-1. Thanks [~tangtianhang] for

[jira] [Resolved] (HBASE-24485) Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-04 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24485. Fix Version/s: 1.7.0 Resolution: Fixed > Backport to branch-1 HBASE-17738

[GitHub] [hbase] infraio merged pull request #1823: HBASE-24485 Backport to branch-1 HBASE-17738 BucketCache startup is slow

2020-06-04 Thread GitBox
infraio merged pull request #1823: URL: https://github.com/apache/hbase/pull/1823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-639239835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-639239083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-639237360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24359) Optionally ignore edits for deleted CFs for replication.

2020-06-04 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126327#comment-17126327 ] Sun Xin commented on HBASE-24359: - [~zghao] OK, I'll do it and thanks for reviewing. > Optionally

[GitHub] [hbase] nyl3532016 commented on a change in pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
nyl3532016 commented on a change in pull request #1851: URL: https://github.com/apache/hbase/pull/1851#discussion_r435664001 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java ## @@ -200,7 +199,6 @@ public void

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126315#comment-17126315 ] Hudson commented on HBASE-24500: Results for branch branch-2 [build #2691 on

[jira] [Commented] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126316#comment-17126316 ] Hudson commented on HBASE-24456: Results for branch branch-2 [build #2691 on

[GitHub] [hbase] Apache-HBase commented on pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1828: URL: https://github.com/apache/hbase/pull/1828#issuecomment-639214219 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-639210057 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] sguggilam commented on a change in pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
sguggilam commented on a change in pull request #1835: URL: https://github.com/apache/hbase/pull/1835#discussion_r435645347 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -78,13 +75,18 @@ import

[GitHub] [hbase] Apache-HBase commented on pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1835: URL: https://github.com/apache/hbase/pull/1835#issuecomment-639206667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r435642448 ## File path: dev-support/create-release/README.txt ## @@ -17,13 +17,23 @@ anomalies are explained up in JIRA. See

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r435642013 ## File path: dev-support/create-release/README.txt ## @@ -17,13 +17,23 @@ anomalies are explained up in JIRA. See

[GitHub] [hbase] busbey commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
busbey commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r435641768 ## File path: dev-support/create-release/README.txt ## @@ -17,13 +17,23 @@ anomalies are explained up in JIRA. See

[GitHub] [hbase] apurtell commented on a change in pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
apurtell commented on a change in pull request #1620: URL: https://github.com/apache/hbase/pull/1620#discussion_r435637248 ## File path: dev-support/create-release/README.txt ## @@ -17,13 +17,23 @@ anomalies are explained up in JIRA. See

[jira] [Updated] (HBASE-24458) release scripts using docker should specify needed disk consistency

2020-06-04 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24458: Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Updated] (HBASE-24458) release scripts using docker should specify needed disk consistency

2020-06-04 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24458: Summary: release scripts using docker should specify needed disk consistency (was: release

[GitHub] [hbase] Apache-HBase commented on pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1828: URL: https://github.com/apache/hbase/pull/1828#issuecomment-639196962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-639195819 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-639195437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-639195328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-06-04 Thread GitBox
busbey commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-639194124 force push just rebased to current master and took care of a conflict. This is an automated message from the

[GitHub] [hbase] Apache9 merged pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache9 merged pull request #1852: URL: https://github.com/apache/hbase/pull/1852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HBASE-24506) async client deadlock

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24506: - Assignee: Duo Zhang > async client deadlock > - > > Key:

[jira] [Work started] (HBASE-24506) async client deadlock

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24506 started by Duo Zhang. - > async client deadlock > - > > Key: HBASE-24506

[jira] [Updated] (HBASE-24506) async client deadlock

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24506: -- Priority: Critical (was: Major) > async client deadlock > - > >

[jira] [Commented] (HBASE-24506) async client deadlock

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126296#comment-17126296 ] Duo Zhang commented on HBASE-24506: --- The problem here is that, in failInit, we will complete all the

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435632309 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCacheWithDifferentWorkingDir.java ## @@ -0,0 +1,64 @@

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435630118 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java ## @@ -85,32 +106,34 @@ public void

[jira] [Created] (HBASE-24506) async client deadlock

2020-06-04 Thread Whitney Jackson (Jira)
Whitney Jackson created HBASE-24506: --- Summary: async client deadlock Key: HBASE-24506 URL: https://issues.apache.org/jira/browse/HBASE-24506 Project: HBase Issue Type: Bug

[GitHub] [hbase] busbey commented on pull request #1813: HBASE-24458 release scripts using docker should specify needed disk consistency

2020-06-04 Thread GitBox
busbey commented on pull request #1813: URL: https://github.com/apache/hbase/pull/1813#issuecomment-639190059 thanks for the reviews y'all. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] asfgit closed pull request #1813: HBASE-24458 release scripts using docker should specify needed disk consistency

2020-06-04 Thread GitBox
asfgit closed pull request #1813: URL: https://github.com/apache/hbase/pull/1813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] busbey commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
busbey commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r435622827 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-04 Thread GitBox
saintstack commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r435617884 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[GitHub] [hbase] Apache-HBase commented on pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1853: URL: https://github.com/apache/hbase/pull/1853#issuecomment-639175740 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435608020 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCacheWithDifferentWorkingDir.java ## @@ -0,0 +1,64 @@

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435607490 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCacheWithDifferentWorkingDir.java ## @@ -0,0 +1,64 @@

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435606974 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java ## @@ -85,32 +106,34 @@ public void

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126255#comment-17126255 ] Hudson commented on HBASE-21905: Results for branch branch-2.2 [build #885 on

[GitHub] [hbase] Apache-HBase commented on pull request #1828: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1828: URL: https://github.com/apache/hbase/pull/1828#issuecomment-639159863 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1853: URL: https://github.com/apache/hbase/pull/1853#issuecomment-639153301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
ndimiduk commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r435577323 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java ## @@ -85,32 +106,34 @@ public void

[GitHub] [hbase] bharathv commented on pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
bharathv commented on pull request #1853: URL: https://github.com/apache/hbase/pull/1853#issuecomment-639141901 > This is useful to your teams as well? Yes. Nice idea :-). This is an automated message from the

[jira] [Commented] (HBASE-24260) Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126204#comment-17126204 ] Bharath Vissapragada commented on HBASE-24260: -- I was playing around with chaos on branch-1

[GitHub] [hbase] bharathv opened a new pull request #1853: HBASE-24260 Add a ClusterManager that issues commands via coprocessor

2020-06-04 Thread GitBox
bharathv opened a new pull request #1853: URL: https://github.com/apache/hbase/pull/1853 Implements `ClusterManager` that relies on the new `ShellExecEndpointCoprocessor` for remote shell command execution. Signed-off-by: Bharath Vissapragada

[GitHub] [hbase] ndimiduk commented on a change in pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-04 Thread GitBox
ndimiduk commented on a change in pull request #1749: URL: https://github.com/apache/hbase/pull/1749#discussion_r435562854 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java ## @@ -183,18 +176,21 @@ public void run() { if

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-639118651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24227) [JDK11] shell fails to launch

2020-06-04 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126172#comment-17126172 ] Nick Dimiduk commented on HBASE-24227: -- Thanks for trying it out [~adityakishore]. We don't support

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-639090140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639060302 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639052541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639051450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
ndimiduk commented on pull request #1844: URL: https://github.com/apache/hbase/pull/1844#issuecomment-639042818 Rebased, and attempted to address all comments. Please take another look. This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-639019472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

2020-06-04 Thread GitBox
virajjasani commented on a change in pull request #1835: URL: https://github.com/apache/hbase/pull/1835#discussion_r435449031 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -78,13 +75,18 @@ import

[GitHub] [hbase] virajjasani commented on a change in pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

2020-06-04 Thread GitBox
virajjasani commented on a change in pull request #1841: URL: https://github.com/apache/hbase/pull/1841#discussion_r435445974 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin4.java ## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software

[GitHub] [hbase] timoha commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-04 Thread GitBox
timoha commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-639009293 I'll let others also comment before submitting a patch. I personally prefer for de-serialize to not have side effects all the way to what shows in the UI and also like removing

[jira] [Commented] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126112#comment-17126112 ] Hudson commented on HBASE-21905: Results for branch master [build #1747 on

[jira] [Commented] (HBASE-24494) Wrap long lines in `_chapters/configuration.adoc`

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126111#comment-17126111 ] Hudson commented on HBASE-24494: Results for branch master [build #1747 on

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126113#comment-17126113 ] Hudson commented on HBASE-24500: Results for branch master [build #1747 on

[jira] [Comment Edited] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125928#comment-17125928 ] Viraj Jasani edited comment on HBASE-24380 at 6/4/20, 5:35 PM: --- Tried

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126091#comment-17126091 ] Hudson commented on HBASE-24500: Results for branch branch-2.3 [build #122 on

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-638994161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-638991364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] HorizonNet commented on a change in pull request #1830: HBASE-24491 Remove HRegionInfo

2020-06-04 Thread GitBox
HorizonNet commented on a change in pull request #1830: URL: https://github.com/apache/hbase/pull/1830#discussion_r435411310 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java ## @@ -766,15 +766,14 @@ private int

[GitHub] [hbase] HorizonNet commented on a change in pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
HorizonNet commented on a change in pull request #1851: URL: https://github.com/apache/hbase/pull/1851#discussion_r435390748 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java ## @@ -200,7 +199,6 @@ public void

[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-04 Thread GitBox
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638958405 Hi @ndimiduk, can you review the latest patch to see if there is anything missing? Thanks! This is an

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-638958544 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1852: URL: https://github.com/apache/hbase/pull/1852#issuecomment-638944169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126010#comment-17126010 ] Wellington Chevreuil commented on HBASE-23313: -- {quote}And this has not been integrated

[GitHub] [hbase] wchevreuil commented on a change in pull request #1852: HBASE-24505 Reimplement Hbck.setRegionStateInMeta

2020-06-04 Thread GitBox
wchevreuil commented on a change in pull request #1852: URL: https://github.com/apache/hbase/pull/1852#discussion_r435336931 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -2500,31 +2502,39 @@ public GetTableStateResponse

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125996#comment-17125996 ] Wellington Chevreuil commented on HBASE-23313: -- {quote}Mind take a look at the sub task?

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-638910982 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1850: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1850: URL: https://github.com/apache/hbase/pull/1850#issuecomment-638909166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125981#comment-17125981 ] Duo Zhang commented on HBASE-23313: --- Mind take a look at the sub task? Where I reimplement the

[GitHub] [hbase] joshelser commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-04 Thread GitBox
joshelser commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r435309158 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-04 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125956#comment-17125956 ] Wellington Chevreuil commented on HBASE-23313: -- {quote}For me, I do not think it is a good

[GitHub] [hbase] Apache-HBase commented on pull request #1648: HBASE-8458 Support for batch version of checkAndMutate()

2020-06-04 Thread GitBox
Apache-HBase commented on pull request #1648: URL: https://github.com/apache/hbase/pull/1648#issuecomment-638879451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] nyl3532016 commented on pull request #1851: HBASE-24504 refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat

2020-06-04 Thread GitBox
nyl3532016 commented on pull request #1851: URL: https://github.com/apache/hbase/pull/1851#issuecomment-638877579 @HorizonNet @infraio mind help review this PR? This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-04 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24412: - Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 > Canary support check

  1   2   >