[GitHub] [hbase] ndimiduk opened a new pull request #1974: Backport "HBASE-22504 Addendum: restore findCommonPrefix" to branch-2.3

2020-06-25 Thread GitBox
ndimiduk opened a new pull request #1974: URL: https://github.com/apache/hbase/pull/1974 Address incompatibility issue raised in 2.3.0RC0 vote thread. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145715#comment-17145715 ] Michael Stack commented on HBASE-21946: --- [~openinx] Any more feedback on this feature now you have

[jira] [Commented] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145713#comment-17145713 ] Michael Stack commented on HBASE-21946: --- HDFS-3246 was backported to branch-2.9: 4f09a6bcfd6

[GitHub] [hbase] ndimiduk opened a new pull request #1973: HBASE-22504 Addendum: restore findCommonPrefix

2020-06-25 Thread GitBox
ndimiduk opened a new pull request #1973: URL: https://github.com/apache/hbase/pull/1973 Address incompatibility issue raised in 2.3.0RC0 vote thread. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] ndimiduk merged pull request #1973: HBASE-22504 Addendum: restore findCommonPrefix

2020-06-25 Thread GitBox
ndimiduk merged pull request #1973: URL: https://github.com/apache/hbase/pull/1973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445746679 ## File path: hbase-shell/src/main/ruby/hbase_constants.rb ## @@ -109,8 +109,8 @@ def self.promote_constants(constants) end end -

[jira] [Updated] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-20819: -- Release Note: Removes HBase::Admin.hcd and HBase::Admin.update_htd_from_arg from hbase-shell.

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-649738353 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-649737703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145696#comment-17145696 ] Elliot Miller edited comment on HBASE-20819 at 6/25/20, 6:08 PM: - h1.

[GitHub] [hbase] virajjasani commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
virajjasani commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445742794 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -79,8 +86,22 @@ // listeners to be notified

[jira] [Comment Edited] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145696#comment-17145696 ] Elliot Miller edited comment on HBASE-20819 at 6/25/20, 6:04 PM: - h1.

[jira] [Updated] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-21879: -- Release Note: Before this issue, we've made the read path 100% offheap when block is in the

[jira] [Commented] (HBASE-24603) Zookeeper sync() call is async

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145703#comment-17145703 ] Andrew Kyle Purtell commented on HBASE-24603: - I came here to +1 (also approved the PR) but

[GitHub] [hbase] apurtell commented on pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
apurtell commented on pull request #1945: URL: https://github.com/apache/hbase/pull/1945#issuecomment-649731033 Approved, assuming a clean precommit prior to merge. This is an automated message from the Apache Git Service.

[GitHub] [hbase] apurtell commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
apurtell commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445736557 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -530,10 +539,26 @@ public void process(WatchedEvent

[GitHub] [hbase] apurtell commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
apurtell commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445736122 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -530,10 +539,26 @@ public void process(WatchedEvent

[GitHub] [hbase] apurtell commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
apurtell commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445735442 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -79,8 +86,22 @@ // listeners to be notified

[GitHub] [hbase] apurtell commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
apurtell commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445734505 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -79,8 +86,22 @@ // listeners to be notified

[jira] [Comment Edited] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145696#comment-17145696 ] Elliot Miller edited comment on HBASE-20819 at 6/25/20, 5:50 PM: - h1.

[jira] [Commented] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145696#comment-17145696 ] Elliot Miller commented on HBASE-20819: --- h1. Changed Constants in this Patch h2. Process To get

[jira] [Updated] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-20819: -- Attachment: HBaseConstants-diff.txt

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649727568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] bharathv commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
bharathv commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445723003 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -479,29 +502,15 @@ public ZNodePaths getZNodePaths() {

[GitHub] [hbase] Apache-HBase commented on pull request #1971: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1971: URL: https://github.com/apache/hbase/pull/1971#issuecomment-649721641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445722179 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -1359,26 +1366,26 @@ def list_locks @admin.getLocks end -# Parse arguments

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445721365 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -971,101 +976,103 @@ def enabled?(table_name) end

[jira] [Updated] (HBASE-24600) Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24600: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Updated] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24205: - Fix Version/s: (was: 2.4.0) > Create metric to know the number of reads that happens from

[jira] [Updated] (HBASE-24605) Break long region names in the web UI

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24605: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Updated] (HBASE-24102) RegionMover should exclude draining/decommissioning nodes from target RSs

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24102: - Fix Version/s: (was: 2.4.0) > RegionMover should exclude draining/decommissioning nodes

[jira] [Updated] (HBASE-24594) testReplicationStatusSink last applied op ts comparison failure

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24594: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Updated] (HBASE-24579) Failed SASL authentication does not result in an exception on client side

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24579: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Updated] (HBASE-24380) Improve WAL splitting log lines to enable sessionization

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24380: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Commented] (HBASE-24516) Parameter copyFiles should be passed in SecureBulkLoadClient

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145129#comment-17145129 ] Nick Dimiduk commented on HBASE-24516: -- Just checking [~Qilin Cao], [~zghao] – is this needed on

[jira] [Updated] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-20819: -- Release Note: Remove HBase::Admin.hcd and HBase::Admin.update_htd_from_arg from hbase-shell

[jira] [Updated] (HBASE-24516) Parameter copyFiles should be passed in SecureBulkLoadClient

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24516: - Fix Version/s: (was: 2.3.1) 2.3.0 > Parameter copyFiles should be passed

[jira] [Updated] (HBASE-24577) Doc WALSplitter classes

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24577: - Fix Version/s: (was: 2.3.1) 2.3.0 > Doc WALSplitter classes >

[jira] [Updated] (HBASE-24550) Passing '-h' or '--help' to bin/hbase doesn't do as expected

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24550: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[jira] [Updated] (HBASE-21405) [DOC] Add Details about Output of "status 'replication'"

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-21405: - Fix Version/s: (was: 2.4.0) > [DOC] Add Details about Output of "status 'replication'" >

[GitHub] [hbase] virajjasani commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
virajjasani commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445715522 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -79,8 +86,22 @@ // listeners to be notified

[GitHub] [hbase] Apache-HBase commented on pull request #1972: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1972: URL: https://github.com/apache/hbase/pull/1972#issuecomment-649712724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24478) The regionInfo parameter for MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions should be plural

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24478: - Fix Version/s: (was: 2.4.0) (was: 2.3.1) 2.3.0 >

[GitHub] [hbase] Apache-HBase commented on pull request #1971: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1971: URL: https://github.com/apache/hbase/pull/1971#issuecomment-649712191 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
virajjasani commented on a change in pull request #1945: URL: https://github.com/apache/hbase/pull/1945#discussion_r445695334 ## File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java ## @@ -479,29 +502,15 @@ public ZNodePaths

[GitHub] [hbase] Apache-HBase commented on pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1945: URL: https://github.com/apache/hbase/pull/1945#issuecomment-649707495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-15179) Cell/DBB end-to-end on the write-path

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145113#comment-17145113 ] Michael Stack commented on HBASE-15179: --- No release notes for big new feature. > Cell/DBB

[jira] [Updated] (HBASE-24631) Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24631: - Release Note: Update our package version numbers throughout the Dockerfiles to be pinned to

[GitHub] [hbase] ndimiduk commented on pull request #1965: HBASE-24631 Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread GitBox
ndimiduk commented on pull request #1965: URL: https://github.com/apache/hbase/pull/1965#issuecomment-649702133 Thanks @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-649691025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] huaxiangsun opened a new pull request #1972: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
huaxiangsun opened a new pull request #1972: URL: https://github.com/apache/hbase/pull/1972 … exists at file system in TransitRegionStateProcedure (#1924) Signed-off-by: stack This is an automated message from the

[GitHub] [hbase] huaxiangsun opened a new pull request #1971: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
huaxiangsun opened a new pull request #1971: URL: https://github.com/apache/hbase/pull/1971 … exists at file system in TransitRegionStateProcedure (#1924) Signed-off-by: stack This is an automated message from the

[jira] [Commented] (HBASE-24634) Promote TestLogRollingNoCluster to LargeTests

2020-06-25 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145073#comment-17145073 ] niuyulin commented on HBASE-24634: -- !image-2020-06-26-00-26-51-151.png|width=794,height=185! > Promote

[jira] [Updated] (HBASE-24634) Promote TestLogRollingNoCluster to LargeTests

2020-06-25 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-24634: - Attachment: image-2020-06-26-00-26-51-151.png > Promote TestLogRollingNoCluster to LargeTests >

[jira] [Commented] (HBASE-24634) Promote TestLogRollingNoCluster to LargeTests

2020-06-25 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145069#comment-17145069 ] niuyulin commented on HBASE-24634: -- only speed 30s on my local machine and almost the same time at

[GitHub] [hbase] mmpataki commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-25 Thread GitBox
mmpataki commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-649668060 > a glance shows the unit test failures are all in the backup/restore system? is that right? Yes, the test failures don't seem to be related. I will try to check them

[GitHub] [hbase] Apache-HBase commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649667568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] bsglz removed a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz removed a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649647335 @saintstack When doing the change, I found some places that also set the forceFlushAllStores true, such as HRegion.bulkLoadHFiles, HRegion.flush and many unit tests.

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649647335 @saintstack When doing the change, I found some places that also set the forceFlushAllStores true, such as HRegion.bulkLoadHFiles, HRegion.flush and many unit tests.

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649647335 @saintstack When do the change, I found some places that also set the forceFlushAllStores true, such as HRegion.bulkLoadHFiles, HRegion.flush and some unit tests. If

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649647335 @saintstack When do the change, I found some places that also set the forceFlushAllStores true, such as HRegion.bulkLoadHFiles and HRegion.flush. If we remove it, we should

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-649639489 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-7196) 'hbase shell status' throws exception when HBase is not running

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-7196: - Priority: Minor (was: Major) > 'hbase shell status' throws exception when HBase is not running

[jira] [Work started] (HBASE-24635) Split TestMetaWithReplicas

2020-06-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24635 started by Duo Zhang. - > Split TestMetaWithReplicas > -- > > Key:

[jira] [Commented] (HBASE-7196) 'hbase shell status' throws exception when HBase is not running

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145045#comment-17145045 ] Elliot Miller commented on HBASE-7196: -- It looks like isMasterRunning was removed from HBaseAdmin by

[jira] [Created] (HBASE-24635) Split TestMetaWithReplicas

2020-06-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24635: - Summary: Split TestMetaWithReplicas Key: HBASE-24635 URL: https://issues.apache.org/jira/browse/HBASE-24635 Project: HBase Issue Type: Task Components:

[GitHub] [hbase] Apache9 commented on pull request #1903: HBASE-24562: Stabilize master startup with meta replicas enabled

2020-06-25 Thread GitBox
Apache9 commented on pull request #1903: URL: https://github.com/apache/hbase/pull/1903#issuecomment-649627876 Next time please fix the checkstyle issues before merging? We do not count checkstyle as -1 only because sometimes it is a bit hard to fix all the problems and also sometimes the

[jira] [Assigned] (HBASE-24634) Promote TestLogRollingNoCluster to LargeTests

2020-06-25 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin reassigned HBASE-24634: Assignee: niuyulin > Promote TestLogRollingNoCluster to LargeTests >

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649607773 > bq. It also set to true in RSRpcServices.flushRegion, would be called by user. > > ok. The user is asking to flush all regions. If user sets it, could convert it to a list

[jira] [Commented] (HBASE-24630) Purge dev javadoc from client bin tarball

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144983#comment-17144983 ] Hudson commented on HBASE-24630: Results for branch master [build #1767 on

[jira] [Commented] (HBASE-24552) Replica region needs to check if primary region directory exists at file system in TransitRegionStateProcedure

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144981#comment-17144981 ] Hudson commented on HBASE-24552: Results for branch master [build #1767 on

[jira] [Commented] (HBASE-24600) Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144984#comment-17144984 ] Hudson commented on HBASE-24600: Results for branch master [build #1767 on

[jira] [Commented] (HBASE-24562) Stabilize master startup with meta replicas enabled

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144982#comment-17144982 ] Hudson commented on HBASE-24562: Results for branch master [build #1767 on

[jira] [Commented] (HBASE-23339) Release scripts should not need to write out a copy of gpg key material

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144985#comment-17144985 ] Hudson commented on HBASE-23339: Results for branch master [build #1767 on

[jira] [Commented] (HBASE-24609) Move MetaTableAccessor out of hbase-client

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144980#comment-17144980 ] Hudson commented on HBASE-24609: Results for branch master [build #1767 on

[jira] [Commented] (HBASE-24431) RSGroupInfo add configuration map to store something extra

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144979#comment-17144979 ] Hudson commented on HBASE-24431: Results for branch master [build #1767 on

[GitHub] [hbase] saintstack commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
saintstack commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649599107 bq. It also set to true in RSRpcServices.flushRegion, would be called by user. ok. The user is asking to flush all regions. If user sets it, could convert it to a list

[jira] [Resolved] (HBASE-24631) Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24631. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.3+. Thanks [~ndimiduk] and

[jira] [Updated] (HBASE-24631) Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24631: -- Fix Version/s: 2.3.0 3.0.0-alpha-1 > Loosen Dockerfile pinned package versions of

[GitHub] [hbase] Apache-HBase commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649571932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649567892 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Commented] (HBASE-24630) Purge dev javadoc from client bin tarball

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144940#comment-17144940 ] Hudson commented on HBASE-24630: Results for branch branch-2.3 [build #155 on

[jira] [Commented] (HBASE-24600) Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144942#comment-17144942 ] Hudson commented on HBASE-24600: Results for branch branch-2.3 [build #155 on

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-649545128 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-24631) Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24631: - Assignee: Nick Dimiduk > Loosen Dockerfile pinned package versions of the "debian-revision" >

[GitHub] [hbase] Apache9 commented on pull request #1965: HBASE-24631 Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread GitBox
Apache9 commented on pull request #1965: URL: https://github.com/apache/hbase/pull/1965#issuecomment-649540443 Let's try it on master branch. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache9 merged pull request #1965: HBASE-24631 Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread GitBox
Apache9 merged pull request #1965: URL: https://github.com/apache/hbase/pull/1965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-24634) Promote TestLogRollingNoCluster to LargeTests

2020-06-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24634: - Summary: Promote TestLogRollingNoCluster to LargeTests Key: HBASE-24634 URL: https://issues.apache.org/jira/browse/HBASE-24634 Project: HBase Issue Type: Task

[jira] [Updated] (HBASE-24634) Promote TestLogRollingNoCluster to LargeTests

2020-06-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24634: -- Labels: beginner trivial (was: ) > Promote TestLogRollingNoCluster to LargeTests >

[jira] [Assigned] (HBASE-24217) Add hadoop 3.2.x support

2020-06-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24217: - Assignee: Duo Zhang > Add hadoop 3.2.x support > > >

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-649518879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #1970: HBASE-24625

2020-06-25 Thread GitBox
Apache9 commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649514331 > > That is to say, AsyncFSWAL.getLogFileSizeIfBeingWritten could not reflect the file length which successfully synced to underlying HDFS, which is not as expected. > >

[GitHub] [hbase] Apache9 commented on a change in pull request #1970: HBASE-24625

2020-06-25 Thread GitBox
Apache9 commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r445520908 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -46,6 +46,10 @@ protected

[GitHub] [hbase] Reidddddd commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-25 Thread GitBox
Reidd commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r445481301 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/MergeNormalizationPlan.java ## @@ -78,4 +82,30 @@ public void

[jira] [Commented] (HBASE-21204) NPE when scan raw DELETE_FAMILY_VERSION and codec is not set

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144832#comment-17144832 ] Hudson commented on HBASE-21204: Results for branch branch-1 [build #1321 on

[jira] [Commented] (HBASE-24618) Backport HBASE-21204 (NPE when scan raw DELETE_FAMILY_VERSION and codec is not set) to branch-1

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144831#comment-17144831 ] Hudson commented on HBASE-24618: Results for branch branch-1 [build #1321 on

[GitHub] [hbase] wchevreuil commented on pull request #1970: HBASE-24625

2020-06-25 Thread GitBox
wchevreuil commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649391009 retest build This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649382004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649374643 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-23339) Release scripts should not need to write out a copy of gpg key material

2020-06-25 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-23339. - Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed > Release scripts should not need to

<    1   2   3   >