[GitHub] [hbase] Apache-HBase commented on pull request #1987: HBASE-24646 Set the log level for ScheduledChore to INFO in HBTU

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1987: URL: https://github.com/apache/hbase/pull/1987#issuecomment-650493467 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-650492503 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…

2020-06-26 Thread GitBox
bsglz commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-650492489 @wchevreuil Thought it again, if this new splitPolicy is useable in branch-2.2 and branch-2.3, but disappear in branch-2.4 without deprecated cycle, is it break the

[GitHub] [hbase] Apache9 opened a new pull request #1987: HBASE-24646 Set the log level for ScheduledChore to INFO in HBTU

2020-06-26 Thread GitBox
Apache9 opened a new pull request #1987: URL: https://github.com/apache/hbase/pull/1987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24635) Split TestMetaWithReplicas

2020-06-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146755#comment-17146755 ] Duo Zhang commented on HBASE-24635: --- Need to wait for HBASE-24562 to see if we want to port to

[jira] [Updated] (HBASE-24635) Split TestMetaWithReplicas

2020-06-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24635: -- Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 > Split

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446475799 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyHeterogeneousStorage.java ## @@ -0,0 +1,185 @@

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446475459 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1564,6 +1568,18 @@ public void

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446475247 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyHeterogeneousStorage.java ## @@ -0,0 +1,185 @@

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446474765 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DateTieredStoreEngine.java ## @@ -94,6 +94,7 @@ public void

[GitHub] [hbase] Apache9 merged pull request #1980: HBASE-24635 Split TestMetaWithReplicas

2020-06-26 Thread GitBox
Apache9 merged pull request #1980: URL: https://github.com/apache/hbase/pull/1980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HBASE-24646) Set the log level for ScheduledChore to INFO in HBTU

2020-06-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24646: - Assignee: Duo Zhang > Set the log level for ScheduledChore to INFO in HBTU >

[jira] [Work started] (HBASE-24646) Set the log level for ScheduledChore to INFO in HBTU

2020-06-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24646 started by Duo Zhang. - > Set the log level for ScheduledChore to INFO in HBTU >

[jira] [Created] (HBASE-24646) Set the log level for ScheduledChore to INFO in HBTU

2020-06-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24646: - Summary: Set the log level for ScheduledChore to INFO in HBTU Key: HBASE-24646 URL: https://issues.apache.org/jira/browse/HBASE-24646 Project: HBase Issue Type:

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2020-06-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146736#comment-17146736 ] Duo Zhang commented on HBASE-24623: --- So a broken WAL file? IIRC we've fixed a bug related to this

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r446471594 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/CatalogFamilyFormat.java ## @@ -363,4 +370,27 @@ public static Delete

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r446471642 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java ## @@ -85,26 +118,41 @@ private boolean isMeta(TableName

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r446471518 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ClientMetaTableAccessor.java ## @@ -164,26 +164,27 @@ private ClientMetaTableAccessor() {

[GitHub] [hbase] Apache9 commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
Apache9 commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r446471410 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractAsyncTableRegionLocator.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to the

[jira] [Commented] (HBASE-24588) Normalizer plan execution is not consistent between plan types

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146720#comment-17146720 ] Hudson commented on HBASE-24588: Results for branch master [build #1769 on

[jira] [Commented] (HBASE-24638) Edit doc on (offheap) memory management

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146719#comment-17146719 ] Hudson commented on HBASE-24638: Results for branch master [build #1769 on

[jira] [Commented] (HBASE-24221) Support bulkLoadHFile by family

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146716#comment-17146716 ] Hudson commented on HBASE-24221: Results for branch branch-2 [build #2721 on

[jira] [Commented] (HBASE-24562) Stabilize master startup with meta replicas enabled

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146715#comment-17146715 ] Hudson commented on HBASE-24562: Results for branch branch-2 [build #2721 on

[jira] [Commented] (HBASE-24552) Replica region needs to check if primary region directory exists at file system in TransitRegionStateProcedure

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146717#comment-17146717 ] Hudson commented on HBASE-24552: Results for branch branch-2 [build #2721 on

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: parse_call_trace.pl > Filter SKIP hinting regression >

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: (was: parse_call_trace.pl) > Filter SKIP hinting regression >

[jira] [Commented] (HBASE-24637) Filter SKIP hinting regression

2020-06-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146705#comment-17146705 ] Andrew Kyle Purtell commented on HBASE-24637: - I am considering adding the instrumentation

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: (was: W-7665966-Instrument-low-level-scan-details-branch-1.patch)

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: (was:

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-26 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: W-7665966-Instrument-low-level-scan-details-branch-2.2.patch

[jira] [Updated] (HBASE-24602) Add Increment and Append support to CheckAndMutate

2020-06-26 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24602: - Description: Currently, CheckAndMutate supports only Put and Delete. Supporting

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2020-06-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146698#comment-17146698 ] Michael Stack commented on HBASE-24623: --- bq. Coming to your case, so when you see the issue in

[GitHub] [hbase] saintstack commented on a change in pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
saintstack commented on a change in pull request #1774: URL: https://github.com/apache/hbase/pull/1774#discussion_r446446620 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractAsyncTableRegionLocator.java ## @@ -0,0 +1,308 @@ +/** + * Licensed to

[jira] [Commented] (HBASE-24221) Support bulkLoadHFile by family

2020-06-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146690#comment-17146690 ] Hudson commented on HBASE-24221: Results for branch branch-2.2 [build #903 on

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-650433945 bq. OK, got it. So you are talking about the whole design and Im expecting you are commenting on the patch. Yeah. This patch presumes a design that is only starting to

[jira] [Comment Edited] (HBASE-24459) Move the locateMeta logic from AsyncMetaRegionTableLocator to ConnectionRegistry

2020-06-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146657#comment-17146657 ] Michael Stack edited comment on HBASE-24459 at 6/26/20, 10:03 PM: -- Duo

[GitHub] [hbase] Apache-HBase commented on pull request #1983: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1983: URL: https://github.com/apache/hbase/pull/1983#issuecomment-650417303 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24459) Move the locateMeta logic from AsyncMetaRegionTableLocator to ConnectionRegistry

2020-06-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146657#comment-17146657 ] Michael Stack commented on HBASE-24459: --- Duo has talked of keeping the ConnectionRegistry

[GitHub] [hbase] Apache-HBase commented on pull request #1985: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1985: URL: https://github.com/apache/hbase/pull/1985#issuecomment-650411532 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446418314 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446413487 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #1985: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1985: URL: https://github.com/apache/hbase/pull/1985#issuecomment-650390234 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1983: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1983: URL: https://github.com/apache/hbase/pull/1983#issuecomment-650377859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446387518 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[jira] [Updated] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-20819: -- Release Note: Removes HBase::Admin.hcd and HBase::Admin.update_htd_from_arg from hbase-shell.

[jira] [Resolved] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-20819. --- Resolution: Fixed Merged. Thanks for nice contrib [~bitoffdev] (thanks for reviews

[GitHub] [hbase] saintstack merged pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
saintstack merged pull request #1959: URL: https://github.com/apache/hbase/pull/1959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1980: HBASE-24635 Split TestMetaWithReplicas

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1980: URL: https://github.com/apache/hbase/pull/1980#issuecomment-650358418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-24645) Include dump files in the jenkins archive

2020-06-26 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24645: Summary: Include dump files in the jenkins archive Key: HBASE-24645 URL: https://issues.apache.org/jira/browse/HBASE-24645 Project: HBase Issue Type: Task

[GitHub] [hbase-native-client] phrocker commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-06-26 Thread GitBox
phrocker commented on a change in pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r446358645 ## File path: src/hbase/client/async-batch-rpc-retrying-caller.cc ## @@ -70,7 +70,8 @@ AsyncBatchRpcRetryingCaller::~AsyncBatchRpcRetryingCaller()

[GitHub] [hbase-native-client] phrocker commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-06-26 Thread GitBox
phrocker commented on a change in pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r446354713 ## File path: CMakeLists.txt ## @@ -154,6 +160,9 @@ endif (OPENSSL_FOUND) if (DOWNLOAD_DEPENDENCIES) +

[GitHub] [hbase] Apache-HBase commented on pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1986: URL: https://github.com/apache/hbase/pull/1986#issuecomment-650340047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] huaxiangsun opened a new pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-06-26 Thread GitBox
huaxiangsun opened a new pull request #1986: URL: https://github.com/apache/hbase/pull/1986 …early stage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
huaxiangsun commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446344983 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #1985: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1985: URL: https://github.com/apache/hbase/pull/1985#issuecomment-650329335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-26 Thread GitBox
virajjasani commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-650329509 > Looks like there were consistent unit test failures in TestNormalizerOnCluster. let's keep an eye on it. Yeah, they pass locally all the time, on the build, it was

[GitHub] [hbase] huaxiangsun merged pull request #1971: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-26 Thread GitBox
huaxiangsun merged pull request #1971: URL: https://github.com/apache/hbase/pull/1971 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] huaxiangsun commented on pull request #1971: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-26 Thread GitBox
huaxiangsun commented on pull request #1971: URL: https://github.com/apache/hbase/pull/1971#issuecomment-650329376 This is the failure, jvm exits, it does not say which test case caused the exit. Do not think it is related with my patch. ``` [ERROR] Failed to execute goal

[GitHub] [hbase] Apache-HBase commented on pull request #1980: HBASE-24635 Split TestMetaWithReplicas

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1980: URL: https://github.com/apache/hbase/pull/1980#issuecomment-650327992 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun merged pull request #1972: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-26 Thread GitBox
huaxiangsun merged pull request #1972: URL: https://github.com/apache/hbase/pull/1972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-650322428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1983: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1983: URL: https://github.com/apache/hbase/pull/1983#issuecomment-650321039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-650320797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-650319359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1984: HBASE-24644 Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1984: URL: https://github.com/apache/hbase/pull/1984#issuecomment-650318684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz edited a comment on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…

2020-06-26 Thread GitBox
bsglz edited a comment on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-650316101 > @bsglz , sorry for the delay. So majority of people on the DISCUSS thread opined towards #3. I think @busbey suggestion to fix IncreasingToUpperBoundRegionSplitPolicy for

[GitHub] [hbase] bsglz commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…

2020-06-26 Thread GitBox
bsglz commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-650316101 > @bsglz , sorry for the delay. So majority of people on the DISCUSS thread opined towards #3. I think @busbey suggestion to fix IncreasingToUpperBoundRegionSplitPolicy for minor

[GitHub] [hbase] Apache-HBase commented on pull request #1979: HBASE-24639 RequestId Tracing Feature for Hbase

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1979: URL: https://github.com/apache/hbase/pull/1979#issuecomment-650311420 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446324754 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -369,7 +369,8 @@ private boolean

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446323076 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/MergeNormalizationPlan.java ## @@ -78,4 +82,30 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1984: HBASE-24644 Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1984: URL: https://github.com/apache/hbase/pull/1984#issuecomment-650309424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] ndimiduk commented on a change in pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-06-26 Thread GitBox
ndimiduk commented on a change in pull request #1922: URL: https://github.com/apache/hbase/pull/1922#discussion_r446319764 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/MergeNormalizationPlan.java ## @@ -78,4 +82,30 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-650304489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Work started] (HBASE-24644) Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24644 started by Nick Dimiduk. > Add a clause to the book noting that sometimes we short-circuit the >

[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public

2020-06-26 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146529#comment-17146529 ] Nick Dimiduk commented on HBASE-21782: -- And there's a release note as well. Yes, I think this issue

[GitHub] [hbase] virajjasani opened a new pull request #1985: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
virajjasani opened a new pull request #1985: URL: https://github.com/apache/hbase/pull/1985 Signed-off-by: Nick Dimiduk This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] ndimiduk opened a new pull request #1984: HBASE-24644 Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread GitBox
ndimiduk opened a new pull request #1984: URL: https://github.com/apache/hbase/pull/1984 Here's an exception where we willingly don't follow the guidelines as stated. Let's make that clear. This is an automated message from

[jira] [Updated] (HBASE-24562) Stabilize master startup with meta replicas enabled

2020-06-26 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-24562: - Affects Version/s: 2.4.0 2.3.0

[jira] [Commented] (HBASE-24562) Stabilize master startup with meta replicas enabled

2020-06-26 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146526#comment-17146526 ] Wellington Chevreuil commented on HBASE-24562: -- Had fixed conflicts and pushed into

[jira] [Assigned] (HBASE-24644) Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-24644: Assignee: Nick Dimiduk > Add a clause to the book noting that sometimes we short-circuit

[jira] [Updated] (HBASE-24562) Stabilize master startup with meta replicas enabled

2020-06-26 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-24562: - Fix Version/s: 2.4.0 2.3.1 > Stabilize master startup with

[jira] [Created] (HBASE-24644) Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24644: Summary: Add a clause to the book noting that sometimes we short-circuit the deprecation cycle Key: HBASE-24644 URL: https://issues.apache.org/jira/browse/HBASE-24644

[GitHub] [hbase] virajjasani opened a new pull request #1983: HBASE-24588 : Submit task for NormalizationPlan (#1933)

2020-06-26 Thread GitBox
virajjasani opened a new pull request #1983: URL: https://github.com/apache/hbase/pull/1983 Signed-off-by: Nick Dimiduk This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-24644) Add a clause to the book noting that sometimes we short-circuit the deprecation cycle

2020-06-26 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146525#comment-17146525 ] Nick Dimiduk commented on HBASE-24644: -- {quote} Usually we should keep the deprecated classes for a

[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…

2020-06-26 Thread GitBox
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-650299753 @bsglz , sorry for the delay. So majority of people on the DISCUSS thread opined towards #3. I think @busbey suggestion to fix IncreasingToUpperBoundRegionSplitPolicy for

[jira] [Created] (HBASE-24643) Replace Cluster#primariesOfRegionsPerServer from int array to treemap

2020-06-26 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24643: Summary: Replace Cluster#primariesOfRegionsPerServer from int array to treemap Key: HBASE-24643 URL: https://issues.apache.org/jira/browse/HBASE-24643 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-650297656 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-650296731 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24588) Normalizer plan execution is not consistent between plan types

2020-06-26 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146500#comment-17146500 ] Viraj Jasani commented on HBASE-24588: -- True, let me create two backport PRs for branch-2 and

[jira] [Commented] (HBASE-24588) Normalizer plan execution is not consistent between plan types

2020-06-26 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146494#comment-17146494 ] Nick Dimiduk commented on HBASE-24588: -- This is a good fix as the existing behavior is broken. +1

[GitHub] [hbase] ndimiduk commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-26 Thread GitBox
ndimiduk commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-650292872 Looks like there were consistent unit test failures in TestNormalizerOnCluster. let's keep an eye on it. This

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-06-26 Thread GitBox
bharathv commented on a change in pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r446305722 ## File path: cmake/DownloadDoubleConversion.cmake ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[jira] [Commented] (HBASE-24641) Add linter checks for patches

2020-06-26 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146488#comment-17146488 ] Bharath Vissapragada commented on HBASE-24641: -- [~phrocker] FYI. Also, do you have a

[jira] [Created] (HBASE-24642) Apache Yetus integration

2020-06-26 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24642: Summary: Apache Yetus integration Key: HBASE-24642 URL: https://issues.apache.org/jira/browse/HBASE-24642 Project: HBase Issue Type:

[jira] [Created] (HBASE-24641) Add linter checks for patches

2020-06-26 Thread Bharath Vissapragada (Jira)
Bharath Vissapragada created HBASE-24641: Summary: Add linter checks for patches Key: HBASE-24641 URL: https://issues.apache.org/jira/browse/HBASE-24641 Project: HBase Issue Type:

[GitHub] [hbase] busbey commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
busbey commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r446299722 ## File path: hbase-shell/src/main/ruby/hbase_constants.rb ## @@ -109,8 +109,8 @@ def self.promote_constants(constants) end end -

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r446296466 ## File path: hbase-shell/src/main/ruby/hbase_constants.rb ## @@ -109,8 +109,8 @@ def self.promote_constants(constants) end end -

[jira] [Commented] (HBASE-24588) Normalizer plan execution is not consistent between plan types

2020-06-26 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146475#comment-17146475 ] Viraj Jasani commented on HBASE-24588: -- Thank you [~ndimiduk] for the review. I believe we can

[GitHub] [hbase] virajjasani merged pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-26 Thread GitBox
virajjasani merged pull request #1933: URL: https://github.com/apache/hbase/pull/1933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-26 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146470#comment-17146470 ] Elliot Miller commented on HBASE-20819: --- h2. Which Constants Should We Keep? Below are my

  1   2   >