virajjasani commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r457076195
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##
@@ -652,4 +626,160 @@ static void
virajjasani commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r457073700
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -3276,11 +3290,16 @@ public
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r457072468
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaLocationCache.java
##
@@ -0,0 +1,164 @@
+/**
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160904#comment-17160904
]
ramkrishna.s.vasudevan commented on HBASE-23634:
[~Bo Cui]
bq. hfile needs 3 NN RPCs to
Apache-HBase commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660808943
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
ramkrish86 commented on a change in pull request #2093:
URL: https://github.com/apache/hbase/pull/2093#discussion_r457061034
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##
@@ -584,8 +584,12 @@ public void run() {
comnetwork commented on a change in pull request #2055:
URL: https://github.com/apache/hbase/pull/2055#discussion_r457043214
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java
##
@@ -59,7 +59,7 @@
private final
[
https://issues.apache.org/jira/browse/HBASE-24745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160885#comment-17160885
]
wenfeiyi666 commented on HBASE-24745:
-
I think the only possibility of this problem is Threads.sleep
[
https://issues.apache.org/jira/browse/HBASE-24745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160883#comment-17160883
]
wenfeiyi666 commented on HBASE-24745:
-
A simple mock test in branch-2.3 and master, everything is
Apache-HBase commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660791473
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660791146
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660790910
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
bsglz commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660782480
> Is the operation expensive?
In my local env, the code below cost about 1μs~200μs, avg<5μs, much lesser
than 1ms.
```
try {
currentHost =
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r457015827
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaLocationCache.java
##
@@ -0,0 +1,164 @@
+/**
+ * Licensed to the Apache
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r457015373
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -3305,24 +3324,31 @@ public
Apache-HBase commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660782024
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r457001736
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##
@@ -652,4 +626,160 @@ static void
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456994780
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -2928,13 +2928,27 @@ public GetActiveMasterResponse
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456994314
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##
@@ -652,4 +626,160 @@ static void
bsglz commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660761034
> > > > In distributed mode, this code would not make effect, because no
host named "localhost".
> > >
> > >
> > > Is this a strong assumption?
> >
> >
> > Not
[
https://issues.apache.org/jira/browse/HBASE-24709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160853#comment-17160853
]
Hudson commented on HBASE-24709:
Results for branch branch-2
[build #2751 on
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456990948
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistry.java
##
@@ -18,21 +18,36 @@
package
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456990289
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##
@@ -3276,11 +3290,16 @@ public LocateMetaRegionResponse
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456988819
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##
@@ -652,4 +626,160 @@ static void
Apache9 commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456988605
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##
@@ -652,4 +626,160 @@ static void
cuibo01 commented on a change in pull request #2084:
URL: https://github.com/apache/hbase/pull/2084#discussion_r456984183
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -846,10 +849,37 @@ private void
cuibo01 commented on a change in pull request #2084:
URL: https://github.com/apache/hbase/pull/2084#discussion_r456983850
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -846,10 +849,37 @@ private void
bharathv commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456974920
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistry.java
##
@@ -18,21 +18,36 @@
package
[
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160834#comment-17160834
]
Hudson commented on HBASE-11288:
Results for branch HBASE-11288.splittable-meta
[build #17 on
Apache-HBase commented on pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#issuecomment-660720769
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2086:
URL: https://github.com/apache/hbase/pull/2086#issuecomment-660716951
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#issuecomment-660713800
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
Apache-HBase commented on pull request #2086:
URL: https://github.com/apache/hbase/pull/2086#issuecomment-660696859
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#issuecomment-660693528
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
virajjasani commented on a change in pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#discussion_r456931717
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##
@@ -652,4 +626,160 @@ static void
sanjeetnishad95 commented on a change in pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#discussion_r456943199
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3000,7 +3001,12 @@ private void
Apache-HBase commented on pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#issuecomment-660682726
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2086:
URL: https://github.com/apache/hbase/pull/2086#issuecomment-660674533
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#issuecomment-660672202
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 commented on pull request #1909:
URL: https://github.com/apache/hbase/pull/1909#issuecomment-660660242
> > > In distributed mode, this code would not make effect, because no host
named "localhost".
> >
> >
> > Is this a strong assumption?
>
> Not strong
Apache9 commented on a change in pull request #2055:
URL: https://github.com/apache/hbase/pull/2055#discussion_r456919711
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java
##
@@ -59,7 +59,7 @@
private final
[
https://issues.apache.org/jira/browse/HBASE-24570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160709#comment-17160709
]
Duo Zhang commented on HBASE-24570:
---
Is this only for 2.2?
> connection#close throws NPE
>
[
https://issues.apache.org/jira/browse/HBASE-24709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani resolved HBASE-24709.
--
Fix Version/s: 2.4.0
1.7.0
2.3.1
virajjasani closed pull request #2099:
URL: https://github.com/apache/hbase/pull/2099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani closed pull request #2044:
URL: https://github.com/apache/hbase/pull/2044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
virajjasani commented on pull request #2099:
URL: https://github.com/apache/hbase/pull/2099#issuecomment-660653805
Changes are reviewed as part of https://github.com/apache/hbase/pull/2044
This is an automated message from
Apache-HBase commented on pull request #2095:
URL: https://github.com/apache/hbase/pull/2095#issuecomment-660652479
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
Apache-HBase commented on pull request #2099:
URL: https://github.com/apache/hbase/pull/2099#issuecomment-660650069
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
brfrn169 commented on pull request #2100:
URL: https://github.com/apache/hbase/pull/2100#issuecomment-660636827
Looks the patch broke some tests. Checking.
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on pull request #2100:
URL: https://github.com/apache/hbase/pull/2100#issuecomment-660635573
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2099:
URL: https://github.com/apache/hbase/pull/2099#issuecomment-660634016
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
virajjasani commented on a change in pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#discussion_r456896681
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3000,7 +3001,12 @@ private void
Apache-HBase commented on pull request #2100:
URL: https://github.com/apache/hbase/pull/2100#issuecomment-660628411
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
virajjasani commented on pull request #2099:
URL: https://github.com/apache/hbase/pull/2099#issuecomment-660626678
```
16:31:01 Running in
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2099/yetus-jdk8-hadoop3-check
[Pipeline] {
[Pipeline] deleteDir
Apache-HBase commented on pull request #2044:
URL: https://github.com/apache/hbase/pull/2044#issuecomment-660617317
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2100:
URL: https://github.com/apache/hbase/pull/2100#issuecomment-660613404
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2098:
URL: https://github.com/apache/hbase/pull/2098#issuecomment-660613084
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m
Apache-HBase commented on pull request #2098:
URL: https://github.com/apache/hbase/pull/2098#issuecomment-660611636
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-24744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Toshihiro Suzuki reassigned HBASE-24744:
Assignee: Toshihiro Suzuki
> enable_table_replication command granting
[
https://issues.apache.org/jira/browse/HBASE-24744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160602#comment-17160602
]
Toshihiro Suzuki edited comment on HBASE-24744 at 7/19/20, 8:29 AM:
Apache-HBase commented on pull request #2099:
URL: https://github.com/apache/hbase/pull/2099#issuecomment-660608408
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
brfrn169 opened a new pull request #2100:
URL: https://github.com/apache/hbase/pull/2100
…table automatically for the user
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/HBASE-24744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160602#comment-17160602
]
Toshihiro Suzuki commented on HBASE-24744:
--
As [~wchevreuil] mentioned, functionally speaking,
Apache-HBase commented on pull request #2099:
URL: https://github.com/apache/hbase/pull/2099#issuecomment-660605333
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
bsglz closed pull request #2096:
URL: https://github.com/apache/hbase/pull/2096
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bsglz opened a new pull request #2099:
URL: https://github.com/apache/hbase/pull/2099
…k hours
Signed-off-by: Viraj Jasani
Signed-off-by: Mingliang Liu
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on pull request #2098:
URL: https://github.com/apache/hbase/pull/2098#issuecomment-660599224
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m
[
https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160587#comment-17160587
]
Viraj Jasani commented on HBASE-24696:
--
+1 for the PR, all places seem covered.
> Include JVM
bsglz commented on pull request #2097:
URL: https://github.com/apache/hbase/pull/2097#issuecomment-660596896
> Target branch looks incorrect. You wanted to raise this PR for branch-2?
Oh, yes, dis misoperation. Thanks.
bsglz closed pull request #2097:
URL: https://github.com/apache/hbase/pull/2097
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
virajjasani commented on pull request #2096:
URL: https://github.com/apache/hbase/pull/2096#issuecomment-660595747
This is real strange. Let's see what logs say.
This is an automated message from the Apache Git Service.
To
virajjasani commented on pull request #2097:
URL: https://github.com/apache/hbase/pull/2097#issuecomment-660594491
Target branch looks incorrect. You wanted to raise this PR for branch-2?
This is an automated message from
72 matches
Mail list logo
