[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751986367 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s

[GitHub] [hbase] Apache9 commented on a change in pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-28 Thread GitBox
Apache9 commented on a change in pull request #2825: URL: https://github.com/apache/hbase/pull/2825#discussion_r549604670 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(M

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751984353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s

[GitHub] [hbase] bsglz commented on a change in pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
bsglz commented on a change in pull request #2823: URL: https://github.com/apache/hbase/pull/2823#discussion_r549601310 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java ## @@ -53,6 +54,8 @@ private Timer bulkLoadTimer;

[GitHub] [hbase] Apache-HBase commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-751982150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751981687 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s

[GitHub] [hbase] Apache-HBase commented on pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2803: URL: https://github.com/apache/hbase/pull/2803#issuecomment-751979996 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-751979007 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2020-12-28 Thread GitBox
nyl3532016 commented on a change in pull request #2814: URL: https://github.com/apache/hbase/pull/2814#discussion_r549594528 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java ## @@ -140,7 +146,7 @@ public WriteEnt

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-751973364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] infraio commented on a change in pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-28 Thread GitBox
infraio commented on a change in pull request #2825: URL: https://github.com/apache/hbase/pull/2825#discussion_r549592345 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(M

[GitHub] [hbase] nyl3532016 commented on pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2020-12-28 Thread GitBox
nyl3532016 commented on pull request #2814: URL: https://github.com/apache/hbase/pull/2814#issuecomment-751971855 > Have to be careful changing this code. It is hard to get it right. > > The narrow notify in place of the notifyAll is nice but I see lots of new synchronize blocks in t

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2020-12-28 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255841#comment-17255841 ] Pankaj Kumar commented on HBASE-25447: -- Discussed with [~Bo Cui] offline, reigon wa

[jira] [Updated] (HBASE-25451) Upgrade commons-io to 2.8.0

2020-12-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25451: -- Fix Version/s: 2.5.0 3.0.0-alpha-1 > Upgrade commons-io to 2.8.0 >

[jira] [Updated] (HBASE-25451) Upgrade commons-io to 2.8.0

2020-12-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25451: -- Component/s: dependencies > Upgrade commons-io to 2.8.0 > --- > >

[GitHub] [hbase] Apache9 opened a new pull request #2825: HBASE-25451 Upgrade commons-io to 2.8.0

2020-12-28 Thread GitBox
Apache9 opened a new pull request #2825: URL: https://github.com/apache/hbase/pull/2825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (HBASE-25451) Upgrade commons-io to 2.8.0

2020-12-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25451: - Assignee: Duo Zhang > Upgrade commons-io to 2.8.0 > --- > >

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2020-12-28 Thread GitBox
nyl3532016 commented on a change in pull request #2814: URL: https://github.com/apache/hbase/pull/2814#discussion_r549587869 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java ## @@ -185,7 +191,7 @@ public void com

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2020-12-28 Thread GitBox
nyl3532016 commented on a change in pull request #2814: URL: https://github.com/apache/hbase/pull/2814#discussion_r549587198 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java ## @@ -272,33 +252,59 @@ public long g

[jira] [Updated] (HBASE-25450) The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25450: Affects Version/s: (was: 2.3.2) 2.0.0 > The parameter "hbase.bucketcach

[jira] [Commented] (HBASE-25450) The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255830#comment-17255830 ] shenshengli commented on HBASE-25450: - The modification here is from Hbase-19187.Mod

[jira] [Updated] (HBASE-25450) The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25450: Description: You can see that the description of this configuration is outdated {quote} hbase.buc

[GitHub] [hbase] Apache-HBase commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-751959671 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 25s

[GitHub] [hbase] Apache-HBase commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751957063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751955378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751954080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-751950647 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2803: URL: https://github.com/apache/hbase/pull/2803#issuecomment-751947966 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[GitHub] [hbase] Apache-HBase commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-751947914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-751947356 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 54

[GitHub] [hbase] Apache-HBase commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-751946331 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2812: URL: https://github.com/apache/hbase/pull/2812#issuecomment-751942585 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42

[GitHub] [hbase] Apache-HBase commented on pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2812: URL: https://github.com/apache/hbase/pull/2812#issuecomment-751941838 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[GitHub] [hbase] Apache-HBase commented on pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2812: URL: https://github.com/apache/hbase/pull/2812#issuecomment-751941599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s

[GitHub] [hbase] lujiefsi commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-28 Thread GitBox
lujiefsi commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751941325 > Otherwise, patch looks good. > > The failures are related? YES, The failures are related, i will check it and fix. ---

[GitHub] [hbase] lujiefsi edited a comment on pull request #2820: HBASE-25432:branch 1

2020-12-28 Thread GitBox
lujiefsi edited a comment on pull request #2820: URL: https://github.com/apache/hbase/pull/2820#issuecomment-751940849 > @lujiefsi branch-1 backport includes only `SecureTestUtil` change? YES, I check the code and find that the bugs do not exist in branch-1, but i still think we sti

[GitHub] [hbase] lujiefsi commented on pull request #2820: HBASE-25432:branch 1

2020-12-28 Thread GitBox
lujiefsi commented on pull request #2820: URL: https://github.com/apache/hbase/pull/2820#issuecomment-751940849 > @lujiefsi branch-1 backport includes only `SecureTestUtil` change? YES, I check the code and find that the bugs do not exist in branch-1, but i still think we need to ha

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-751940343 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-28 Thread GitBox
ZhaoBQ commented on a change in pull request #2803: URL: https://github.com/apache/hbase/pull/2803#discussion_r549560738 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java ## @@ -82,8 +83,11 @@ public static void sanityCheck(final

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-751939110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751935637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[GitHub] [hbase] Apache9 commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-28 Thread GitBox
Apache9 commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751935248 The spotbugs warning is not introduced by the patch here. Will file another issue to see how to fix it. Thi

[jira] [Created] (HBASE-25452) Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat

2020-12-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25452: - Summary: Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat Key: HBASE-25452 URL: https://issues.apache.org/jira/browse/HBASE-25452 Project: HBase

[jira] [Created] (HBASE-25451) Upgrade commons-io to 2.8.0

2020-12-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25451: - Summary: Upgrade commons-io to 2.8.0 Key: HBASE-25451 URL: https://issues.apache.org/jira/browse/HBASE-25451 Project: HBase Issue Type: Task Reporter:

[jira] [Updated] (HBASE-25435) Slow metric value can be configured

2020-12-28 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen updated HBASE-25435: - Attachment: (was: HBASE-25435-master-v1.patch) > Slow metric value can be configured > -

[jira] [Updated] (HBASE-25434) SlowDelete & SlowPut metric value should use updateDelete & updatePut

2020-12-28 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen updated HBASE-25434: - Attachment: (was: HBASE-25434-master-v1.patch) > SlowDelete & SlowPut metric value should use update

[GitHub] [hbase] leyangyueshan commented on a change in pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
leyangyueshan commented on a change in pull request #2823: URL: https://github.com/apache/hbase/pull/2823#discussion_r549551847 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java ## @@ -68,6 +71,7 @@ public MetricsRegionServe

[GitHub] [hbase] Apache-HBase commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-751929697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
anoopsjohn commented on a change in pull request #2821: URL: https://github.com/apache/hbase/pull/2821#discussion_r549550856 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java ## @@ -234,7 +234,7 @@ public static long getOnHeapCacheSiz

[GitHub] [hbase] Apache-HBase commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-751927953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16

[GitHub] [hbase] bsglz commented on a change in pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
bsglz commented on a change in pull request #2823: URL: https://github.com/apache/hbase/pull/2823#discussion_r549546402 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java ## @@ -68,6 +71,7 @@ public MetricsRegionServer(Metric

[GitHub] [hbase] ZhaoBQ commented on a change in pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-28 Thread GitBox
ZhaoBQ commented on a change in pull request #2812: URL: https://github.com/apache/hbase/pull/2812#discussion_r549545528 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java ## @@ -292,6 +347,13 @@ public void testStringCustom

[jira] [Commented] (HBASE-25447) remoteProc is suspended due to OOM ERROR

2020-12-28 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255772#comment-17255772 ] Bo Cui commented on HBASE-25447: 1. the timeoutThread rarely encounter exceptions. and i

[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2020-12-28 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25449: Priority: Major (was: Minor) > 'dfs.client.read.shortcircuit' should not be set in hbase-default.

[GitHub] [hbase] Apache-HBase commented on pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2823: URL: https://github.com/apache/hbase/pull/2823#issuecomment-751921288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21

[GitHub] [hbase] cuibo01 opened a new pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR

2020-12-28 Thread GitBox
cuibo01 opened a new pull request #2824: URL: https://github.com/apache/hbase/pull/2824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751919952 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751919105 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] Apache-HBase commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751918972 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s

[GitHub] [hbase] shenshengli commented on a change in pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
shenshengli commented on a change in pull request #2821: URL: https://github.com/apache/hbase/pull/2821#discussion_r549540838 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java ## @@ -234,7 +234,7 @@ public static long getOnHeapCacheSi

[GitHub] [hbase] Apache9 commented on a change in pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-28 Thread GitBox
Apache9 commented on a change in pull request #2813: URL: https://github.com/apache/hbase/pull/2813#discussion_r549539702 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java ## @@ -203,26 +204,36 @@ public boolean isClosed() {

[GitHub] [hbase] shenshengli commented on a change in pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
shenshengli commented on a change in pull request #2821: URL: https://github.com/apache/hbase/pull/2821#discussion_r549539669 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java ## @@ -234,7 +234,7 @@ public static long getOnHeapCacheSi

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2020-12-28 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255764#comment-17255764 ] shenshengli commented on HBASE-25449: - {quote}Please explain more what you are think

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2020-12-28 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255763#comment-17255763 ] shenshengli commented on HBASE-25449: - Because this is an HDFS client parameter, the

[GitHub] [hbase] leyangyueshan commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…

2020-12-28 Thread GitBox
leyangyueshan commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-751915931 Unit test fiexed. this pr should go in before #2823。 This is an automated message from the Apache Git Serv

[GitHub] [hbase] leyangyueshan commented on a change in pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
leyangyueshan commented on a change in pull request #2823: URL: https://github.com/apache/hbase/pull/2823#discussion_r549536937 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java ## @@ -53,6 +54,8 @@ private Timer bulkLoad

[GitHub] [hbase] z-york commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2020-12-28 Thread GitBox
z-york commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r549514178 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreContext.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] GeorryHuang commented on a change in pull request #2815: HBASE-24751 Display Task completion time and/or processing duration o…

2020-12-28 Thread GitBox
GeorryHuang commented on a change in pull request #2815: URL: https://github.com/apache/hbase/pull/2815#discussion_r549513981 ## File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/common/TaskMonitorTmpl.jamon ## @@ -116,6 +117,7 @@ String parent = "";

[GitHub] [hbase] z-york commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2020-12-28 Thread GitBox
z-york commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r549513396 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreContext.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751875173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s

[GitHub] [hbase] saintstack commented on a change in pull request #2803: HBASE-25431 MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2803: URL: https://github.com/apache/hbase/pull/2803#discussion_r549492865 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java ## @@ -82,8 +83,11 @@ public static void sanityCheck(f

[GitHub] [hbase] Apache-HBase commented on pull request #2807: HBASE-25438 Update create-release mvn in Dockerfile; its 3.6.0; make …

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2807: URL: https://github.com/apache/hbase/pull/2807#issuecomment-751868584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #2807: HBASE-25438 Update create-release mvn in Dockerfile; its 3.6.0; make …

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2807: URL: https://github.com/apache/hbase/pull/2807#issuecomment-751868516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] Apache-HBase commented on pull request #2807: HBASE-25438 Update create-release mvn in Dockerfile; its 3.6.0; make …

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2807: URL: https://github.com/apache/hbase/pull/2807#issuecomment-751868438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[GitHub] [hbase] saintstack commented on pull request #2810: HBASE-25441:add security check for RSRpcSever

2020-12-28 Thread GitBox
saintstack commented on pull request #2810: URL: https://github.com/apache/hbase/pull/2810#issuecomment-751853344 Are the failures related? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] saintstack commented on a change in pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2812: URL: https://github.com/apache/hbase/pull/2812#discussion_r549476078 ## File path: hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java ## @@ -292,6 +347,13 @@ public void testStringCu

[GitHub] [hbase] saintstack commented on a change in pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2813: URL: https://github.com/apache/hbase/pull/2813#discussion_r549470855 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java ## @@ -84,64 +96,101 @@ private boolean isMeta(TableName

[GitHub] [hbase] saintstack commented on a change in pull request #2814: HBASE-25442 Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify()

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2814: URL: https://github.com/apache/hbase/pull/2814#discussion_r549462374 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java ## @@ -140,7 +146,7 @@ public WriteEnt

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255700#comment-17255700 ] Hudson commented on HBASE-24850: Results for branch branch-2.2 [build #142 on b

[GitHub] [hbase] taklwu edited a comment on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-12-28 Thread GitBox
taklwu edited a comment on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-751833447 thanks Duo for your understanding and comments ;) and happy holidays! @z-york your point on idempotent is good, but at this point will you agree that we create a foll

[GitHub] [hbase] taklwu commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-12-28 Thread GitBox
taklwu commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-751833447 thanks Duo for your understanding and comments ;) and happy holidays! @z-york your point on idempotent is good, but at this point will you agree that we create a follow up o

[GitHub] [hbase] saintstack commented on a change in pull request #2815: HBASE-24751 Display Task completion time and/or processing duration o…

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2815: URL: https://github.com/apache/hbase/pull/2815#discussion_r549456755 ## File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/common/TaskMonitorTmpl.jamon ## @@ -116,6 +117,7 @@ String parent = "";

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2020-12-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255696#comment-17255696 ] Michael Stack commented on HBASE-25449: --- Please explain more what you are thinking

[jira] [Commented] (HBASE-25432) we should add security checks for setTableStateInMeta and fixMeta

2020-12-28 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255695#comment-17255695 ] Michael Stack commented on HBASE-25432: --- I pushed on branch-2.3+. [~vjasani] notic

[GitHub] [hbase] saintstack merged pull request #2819: HBASE-25432: branch-2.3 add security checks for setTableStateInMeta a…

2020-12-28 Thread GitBox
saintstack merged pull request #2819: URL: https://github.com/apache/hbase/pull/2819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack merged pull request #2818: HBASE-25432: branch-2 add security checks for setTableStateInMeta and…

2020-12-28 Thread GitBox
saintstack merged pull request #2818: URL: https://github.com/apache/hbase/pull/2818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack merged pull request #2817: HBASE-25432: branch-2.4 add security checks for setTableStateInMeta a…

2020-12-28 Thread GitBox
saintstack merged pull request #2817: URL: https://github.com/apache/hbase/pull/2817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack merged pull request #2809: HBASE-25432:add security checks for setTableStateInMeta and fixMeta

2020-12-28 Thread GitBox
saintstack merged pull request #2809: URL: https://github.com/apache/hbase/pull/2809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2813: HBASE-23898 Add trace support for simple apis in async client

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2813: URL: https://github.com/apache/hbase/pull/2813#issuecomment-751828190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] saintstack commented on a change in pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2821: URL: https://github.com/apache/hbase/pull/2821#discussion_r549450453 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java ## @@ -234,7 +234,7 @@ public static long getOnHeapCacheSiz

[GitHub] [hbase] saintstack commented on a change in pull request #2823: HBASE-25435 Slow metric value can be configured

2020-12-28 Thread GitBox
saintstack commented on a change in pull request #2823: URL: https://github.com/apache/hbase/pull/2823#discussion_r549449092 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java ## @@ -53,6 +54,8 @@ private Timer bulkLoadTim

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255686#comment-17255686 ] Hudson commented on HBASE-24850: Results for branch branch-2 [build #139 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #2819: HBASE-25432: branch-2.3 add security checks for setTableStateInMeta a…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2819: URL: https://github.com/apache/hbase/pull/2819#issuecomment-751801787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255650#comment-17255650 ] Hudson commented on HBASE-24850: Results for branch branch-2.3 [build #132 on b

[jira] [Resolved] (HBASE-24850) CellComparator perf improvement

2020-12-28 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan resolved HBASE-24850. Fix Version/s: 2.4.1 2.3.4 2.2.7

[jira] [Commented] (HBASE-24850) CellComparator perf improvement

2020-12-28 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255648#comment-17255648 ] ramkrishna.s.vasudevan commented on HBASE-24850: Puhsed to master, branc

[GitHub] [hbase] Apache-HBase commented on pull request #2818: HBASE-25432: branch-2 add security checks for setTableStateInMeta and…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2818: URL: https://github.com/apache/hbase/pull/2818#issuecomment-751782813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41

[GitHub] [hbase] Apache-HBase commented on pull request #2818: HBASE-25432: branch-2 add security checks for setTableStateInMeta and…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2818: URL: https://github.com/apache/hbase/pull/2818#issuecomment-751778962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] Apache-HBase commented on pull request #2819: HBASE-25432: branch-2.3 add security checks for setTableStateInMeta a…

2020-12-28 Thread GitBox
Apache-HBase commented on pull request #2819: URL: https://github.com/apache/hbase/pull/2819#issuecomment-751772389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] virajjasani commented on pull request #2820: HBASE-25432:branch 1

2020-12-28 Thread GitBox
virajjasani commented on pull request #2820: URL: https://github.com/apache/hbase/pull/2820#issuecomment-751771455 @lujiefsi branch-1 backport includes only `SecureTestUtil` change? This is an automated message from the Apach

  1   2   >