[GitHub] [hbase] Apache-HBase commented on pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2816: URL: https://github.com/apache/hbase/pull/2816#issuecomment-755144721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2816: URL: https://github.com/apache/hbase/pull/2816#issuecomment-755143364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] mokai87 commented on a change in pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 commented on a change in pull request #2846: URL: https://github.com/apache/hbase/pull/2846#discussion_r552417793 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1233,9 +1233,8 @@ public void moveServers(Set

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-755140184 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25435) Slow metric value can be configured

2021-01-05 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen resolved HBASE-25435. -- Resolution: Fixed > Slow metric value can be configured > --- > >

[jira] [Resolved] (HBASE-21177) Add per-table metrics on getTime,putTime and scanTime

2021-01-05 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen resolved HBASE-21177. -- Resolution: Duplicate > Add per-table metrics on getTime,putTime and scanTime >

[jira] [Assigned] (HBASE-21177) Add per-table metrics on getTime,putTime and scanTime

2021-01-05 Thread xijiawen (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xijiawen reassigned HBASE-21177: Assignee: xijiawen > Add per-table metrics on getTime,putTime and scanTime >

[GitHub] [hbase] Apache9 merged pull request #2838: HBASE-25458 HRegion methods cleanup

2021-01-05 Thread GitBox
Apache9 merged pull request #2838: URL: https://github.com/apache/hbase/pull/2838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] virajjasani commented on a change in pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
virajjasani commented on a change in pull request #2846: URL: https://github.com/apache/hbase/pull/2846#discussion_r552405945 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1233,9 +1233,8 @@ public void

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259451#comment-17259451 ] Viraj Jasani commented on HBASE-25329: -- {quote}It's much easier to parse this file rather than

[GitHub] [hbase] Apache-HBase commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-755118042 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-755116771 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552389039 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java ## @@ -138,6 +138,10 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2846: URL: https://github.com/apache/hbase/pull/2846#issuecomment-755102735 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552382472 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java ## @@ -138,6 +138,10 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-755095879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552381911 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -474,33 +502,14 @@ public long getBlockingFileCount() {

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552381002 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1206,53 +1218,34 @@ public StoreFileWriter

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552380797 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreContext.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-755092829 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-755084616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2846: URL: https://github.com/apache/hbase/pull/2846#issuecomment-755083727 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-05 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259420#comment-17259420 ] Pankaj Kumar commented on HBASE-25445: -- Yeah Anoop, this problem occured when we enabled Proc based

[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL

2021-01-05 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259419#comment-17259419 ] Anoop Sam John commented on HBASE-25445: This issues arises when we have WAL split NOT managed

[GitHub] [hbase] Apache-HBase commented on pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2846: URL: https://github.com/apache/hbase/pull/2846#issuecomment-755082589 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755067504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755067357 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755065794 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755058732 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25438) Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25438. --- Resolution: Fixed Re-resolving. Just added the -L to curl call: diff --git

[jira] [Reopened] (HBASE-25438) Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25438: --- Reopen to add an addendum found testing. > Update create-release mvn in Dockerfile; its 3.6.0;

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755057780 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755056448 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] mokai87 closed pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 closed pull request #2847: URL: https://github.com/apache/hbase/pull/2847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755045936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] mokai87 commented on a change in pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 commented on a change in pull request #2846: URL: https://github.com/apache/hbase/pull/2846#discussion_r552324003 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1233,9 +1233,7 @@ public void moveServers(Set

[GitHub] [hbase] mokai87 closed pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 closed pull request #2846: URL: https://github.com/apache/hbase/pull/2846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2800: URL: https://github.com/apache/hbase/pull/2800#issuecomment-755044679 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755044689 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2846: URL: https://github.com/apache/hbase/pull/2846#issuecomment-755042082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2847: URL: https://github.com/apache/hbase/pull/2847#issuecomment-755041421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24755) [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread mokai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259357#comment-17259357 ] mokai commented on HBASE-24755: --- [~pankajkumar]The PRs are raised, could you help to review? >

[GitHub] [hbase] mokai87 opened a new pull request #2847: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 opened a new pull request #2847: URL: https://github.com/apache/hbase/pull/2847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-25448) c++库编译不通过

2021-01-05 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259352#comment-17259352 ] Bharath Vissapragada commented on HBASE-25448: -- Mind filing/translating to English for

[GitHub] [hbase] ZhaoBQ commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)

2021-01-05 Thread GitBox
ZhaoBQ commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-755029511 Applied to master @saintstack . PR2840 contains this. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] mokai87 commented on a change in pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 commented on a change in pull request #2846: URL: https://github.com/apache/hbase/pull/2846#discussion_r552324003 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1233,9 +1233,7 @@ public void moveServers(Set

[GitHub] [hbase] Apache-HBase commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-755028969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] mokai87 opened a new pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

2021-01-05 Thread GitBox
mokai87 opened a new pull request #2846: URL: https://github.com/apache/hbase/pull/2846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-25463) Fix comment error

2021-01-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259350#comment-17259350 ] Hudson commented on HBASE-25463: Results for branch branch-2.4 [build #23 on

[jira] [Commented] (HBASE-25318) Configure where IntegrationTestImportTsv generates HFiles

2021-01-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259349#comment-17259349 ] Hudson commented on HBASE-25318: Results for branch branch-2.4 [build #23 on

[GitHub] [hbase] bharathv edited a comment on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-05 Thread GitBox
bharathv edited a comment on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-755028030 Stumbled upon this one. > Just a simple flag like initialized is enough? After we finish the initialization work, we set the flag to true, and regionServerReport

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552323137 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] bharathv commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-05 Thread GitBox
bharathv commented on pull request #2769: URL: https://github.com/apache/hbase/pull/2769#issuecomment-755028030 Stumbled upon this one. > Just a simple flag like initialized is enough? After we finish the initialization work, we set the flag to true, and regionServerReport will

[jira] [Commented] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2021-01-05 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259347#comment-17259347 ] Bharath Vissapragada commented on HBASE-25032: -- Thanks [~caroliney14] for pinging me on the

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552321656 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java ## @@ -138,6 +138,10 @@ public boolean

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552321526 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -254,48 +244,47 @@ protected HStore(final HRegion

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552321478 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -347,6 +331,48 @@ protected HStore(final HRegion region,

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552321068 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -474,33 +502,14 @@ public long getBlockingFileCount() {

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552320678 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreContext.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] saintstack commented on a change in pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2754: URL: https://github.com/apache/hbase/pull/2754#discussion_r552308847 ## File path: dev-support/release-vm/README.md ## @@ -0,0 +1,63 @@ +# HBase Release Env + +This is a vagrant project that provides a virtual machine

[GitHub] [hbase] bharathv commented on pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-05 Thread GitBox
bharathv commented on pull request #2762: URL: https://github.com/apache/hbase/pull/2762#issuecomment-755010117 Thanks for putting this together. Definitely useful to have more insights into RIT states. I added a comment in the jira. Would like to know your thoughts.

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-05 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259327#comment-17259327 ] Bharath Vissapragada commented on HBASE-25329: -- Patch seems fine but was curious if we

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259325#comment-17259325 ] Nick Dimiduk commented on HBASE-25465: -- "If it actually works" :) > Use javac --release option for

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259319#comment-17259319 ] Sean Busbey commented on HBASE-25465: - Nice! If this works we could remove our enforcer rule around

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754982803 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754982706 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754982472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754982363 Latest commit fixes ssh configurations and outlines basic steps to verify the agent forwarding in the readme. "works for me".

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754970043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754969833 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754969739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259295#comment-17259295 ] Michael Stack commented on HBASE-25465: --- create-release should make use of this. Thanks for

[jira] [Updated] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25465: -- Component/s: create-release > Use javac --release option for supporting cross version

[jira] [Updated] (HBASE-25466) [create-release] Use release:prepare tagging and setting version numbers

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25466: -- Description: Our [~ndimiduk] fingered release:prepare as alternative for our explicit

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754968807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (HBASE-25466) [create-release] Use release:prepare tagging and setting version numbers

2021-01-05 Thread Michael Stack (Jira)
Michael Stack created HBASE-25466: - Summary: [create-release] Use release:prepare tagging and setting version numbers Key: HBASE-25466 URL: https://issues.apache.org/jira/browse/HBASE-25466 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
Apache-HBase commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754968478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2806: URL: https://github.com/apache/hbase/pull/2806#discussion_r552264625 ## File path: dev-support/create-release/release-build.sh ## @@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then git config user.name "$GIT_NAME"

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552255807 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java ## @@ -138,6 +138,10 @@ public boolean

[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552254130 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong

[GitHub] [hbase] ndimiduk commented on a change in pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
ndimiduk commented on a change in pull request #2806: URL: https://github.com/apache/hbase/pull/2806#discussion_r552248178 ## File path: dev-support/create-release/release-build.sh ## @@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then git config user.name "$GIT_NAME"

[GitHub] [hbase] ndimiduk commented on a change in pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
ndimiduk commented on a change in pull request #2806: URL: https://github.com/apache/hbase/pull/2806#discussion_r552247999 ## File path: dev-support/create-release/release-build.sh ## @@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then git config user.name "$GIT_NAME"

[jira] [Resolved] (HBASE-24573) do-release should sign the commits and tag it creates

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24573. --- Fix Version/s: 3.0.0-alpha-1 Assignee: Michael Stack Resolution: Fixed This

[GitHub] [hbase] saintstack closed pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
saintstack closed pull request #2806: URL: https://github.com/apache/hbase/pull/2806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ndimiduk commented on pull request #2754: HBASE-25375 Provide a VM-based release environment

2021-01-05 Thread GitBox
ndimiduk commented on pull request #2754: URL: https://github.com/apache/hbase/pull/2754#issuecomment-754941143 Upgrading this VM to 20.04 (focal) gives me gpg 2.2.19 on the VM side. with this, and 2.2.26 on the mac side, i’m able to forward my agent and `ssh -T g...@github.com` run from

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552205785 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -246,6 +234,8 @@ private AtomicLong compactedCellsSize =

[GitHub] [hbase] saintstack commented on pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
saintstack commented on pull request #2806: URL: https://github.com/apache/hbase/pull/2806#issuecomment-754909458 Looks like this went in with commit 1ca49ea50c8a2b552af9030b4e1bdcd27f618461 Author: Michael Stack Date: Sat Jan 2 11:32:47 2021 -0800 HBASE-25438

[GitHub] [hbase] saintstack commented on a change in pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
saintstack commented on a change in pull request #2806: URL: https://github.com/apache/hbase/pull/2806#discussion_r552201134 ## File path: dev-support/create-release/release-build.sh ## @@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then git config user.name "$GIT_NAME"

[GitHub] [hbase] taklwu commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

2021-01-05 Thread GitBox
taklwu commented on a change in pull request #2800: URL: https://github.com/apache/hbase/pull/2800#discussion_r552203329 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java ## @@ -136,4 +140,26 @@ public static OptionalLong

[jira] [Updated] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25465: Description: See

[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259185#comment-17259185 ] Michael Stack commented on HBASE-25449: --- I see. You want the hdfs-site.xml configuration to shine

[jira] [Commented] (HBASE-25459) WAL can't be cleaned with phoenix5

2021-01-05 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259189#comment-17259189 ] Andrew Kyle Purtell commented on HBASE-25459: - {quote}After reviewing the related code, I

[GitHub] [hbase] ndimiduk commented on a change in pull request #2806: HBASE-24573 do-release should sign the commits and tag it creates

2021-01-05 Thread GitBox
ndimiduk commented on a change in pull request #2806: URL: https://github.com/apache/hbase/pull/2806#discussion_r552186288 ## File path: dev-support/create-release/release-build.sh ## @@ -136,19 +136,21 @@ if [[ "$1" == "tag" ]]; then git config user.name "$GIT_NAME"

[GitHub] [hbase] apurtell commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…

2021-01-05 Thread GitBox
apurtell commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-754870237 VisibleForTesting annotation, as you have described why you want it, is equivalent to a code comment placed at the same location. Make a more clear argument if there is really

[jira] [Commented] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259195#comment-17259195 ] Andrew Kyle Purtell commented on HBASE-25465: - Not sure if this is of any interest but I

[jira] [Created] (HBASE-25465) Use javac --release option for supporting cross version compilation in create-release

2021-01-05 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25465: --- Summary: Use javac --release option for supporting cross version compilation in create-release Key: HBASE-25465 URL:

[jira] [Commented] (HBASE-25463) Fix comment error

2021-01-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259168#comment-17259168 ] Hudson commented on HBASE-25463: Results for branch branch-2.2 [build #144 on

[jira] [Commented] (HBASE-25318) Configure where IntegrationTestImportTsv generates HFiles

2021-01-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259167#comment-17259167 ] Hudson commented on HBASE-25318: Results for branch branch-2.2 [build #144 on

[jira] [Commented] (HBASE-25459) WAL can't be cleaned with phoenix5

2021-01-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259165#comment-17259165 ] Michael Stack commented on HBASE-25459: --- Agree w/ Wellington on his general position (Lets not

[GitHub] [hbase] saintstack commented on pull request #2841: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit (addendum)

2021-01-05 Thread GitBox
saintstack commented on pull request #2841: URL: https://github.com/apache/hbase/pull/2841#issuecomment-754849668 You want this applied to Master @ZhaoBQ ? Or to branch-2? Thanks. This is an automated message from the Apache

  1   2   >