[GitHub] [hbase] ddupg merged pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
ddupg merged pull request #3806: URL: https://github.com/apache/hbase/pull/3806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [hbase] Apache-HBase commented on pull request #3812: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3812: URL: https://github.com/apache/hbase/pull/3812#issuecomment-957126734 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [hbase] Apache-HBase commented on pull request #3811: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3811: URL: https://github.com/apache/hbase/pull/3811#issuecomment-957119762 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6

[GitHub] [hbase] clarax opened a new pull request #3812: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
clarax opened a new pull request #3812: URL: https://github.com/apache/hbase/pull/3812 …f list backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [hbase] clarax opened a new pull request #3811: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
clarax opened a new pull request #3811: URL: https://github.com/apache/hbase/pull/3811 …f list backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [hbase] Apache-HBase commented on pull request #3723: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3723: URL: https://github.com/apache/hbase/pull/3723#issuecomment-957091813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3723: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3723: URL: https://github.com/apache/hbase/pull/3723#issuecomment-957090085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[GitHub] [hbase] Apache-HBase commented on pull request #3723: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3723: URL: https://github.com/apache/hbase/pull/3723#issuecomment-957089574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437132#comment-17437132 ] chenglei edited comment on HBASE-25905 at 11/2/21, 3:55 AM:

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437132#comment-17437132 ] chenglei commented on HBASE-25905: -- [~Xiaolin Ha], thank you for reply, for your new as

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437132#comment-17437132 ] chenglei edited comment on HBASE-25905 at 11/2/21, 3:54 AM:

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437129#comment-17437129 ] Xiaolin Ha commented on HBASE-25905: The reasoning is blemished, I'll dig more. > S

[jira] [Issue Comment Deleted] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25905: --- Comment: was deleted (was: [~comnetwork] Thanks your reminder. You are right. The scenario I assumed

[jira] [Issue Comment Deleted] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25905: --- Comment: was deleted (was: So this problem offten occurs with WAL stuck issues is because there are

[jira] [Commented] (HBASE-26310) Repro balancer behavior during iterations

2021-11-01 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437128#comment-17437128 ] Clara Xiong commented on HBASE-26310: - The PR is rolled up in [https://github.com/ap

[jira] [Updated] (HBASE-26310) Repro balancer behavior during iterations

2021-11-01 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-26310: Parent: HBASE-26309 Issue Type: Sub-task (was: Bug) > Repro balancer behavior during iter

[jira] [Updated] (HBASE-26310) Repro balancer behavior during iterations

2021-11-01 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated HBASE-26310: Parent: (was: HBASE-26311) Issue Type: Bug (was: Sub-task) > Repro balancer behavior

[GitHub] [hbase] clarax closed pull request #3711: HBASE-26310 Repro balancer behavior during iterations

2021-11-01 Thread GitBox
clarax closed pull request #3711: URL: https://github.com/apache/hbase/pull/3711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [hbase] clarax commented on pull request #3711: HBASE-26310 Repro balancer behavior during iterations

2021-11-01 Thread GitBox
clarax commented on pull request #3711: URL: https://github.com/apache/hbase/pull/3711#issuecomment-957075260 included in https://github.com/apache/hbase/pull/3723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437118#comment-17437118 ] chenglei commented on HBASE-26384: -- [~zhangduo],thank you very much for code review. >

[jira] [Commented] (HBASE-26411) Wal do not roll and write a big wal

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437114#comment-17437114 ] chenglei commented on HBASE-26411: -- [~binlijin], Would you please upload the full jstac

[GitHub] [hbase] YutSean commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
YutSean commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-957047568 > > There is no method of InetSocketAddress return the colon concat result directly for unresolved address. Every usage of our tostring method should be reviewed if there could ge

[jira] [Commented] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437107#comment-17437107 ] Hudson commented on HBASE-26384: Results for branch branch-2.4 [build #228 on b

[jira] [Commented] (HBASE-26404) Update javadoc for CellUtil#createCell with tags methods.

2021-11-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437106#comment-17437106 ] Hudson commented on HBASE-26404: Results for branch branch-2.4 [build #228 on b

[jira] [Resolved] (HBASE-26407) Introduce a region replication sink for sinking WAL edits to secondary replicas directly

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26407. --- Fix Version/s: HBASE-26233 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBA

[jira] [Created] (HBASE-26415) Separate master read and client read meta

2021-11-01 Thread Lijin Bin (Jira)
Lijin Bin created HBASE-26415: - Summary: Separate master read and client read meta Key: HBASE-26415 URL: https://issues.apache.org/jira/browse/HBASE-26415 Project: HBase Issue Type: Bug Affec

[GitHub] [hbase] Apache-HBase commented on pull request #3810: HBASE-26414 Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3810: URL: https://github.com/apache/hbase/pull/3810#issuecomment-957007149 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[GitHub] [hbase] Apache-HBase commented on pull request #3810: HBASE-26414 Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3810: URL: https://github.com/apache/hbase/pull/3810#issuecomment-957006051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5

[GitHub] [hbase] Apache-HBase commented on pull request #3810: HBASE-26414 Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3810: URL: https://github.com/apache/hbase/pull/3810#issuecomment-957004645 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[GitHub] [hbase] Apache9 merged pull request #3807: HBASE-26407 Introduce a region replication sink for sinking WAL edits…

2021-11-01 Thread GitBox
Apache9 merged pull request #3807: URL: https://github.com/apache/hbase/pull/3807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (HBASE-26414) Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437083#comment-17437083 ] Duo Zhang commented on HBASE-26414: --- https://github.com/open-telemetry/opentelemetry-j

[GitHub] [hbase] ndimiduk opened a new pull request #3810: HBASE-26414 Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread GitBox
ndimiduk opened a new pull request #3810: URL: https://github.com/apache/hbase/pull/3810 In an effort to not fail a blocker and walk away, here's something that may also be incorrect, but seems more correct than what we currently have. -- This is an automated message from the Apache Git

[jira] [Updated] (HBASE-26414) Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26414: - Priority: Blocker (was: Major) > Tracing INSTRUMENTATION_NAME is incorrect > --

[jira] [Commented] (HBASE-26414) Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437076#comment-17437076 ] Nick Dimiduk commented on HBASE-26414: -- Marking as blocker as this is a public name

[jira] [Created] (HBASE-26414) Tracing INSTRUMENTATION_NAME is incorrect

2021-11-01 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-26414: Summary: Tracing INSTRUMENTATION_NAME is incorrect Key: HBASE-26414 URL: https://issues.apache.org/jira/browse/HBASE-26414 Project: HBase Issue Type: Bug

[GitHub] [hbase] Apache-HBase commented on pull request #3803: HBASE-26304: Reflect out of band locality improvements in metrics and balancer

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3803: URL: https://github.com/apache/hbase/pull/3803#issuecomment-956899169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[GitHub] [hbase] Apache-HBase commented on pull request #3803: HBASE-26304: Reflect out of band locality improvements in metrics and balancer

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3803: URL: https://github.com/apache/hbase/pull/3803#issuecomment-956773068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 5

[GitHub] [hbase] Apache-HBase commented on pull request #3803: HBASE-26304: Reflect out of band locality improvements in metrics and balancer

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3803: URL: https://github.com/apache/hbase/pull/3803#issuecomment-956571578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17

[GitHub] [hbase] Apache-HBase commented on pull request #3807: HBASE-26407 Introduce a region replication sink for sinking WAL edits…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3807: URL: https://github.com/apache/hbase/pull/3807#issuecomment-956565419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8

[GitHub] [hbase] Apache-HBase commented on pull request #3807: HBASE-26407 Introduce a region replication sink for sinking WAL edits…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3807: URL: https://github.com/apache/hbase/pull/3807#issuecomment-956528369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

[jira] [Commented] (HBASE-26404) Update javadoc for CellUtil#createCell with tags methods.

2021-11-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436975#comment-17436975 ] Hudson commented on HBASE-26404: Results for branch branch-2 [build #382 on bui

[jira] [Comment Edited] (HBASE-26241) Showcase/document a end-to-end tracing integreated with an external sink e.g. Jaeger or zipkin

2021-11-01 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436938#comment-17436938 ] Tak-Lon (Stephen) Wu edited comment on HBASE-26241 at 11/1/21, 4:58 PM: --

[jira] [Commented] (HBASE-26241) Showcase/document a end-to-end tracing integreated with an external sink e.g. Jaeger or zipkin

2021-11-01 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436938#comment-17436938 ] Tak-Lon (Stephen) Wu commented on HBASE-26241: -- [~ndimiduk] I'm going to do

[jira] [Assigned] (HBASE-26241) Showcase/document a end-to-end tracing integreated with an external sink e.g. Jaeger or zipkin

2021-11-01 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26241: Assignee: Tak-Lon (Stephen) Wu > Showcase/document a end-to-end tracing i

[GitHub] [hbase] clarax commented on a change in pull request #3723: HBASE-26309 Balancer tends to move regions to the server at the end o…

2021-11-01 Thread GitBox
clarax commented on a change in pull request #3723: URL: https://github.com/apache/hbase/pull/3723#discussion_r740344466 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/LoadCandidateGenerator.java ## @@ -34,27 +35,51 @@ BalanceAction generate

[GitHub] [hbase] Apache-HBase commented on pull request #3807: HBASE-26407 Introduce a region replication sink for sinking WAL edits…

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3807: URL: https://github.com/apache/hbase/pull/3807#issuecomment-956375914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[jira] [Updated] (HBASE-26413) Limit the total size of buffered region replication entries

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26413: -- Component/s: read replicas > Limit the total size of buffered region replication entries > ---

[jira] [Updated] (HBASE-26412) Handle sink failure in RegionReplicationSink

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26412: -- Component/s: read replicas > Handle sink failure in RegionReplicationSink > --

[jira] [Created] (HBASE-26412) Handle sink failure in RegionReplicationSink

2021-11-01 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26412: - Summary: Handle sink failure in RegionReplicationSink Key: HBASE-26412 URL: https://issues.apache.org/jira/browse/HBASE-26412 Project: HBase Issue Type: Sub-task

[jira] [Created] (HBASE-26413) Limit the total size of buffered region replication entries

2021-11-01 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26413: - Summary: Limit the total size of buffered region replication entries Key: HBASE-26413 URL: https://issues.apache.org/jira/browse/HBASE-26413 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #3716: HBASE-26323 introduce a SnapshotProcedure

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3716: URL: https://github.com/apache/hbase/pull/3716#issuecomment-956327535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[GitHub] [hbase] Apache9 commented on pull request #3700: HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur…

2021-11-01 Thread GitBox
Apache9 commented on pull request #3700: URL: https://github.com/apache/hbase/pull/3700#issuecomment-956319958 Any progress here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (HBASE-26384) Segment already flushed to hfile may still be remained in CompactingMemStore

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26384: -- Fix Version/s: 2.4.9 3.0.0-alpha-2 2.5.0 Hadoop Flags: Revie

[GitHub] [hbase] Apache9 merged pull request #3779: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
Apache9 merged pull request #3779: URL: https://github.com/apache/hbase/pull/3779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [hbase] Apache9 merged pull request #3777: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
Apache9 merged pull request #3777: URL: https://github.com/apache/hbase/pull/3777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [hbase] Apache9 commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
Apache9 commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-956292652 > There is no method of InetSocketAddress return the colon concat result directly for unresolved address. Every usage of our tostring method should be reviewed if there could get

[GitHub] [hbase] Apache-HBase commented on pull request #3716: HBASE-26323 introduce a SnapshotProcedure

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3716: URL: https://github.com/apache/hbase/pull/3716#issuecomment-956274227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] Apache-HBase commented on pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3806: URL: https://github.com/apache/hbase/pull/3806#issuecomment-956265862 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s

[GitHub] [hbase] Apache-HBase commented on pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3806: URL: https://github.com/apache/hbase/pull/3806#issuecomment-956257657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436838#comment-17436838 ] Xiaolin Ha commented on HBASE-25905: So this problem offten occurs with WAL stuck is

[GitHub] [hbase] YutSean commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
YutSean commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-956222013 There is no method of InetSocketAddress return the colon concat result directly for unresolved address. Every usage of our tostring method should be reviewed if there could get un

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436820#comment-17436820 ] Xiaolin Ha commented on HBASE-25905: [~comnetwork] Thanks your reminder. You are rig

[jira] [Commented] (HBASE-26404) Update javadoc for CellUtil#createCell with tags methods.

2021-11-01 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436796#comment-17436796 ] Rushabh Shah commented on HBASE-26404: -- Thank you [~zhangduo] for the review and co

[GitHub] [hbase] Apache-HBase commented on pull request #3716: HBASE-26323 introduce a SnapshotProcedure

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3716: URL: https://github.com/apache/hbase/pull/3716#issuecomment-956186021 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei edited comment on HBASE-25905 at 11/1/21, 11:37 AM: -

[GitHub] [hbase] Apache-HBase commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-956159501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei edited comment on HBASE-25905 at 11/1/21, 11:31 AM: -

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei edited comment on HBASE-25905 at 11/1/21, 11:31 AM: -

[GitHub] [hbase] Apache-HBase commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-956155493 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei edited comment on HBASE-25905 at 11/1/21, 11:27 AM: -

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei edited comment on HBASE-25905 at 11/1/21, 11:27 AM: -

[jira] [Comment Edited] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei edited comment on HBASE-25905 at 11/1/21, 11:27 AM: -

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436769#comment-17436769 ] chenglei commented on HBASE-25905: -- [~Xiaolin Ha],I have some problem about your descri

[GitHub] [hbase] Apache9 commented on a change in pull request #3777: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
Apache9 commented on a change in pull request #3777: URL: https://github.com/apache/hbase/pull/3777#discussion_r740127643 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ## @@ -1921,6 +1922,225 @@ private void doWriteTestLargeCell

[GitHub] [hbase] Apache-HBase commented on pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3806: URL: https://github.com/apache/hbase/pull/3806#issuecomment-956128585 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30

[jira] [Commented] (HBASE-26411) Wal do not roll and write a big wal

2021-11-01 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436755#comment-17436755 ] Lijin Bin commented on HBASE-26411: --- Have not find out the reason. > Wal do not roll

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436754#comment-17436754 ] Xiaolin Ha commented on HBASE-25905: {code:java} 2021-11-01 10:08:58,771 WARN  [Asyn

[GitHub] [hbase] comnetwork commented on a change in pull request #3777: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
comnetwork commented on a change in pull request #3777: URL: https://github.com/apache/hbase/pull/3777#discussion_r740113588 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ## @@ -1921,6 +1922,225 @@ private void doWriteTestLargeC

[GitHub] [hbase] comnetwork commented on a change in pull request #3777: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
comnetwork commented on a change in pull request #3777: URL: https://github.com/apache/hbase/pull/3777#discussion_r740113588 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ## @@ -1921,6 +1922,225 @@ private void doWriteTestLargeC

[GitHub] [hbase] comnetwork commented on a change in pull request #3777: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
comnetwork commented on a change in pull request #3777: URL: https://github.com/apache/hbase/pull/3777#discussion_r740113588 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ## @@ -1921,6 +1922,225 @@ private void doWriteTestLargeC

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-956110817 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s

[GitHub] [hbase] Apache-HBase commented on pull request #3297: HBASE-25905 Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3297: URL: https://github.com/apache/hbase/pull/3297#issuecomment-956106783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s

[GitHub] [hbase] Apache9 commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
Apache9 commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-956097953 This maybe a big problem if Java17 changes the return value format of InetSocketAddress.toString. Does InetSockerAddress provide other method to get the colon concat result? We sh

[GitHub] [hbase] Apache-HBase commented on pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3806: URL: https://github.com/apache/hbase/pull/3806#issuecomment-956089390 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[jira] [Commented] (HBASE-26411) Wal do not roll and write a big wal

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436722#comment-17436722 ] Duo Zhang commented on HBASE-26411: --- OK, so first, in AsyncFSWAL.syncCompleted, beside

[GitHub] [hbase] Apache-HBase commented on pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3809: URL: https://github.com/apache/hbase/pull/3809#issuecomment-956080041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9

[jira] [Updated] (HBASE-26411) Wal do not roll and write a big wal

2021-11-01 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-26411: -- Summary: Wal do not roll and write a big wal (was: Wal do not roll and write a bit wal ) > Wal do n

[jira] [Created] (HBASE-26411) Wal do not roll and write a bit wal

2021-11-01 Thread Lijin Bin (Jira)
Lijin Bin created HBASE-26411: - Summary: Wal do not roll and write a bit wal Key: HBASE-26411 URL: https://issues.apache.org/jira/browse/HBASE-26411 Project: HBase Issue Type: Bug Affects Ve

[GitHub] [hbase] Apache-HBase commented on pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache-HBase commented on pull request #3806: URL: https://github.com/apache/hbase/pull/3806#issuecomment-956068994 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1

[GitHub] [hbase] Apache9 commented on a change in pull request #3777: HBASE-26384 Segment already flushed to hfile may still be remained in…

2021-11-01 Thread GitBox
Apache9 commented on a change in pull request #3777: URL: https://github.com/apache/hbase/pull/3777#discussion_r740062652 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java ## @@ -1921,6 +1922,225 @@ private void doWriteTestLargeCell

[GitHub] [hbase] Apache9 commented on pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache9 commented on pull request #3806: URL: https://github.com/apache/hbase/pull/3806#issuecomment-956054104 Please fix the checkstyle issue before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [hbase] Apache9 commented on a change in pull request #3806: HBASE-26406 Can not add peer replicating to non-HBase

2021-11-01 Thread GitBox
Apache9 commented on a change in pull request #3806: URL: https://github.com/apache/hbase/pull/3806#discussion_r740047961 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -358,13 +358,13 @@ private void check

[GitHub] [hbase-connectors] YutSean commented on pull request #86: HBASE-26354 [hbase-connectors] Added python client for HBase thrift service

2021-11-01 Thread GitBox
YutSean commented on pull request #86: URL: https://github.com/apache/hbase-connectors/pull/86#issuecomment-956044537 Any other comments on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436701#comment-17436701 ] Duo Zhang commented on HBASE-25905: --- In waitForSafePoint, after setting waitingRoll, w

[jira] [Commented] (HBASE-26047) [JDK17] Track JDK17 unit test failures

2021-11-01 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436698#comment-17436698 ] Yutong Xiao commented on HBASE-26047: - [~huaxiangsun] I fixed another UT failure [H

[GitHub] [hbase] YutSean opened a new pull request #3809: HBASE-26410 Fix HBase TestCanaryTool for Java17

2021-11-01 Thread GitBox
YutSean opened a new pull request #3809: URL: https://github.com/apache/hbase/pull/3809 https://issues.apache.org/jira/browse/HBASE-26410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Updated] (HBASE-26410) Fix HBase TestCanaryTool for Java17

2021-11-01 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26410: Attachment: InetSocketAccessHolder.tostring() in Java17.png > Fix HBase TestCanaryTool for Java17

[jira] [Commented] (HBASE-26410) Fix HBase TestCanaryTool for Java17

2021-11-01 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436681#comment-17436681 ] Yutong Xiao commented on HBASE-26410: - The reason is the method tostring of InetSock

[jira] [Created] (HBASE-26410) Fix HBase TestCanaryTool for Java17

2021-11-01 Thread Yutong Xiao (Jira)
Yutong Xiao created HBASE-26410: --- Summary: Fix HBase TestCanaryTool for Java17 Key: HBASE-26410 URL: https://issues.apache.org/jira/browse/HBASE-26410 Project: HBase Issue Type: Bug

[jira] [Updated] (HBASE-25905) Shutdown of WAL stuck at waitForSafePoint

2021-11-01 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25905: --- Description: We use the fan-out HDFS OutputStream and AsyncFSWAL on our clusters, but met the probl

  1   2   >