Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1801264855
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1386145595
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -104,6 +108,55 @@ protected void
GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1386129802
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -2763,6 +2763,13 @@ protected String getDescription() {
private long
[
https://issues.apache.org/jira/browse/HBASE-28184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783899#comment-17783899
]
Hudson commented on HBASE-28184:
Results for branch branch-2
[build #920 on
Apache-HBase commented on PR #5486:
URL: https://github.com/apache/hbase/pull/5486#issuecomment-1801202940
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5486:
URL: https://github.com/apache/hbase/pull/5486#issuecomment-1801197194
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
GeorryHuang commented on PR #2924:
URL: https://github.com/apache/hbase/pull/2924#issuecomment-1801177818
> We are good to go?
Yes, I am going to merge it into the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1801133980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1801108114
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #5469:
URL: https://github.com/apache/hbase/pull/5469#issuecomment-1801082162
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
[
https://issues.apache.org/jira/browse/HBASE-28184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783883#comment-17783883
]
Hudson commented on HBASE-28184:
Results for branch branch-2.4
[build #648 on
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1801055324
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5486:
URL: https://github.com/apache/hbase/pull/5486#issuecomment-1800953088
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache9 commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1385915285
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -94,8 +94,9 @@ private void checkObsoleteConfigurations() {
}
}
-
Apache-HBase commented on PR #5469:
URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800947059
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache9 commented on code in PR #5506:
URL: https://github.com/apache/hbase/pull/5506#discussion_r1385891214
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java:
##
@@ -77,16 +81,49 @@ public void cacheBlock(BlockCacheKey cacheKey, Cacheable
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1800910898
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800883383
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1800879769
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
charlesconnell commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800851233
Looking for a solution to cleanly support the various uses of
MobFileCleanerChore in test code, I gave it a constructor that takes an Admin
directly.
--
This is an automated
Apache-HBase commented on PR #5469:
URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800408637
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800331863
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 10s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800328948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800323334
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800295253
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5469:
URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800291991
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
Apache-HBase commented on PR #5469:
URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800291723
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
Apache-HBase commented on PR #5469:
URL: https://github.com/apache/hbase/pull/5469#issuecomment-1800291113
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1800288607
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #5373:
URL: https://github.com/apache/hbase/pull/5373#issuecomment-1800276633
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
bbeaudreault commented on PR #5488:
URL: https://github.com/apache/hbase/pull/5488#issuecomment-1800247752
I deployed this to one of our prod servers, which is an extreme case that
typically spends about 12% of time deserializing Filters. With the patch, it
spends less than 5% time now.
jbewing commented on code in PR #5373:
URL: https://github.com/apache/hbase/pull/5373#discussion_r1385605592
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java:
##
@@ -486,52 +500,171 @@ public boolean shouldUseScanner(Scan scan, HStore
[
https://issues.apache.org/jira/browse/HBASE-28184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rushabh Shah resolved HBASE-28184.
--
Resolution: Fixed
> Tailing the WAL is very slow if there are multiple peers.
>
[
https://issues.apache.org/jira/browse/HBASE-28184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783777#comment-17783777
]
Rushabh Shah commented on HBASE-28184:
--
Committed the change to branch-2.4. branch-2.5, branch-2,
[
https://issues.apache.org/jira/browse/HBASE-28184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rushabh Shah updated HBASE-28184:
-
Fix Version/s: 2.6.0
2.4.18
3.0.0-beta-1
bbeaudreault commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1385476662
##
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##
@@ -92,10 +92,6 @@ private void checkObsoleteConfigurations() {
}
}
Apache-HBase commented on PR #5087:
URL: https://github.com/apache/hbase/pull/5087#issuecomment-1799674962
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
jbewing commented on code in PR #5373:
URL: https://github.com/apache/hbase/pull/5373#discussion_r1385442557
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java:
##
@@ -486,52 +500,171 @@ public boolean shouldUseScanner(Scan scan, HStore
bbeaudreault commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1799650213
Also please fix checkstyle and spotless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on PR #5087:
URL: https://github.com/apache/hbase/pull/5087#issuecomment-1799602409
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5509:
URL: https://github.com/apache/hbase/pull/5509#issuecomment-1799581402
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5508:
URL: https://github.com/apache/hbase/pull/5508#issuecomment-1799538716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
[
https://issues.apache.org/jira/browse/HBASE-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783745#comment-17783745
]
Charles Connell commented on HBASE-24687:
-
I've written a new PR that is a simple one-liner fix
Apache-HBase commented on PR #5508:
URL: https://github.com/apache/hbase/pull/5508#issuecomment-1799503614
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
shahrs87 merged PR #5505:
URL: https://github.com/apache/hbase/pull/5505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shahrs87 merged PR #5504:
URL: https://github.com/apache/hbase/pull/5504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shahrs87 commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1799422621
```
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running
bbeaudreault commented on code in PR #5373:
URL: https://github.com/apache/hbase/pull/5373#discussion_r1385321321
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java:
##
@@ -486,52 +500,171 @@ public boolean shouldUseScanner(Scan scan,
shahrs87 merged PR #5503:
URL: https://github.com/apache/hbase/pull/5503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5444:
URL: https://github.com/apache/hbase/pull/5444#issuecomment-1799073878
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5444:
URL: https://github.com/apache/hbase/pull/5444#issuecomment-1799066778
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5506:
URL: https://github.com/apache/hbase/pull/5506#issuecomment-1799066206
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5506:
URL: https://github.com/apache/hbase/pull/5506#issuecomment-1799064024
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5444:
URL: https://github.com/apache/hbase/pull/5444#issuecomment-1799049095
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
petersomogyi commented on code in PR #5506:
URL: https://github.com/apache/hbase/pull/5506#discussion_r1385174911
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java:
##
@@ -77,16 +81,49 @@ public void cacheBlock(BlockCacheKey cacheKey,
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798965898
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
charlesconnell commented on code in PR #5444:
URL: https://github.com/apache/hbase/pull/5444#discussion_r1385133672
##
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##
@@ -219,17 +219,17 @@ static String[] getDefaultCipherSuites(boolean
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798936396
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5087:
URL: https://github.com/apache/hbase/pull/5087#issuecomment-1798862679
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5508:
URL: https://github.com/apache/hbase/pull/5508#issuecomment-1798794286
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
guluo2016 opened a new pull request, #5508:
URL: https://github.com/apache/hbase/pull/5508
Deatils see :
[HBASE-28191](https://issues.apache.org/jira/browse/HBASE-28191)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/HBASE-28191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
guluo updated HBASE-28191:
--
Description:
Reproduction Steps:
1. We create a new table with many regions , for example:
{code:java}
guluo created HBASE-28191:
-
Summary: Meta browser can happen NPE when the server or target
server of region is null
Key: HBASE-28191
URL: https://issues.apache.org/jira/browse/HBASE-28191
Project: HBase
Apache-HBase commented on PR #5506:
URL: https://github.com/apache/hbase/pull/5506#issuecomment-1798418203
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
bbeaudreault commented on code in PR #5488:
URL: https://github.com/apache/hbase/pull/5488#discussion_r1384840873
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {
bbeaudreault commented on code in PR #5488:
URL: https://github.com/apache/hbase/pull/5488#discussion_r1384836073
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {
bbeaudreault commented on code in PR #5488:
URL: https://github.com/apache/hbase/pull/5488#discussion_r1384834533
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798388115
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798339218
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798332194
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
ndimiduk commented on code in PR #5488:
URL: https://github.com/apache/hbase/pull/5488#discussion_r1384678667
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1798001038
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
72 matches
Mail list logo
