Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2024-01-06 Thread via GitHub
chaijunjie0101 commented on PR #5502: URL: https://github.com/apache/hbase/pull/5502#issuecomment-1879984954 @bbeaudreault thanks for suggestting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5606: URL: https://github.com/apache/hbase/pull/5606#issuecomment-1879980295 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker

[jira] [Commented] (HBASE-28277) Move minimum hadoop 3 support to 3.3.x for 2.6+

2024-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803912#comment-17803912 ] Hudson commented on HBASE-28277: Results for branch branch-2 [build #956 on bui

[jira] [Commented] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc

2024-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803911#comment-17803911 ] Hudson commented on HBASE-28290: Results for branch branch-2 [build #956 on bui

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1879969711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker

[jira] [Commented] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc

2024-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803907#comment-17803907 ] Hudson commented on HBASE-28290: Results for branch branch-2.4 [build #676 on b

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1879929098 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5606: URL: https://github.com/apache/hbase/pull/5606#issuecomment-1879926144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

[jira] [Commented] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc

2024-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803895#comment-17803895 ] Hudson commented on HBASE-28290: Results for branch branch-2.6 [build #23 on bu

[jira] [Commented] (HBASE-28277) Move minimum hadoop 3 support to 3.3.x for 2.6+

2024-01-06 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803896#comment-17803896 ] Hudson commented on HBASE-28277: Results for branch branch-2.6 [build #23 on bu

Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1879917971 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1879917934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docke

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1879880093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1443871250 ## hbase-assembly/src/main/assembly/client.xml: ## @@ -67,6 +67,13 @@ io.opentelemetry.javaagent:* org.hamcrest:hamcrest-core

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1443871250 ## hbase-assembly/src/main/assembly/client.xml: ## @@ -67,6 +67,13 @@ io.opentelemetry.javaagent:* org.hamcrest:hamcrest-core

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1443871152 ## pom.xml: ## @@ -844,8 +844,7 @@ 2.3.1 3.1.0 2.1.1 -2.3.2 -3.0.1-b08 +9.0.84 Review Comment: Chose based on https://tomcat.apache.org/w

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1879868244 Built code locally, generated assembly, untarred assembly, started local hbase instance. Tested Master/RS Web UI, works fine. TODO: Need to test REST and Thrift web interfaces. Also nee

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Status: Patch Available (was: In Progress) > Replace javax.servlet.jsp dependency with tomcat-jasp

Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1879867485 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 13s | Docker

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1879848900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443797575 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443797575 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]

2024-01-06 Thread via GitHub
virajjasani commented on code in PR #5603: URL: https://github.com/apache/hbase/pull/5603#discussion_r1443865810 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java: ## @@ -129,6 +132,8 @@ public TakeSnapshotHandler(SnapshotDescription

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443865420 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]

2024-01-06 Thread via GitHub
virajjasani commented on code in PR #5603: URL: https://github.com/apache/hbase/pull/5603#discussion_r1443865243 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java: ## @@ -147,12 +152,16 @@ private TableDescriptor loadTableDescriptor()

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443865109 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443865109 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]

2024-01-06 Thread via GitHub
virajjasani commented on code in PR #5603: URL: https://github.com/apache/hbase/pull/5603#discussion_r1443864755 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java: ## @@ -147,12 +152,16 @@ private TableDescriptor loadTableDescriptor()

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443864302 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443862186 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443862186 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443862041 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443860238 ## hbase-common/src/main/resources/hbase-default.xml: ## @@ -1631,6 +1631,24 @@ possible configurations would overwhelm and obscure the important. Possible valu

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443853210 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.prot

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443855136 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.prot

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1879826428 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443854578 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java: ## @@ -152,6 +152,9 @@ public class HttpServer implements FilterContainer { "hbase.security

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443854516 ## hbase-common/src/main/resources/hbase-default.xml: ## @@ -1631,6 +1631,24 @@ possible configurations would overwhelm and obscure the important. Possible values

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443853902 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java: ## @@ -850,8 +853,13 @@ protected void addDefaultServlets(ContextHandlerCollection contexts, Co

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443853210 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.prot

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
eubnara commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443851880 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java: ## @@ -1129,7 +1137,7 @@ public void setThreads(int min, int max) { private void initSpnego(C

Re: [PR] HBASE-18999 Shell support for multiple columns for DML commands [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5585: URL: https://github.com/apache/hbase/pull/5585#issuecomment-1879772165 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-18999 Shell support for multiple columns for DML commands [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5585: URL: https://github.com/apache/hbase/pull/5585#issuecomment-1879771921 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443816313 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileWriter.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-18999 Shell support for multiple columns for DML commands [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5585: URL: https://github.com/apache/hbase/pull/5585#issuecomment-1879770587 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

[jira] [Work started] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28070 started by Nihal Jain. -- > Replace javax.servlet.jsp dependency with tomcat-jasper > --

Re: [PR] HBASE-18999 Shell support for multiple columns for DML commands [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on PR #5585: URL: https://github.com/apache/hbase/pull/5585#issuecomment-1879766814 Pushed local changes, still not ready, will do a little more self review and testing. Will take up later. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803845#comment-17803845 ] Nihal Jain commented on HBASE-28070: Will close HBASE-27817, if this aproach is appr

[jira] [Comment Edited] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803845#comment-17803845 ] Nihal Jain edited comment on HBASE-28070 at 1/6/24 5:45 PM:

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Component/s: security UI > Replace javax.servlet.jsp dependency with tomcat-jasper

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Description: *Problem Statement* HBase has to explicitly depends on org.glassfish:javax.el:jar:3.0.

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Description: *Problem Statement* HBase has to explicitly depends on org.glassfish:javax.el:jar:3.0.

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Description: HBase has to explicitly depends on org.glassfish:javax.el:jar:3.0.1-b08 as this depend

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Description: HBase has to explicitly depends on org.glassfish:javax.el:jar:3.0.1-b08 as this depend

[jira] [Updated] (HBASE-28070) Replace javax.servlet.jsp dependency with tomcat-jasper

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28070: --- Summary: Replace javax.servlet.jsp dependency with tomcat-jasper (was: CVE-2020-15250 in org.glass

[jira] [Commented] (HBASE-28070) CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803840#comment-17803840 ] Nihal Jain commented on HBASE-28070: I plan to work on this. Assigning myself! > CV

[jira] [Assigned] (HBASE-28070) CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08

2024-01-06 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain reassigned HBASE-28070: -- Assignee: Nihal Jain > CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08 >

Re: [PR] HBASE-28242: Adapts ProfileServlet for async-profiler 2.x [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5566: URL: https://github.com/apache/hbase/pull/5566#issuecomment-1879755335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443800969 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443800969 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443800969 ## src/main/asciidoc/_chapters/hbase-default.adoc: ## @@ -1949,6 +1949,34 @@ If the DFSClient configuration `simple` +[[hbase.security.authentication.ui.metrics.pr

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on code in PR #5606: URL: https://github.com/apache/hbase/pull/5606#discussion_r1443793663 ## hbase-common/src/main/resources/hbase-default.xml: ## @@ -1631,6 +1631,24 @@ possible configurations would overwhelm and obscure the important. Possible valu

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
NihalJain commented on PR #5606: URL: https://github.com/apache/hbase/pull/5606#issuecomment-1879750768 Hi @eubnara Welcome and thank you for your first PR in Apache HBase.Please have a look at the review comments and please let me know if you need any support. -- This is an automated m

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1879744838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1879742301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2024-01-06 Thread via GitHub
chaijunjie0101 commented on PR #5502: URL: https://github.com/apache/hbase/pull/5502#issuecomment-1879734415 > Ping @chaijunjie0101 i am so sorry, i forget it... i will fix it as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1879666334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5606: URL: https://github.com/apache/hbase/pull/5606#issuecomment-1879650991 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-1879650845 > I think the PR still needs a lot of polishing... > > A lot of changes seems unrelated, and the new flag does not work for mob and stripe compaction? At least we should discuss thi

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443692228 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -41,7 +45,7 @@ * Default implementation of StoreFileManager. No

Re: [PR] HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… [hbase]

2024-01-06 Thread via GitHub
Apache9 commented on PR #5502: URL: https://github.com/apache/hbase/pull/5502#issuecomment-1879637956 Ping @chaijunjie0101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443690909 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */ @Restrict

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2024-01-06 Thread via GitHub
Apache9 commented on code in PR #5589: URL: https://github.com/apache/hbase/pull/5589#discussion_r1443690388 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java: ## @@ -125,6 +125,21 @@ public StripeCompactionRequest select

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443689986 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFileManager.java: ## @@ -300,7 +300,7 @@ private double getMidStripeSplitRatio(long smalle

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443688028 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java: ## @@ -17,42 +17,45 @@ */ package org.apache.hadoop.hbase.regio

Re: [PR] HBASE-28294 Support to skip Kerberos authentication for metric endpoints [hbase]

2024-01-06 Thread via GitHub
Apache-HBase commented on PR #5606: URL: https://github.com/apache/hbase/pull/5606#issuecomment-1879633098 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443685793 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java: ## @@ -17,42 +17,45 @@ */ package org.apache.hadoop.hbase.regio

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443676077 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java: ## @@ -464,7 +464,6 @@ protected boolean performCompaction(FileDetails fd

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443673538 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DualFileWriter.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-01-06 Thread via GitHub
Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1443671033 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java: ## @@ -464,7 +464,6 @@ protected boolean performCompaction(FileDetails fd,

Re: [PR] HBASE-28287 Fix the inaccurate expired time of MOB HFiles [hbase]

2024-01-06 Thread via GitHub
Apache9 commented on code in PR #5599: URL: https://github.com/apache/hbase/pull/5599#discussion_r1443670031 ## hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestExpiredMobFileCleaner.java: ## @@ -140,7 +140,8 @@ public void testCleaner() throws Exception { assertE

[jira] [Resolved] (HBASE-28277) Move minimum hadoop 3 support to 3.3.x for 2.6+

2024-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28277. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Hadoop Flags: Reviewed Release Note: T

[jira] [Resolved] (HBASE-28290) Add 'TM' superscript to the index page title when generating javadoc

2024-01-06 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28290. --- Fix Version/s: 2.6.0 2.4.18 2.5.8 3.0.0-beta

Re: [PR] HBASE-28277 Move minimum hadoop 3 support to 3.3.x for 2.6+ [hbase]

2024-01-06 Thread via GitHub
Apache9 merged PR #5598: URL: https://github.com/apache/hbase/pull/5598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

Re: [PR] HBASE-28290 Addendum use 'Test API' for test javadoc [hbase]

2024-01-06 Thread via GitHub
Apache9 merged PR #5602: URL: https://github.com/apache/hbase/pull/5602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.