[
https://issues.apache.org/jira/browse/HBASE-21755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749002#comment-16749002
]
Zach York commented on HBASE-21755:
---
Things like this tend to creep up because new features are added
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1671#comment-1671
]
Zach York commented on HBASE-21070:
---
I fixed the checkstyle issue locally.
> SnapshotFileCache won't
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21070:
--
Attachment: HBASE-21070.master.003.patch
> SnapshotFileCache won't update for snapshots stored in S3
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744240#comment-16744240
]
Zach York commented on HBASE-21070:
---
[~liuml07] Sorry for the long, long silence. I got busy with
[
https://issues.apache.org/jira/browse/HBASE-21544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710579#comment-16710579
]
Zach York commented on HBASE-21544:
---
Good by me. Feel free to push.
> Backport HBASE-20734 Colocate
[
https://issues.apache.org/jira/browse/HBASE-21544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709375#comment-16709375
]
Zach York commented on HBASE-21544:
---
I'll try to review today.
> Backport HBASE-20734 Colocate
[
https://issues.apache.org/jira/browse/HBASE-21544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707642#comment-16707642
]
Zach York edited comment on HBASE-21544 at 12/3/18 6:43 PM:
[~elserj] are
[
https://issues.apache.org/jira/browse/HBASE-21544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707642#comment-16707642
]
Zach York commented on HBASE-21544:
---
[~elserj] are you guys storing the WAL on HDFS? In that case, I
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Fix Version/s: 1.5.0
> Improve Snapshot Performance with Temporary Snapshot Directory when rootDir
>
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Improve Snapshot Performance
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648242#comment-16648242
]
Zach York commented on HBASE-21098:
---
I manually ran xmllint and it returned successfully. I will
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642573#comment-16642573
]
Zach York commented on HBASE-21098:
---
[~apurtell] Any idea on the xml parsing error:
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640478#comment-16640478
]
Zach York commented on HBASE-21070:
---
I was basically working on fixing the test as
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Attachment: HBASE-21098.branch-1.002.patch
> Improve Snapshot Performance with Temporary Snapshot
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640217#comment-16640217
]
Zach York commented on HBASE-21098:
---
[~apurtell] It should be assigned to Tyler, he did the vast
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639048#comment-16639048
]
Zach York commented on HBASE-21098:
---
I needed to change a bit of code for branch-1 for it to pass
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Attachment: HBASE-21098.branch-1.001.patch
> Improve Snapshot Performance with Temporary Snapshot
[
https://issues.apache.org/jira/browse/HBASE-21257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21257:
--
Status: Patch Available (was: Reopened)
> misspelled words.[occured -> occurred]
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Release Note: Previously the recovered.edits directory was under the root
directory. This JIRA moves
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628832#comment-16628832
]
Zach York commented on HBASE-20734:
---
Thanks [~reidchan]! Sorry this had drifted off my radar before I
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Release Note: HBASE-20723 moved the recovered.edits directory to be under
the root directory. This
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620581#comment-16620581
]
Zach York commented on HBASE-20734:
---
Thanks [~reidchan]!
What is the next step here? Are we still
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.branch-1.005.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618256#comment-16618256
]
Zach York commented on HBASE-20734:
---
[~apurtell] I have updated the patch for branch-1, can you take a
[
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618062#comment-16618062
]
Zach York commented on HBASE-20952:
---
{quote}That's exactly I wanted to say. There are some cases where
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614219#comment-16614219
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] any further thoughts?
> Colocate
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614180#comment-16614180
]
Zach York commented on HBASE-21098:
---
Pushed to branch-2 and master. Wrangling a test before pushing it
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Fix Version/s: 2.2.0
3.0.0
> Improve Snapshot Performance with Temporary Snapshot
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614121#comment-16614121
]
Zach York commented on HBASE-20734:
---
Oh weird, I didn't notice the indenting... I'll remove this.
>
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611372#comment-16611372
]
Zach York commented on HBASE-21098:
---
Starting to commit to master, branch-2, and (hopefully) branch-1
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.012.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.branch-1.004.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609930#comment-16609930
]
Zach York commented on HBASE-21098:
---
[~apurtell] I'll see how difficult the port is, Tyler mentioned
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609922#comment-16609922
]
Zach York commented on HBASE-21098:
---
Sorry for missing your earlier +1 Mingliang!
I'll be pushing
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.011.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609851#comment-16609851
]
Zach York commented on HBASE-20734:
---
[~reidchan] Thanks for the review, sorry I'm slow updating.
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609644#comment-16609644
]
Zach York commented on HBASE-21098:
---
Anybody have any further comments? [~liuml07]
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605070#comment-16605070
]
Zach York commented on HBASE-21070:
---
Sorry for being a little absent on this over the past couple
[
https://issues.apache.org/jira/browse/HBASE-20226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605053#comment-16605053
]
Zach York commented on HBASE-20226:
---
This is related to the work going on in HBASE-21098. It's likely
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605048#comment-16605048
]
Zach York commented on HBASE-20734:
---
That'd be great, thanks [~reidchan]!
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-21154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605043#comment-16605043
]
Zach York commented on HBASE-21154:
---
I have a small concern (not with the actual change, but with the
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603537#comment-16603537
]
Zach York commented on HBASE-20734:
---
Regarding Ted's call for more reviewers, Andrew already reviewed,
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599345#comment-16599345
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] any more comments? Latest diff is up.
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.010.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595745#comment-16595745
]
Zach York commented on HBASE-21070:
---
Good catch on readLock, missed removing that.
The volatile
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.009.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595644#comment-16595644
]
Zach York commented on HBASE-20734:
---
Also FYI [~apurtell], the branch-1 patch contains the backwards
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.branch-1.003.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.008.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595631#comment-16595631
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] Thanks for the review. I'll change those
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.007.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.branch-1.002.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594323#comment-16594323
]
Zach York commented on HBASE-20734:
---
[~yuzhih...@gmail.com] did you have any comments on the master
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594319#comment-16594319
]
Zach York commented on HBASE-20734:
---
Attached a rebased patch since the checkstyle didn't seem related
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.006.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.005.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594275#comment-16594275
]
Zach York commented on HBASE-21070:
---
patch 2 adds additionally logging suggested by [~stack].
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21070:
--
Attachment: HBASE-21070.master.002.patch
> SnapshotFileCache won't update for snapshots stored in S3
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594259#comment-16594259
]
Zach York commented on HBASE-21098:
---
+1 LGTM.
> Improve Snapshot Performance with Temporary Snapshot
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592056#comment-16592056
]
Zach York commented on HBASE-20734:
---
I haven't updated the branch-1 patch for that yet, I was waiting
[
https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592041#comment-16592041
]
Zach York commented on HBASE-18840:
---
I think either of these could potentially work. But yes, the main
[
https://issues.apache.org/jira/browse/HBASE-20429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592008#comment-16592008
]
Zach York commented on HBASE-20429:
---
If you're interested in HBASE-20723, you could also apply/review
[
https://issues.apache.org/jira/browse/HBASE-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591995#comment-16591995
]
Zach York commented on HBASE-18860:
---
Makes sense to me. It seemed like a waste to create a whole new
[
https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591989#comment-16591989
]
Zach York commented on HBASE-18840:
---
I'm okay with having it interact with HBCK, but this patch only
[
https://issues.apache.org/jira/browse/HBASE-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591979#comment-16591979
]
Zach York commented on HBASE-18477:
---
We can turn off nightly tests, definitely! Saves me an email
[
https://issues.apache.org/jira/browse/HBASE-20429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591970#comment-16591970
]
Zach York commented on HBASE-20429:
---
[~apurtell] Makes sense. We'll tackle FS redo in a separate JIRA.
[
https://issues.apache.org/jira/browse/HBASE-20429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589911#comment-16589911
]
Zach York commented on HBASE-20429:
---
Anyone interested in this want to review two related S3 related
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Affects Version/s: 2.1.0
> HBase on S3 Snapshot Performance Increase
>
[
https://issues.apache.org/jira/browse/HBASE-21098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21098:
--
Priority: Major (was: Minor)
> HBase on S3 Snapshot Performance Increase
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586538#comment-16586538
]
Zach York commented on HBASE-21070:
---
All these tests pass locally.
> SnapshotFileCache won't update
[
https://issues.apache.org/jira/browse/HBASE-20429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584616#comment-16584616
]
Zach York commented on HBASE-20429:
---
I was planning to starting work on some of this in a little bit,
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.004.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584509#comment-16584509
]
Zach York commented on HBASE-20734:
---
Latest patch fixes the tests.
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21070:
--
Status: Patch Available (was: Open)
> SnapshotFileCache won't update for snapshots stored in S3
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-21070:
--
Attachment: HBASE-21070.master.001.patch
> SnapshotFileCache won't update for snapshots stored in S3
Zach York created HBASE-21070:
-
Summary: SnapshotFileCache won't update for snapshots stored in S3
Key: HBASE-21070
URL: https://issues.apache.org/jira/browse/HBASE-21070
Project: HBase
Issue
[
https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584434#comment-16584434
]
Zach York commented on HBASE-20723:
---
[~jerrychabot] that commit doesn't appear in Apache HBase 1.3.1
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584280#comment-16584280
]
Zach York commented on HBASE-20734:
---
New patch fixes TestHeapSize
> Colocate recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.003.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583205#comment-16583205
]
Zach York commented on HBASE-20734:
---
Got it now, RB up!
> Colocate recovered edits directory with
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.002.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583202#comment-16583202
]
Zach York commented on HBASE-20734:
---
Apparently I lost my reviewboard password... let me try to
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20734:
--
Attachment: HBASE-20734.master.001.patch
> Colocate recovered edits directory with hbase.wal.dir
>
[
https://issues.apache.org/jira/browse/HBASE-21060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581486#comment-16581486
]
Zach York commented on HBASE-21060:
---
I personally don't need HBASE-17861 in branch-1.3 or branch-1.2,
[
https://issues.apache.org/jira/browse/HBASE-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581481#comment-16581481
]
Zach York commented on HBASE-18477:
---
[~busbey] ping - Are you still interested or should I try to look
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575480#comment-16575480
]
Zach York commented on HBASE-20734:
---
Finally have some time to work on this again. I guess a single
[
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575422#comment-16575422
]
Zach York commented on HBASE-20952:
---
{quote}What do we need in terms of durability guarantees? Is
[
https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568906#comment-16568906
]
Zach York commented on HBASE-20952:
---
So taking a very rough stab at this based on a few thoughts, but
[
https://issues.apache.org/jira/browse/HBASE-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568740#comment-16568740
]
Zach York commented on HBASE-18477:
---
[~busbey] Any chance you can review again when you get the
[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567433#comment-16567433
]
Zach York commented on HBASE-20856:
---
[~reidchan] In the how to close Github PRs, it suggests that
[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566480#comment-16566480
]
Zach York commented on HBASE-20856:
---
[~reidchan] I asked [~taklwu] to use PRs to review his code as,
[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach York updated HBASE-20856:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> PITA having to set WAL provider
[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566047#comment-16566047
]
Zach York commented on HBASE-20856:
---
Resolving. Anyone know why I don't see an option to be able to
[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566046#comment-16566046
]
Zach York commented on HBASE-20856:
---
Pushed to master, branch-2, branch-2.1, and branch-2.0.
> PITA
[
https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565765#comment-16565765
]
Zach York commented on HBASE-20856:
---
Sure, I'll commit now.
> PITA having to set WAL provider in two
[
https://issues.apache.org/jira/browse/HBASE-20989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565742#comment-16565742
]
Zach York commented on HBASE-20989:
---
+1
> Minor, miscellaneous logging fixes
>
[
https://issues.apache.org/jira/browse/HBASE-20989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564376#comment-16564376
]
Zach York commented on HBASE-20989:
---
Some minor comments left in RB
> Minor, miscellaneous logging
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559368#comment-16559368
]
Zach York commented on HBASE-20734:
---
{quote}I don't seem to find the code where, if recovered edits
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559009#comment-16559009
]
Zach York commented on HBASE-20734:
---
PR [https://github.com/apache/hbase/pull/86] contains the master
[
https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558921#comment-16558921
]
Zach York commented on HBASE-20734:
---
Sorry it took so long to get the master patch up. I'll be
101 - 200 of 729 matches
Mail list logo