Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-10 Thread via GitHub
bbeaudreault merged PR #5488: URL: https://github.com/apache/hbase/pull/5488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804838158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804823842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804509255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804373350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804361882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
bbeaudreault commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804131667 I think this is ready for merge, if anyone has any other feedback since the move to on-demand loading. Note I decided to use a ConcurrentHashMap rather than LoadingCache or

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384834533 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-09 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1804022713 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1803315656 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1803308936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1803141538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1803106984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1803101440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1802933206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-08 Thread via GitHub
bbeaudreault commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1802853945 I just pushed a commit which populates the cache on-demand, negating the need for any classpath traversal. I used our ConcurrentMapUtils.computeIfAbsent, which does a get followed by

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1800247752 I deployed this to one of our prod servers, which is an extreme case that typically spends about 12% of time deserializing Filters. With the patch, it spends less than 5% time now.

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384840873 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384836073 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -304,6 +305,24 @@ public static boolean isClassLoaderLoaded() {

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384834533 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-07 Thread via GitHub
ndimiduk commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1384678667 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java: ## @@ -1552,13 +1571,23 @@ public static ComparatorProtos.Comparator

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1796230994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1795951506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1795096884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1383408208 ## hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestComparatorSerialization.java: ## @@ -99,4 +129,51 @@ public void testBigDecimalComparator() throws

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1383396372 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReflectedFunctionCache.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1383390765 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReflectionUtils.java: ## @@ -208,6 +214,30 @@ private static String getTaskName(long id, String name) {

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
bbeaudreault commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1383374974 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReflectedFunctionCache.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-06 Thread via GitHub
Apache9 commented on code in PR #5488: URL: https://github.com/apache/hbase/pull/5488#discussion_r1383316307 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReflectedFunctionCache.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
bbeaudreault commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1789873864 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1789834308 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1789832158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1789588375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1789501357 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1789343536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-11-01 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1788978133 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-10-31 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1788306327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-10-31 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1788304130 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-10-31 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1788152431 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-10-31 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1788104930 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-10-31 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1788102656 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-27276 Reduce reflection overhead in Filter deserialization [hbase]

2023-10-31 Thread via GitHub
Apache-HBase commented on PR #5488: URL: https://github.com/apache/hbase/pull/5488#issuecomment-1787778601 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |