[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574258#comment-15574258
]
Duo Zhang commented on HBASE-16835:
---
Paste the comments on rb here.
{quote}
Michael St
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574259#comment-15574259
]
Duo Zhang commented on HBASE-16835:
---
{quote}
Michael Stack
We have to do the watcher? I
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574261#comment-15574261
]
Duo Zhang commented on HBASE-16835:
---
{quote}
enis
Why do we need curator here rather th
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574267#comment-15574267
]
Duo Zhang commented on HBASE-16835:
---
[~stack] [~enis] FYI.
> Revisit the zookeeper usa
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576989#comment-15576989
]
stack commented on HBASE-16835:
---
I like the description. Says it well.
> Revisit the zooke
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578021#comment-15578021
]
Duo Zhang commented on HBASE-16835:
---
As I said in HBASE-15921, I always use watcher tog
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578087#comment-15578087
]
Duo Zhang commented on HBASE-16835:
---
{code:title=ClusterRegistry.java}
interface Cluste
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578401#comment-15578401
]
stack commented on HBASE-16835:
---
Thanks for doing this writeup [~Apache9]
Agree that getCl
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579875#comment-15579875
]
Duo Zhang commented on HBASE-16835:
---
{quote}
Could we add the web ui port and other vi
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579893#comment-15579893
]
Duo Zhang commented on HBASE-16835:
---
Will come back when I finish the async scan since
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580409#comment-15580409
]
stack commented on HBASE-16835:
---
bq. Yeah but I think we still need to fetch the root regio
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607773#comment-15607773
]
Hadoop QA commented on HBASE-16835:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608064#comment-15608064
]
Hadoop QA commented on HBASE-16835:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608307#comment-15608307
]
Duo Zhang commented on HBASE-16835:
---
[~stack] The patch you committed in hbase-15789 mi
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608868#comment-15608868
]
Anoop Sam John commented on HBASE-16835:
bq.hbase-protocol-shaded/src/main/patche
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609758#comment-15609758
]
stack commented on HBASE-16835:
---
My fault on the RAT check. Let me fix.
Yes on two differe
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609809#comment-15609809
]
stack commented on HBASE-16835:
---
Pushed HBASE-16949 to fix the above.
> Revisit the zookee
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610317#comment-15610317
]
Duo Zhang commented on HBASE-16835:
---
But I do not think the precommit job could read ou
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610882#comment-15610882
]
stack commented on HBASE-16835:
---
bq. But I do not think the precommit job could read our do
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610908#comment-15610908
]
Duo Zhang commented on HBASE-16835:
---
{quote}
We don't do protoc as part of our build. I
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610963#comment-15610963
]
stack commented on HBASE-16835:
---
When you say old registry, you mean branch-1?
Yeah, preco
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610992#comment-15610992
]
Duo Zhang commented on HBASE-16835:
---
We do have a Registry in master...
https://github
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611058#comment-15611058
]
stack commented on HBASE-16835:
---
RIght. We have Registry and ClusterRegistry. Why out put t
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611081#comment-15611081
]
Duo Zhang commented on HBASE-16835:
---
Registry is design for blocking access only and th
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612387#comment-15612387
]
Sean Busbey commented on HBASE-16835:
-
{quote}
bq. We don't do protoc as part of our
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612410#comment-15612410
]
stack commented on HBASE-16835:
---
Thanks for clarification.
Seems odd to call it ClusterReg
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612433#comment-15612433
]
stack commented on HBASE-16835:
---
Thanks [~busbey] Filed HBASE-16955. Let me have a go at it
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613886#comment-15613886
]
Duo Zhang commented on HBASE-16835:
---
Fine. Let et change the class name.
> Revisit the
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614275#comment-15614275
]
Hadoop QA commented on HBASE-16835:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614314#comment-15614314
]
Duo Zhang commented on HBASE-16835:
---
Any other concerns of the new patch? [~stack]
Tha
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614324#comment-15614324
]
stack commented on HBASE-16835:
---
No. Looks great. +1.
> Revisit the zookeeper usage at cli
[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615196#comment-15615196
]
Hudson commented on HBASE-16835:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix
32 matches
Mail list logo
