[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697617#comment-15697617 ] Hadoop QA commented on HBASE-17174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-25 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695381#comment-15695381 ] ChiaPing Tsai commented on HBASE-17174: --- All failed tests pass locally. > Use shar

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695225#comment-15695225 ] Hadoop QA commented on HBASE-17174: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694971#comment-15694971 ] ChiaPing Tsai commented on HBASE-17174: --- hi [~jinghe], [~anoop.hbase] I refactor/cl

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694922#comment-15694922 ] ChiaPing Tsai commented on HBASE-17174: --- copy that. > Use shared threadpool in Buf

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694913#comment-15694913 ] Anoop Sam John commented on HBASE-17174: Seems there are many unrelated changes h

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694904#comment-15694904 ] ChiaPing Tsai commented on HBASE-17174: --- The v2++ patch makes BufferedMutatorImpl h

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694854#comment-15694854 ] ramkrishna.s.vasudevan commented on HBASE-17174: Valid point. Good commen

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694660#comment-15694660 ] Jerry He commented on HBASE-17174: -- BufferedMutator should not close an external Executo

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694447#comment-15694447 ] Ted Yu commented on HBASE-17174: lgtm {code} 77 * non-final so can be overridden

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694216#comment-15694216 ] Hadoop QA commented on HBASE-17174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693969#comment-15693969 ] ChiaPing Tsai commented on HBASE-17174: --- You inspire me. I will address your commen

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693948#comment-15693948 ] Anoop Sam John commented on HBASE-17174: That is a wrong expectation itself IMO.

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693936#comment-15693936 ] ChiaPing Tsai commented on HBASE-17174: --- It is a good idea, but it may can't deal w

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread ChiaPing Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693900#comment-15693900 ] ChiaPing Tsai commented on HBASE-17174: --- bq. How about calling pool.shutdowNow() in

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693866#comment-15693866 ] Anoop Sam John commented on HBASE-17174: So BufferedMutator can be created using

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693814#comment-15693814 ] Ted Yu commented on HBASE-17174: {code} 204 terminated = this.pool.awaitTer

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693735#comment-15693735 ] Hadoop QA commented on HBASE-17174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-17174) Use shared threadpool in BufferedMutatorImpl

2016-11-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693389#comment-15693389 ] Hadoop QA commented on HBASE-17174: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo