[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697617#comment-15697617
]
Hadoop QA commented on HBASE-17174:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695381#comment-15695381
]
ChiaPing Tsai commented on HBASE-17174:
---
All failed tests pass locally.
> Use shar
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695225#comment-15695225
]
Hadoop QA commented on HBASE-17174:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694971#comment-15694971
]
ChiaPing Tsai commented on HBASE-17174:
---
hi [~jinghe], [~anoop.hbase]
I refactor/cl
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694922#comment-15694922
]
ChiaPing Tsai commented on HBASE-17174:
---
copy that.
> Use shared threadpool in Buf
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694913#comment-15694913
]
Anoop Sam John commented on HBASE-17174:
Seems there are many unrelated changes h
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694904#comment-15694904
]
ChiaPing Tsai commented on HBASE-17174:
---
The v2++ patch makes BufferedMutatorImpl h
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694854#comment-15694854
]
ramkrishna.s.vasudevan commented on HBASE-17174:
Valid point. Good commen
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694660#comment-15694660
]
Jerry He commented on HBASE-17174:
--
BufferedMutator should not close an external Executo
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694447#comment-15694447
]
Ted Yu commented on HBASE-17174:
lgtm
{code}
77 * non-final so can be overridden
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694216#comment-15694216
]
Hadoop QA commented on HBASE-17174:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693969#comment-15693969
]
ChiaPing Tsai commented on HBASE-17174:
---
You inspire me. I will address your commen
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693948#comment-15693948
]
Anoop Sam John commented on HBASE-17174:
That is a wrong expectation itself IMO.
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693936#comment-15693936
]
ChiaPing Tsai commented on HBASE-17174:
---
It is a good idea, but it may can't deal w
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693900#comment-15693900
]
ChiaPing Tsai commented on HBASE-17174:
---
bq. How about calling pool.shutdowNow() in
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693866#comment-15693866
]
Anoop Sam John commented on HBASE-17174:
So BufferedMutator can be created using
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693814#comment-15693814
]
Ted Yu commented on HBASE-17174:
{code}
204 terminated = this.pool.awaitTer
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693735#comment-15693735
]
Hadoop QA commented on HBASE-17174:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693389#comment-15693389
]
Hadoop QA commented on HBASE-17174:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
19 matches
Mail list logo