[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516558#comment-16516558
]
Hudson commented on HBASE-20478:
Results for branch branch-2
[build #878 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494466#comment-16494466
]
Hudson commented on HBASE-20478:
Results for branch master
[build #349 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493692#comment-16493692
]
Sean Busbey commented on HBASE-20478:
-
lol. I dunno, I can see how that sounds painful. I'm willing
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493689#comment-16493689
]
Mike Drob commented on HBASE-20478:
---
[~busbey] - I have no desire to pull this back to any other
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493681#comment-16493681
]
Mike Drob commented on HBASE-20478:
---
I restored the comment and added it to the other applicable
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493642#comment-16493642
]
Sean Busbey commented on HBASE-20478:
-
okay. I'd rather have that kind of comment still in place (or
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493590#comment-16493590
]
Mike Drob commented on HBASE-20478:
---
Overzealous pruning, most likely. The other methods on that class
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493549#comment-16493549
]
Sean Busbey commented on HBASE-20478:
-
{code}
diff --git
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493365#comment-16493365
]
Jan Hentschel commented on HBASE-20478:
---
[~mdrob] Checkstyle should be fine for most modules, but
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492914#comment-16492914
]
Hadoop QA commented on HBASE-20478:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492807#comment-16492807
]
Hadoop QA commented on HBASE-20478:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492805#comment-16492805
]
Mike Drob commented on HBASE-20478:
---
v8: upload the correct patch
> move import checks from hbaseanti
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492801#comment-16492801
]
Hadoop QA commented on HBASE-20478:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492800#comment-16492800
]
Mike Drob commented on HBASE-20478:
---
v7: drop to checkstyle 8.2 due to
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492182#comment-16492182
]
Hadoop QA commented on HBASE-20478:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492114#comment-16492114
]
Mike Drob commented on HBASE-20478:
---
v6: suppress the checkstyle warning for
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492115#comment-16492115
]
Hadoop QA commented on HBASE-20478:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492053#comment-16492053
]
Hadoop QA commented on HBASE-20478:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492018#comment-16492018
]
Hadoop QA commented on HBASE-20478:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491873#comment-16491873
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #7 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491778#comment-16491778
]
Mike Drob commented on HBASE-20478:
---
{noformat}
mdrob@mdrob-MBP:~/IdeaProjects/hbase$ diff
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491458#comment-16491458
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #6 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491258#comment-16491258
]
Mike Drob commented on HBASE-20478:
---
posted question to checkstyle community:
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491239#comment-16491239
]
Mike Drob commented on HBASE-20478:
---
Been playing around with this locally, the problem according to
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490057#comment-16490057
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #5 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488231#comment-16488231
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #4 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487805#comment-16487805
]
Mike Drob commented on HBASE-20478:
---
Ok, looks like a lot of import order complaints about
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487641#comment-16487641
]
Sean Busbey commented on HBASE-20478:
-
the -branch files are all empty as a side effect of running in
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487638#comment-16487638
]
Sean Busbey commented on HBASE-20478:
-
build #2 on the feature branch:
bq. -0 checkstyle 2m
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487635#comment-16487635
]
Sean Busbey commented on HBASE-20478:
-
bq. Ugh, that's a lot of failures. Need to do more digging to
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487597#comment-16487597
]
Mike Drob commented on HBASE-20478:
---
Yea, I think this means we weren't running checkstyle in the
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487589#comment-16487589
]
Mike Drob commented on HBASE-20478:
---
Ugh, that's a lot of failures. Need to do more digging to figure
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487572#comment-16487572
]
Sean Busbey commented on HBASE-20478:
-
here's checkstyle from run #2:
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486586#comment-16486586
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #3 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484666#comment-16484666
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #2 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484354#comment-16484354
]
Sean Busbey commented on HBASE-20478:
-
Here's the build I started, I expect it'll post a result here
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484353#comment-16484353
]
Sean Busbey commented on HBASE-20478:
-
you should ignore build #1 of any new branch. there's a
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484351#comment-16484351
]
Sean Busbey commented on HBASE-20478:
-
I scanned for pipeline branches and it showed up. I started a
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484349#comment-16484349
]
Hudson commented on HBASE-20478:
Results for branch HBASE-20478
[build #1 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484345#comment-16484345
]
Sean Busbey commented on HBASE-20478:
-
I don't see it in the list of nightly branches:
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484331#comment-16484331
]
Mike Drob commented on HBASE-20478:
---
[~busbey] - where do i go to look for the nightly results since
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477733#comment-16477733
]
Mike Drob commented on HBASE-20478:
---
I pushed v4 to a feature branch, will check back in after the
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459766#comment-16459766
]
Sean Busbey commented on HBASE-20478:
-
could we do the "only run the plugin under jdk8" trick we do
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457591#comment-16457591
]
Hudson commented on HBASE-20478:
Results for branch master
[build #314 on
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455636#comment-16455636
]
Mike Drob commented on HBASE-20478:
---
Checkstyle 7+ requires JDK 8+, so won't be able to backport such a
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455454#comment-16455454
]
Hadoop QA commented on HBASE-20478:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454675#comment-16454675
]
Mike Drob commented on HBASE-20478:
---
I reverted the change for now until we figure out the proper
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454672#comment-16454672
]
Sean Busbey commented on HBASE-20478:
-
let's pick one and use it an addendum. you prefer patch or
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454671#comment-16454671
]
Mike Drob commented on HBASE-20478:
---
you're right, running locally I get:
{noformat}
[ERROR] Failed to
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454643#comment-16454643
]
Sean Busbey commented on HBASE-20478:
-
I pushed this to master, but in backporting ran into a problem
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454364#comment-16454364
]
Sean Busbey commented on HBASE-20478:
-
yeah that matches my understanding. I don't know why we got
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454328#comment-16454328
]
Mike Drob commented on HBASE-20478:
---
Oh, I thought we were waiting on QA to run, but it looks like it
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454308#comment-16454308
]
Sean Busbey commented on HBASE-20478:
-
I'd like to merge this now. any objections?
> move import
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453320#comment-16453320
]
Hadoop QA commented on HBASE-20478:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453061#comment-16453061
]
Hadoop QA commented on HBASE-20478:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452682#comment-16452682
]
Hadoop QA commented on HBASE-20478:
---
(!) A patch to the testing environment has been detected.
[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452595#comment-16452595
]
Mike Drob commented on HBASE-20478:
---
getting the treemap stuff into our error-prone ruleset was proving
57 matches
Mail list logo
