[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553802#comment-16553802 ] Hudson commented on HBASE-20744: Results for branch branch-1 [build #390 on

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553617#comment-16553617 ] Xu Cang commented on HBASE-20744: - Findbugs is ok now. but javac complains about this:  

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553584#comment-16553584 ] Ted Yu commented on HBASE-20744: bq. hbase-hadoop2-compat generated 0 new + 0 unchanged - 1 fixed = 0

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553567#comment-16553567 ] Xu Cang commented on HBASE-20744: - I guess it's not ready to be committed. [~yuzhih...@gmail.com] There

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553537#comment-16553537 ] Hadoop QA commented on HBASE-20744: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread huaxiang sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553331#comment-16553331 ] huaxiang sun commented on HBASE-20744: -- Thanks [~xucang] for the patch. The

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553249#comment-16553249 ] Xu Cang commented on HBASE-20744: - Correct, updated a new version. Thanks for the review.

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553238#comment-16553238 ] Ted Yu commented on HBASE-20744: {code} +public synchronized byte[] getOurBytes() { + return

[jira] [Commented] (HBASE-20744) Address FindBugs warnings in branch-1

2018-07-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553234#comment-16553234 ] Ted Yu commented on HBASE-20744: [~huaxiang]: Can you take a look at the change to