[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720644#comment-16720644
]
Josh Elser commented on HBASE-21246:
Filed HBASE-21599 and HBASE-21600 to circle back around on the
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717626#comment-16717626
]
Josh Elser commented on HBASE-21246:
{quote} The property 'name' looks redundant to me in
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716206#comment-16716206
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716052#comment-16716052
]
Reid Chan commented on HBASE-21246:
---
Overall LGTM!
Few suggestions,
{code}
public FSWALIdentity(Path
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715849#comment-16715849
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715585#comment-16715585
]
Ankit Singhal commented on HBASE-21246:
---
[~elserj],
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715410#comment-16715410
]
Ankit Singhal commented on HBASE-21246:
---
Thanks [~elserj] for the review.
{quote}I see
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715060#comment-16715060
]
Josh Elser commented on HBASE-21246:
{quote}used master for pre-commit jenkin build as HBASE-20952
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714223#comment-16714223
]
Reid Chan commented on HBASE-21246:
---
Thanks for the ping [~an...@apache.org]. I need some time, will
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713573#comment-16713573
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713256#comment-16713256
]
Ankit Singhal commented on HBASE-21246:
---
[~elserj]/[~reidchan],
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689816#comment-16689816
]
Ted Yu commented on HBASE-21246:
Patch v43 is mostly formatting change on top of v41.
> Introduce
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688506#comment-16688506
]
Ted Yu commented on HBASE-21246:
Patch v41 fixes TestDLSAsyncFSWAL .
TestDLSAsyncFSWAL#countWAL was
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686778#comment-16686778
]
Ted Yu commented on HBASE-21246:
There are fewer test failures with patch v39.
Need to handle failure
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685515#comment-16685515
]
Ted Yu commented on HBASE-21246:
Patch v37 fixes infinite call in
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682638#comment-16682638
]
Ted Yu commented on HBASE-21246:
Currently there are about 69 failing test classes.
Working through
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681979#comment-16681979
]
Ted Yu commented on HBASE-21246:
Patch v34 is based on current master.
Running test suite locally to
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680549#comment-16680549
]
Ted Yu commented on HBASE-21246:
Looking at compilation errors for patch v22: 321 lines in the
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680506#comment-16680506
]
Josh Elser commented on HBASE-21246:
Keeping HBASE-21456 in mind, I think something between v21 and
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679936#comment-16679936
]
Josh Elser commented on HBASE-21246:
bq. Can we file a sub task for refactoring WALFactory,
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679918#comment-16679918
]
Josh Elser commented on HBASE-21246:
bq. Can we file a sub task for refactoring WALFactory, let's
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679257#comment-16679257
]
Reid Chan commented on HBASE-21246:
---
Can we file a sub task for refactoring WALFactory, let's start
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678393#comment-16678393
]
Josh Elser commented on HBASE-21246:
bq. WALFactory is only responsible for WALProvider's creation
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677662#comment-16677662
]
Reid Chan commented on HBASE-21246:
---
I spent some time on comments above, diagrams and basic codes
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676063#comment-16676063
]
Reid Chan commented on HBASE-21246:
---
I'm reading the diagrams, thanks for the work!
> Introduce
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675869#comment-16675869
]
Josh Elser commented on HBASE-21246:
[~stack], [~reidchan], see Ted's attached images
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675528#comment-16675528
]
Ted Yu commented on HBASE-21246:
In patch v24, I dropped the static methods from WALFactory - there are
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675458#comment-16675458
]
Ted Yu commented on HBASE-21246:
replication-src-creates-wal-reader.jpg shows how WAL Reader is created
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672343#comment-16672343
]
Josh Elser commented on HBASE-21246:
{quote}Unreadable. Conveys nothing but complexity
{quote}
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671880#comment-16671880
]
Ted Yu commented on HBASE-21246:
bq. Why as attachments to the issue and not integrated into design doc?
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671847#comment-16671847
]
stack commented on HBASE-21246:
---
Unreadable. Conveys nothing but complexity. Why as attachments to the
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670472#comment-16670472
]
Ted Yu commented on HBASE-21246:
wal-providers.png is diagram for WALProvider related classes.
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670238#comment-16670238
]
Josh Elser commented on HBASE-21246:
bq. That sounds like a sensible approach (including diagrams
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669058#comment-16669058
]
stack commented on HBASE-21246:
---
bq. But WAL system's architecture is not very clear, and api/class
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668955#comment-16668955
]
Ted Yu commented on HBASE-21246:
bq. Missed push-down into WALProvider
The push-down is implemented in
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668840#comment-16668840
]
Ted Yu commented on HBASE-21246:
bq. This is extracting the creation time, right?
The start time is
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668830#comment-16668830
]
Ted Yu commented on HBASE-21246:
Thanks for detailed comments, Josh.
bq. This still banks on the
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668607#comment-16668607
]
Reid Chan commented on HBASE-21246:
---
bq. Diagrams would have helped. from sir [~stack]
Let me help to
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667936#comment-16667936
]
Josh Elser commented on HBASE-21246:
My take overall: seems like the changes are largely equivalent
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667447#comment-16667447
]
Ted Yu commented on HBASE-21246:
Patch v20 is intended to show how WALIdentity is used in various WAL
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663020#comment-16663020
]
Josh Elser commented on HBASE-21246:
bq. Why then did we remove the many other threads but decide to
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661097#comment-16661097
]
stack commented on HBASE-21246:
---
bq. Through NoSuchLogException, we would consolidate WAL system error
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661038#comment-16661038
]
Ted Yu commented on HBASE-21246:
Modified previous comment with more background information.
bq.
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659991#comment-16659991
]
Josh Elser commented on HBASE-21246:
{quote}{quote}Why do we have a String constructor anyways?
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659978#comment-16659978
]
Ted Yu commented on HBASE-21246:
I ran failed tests with patch v8 which passed.
{code}
[ERROR] Crashed
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659960#comment-16659960
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659867#comment-16659867
]
Ted Yu commented on HBASE-21246:
bq. Why do we have a String constructor anyways?
One example usage for
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659842#comment-16659842
]
Ted Yu commented on HBASE-21246:
bq. is the 'design' the thread attached to the document or do we read
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659826#comment-16659826
]
stack commented on HBASE-21246:
---
The link works now. Thanks.
So, exactly my point, is the 'design' the
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659691#comment-16659691
]
Ted Yu commented on HBASE-21246:
I have updated the link to point to the actual thread on the design
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659672#comment-16659672
]
stack commented on HBASE-21246:
---
bq. See this thread on the doc:
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659666#comment-16659666
]
Ted Yu commented on HBASE-21246:
Stack's questions seem to be at higher level. So allow me to respond to
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659628#comment-16659628
]
stack commented on HBASE-21246:
---
Where is WALIdentity in the design doc? Designed or are we trying
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659626#comment-16659626
]
Josh Elser commented on HBASE-21246:
{quote}Waiting for more review.
{quote}
I don't think there's
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659601#comment-16659601
]
Ted Yu commented on HBASE-21246:
Addressed above comment in patch v8.
Waiting for more review.
>
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659589#comment-16659589
]
Josh Elser commented on HBASE-21246:
You looking for a review, [~yuzhih...@gmail.com], or still
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656853#comment-16656853
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654526#comment-16654526
]
Duo Zhang commented on HBASE-21246:
---
So maybe we should add more comments to say that this method is
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654524#comment-16654524
]
Josh Elser commented on HBASE-21246:
{quote}in the replication tracking system, we need to serialize
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654491#comment-16654491
]
Duo Zhang commented on HBASE-21246:
---
So maybe another problem is that, where do we need the
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654485#comment-16654485
]
Duo Zhang commented on HBASE-21246:
---
So the point here is that, FWIW, in the replication tracking
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653646#comment-16653646
]
Ted Yu commented on HBASE-21246:
When making relevant changes in replication related classes, I came
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652899#comment-16652899
]
Ted Yu commented on HBASE-21246:
bq. the strange thing is that we have a method which creates
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652832#comment-16652832
]
Duo Zhang commented on HBASE-21246:
---
For me I'm OK with the WALIdentity but the strange thing is that
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651982#comment-16651982
]
Ted Yu commented on HBASE-21246:
See if I understand Josh's proposal correctly. Under Josh's proposal,
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651955#comment-16651955
]
Josh Elser commented on HBASE-21246:
Just noticed I had this pending.. sorry for the delay:
{quote}I
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646943#comment-16646943
]
stack commented on HBASE-21246:
---
bq. You have a suggestion?
I was commenting on the fact that we have a
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646794#comment-16646794
]
Ted Yu commented on HBASE-21246:
bq. are there places aside from replication (where we put a wal into
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646763#comment-16646763
]
Josh Elser commented on HBASE-21246:
{quote}So, a key for an instance of something called a
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646733#comment-16646733
]
stack commented on HBASE-21246:
---
bq. Like WALIdentity is uniquely identifying a WAL stored in this
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646489#comment-16646489
]
Josh Elser commented on HBASE-21246:
{quote}How does a WALIdentity float free of a WAL Instance? You
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646071#comment-16646071
]
Duo Zhang commented on HBASE-21246:
---
But you can just create a WALIdentity from a String? Does it
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646005#comment-16646005
]
stack commented on HBASE-21246:
---
I thought WALIdentity would be an opaque class that we'd pass around.
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645897#comment-16645897
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645719#comment-16645719
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645687#comment-16645687
]
Josh Elser commented on HBASE-21246:
{code:java}
+ * For the FS based path, it will be just a
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645553#comment-16645553
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645443#comment-16645443
]
Ted Yu commented on HBASE-21246:
I ran TestMasterFailoverWithProcedures with patch locally which passed.
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645400#comment-16645400
]
Hadoop QA commented on HBASE-21246:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645355#comment-16645355
]
Ted Yu commented on HBASE-21246:
bq. Why isn't this a WALProvider method?
The start time of a WAL is
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645333#comment-16645333
]
Josh Elser commented on HBASE-21246:
{code:java}
+ static WALIdentity UNKNOWN = new WALIdentity() {
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645331#comment-16645331
]
Josh Elser commented on HBASE-21246:
{code:java}
+ /**
+ * Starting time of the wal which help in
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638994#comment-16638994
]
Ted Yu commented on HBASE-21246:
Now that design doc is back to review mode, please allow some more time
[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631228#comment-16631228
]
Duo Zhang commented on HBASE-21246:
---
Why we have a getSize in WALIdentity?
And do we want to
84 matches
Mail list logo
