[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510689#comment-17510689 ] Viraj Jasani commented on HBASE-23279: -- {quote}ROW_INDEX_V1 may not be a good defau

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510168#comment-17510168 ] Andrew Kyle Purtell commented on HBASE-23279: - ROW_INDEX_V1 may not be a goo

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509115#comment-17509115 ] Bryan Beaudreault commented on HBASE-23279: --- Seems like this issue stalled a b

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074615#comment-17074615 ] Viraj Jasani commented on HBASE-23279: -- [~anoop.hbase] After completion of child Ji

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025610#comment-17025610 ] Michael Stack commented on HBASE-23279: --- Seems like a problem that needs some work

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024380#comment-17024380 ] HBase QA commented on HBASE-23279: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || V

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024332#comment-17024332 ] Anoop Sam John commented on HBASE-23279: bq.milarly if the next available bucket

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024296#comment-17024296 ] ramkrishna.s.vasudevan commented on HBASE-23279: bq..withDataBlockEncodi

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024294#comment-17024294 ] ramkrishna.s.vasudevan commented on HBASE-23279: bq.If the size of the b

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024227#comment-17024227 ] Anoop Sam John commented on HBASE-23279: In BC the bucket size selection should

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024179#comment-17024179 ] ramkrishna.s.vasudevan commented on HBASE-23279: The test case had to be

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023555#comment-17023555 ] Anoop Sam John commented on HBASE-23279: The test case issue wrt offset/len what

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023554#comment-17023554 ] Anoop Sam John commented on HBASE-23279: The offsets index data will be written

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023041#comment-17023041 ] Michael Stack commented on HBASE-23279: --- bq. This extra offsets size info is NOT t

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022942#comment-17022942 ] Anoop Sam John commented on HBASE-23279: Here the fail report says bq.expected:

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022904#comment-17022904 ] ramkrishna.s.vasudevan commented on HBASE-23279: [~vjasani] With any oth

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022730#comment-17022730 ] Viraj Jasani commented on HBASE-23279: -- Sure [~stack], someone can take a look. Als

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022726#comment-17022726 ] Michael Stack commented on HBASE-23279: --- I don't know of any ArrayIndexOutOfBounds

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022717#comment-17022717 ] Viraj Jasani commented on HBASE-23279: -- Tried updating block size, entryCount(for l

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022629#comment-17022629 ] Viraj Jasani commented on HBASE-23279: -- {quote}Offset is not right? Is our. math of

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022626#comment-17022626 ] Michael Stack commented on HBASE-23279: --- Seems like a basic issue w/ ByteBuff and

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022602#comment-17022602 ] Viraj Jasani commented on HBASE-23279: -- We have this function in ByteBufferUtils:

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022575#comment-17022575 ] Viraj Jasani commented on HBASE-23279: -- Yes it is relevant, unfortunately. Checking

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022560#comment-17022560 ] Michael Stack commented on HBASE-23279: --- Fail looks related? > Switch default blo

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022552#comment-17022552 ] HBase QA commented on HBASE-23279: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022472#comment-17022472 ] Michael Stack commented on HBASE-23279: --- Patch looks good. Not sure why you had to

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022455#comment-17022455 ] Viraj Jasani commented on HBASE-23279: -- Uploaded new patch 004. Let's see how QA ru

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022361#comment-17022361 ] Michael Stack commented on HBASE-23279: --- Lets get it in. +1 on your patch. Reenabl

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022362#comment-17022362 ] Viraj Jasani commented on HBASE-23279: -- Sure let me put up a new patch now that we

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020718#comment-17020718 ] Viraj Jasani commented on HBASE-23279: -- It would be great to have HBASE-23705 lande

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020656#comment-17020656 ] Michael Stack commented on HBASE-23279: --- FYI, GetClosest is a good test but with a

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013351#comment-17013351 ] Viraj Jasani commented on HBASE-23279: -- [~stack] Size difference has been one obsta

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013140#comment-17013140 ] Michael Stack commented on HBASE-23279: --- How we doing here [~vjasani]? [~anoop.hba

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988476#comment-16988476 ] Anoop Sam John commented on HBASE-23279: bq.ROW_INDEX_V1 is the only encoding wi

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981598#comment-16981598 ] Viraj Jasani commented on HBASE-23279: -- We have TestDataBlockEncodingTool with 3 te

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980993#comment-16980993 ] Viraj Jasani commented on HBASE-23279: -- {quote}Patch looks good generally. Are the

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980983#comment-16980983 ] Lars Hofhansl commented on HBASE-23279: --- Patch looks good generally. Are the chang

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980900#comment-16980900 ] HBase QA commented on HBASE-23279: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980847#comment-16980847 ] Viraj Jasani commented on HBASE-23279: -- Repeated the test for 3 tables a couple of

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979797#comment-16979797 ] Anoop Sam John commented on HBASE-23279: Thanks for the tests. It helps.. WRT bl

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979240#comment-16979240 ] Viraj Jasani commented on HBASE-23279: -- [~stack] [~ram_krish] IMO, there should no

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979018#comment-16979018 ] Viraj Jasani commented on HBASE-23279: -- The only change require in attached patch 0

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979017#comment-16979017 ] Viraj Jasani commented on HBASE-23279: --   {quote}You can try enabling other encodin

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979011#comment-16979011 ] Anoop Sam John commented on HBASE-23279: Ya still good to experiment to know the

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979009#comment-16979009 ] Anoop Sam John commented on HBASE-23279: bq.ROW_INDEX_V1 indeed seems to be taki

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979010#comment-16979010 ] ramkrishna.s.vasudevan commented on HBASE-23279: [~vjasani] You can try

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979003#comment-16979003 ] Michael Stack commented on HBASE-23279: --- Do we support get closest at or before in

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978999#comment-16978999 ] Viraj Jasani commented on HBASE-23279: -- Facing some issue with one UT: TestGetClose

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978806#comment-16978806 ] HBase QA commented on HBASE-23279: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978012#comment-16978012 ] HBase QA commented on HBASE-23279: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977882#comment-16977882 ] Michael Stack commented on HBASE-23279: --- On patch, this n -> DataBlockEn

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1697#comment-1697 ] Viraj Jasani commented on HBASE-23279: -- ROW_INDEX_V1 indeed seems to be taking more

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976848#comment-16976848 ] HBase QA commented on HBASE-23279: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vot

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976757#comment-16976757 ] Viraj Jasani commented on HBASE-23279: -- Tried reading data in bulk using LTT locall

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974596#comment-16974596 ] Lars Hofhansl commented on HBASE-23279: --- Thanks all. So based on the discussion h

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973034#comment-16973034 ] Anoop Sam John commented on HBASE-23279: Seems ya... For larger block size like

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972664#comment-16972664 ] Michael Stack commented on HBASE-23279: --- Related, hbase:meta really needs this (HB

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972546#comment-16972546 ] Viraj Jasani commented on HBASE-23279: -- Probably it's good to add 3% increment for

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972432#comment-16972432 ] Viraj Jasani commented on HBASE-23279: -- Seems like this is the one? BucketAllocato

[jira] [Commented] (HBASE-23279) Switch default block encoding to ROW_INDEX_V1

[ https://issues.apache.org/jira/browse/HBASE-23279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972113#comment-16972113 ] Anoop Sam John commented on HBASE-23279: Every HFile block will have slightly mo