[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495334#comment-13495334
]
nkeywal commented on HBASE-5937:
Hi Flavio,
Done, it's in HBASE-6931 / HBASE-7146
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495323#comment-13495323
]
Flavio Junqueira commented on HBASE-5937:
-
[~nkeywal] Please create a subtask unde
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495318#comment-13495318
]
nkeywal commented on HBASE-5937:
In FSHLog, a wrong reference to getReader survived in the
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468184#comment-13468184
]
Hudson commented on HBASE-5937:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #204 (See
[https
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468178#comment-13468178
]
Hudson commented on HBASE-5937:
---
Integrated in HBase-TRUNK #3409 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468134#comment-13468134
]
stack commented on HBASE-5937:
--
Updated the svn commit log to point to this issue instead of
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468066#comment-13468066
]
Ted Yu commented on HBASE-5937:
---
I am confused as to the scope of the commit:
{code}
$ svn l
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467855#comment-13467855
]
stack commented on HBASE-5937:
--
I can restore the annotation on commit. Will leave it privat
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467829#comment-13467829
]
Ted Yu commented on HBASE-5937:
---
Nice to see a green QA run.
{code}
-@InterfaceAudience.Priv
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467813#comment-13467813
]
Hadoop QA commented on HBASE-5937:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467589#comment-13467589
]
Flavio Junqueira commented on HBASE-5937:
-
I'll add an issue to the umbrella jira
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467575#comment-13467575
]
Hadoop QA commented on HBASE-5937:
--
{color:red}-1 overall{color}. Here are the results o
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467295#comment-13467295
]
Andrew Purtell commented on HBASE-5937:
---
+1 on approach and using an umbrella to gro
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467253#comment-13467253
]
Flavio Junqueira commented on HBASE-5937:
-
Sure, I can work on the cleanup. Hopefu
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467249#comment-13467249
]
stack commented on HBASE-5937:
--
bq. To me it sounds like a feature that is implementation-spe
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467232#comment-13467232
]
Flavio Junqueira commented on HBASE-5937:
-
bq. Its fine it doesn't need to split b
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466998#comment-13466998
]
Enis Soztutar commented on HBASE-5937:
--
bq. I think I said this in another jira, but
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466953#comment-13466953
]
stack commented on HBASE-5937:
--
bq. The splitter might not be necessary for every implementat
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466886#comment-13466886
]
Flavio Junqueira commented on HBASE-5937:
-
Thanks a lot for the review, Stack, and
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466591#comment-13466591
]
stack commented on HBASE-5937:
--
How is HLogSplitter going to work w/ different implementation
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466590#comment-13466590
]
stack commented on HBASE-5937:
--
bq. ...Making of HLog an interface and redesigning it all at
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466499#comment-13466499
]
Flavio Junqueira commented on HBASE-5937:
-
[~yuzhih...@gmail.com] bq. Looking at H
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466402#comment-13466402
]
stack commented on HBASE-5937:
--
Looking at the patch, its looking great.
You fellas like how
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466401#comment-13466401
]
Ted Yu commented on HBASE-5937:
---
bq. especially if not there originally
The javadoc came fro
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466394#comment-13466394
]
stack commented on HBASE-5937:
--
Do javadoc in another patch, especially if not there original
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466332#comment-13466332
]
Hadoop QA commented on HBASE-5937:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466307#comment-13466307
]
Ted Yu commented on HBASE-5937:
---
It turns out the patch posted @ 29/Sep/12 10:14 applies cle
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466288#comment-13466288
]
Ted Yu commented on HBASE-5937:
---
@Flavio:
Your recent rebase didn't work because HBASE-6476
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466282#comment-13466282
]
Hadoop QA commented on HBASE-5937:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466166#comment-13466166
]
Hadoop QA commented on HBASE-5937:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466165#comment-13466165
]
Flavio Junqueira commented on HBASE-5937:
-
Thanks for checking it out, Ted.
I che
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466067#comment-13466067
]
Ted Yu commented on HBASE-5937:
---
Thanks Flavio for the effort.
For HLogUtil.java and HLogFa
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466032#comment-13466032
]
Hadoop QA commented on HBASE-5937:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465599#comment-13465599
]
Hadoop QA commented on HBASE-5937:
--
-1 overall. Here are the results of testing the late
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460631#comment-13460631
]
stack commented on HBASE-5937:
--
bq. Any clue of why this could be happening?
Somehow the tes
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460592#comment-13460592
]
Flavio Junqueira commented on HBASE-5937:
-
Thanks for responding, Stack.
bq. Sorr
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460232#comment-13460232
]
stack commented on HBASE-5937:
--
[~fpj] Sorry for not getting to your log. What have you been
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459755#comment-13459755
]
Flavio Junqueira commented on HBASE-5937:
-
I've been able to fix a few bugs, and I
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451103#comment-13451103
]
stack commented on HBASE-5937:
--
Post log Flavio.
> Refactor HLog into an int
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451098#comment-13451098
]
Flavio Junqueira commented on HBASE-5937:
-
I've been looking at TestMultiParallel
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449640#comment-13449640
]
Flavio Junqueira commented on HBASE-5937:
-
I have moved static finals to HLog as s
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438842#comment-13438842
]
stack commented on HBASE-5937:
--
bq. The problem with these is that they take a individual log
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438734#comment-13438734
]
Ivan Kelly commented on HBASE-5937:
---
{quote}
Can you factory it in places like HLogInput
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437158#comment-13437158
]
stack commented on HBASE-5937:
--
bq. In the case we make them part of the interface, we will n
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434504#comment-13434504
]
Zhihong Ted Yu commented on HBASE-5937:
---
Here is partial list of failed tests:
{code
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434247#comment-13434247
]
Zhihong Ted Yu commented on HBASE-5937:
---
Thanks Flavio and Ivan for tackling this is
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434231#comment-13434231
]
Zhihong Ted Yu commented on HBASE-5937:
---
@Li:
Can I assign this issue to Flavio ?
T
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434195#comment-13434195
]
Flavio Junqueira commented on HBASE-5937:
-
I wanted to report the progress Ivan an
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428184#comment-13428184
]
Zhihong Ted Yu commented on HBASE-5937:
---
Right.
> Refactor HLog int
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428181#comment-13428181
]
Flavio Junqueira commented on HBASE-5937:
-
Just to make sure, there is nothing don
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268074#comment-13268074
]
Li Pi commented on HBASE-5937:
--
Mostly. But you could use it for other things too.
[
https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268056#comment-13268056
]
Zhihong Yu commented on HBASE-5937:
---
We should define clearer goals for the interface.
I
52 matches
Mail list logo
