Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-29 Thread via GitHub
rmdmattingly commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1971595114 I believe [this test failure](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5713/2/testReport/org.apache.hadoop.hbase.regionserver/TestHRegion/precommit_checks___yetu

Re: [PR] Backport "HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition (#5699)" to branch-2.5 [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5731: URL: https://github.com/apache/hbase/pull/5731#issuecomment-1971631542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s | Docke

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2 [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5723: URL: https://github.com/apache/hbase/pull/5723#issuecomment-1971642457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docker

Re: [PR] Backport "HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition (#5699)" to branch-2.5 [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5731: URL: https://github.com/apache/hbase/pull/5731#issuecomment-1971655625 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docke

Re: [PR] HBASE-20693 Refactor thrift jsp's and extract header and footer [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5732: URL: https://github.com/apache/hbase/pull/5732#issuecomment-1971658631 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] HBASE-20693 Refactor thrift jsp's and extract header and footer [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5732: URL: https://github.com/apache/hbase/pull/5732#issuecomment-1971669668 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] Backport "HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition (#5699)" to branch-2.5 [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5731: URL: https://github.com/apache/hbase/pull/5731#issuecomment-1971673124 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

Re: [PR] HBASE-20693 Refactor thrift jsp's and extract header and footer [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5732: URL: https://github.com/apache/hbase/pull/5732#issuecomment-1971675627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docke

Re: [PR] HBASE-20693 Refactor thrift jsp's and extract header and footer [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5732: URL: https://github.com/apache/hbase/pull/5732#issuecomment-1971690196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 51s | Docke

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.6 [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5725: URL: https://github.com/apache/hbase/pull/5725#issuecomment-1971739741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1971748851 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1971856974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1971887197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1971913204 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker

Re: [PR] HBASE-27230 RegionServer should be aborted when WAL.sync throws Timeout. [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5711: URL: https://github.com/apache/hbase/pull/5711#issuecomment-1971941064 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-27230 RegionServer should be aborted when WAL.sync throws Timeout. [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5711: URL: https://github.com/apache/hbase/pull/5711#issuecomment-1971950089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1971968268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker

[PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
charlesconnell opened a new pull request, #5733: URL: https://github.com/apache/hbase/pull/5733 Having all three replicas of each WAL file blocks makes it less likely that failures of a co-located RegionServer and DataNode result of a corrupt WAL file. See the JIRA ticket for more details a

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1972085143 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972117232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docke

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1972143532 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
jojochuang commented on code in PR #5733: URL: https://github.com/apache/hbase/pull/5733#discussion_r1508315806 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java: ## @@ -105,8 +105,13 @@ protected void initOutput(FileSystem fs, Path pa

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
jojochuang commented on code in PR #5733: URL: https://github.com/apache/hbase/pull/5733#discussion_r1508315806 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java: ## @@ -105,8 +105,13 @@ protected void initOutput(FileSystem fs, Path pa

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
charlesconnell commented on code in PR #5733: URL: https://github.com/apache/hbase/pull/5733#discussion_r1508399071 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java: ## @@ -105,8 +105,13 @@ protected void initOutput(FileSystem fs, Pat

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972360804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972361595 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docke

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972366873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docker

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972397739 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1972426005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1972500120 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] Backport "HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition (#5699)" to branch-2.5 [hbase]

2024-02-29 Thread via GitHub
ndimiduk merged PR #5731: URL: https://github.com/apache/hbase/pull/5731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2 [hbase]

2024-02-29 Thread via GitHub
ndimiduk merged PR #5723: URL: https://github.com/apache/hbase/pull/5723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.6 [hbase]

2024-02-29 Thread via GitHub
ndimiduk merged PR #5725: URL: https://github.com/apache/hbase/pull/5725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

[PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.5 [hbase]

2024-02-29 Thread via GitHub
ndimiduk opened a new pull request, #5734: URL: https://github.com/apache/hbase/pull/5734 We see unit test failures in Jenkins that look like this: ``` java.lang.IllegalArgumentException: run queue not empty at org.apache.hbase.thirdparty.com.google.common.base.Precondition

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1972572224 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.5 [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5734: URL: https://github.com/apache/hbase/pull/5734#issuecomment-1972585812 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker

[PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-02-29 Thread via GitHub
ndimiduk opened a new pull request, #5735: URL: https://github.com/apache/hbase/pull/5735 We occasionally get a test failure in TestCleanerChore.retriesIOExceptionInStatus. For example, from a recent PR build [0] on branch-2.6, ``` java.util.concurrent.ExecutionException: java.io.

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972616779 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972619165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-02-29 Thread via GitHub
ndimiduk commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1972623011 Relates to test change introduced in #4730. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Backport "HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer" to branch-2.6 [hbase]

2024-02-29 Thread via GitHub
NihalJain commented on PR #5729: URL: https://github.com/apache/hbase/pull/5729#issuecomment-1972623212 Hey @ndimiduk would you have some cycles to review this? Similar refactoring was also part of #5215 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] HBASE-20693 Refactor thrift jsp's and extract header and footer [hbase]

2024-02-29 Thread via GitHub
NihalJain commented on PR #5732: URL: https://github.com/apache/hbase/pull/5732#issuecomment-1972625739 Hey @ndimiduk would you have some cycles to review this? Similar refactoring was also part of rest module in https://github.com/apache/hbase/pull/5215 Also you had a +1 on JIRA HBASE-2069

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-02-29 Thread via GitHub
NihalJain commented on PR #5718: URL: https://github.com/apache/hbase/pull/5718#issuecomment-1972626628 Will merge this later today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1972633287 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-02-29 Thread via GitHub
NihalJain commented on code in PR #5735: URL: https://github.com/apache/hbase/pull/5735#discussion_r1508586001 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java: ## @@ -154,16 +160,25 @@ public FileStatus[] listStatus(Path f) throws IOExc

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-02-29 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1972673098 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-02-29 Thread via GitHub
Apache9 commented on code in PR #5735: URL: https://github.com/apache/hbase/pull/5735#discussion_r1508606272 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java: ## @@ -154,16 +160,25 @@ public FileStatus[] listStatus(Path f) throws IOExcep

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
NihalJain commented on code in PR #5735: URL: https://github.com/apache/hbase/pull/5735#discussion_r1508586001 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java: ## @@ -154,16 +160,25 @@ public FileStatus[] listStatus(Path f) throws IOExc

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.5 [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5734: URL: https://github.com/apache/hbase/pull/5734#issuecomment-1972830865 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s | Docke

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.5 [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5734: URL: https://github.com/apache/hbase/pull/5734#issuecomment-1972863461 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

Re: [PR] Backport "HBASE-28403 Improve debugging for failures in procedure tests (#5709)" to branch-2.5 [hbase]

2024-03-01 Thread via GitHub
ndimiduk merged PR #5734: URL: https://github.com/apache/hbase/pull/5734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
ndimiduk commented on PR #5736: URL: https://github.com/apache/hbase/pull/5736#issuecomment-1972930056 I haven't actually tested this yet, but I think this is what we need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
Apache9 commented on code in PR #5736: URL: https://github.com/apache/hbase/pull/5736#discussion_r1508803103 ## dev-support/create-release/release-util.sh: ## @@ -613,6 +613,8 @@ function update_releasenotes { else mv "${releasenotes}" "${project_dir}/RELEASENOTES.md"

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
ndimiduk commented on code in PR #5736: URL: https://github.com/apache/hbase/pull/5736#discussion_r1508805407 ## dev-support/create-release/release-util.sh: ## @@ -745,6 +747,8 @@ function maven_set_version { #input: log "${MVN[@]}" versions:set-property -Dproperty=revisio

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5736: URL: https://github.com/apache/hbase/pull/5736#issuecomment-1972943206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5736: URL: https://github.com/apache/hbase/pull/5736#issuecomment-1972943252 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5736: URL: https://github.com/apache/hbase/pull/5736#issuecomment-1972943351 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s | Docke

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5736: URL: https://github.com/apache/hbase/pull/5736#issuecomment-1972945516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28414 create-release should spotless:apply after making any file changes [hbase]

2024-03-01 Thread via GitHub
ndimiduk commented on code in PR #5736: URL: https://github.com/apache/hbase/pull/5736#discussion_r150886 ## dev-support/create-release/release-util.sh: ## @@ -613,6 +613,8 @@ function update_releasenotes { else mv "${releasenotes}" "${project_dir}/RELEASENOTES.md"

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1972990075 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1972998792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1973009418 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-03-01 Thread via GitHub
NihalJain merged PR #5718: URL: https://github.com/apache/hbase/pull/5718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apach

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-03-01 Thread via GitHub
NihalJain commented on PR #5718: URL: https://github.com/apache/hbase/pull/5718#issuecomment-1973074683 Hi @DieterDP-ng thanks for the PR. I have merged this PR. But going forward, please raise PRs targeted at master first. We merge PRs in master and then backport to older branches. Let me

Re: [PR] Backport "HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer" to branch-2.6 [hbase]

2024-03-01 Thread via GitHub
ndimiduk commented on PR #5729: URL: https://github.com/apache/hbase/pull/5729#issuecomment-1973126720 > Ran postman collection for basic CRUD test for REST at https://gist.github.com/NihalJain/7db91823bd140e41953a88eb3df56eae: All tests PASS Do we not have this kind of basic functio

Re: [PR] Backport "HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer" to branch-2.6 [hbase]

2024-03-01 Thread via GitHub
NihalJain commented on PR #5729: URL: https://github.com/apache/hbase/pull/5729#issuecomment-1973170037 > Do we not have this kind of basic functional test in the suite? I suppose we do but that must run inside minicluster. I run this by pointing to a node (local/distributed).

Re: [PR] Backport "HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer" to branch-2.6 [hbase]

2024-03-01 Thread via GitHub
NihalJain merged PR #5729: URL: https://github.com/apache/hbase/pull/5729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apach

Re: [PR] HBASE-20693 Refactor thrift jsp's and extract header and footer [hbase]

2024-03-01 Thread via GitHub
NihalJain merged PR #5732: URL: https://github.com/apache/hbase/pull/5732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apach

[PR] Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo… [hbase]

2024-03-01 Thread via GitHub
NihalJain opened a new pull request, #5737: URL: https://github.com/apache/hbase/pull/5737 …oter (#5732)" and Backport "HBASE-18382 add transport type info into Thrift UI (#880)" to branch-2 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo… [hbase]

2024-03-01 Thread via GitHub
NihalJain commented on PR #5737: URL: https://github.com/apache/hbase/pull/5737#issuecomment-1973268319 #5732 did not apply cleanly to branch-2 as HBASE-18382 is missing there. For now raised a backport for the same with this PR. Just copied the 3 files from branch-3 and overwrote o

Re: [PR] Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo… [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5737: URL: https://github.com/apache/hbase/pull/5737#issuecomment-1973281328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

Re: [PR] Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo… [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5737: URL: https://github.com/apache/hbase/pull/5737#issuecomment-1973291058 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s | Docke

Re: [PR] Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo… [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5737: URL: https://github.com/apache/hbase/pull/5737#issuecomment-1973291439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docke

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-03-01 Thread via GitHub
Apache9 commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1973309030 What is the problem of using curator here? This is just an example, with curator the code could be simpler... -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-03-01 Thread via GitHub
DieterDP-ng commented on PR #5718: URL: https://github.com/apache/hbase/pull/5718#issuecomment-1973383085 Thanks @NihalJain, I'll do so in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-03-01 Thread via GitHub
stoty commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1973453219 * IMO it's always better not to have a dependency than it is to have one, when it is avoidable. * Curator libs are added to the HBase classpath. Curator libs are also present on the Hadoop

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1973481016 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1973520811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1973828171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache-HBase commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1973827728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-01 Thread via GitHub
Apache9 commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1974199663 The test is failing in jdk17 build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-03-01 Thread via GitHub
Apache9 commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1974202567 For me, this is in hbase-example, we should use the simpler way to show users how to use a feature, curator is much simpler than using zookeeper directly right? Maybe we could discuss wheth

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-03-01 Thread via GitHub
Apache9 commented on PR #5733: URL: https://github.com/apache/hbase/pull/5733#issuecomment-1974202933 By default we use AsyncProtobufLogWriter, so we also need to change the code there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation [hbase]

2024-03-01 Thread via GitHub
Apache9 commented on code in PR #5733: URL: https://github.com/apache/hbase/pull/5733#discussion_r1509828660 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java: ## @@ -105,8 +105,13 @@ protected void initOutput(FileSystem fs, Path path,

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-03-01 Thread via GitHub
stoty commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1974357734 Curator can be simpler whan used to implement some of the more advanced synchronization constructs. In this case all we do is read and watch a simple value, and I would argue that my versi

Re: [PR] HBASE-28411 Remove direct dependency on Curator [hbase]

2024-03-02 Thread via GitHub
Apache9 commented on PR #5726: URL: https://github.com/apache/hbase/pull/5726#issuecomment-1974827236 I think we can start a discussion thread on the dev list about whether to include Hanse-examples in our binary releases. And we still need to dig why we add curator in hbase-endpoint, for

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-02 Thread via GitHub
ndimiduk commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1975076929 I think that my fix is incomplete. Or there's something else disrupting the test harness. The test was terminated, interrupting the chore thread, while the waiter loop had only sat for 5 s

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-02 Thread via GitHub
ndimiduk commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1975078085 In fact, jenkins doesn't tell us which of these failed runs is the output we have in the unit test summary. ``` [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.master.cleaner.Test

Re: [PR] HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus [hbase]

2024-03-03 Thread via GitHub
ndimiduk commented on PR #5735: URL: https://github.com/apache/hbase/pull/5735#issuecomment-1975078887 There is still a race. ``` [ERROR] org.apache.hadoop.hbase.master.cleaner.TestCleanerChore Time elapsed: 779.999 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test

[PR] HBASE-28415 Remove Curator dependency from hbase-endpoint [hbase]

2024-03-03 Thread via GitHub
stoty opened a new pull request, #5738: URL: https://github.com/apache/hbase/pull/5738 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28415 Remove Curator dependency from hbase-endpoint [hbase]

2024-03-03 Thread via GitHub
stoty commented on PR #5738: URL: https://github.com/apache/hbase/pull/5738#issuecomment-1975752110 This is the hbase-endpoint dependency cleanup, split from HBASE-28411, as discussed, @Apache9 . -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] HBASE-28381 Support building hbase-operator-tools with JDK17 [hbase-operator-tools]

2024-03-03 Thread via GitHub
NihalJain commented on PR #141: URL: https://github.com/apache/hbase-operator-tools/pull/141#issuecomment-1975757993 Lets see if we can get any more reviews by EOD. Otherwise will merge this to codebase later tonight. -- This is an automated message from the Apache Git Service. To respon

[PR] HBASE-28416 Remove hbase-examples from hbase-assembly [hbase]

2024-03-03 Thread via GitHub
stoty opened a new pull request, #5739: URL: https://github.com/apache/hbase/pull/5739 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28415 Remove Curator dependency from hbase-endpoint [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5738: URL: https://github.com/apache/hbase/pull/5738#issuecomment-1975771078 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28415 Remove Curator dependency from hbase-endpoint [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5738: URL: https://github.com/apache/hbase/pull/5738#issuecomment-1975772790 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28415 Remove Curator dependency from hbase-endpoint [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5738: URL: https://github.com/apache/hbase/pull/5738#issuecomment-1975773221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s | Docke

Re: [PR] HBASE-28415 Remove Curator dependency from hbase-endpoint [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5738: URL: https://github.com/apache/hbase/pull/5738#issuecomment-1975774655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28416 Remove hbase-examples from hbase-assembly [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5739: URL: https://github.com/apache/hbase/pull/5739#issuecomment-1975799297 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docke

Re: [PR] HBASE-28416 Remove hbase-examples from hbase-assembly [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5739: URL: https://github.com/apache/hbase/pull/5739#issuecomment-1975799638 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docke

Re: [PR] HBASE-28416 Remove hbase-examples from hbase-assembly [hbase]

2024-03-03 Thread via GitHub
Apache-HBase commented on PR #5739: URL: https://github.com/apache/hbase/pull/5739#issuecomment-1975801575 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

<    4   5   6   7   8   9   10   11   12   13   >