Re: [PR] Add Hive integration tests [iceberg-python]

Fokko merged PR #207: URL: https://github.com/apache/iceberg-python/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Hive integration tests [iceberg-python]

Fokko commented on PR #207: URL: https://github.com/apache/iceberg-python/pull/207#issuecomment-1896052914 Thanks @HonahX for the review  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add Hive integration tests [iceberg-python]

Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1455755578 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427569648 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427569648 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427591155 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427591155 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427569648 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Hive integration tests [iceberg-python]

Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427172141 ## dev/Dockerfile: ## @@ -62,7 +60,7 @@ RUN chmod u+x /opt/spark/sbin/* && \ RUN pip3 install -q ipython -RUN pip3 install

Re: [PR] Add Hive integration tests [iceberg-python]

Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427153974 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Hive integration tests [iceberg-python]

Fokko commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1427150320 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1426357825 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1426280842 ## tests/integration/__init__.py: ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Add Hive integration tests [iceberg-python]

HonahX commented on code in PR #207: URL: https://github.com/apache/iceberg-python/pull/207#discussion_r1426357825 ## tests/integration/test_hive.py: ## @@ -0,0 +1,409 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[PR] Add Hive integration tests [iceberg-python]

Fokko opened a new pull request, #207: URL: https://github.com/apache/iceberg-python/pull/207 This makes it easier to test round trips of updating tables. Currently, we have integration tests for the REST catalog, but there the REST catalog takes care of updating the metadata. This