nastra commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1878559904
@cgpoh can you please port these changes to other Flink versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
pvary commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1878512144
> > Do we have a way to check if the new tests were running on the CI? With
the correct parameters?
>
> I don't think so, but I was verifying them all locally
In this case, I a
nastra commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1877466639
> Do we have a way to check if the new tests were running on the CI? With
the correct parameters?
I don't think so, but I was verifying them all locally
--
This is an automated me
pvary commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1877465254
Do we have a way to check if the new tests were running on the CI? With the
correct parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
cgpoh commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1870902422
> @cgpoh I took the liberty to address the remaining items so that we can
get this in. @pvary could you do a final review on this one please? I think we
would also want to apply this to Fli
nastra commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1867581096
@cgpoh I took the liberty to address the remaining items so that we can get
this in. @pvary could you do a final review on this one please?
I thin we would also want to apply this to Fli
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434967495
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceBoundedSql.java:
##
@@ -26,26 +26,27 @@
import org.apache.flink.table.api.TableEnvir
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434965909
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,41 +53,36 @@
import org.apache.iceberg.types.Types;
import org.apache.
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434965644
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,41 +53,36 @@
import org.apache.iceberg.types.Types;
import org.apache.
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434965278
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,41 +53,36 @@
import org.apache.iceberg.types.Types;
import org.apache.
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434965009
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormat.java:
##
@@ -33,21 +33,20 @@
import org.apache.iceberg.Schema;
import org.apach
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434962899
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormat.java:
##
@@ -140,9 +140,9 @@ public void testBasicProjection() throws IOException
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434958256
##
data/src/test/java/org/apache/iceberg/data/GenAppenderHelper.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434950138
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -337,82 +334,72 @@ private static void assertAvroEquals(
if (expected == null &&
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1434948333
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -193,109 +192,106 @@ private static void assertEquals(
return;
}
-A
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432597940
##
data/src/test/java/org/apache/iceberg/data/GenAppenderHelper.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432509022
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -458,19 +457,20 @@ private void testFilterExp(Expression filter, String
sql
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432508266
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -200,20 +199,19 @@ private void validateIdentityPartitionProjections(
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432507299
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,41 +53,36 @@
import org.apache.iceberg.types.Types;
import org.apache.
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432506498
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,41 +53,36 @@
import org.apache.iceberg.types.Types;
import org.apache.
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1432507642
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,41 +53,36 @@
import org.apache.iceberg.types.Types;
import org.apache.
cgpoh commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1863682637
> @cgpoh #9161 was just merged, can you please rebase this PR?
@nastra Thanks, will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message,
nastra commented on PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1862488848
@cgpoh https://github.com/apache/iceberg/pull/9161 was just merged, can you
please rebase this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1421376428
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -193,109 +192,106 @@ private static void assertEquals(
return;
}
-A
rodmeneses commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1420810926
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -523,89 +510,103 @@ public static void assertEquals(ManifestFile expected,
Manif
rodmeneses commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1420797428
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -193,109 +192,106 @@ private static void assertEquals(
return;
}
-
rodmeneses commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1420794807
##
data/src/test/java/org/apache/iceberg/data/GenAppenderHelper.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
nastra commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1420194979
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,37 +51,28 @@
import org.apache.iceberg.types.Types;
import org.apache.
pvary commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1419643002
##
data/src/test/java/org/apache/iceberg/data/GenAppenderHelper.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1418251955
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -483,7 +473,7 @@ private static void assertArrayValues(
private static void asser
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1418251447
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -523,89 +513,102 @@ public static void assertEquals(ManifestFile expected,
ManifestFi
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1418227381
##
data/src/test/java/org/apache/iceberg/data/GenAppenderHelper.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1416542177
##
data/src/test/java/org/apache/iceberg/data/GenAppenderHelper.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1416542497
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,37 +51,28 @@
import org.apache.iceberg.types.Types;
import org.apache.i
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1416540648
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java:
##
@@ -49,37 +51,28 @@
import org.apache.iceberg.types.Types;
import org.apache.i
cgpoh commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1416540362
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/HadoopCatResource.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
36 matches
Mail list logo
