Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on PR #9340: URL: https://github.com/apache/iceberg/pull/9340#issuecomment-1877413431 Merged! Thanks for getting this working @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
rdblue merged PR #9340: URL: https://github.com/apache/iceberg/pull/9340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1441709373 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident, Schema

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1441669272 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435220090 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435218641 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident, Schema

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435206411 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident, Schema

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435206166 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident, Schema

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435205674 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident, Schema

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435204168 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435202719 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435201928 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435200838 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435198050 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java: ## @@ -31,8 +31,10 @@ import org.apache.spark.sql.connector.catalog.SupportsNam

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435196601 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435195918 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/V2ViewDescription.scala: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435194286 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435193759 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435192720 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1435191468 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-22 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1434909916 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-21 Thread via GitHub
amogh-jahagirdar commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1434470861 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-21 Thread via GitHub
amogh-jahagirdar commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1434452595 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-21 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1434201832 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java: ## @@ -31,8 +31,10 @@ import org.apache.spark.sql.connector.catalog.SupportsNam

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-21 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1433987312 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-21 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1433985140 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432977949 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432924610 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432876466 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432875557 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432847330 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432844969 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432844267 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432837104 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432837381 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432702415 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432641334 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432640655 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432639249 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432638172 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432637760 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432637532 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/V2ViewDescription.scala: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432634448 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-20 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1432634448 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431863233 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431863233 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431861828 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431861467 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431854785 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431853526 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkCatalog.java: ## @@ -31,8 +31,10 @@ import org.apache.spark.sql.connector.catalog.SupportsNam

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431850234 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestBaseWithCatalog.java: ## @@ -87,7 +87,7 @@ public SparkTestBaseWithCatalog( config.forEach(

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431849001 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431848699 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431846400 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431845174 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431846020 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431842806 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431839691 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431834246 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431833263 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431831525 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431830077 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431824437 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431823108 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431821372 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/V2ViewDescription.scala: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431819566 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431818650 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
rdblue commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431816934 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431246337 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431246021 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431244634 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/logicalOperators.scala: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2023-12-19 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1431240041 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CreateViewAnalysis.scala: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Softwa