Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-19 Thread via GitHub
nastra merged PR #9161: URL: https://github.com/apache/iceberg/pull/9161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-15 Thread via GitHub
pvary commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1428116580 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -223,52 +219,33 @@ public void createInputFile() throws IOException {

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-14 Thread via GitHub
nastra commented on PR #9161: URL: https://github.com/apache/iceberg/pull/9161#issuecomment-1857383702 @Fokko @pvary could you review this one please? Once this is merged we can use it for https://github.com/apache/iceberg/pull/9185 -- This is an automated message from the Apache Git

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-13 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1425072357 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -223,52 +219,33 @@ public void createInputFile() throws IOException {

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-13 Thread via GitHub
GianlucaPrincipini commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1425003497 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -223,52 +219,33 @@ public void createInputFile() throws

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-12 Thread via GitHub
nastra commented on PR #9161: URL: https://github.com/apache/iceberg/pull/9161#issuecomment-1853420221 @GianlucaPrincipini the PR still contains more changes than necessary. The scope of this PR is to add the parameterized test extensions and the conversion of `TestDictRowGroupFilter`. Can

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-12 Thread via GitHub
nastra commented on PR #9161: URL: https://github.com/apache/iceberg/pull/9161#issuecomment-1851505751 @GianlucaPrincipini this PR now contains unfortunately more changes than I anticipated, so I would suggest to focus only on adding the `ParameterizedTestExtension` and converting

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-12 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423607969 ## data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java: ## @@ -43,18 +45,28 @@ public class GenericAppenderHelper { private final Table table;

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-12 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423607969 ## data/src/test/java/org/apache/iceberg/data/GenericAppenderHelper.java: ## @@ -43,18 +45,28 @@ public class GenericAppenderHelper { private final Table table;

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-12 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423603940 ## api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-12 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423602994 ## api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java: ## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-11 Thread via GitHub
GianlucaPrincipini commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1423154765 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -173,6 +178,60 @@ public static void assertSameSchemaMap(Map map1, Map

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-11 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1422771246 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -173,6 +178,60 @@ public static void assertSameSchemaMap(Map map1, Map

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-11 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1422771246 ## api/src/test/java/org/apache/iceberg/TestHelpers.java: ## @@ -173,6 +178,60 @@ public static void assertSameSchemaMap(Map map1, Map

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-11 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1422100956 ## api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-11 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1422099227 ## api/src/test/java/org/apache/iceberg/Parameter.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-11 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1422097196 ## LICENSE: ## @@ -323,3 +323,15 @@ This product includes code from Apache HttpComponents Client. Copyright: 1999-2022 The Apache Software Foundation. Home page:

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-09 Thread via GitHub
GianlucaPrincipini commented on PR #9161: URL: https://github.com/apache/iceberg/pull/9161#issuecomment-1848794660 Hi @nastra, I migrated `TestIcebergInputFormats` in MR module, which is a slightly more complex test class than `TestDictionaryRowGroupFilter`. I found some other class that

Re: [PR] Support parameterized tests at class-level with JUnit5 [iceberg]

2023-12-07 Thread via GitHub
nastra commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1419205681 ## api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or