[jira] [Created] (SOLR-14376) Optimize SolrIndexSearcher.getDocSet and getProcessedFilter for empty fq

2020-03-31 Thread David Smiley (Jira)
David Smiley created SOLR-14376: --- Summary: Optimize SolrIndexSearcher.getDocSet and getProcessedFilter for empty fq Key: SOLR-14376 URL: https://issues.apache.org/jira/browse/SOLR-14376 Project: Solr

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401318959 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@ -120,67

[GitHub] [lucene-solr] bringyou commented on issue #1389: LUCENE-9298: fix clearDeletedDocIds in BufferedUpdates

2020-03-31 Thread GitBox
bringyou commented on issue #1389: LUCENE-9298: fix clearDeletedDocIds in BufferedUpdates URL: https://github.com/apache/lucene-solr/pull/1389#issuecomment-606987371 @s1monw sorry to bother, but can you take a look? This is

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401313568 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@ -120,67

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401310167 ## File path: solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java ## @@ -228,12

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-03-31 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072269#comment-17072269 ] Chris M. Hostetter commented on SOLR-13132: --- {quote}The changes presented here now consist of:

[GitHub] [lucene-solr] MarcusSorealheis commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-03-31 Thread GitBox
MarcusSorealheis commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r401246229 ## File path: solr/bin/solr ## @@ -2089,6 +2089,14 @@ else SECURITY_MANAGER_OPTS=() fi +#

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072197#comment-17072197 ] Mike Drob commented on LUCENE-9266: --- Follow on issues identified so far: 1) Dawid's idea to stamp the

[GitHub] [lucene-solr] mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-606889736 @jpountz Thank you for the review. > I wonder whether we could make it easier to write implementations. I

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r401228325 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r401227871 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r401227632 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java

[jira] [Commented] (LUCENE-9170) wagon-ssh Maven HTTPS issue

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072149#comment-17072149 ] Mike Drob commented on LUCENE-9170: --- Sure, mine is very similar to [~ichattopadhyaya]'s patch. >

[jira] [Updated] (LUCENE-9170) wagon-ssh Maven HTTPS issue

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9170: -- Attachment: LUCENE-9170.patch > wagon-ssh Maven HTTPS issue > --- > >

[jira] [Updated] (LUCENE-9170) wagon-ssh Maven HTTPS issue

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9170: -- Attachment: (was: LUCENE-9170.patch) > wagon-ssh Maven HTTPS issue > ---

[jira] [Updated] (LUCENE-9170) wagon-ssh Maven HTTPS issue

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9170: -- Attachment: LUCENE-9170.patch > wagon-ssh Maven HTTPS issue > --- > >

[jira] [Updated] (SOLR-14265) Move collections admin API to v2 completely

2020-03-31 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta updated SOLR-14265: Summary: Move collections admin API to v2 completely (was: Move to admin API to v2 completely )

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r401172383 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r401166452 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r401165360 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r401164140 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r401163791 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
madrob commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r401163433 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[jira] [Commented] (SOLR-13579) Create resource management API

2020-03-31 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072035#comment-17072035 ] Andrzej Bialecki commented on SOLR-13579: - As explained above, in theory CoreContainer-level

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072034#comment-17072034 ] Dawid Weiss commented on LUCENE-9266: - bq. I'm not confident that running the java download class

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401059644 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401065312 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401059139 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401067383 ## File path: solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401064123 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401061433 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401063622 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

2020-03-31 Thread GitBox
cpoerschke commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401058472 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java ## @@

[jira] [Commented] (LUCENE-9170) wagon-ssh Maven HTTPS issue

2020-03-31 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071957#comment-17071957 ] Alan Woodward commented on LUCENE-9170: --- I'm hitting this in elasticsearch CI as well; [~mdrob]

[jira] [Commented] (LUCENE-9198) Remove news section from TLP website

2020-03-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071943#comment-17071943 ] Uwe Schindler commented on LUCENE-9198: --- Thanks! > Remove news section from TLP website >

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config

2020-03-31 Thread GitBox
HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config URL: https://github.com/apache/lucene-solr/pull/1392#discussion_r401045606 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config

2020-03-31 Thread GitBox
HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config URL: https://github.com/apache/lucene-solr/pull/1392#discussion_r401042663 ## File path:

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config

2020-03-31 Thread GitBox
HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config URL: https://github.com/apache/lucene-solr/pull/1392#discussion_r400993317 ## File path:

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config

2020-03-31 Thread GitBox
HoustonPutman commented on a change in pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config URL: https://github.com/apache/lucene-solr/pull/1392#discussion_r401042877 ## File path:

[jira] [Commented] (LUCENE-9198) Remove news section from TLP website

2020-03-31 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071905#comment-17071905 ] Alan Woodward commented on LUCENE-9198: --- I've removed the combined release messages > Remove news

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071889#comment-17071889 ] Mike Drob commented on LUCENE-9266: --- > but distribute source tarballs without it Where does the

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-03-31 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071887#comment-17071887 ] Mike Drob commented on LUCENE-9266: --- >  Seems like we can keep it in the repository (for convenience)

[jira] [Resolved] (SOLR-14273) Autoscaling "cores" tag should support "strict : false"

2020-03-31 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14273. - Resolution: Later I'm resolving this as Later - perhaps one day we need an explicit

[jira] [Comment Edited] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071852#comment-17071852 ] Jan Høydahl edited comment on SOLR-14014 at 3/31/20, 2:47 PM: -- Remember that

[jira] [Commented] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071852#comment-17071852 ] Jan Høydahl commented on SOLR-14014: Remember that the Admin UI is full of inter-links to other Solr

[jira] [Commented] (SOLR-11245) Cloud native Dockerfile

2020-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-11245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071846#comment-17071846 ] Jan Høydahl commented on SOLR-11245: Ok, I dumped a branch I had lying around into PR

[GitHub] [lucene-solr] janhoy opened a new pull request #1393: SOLR-11245 Cloud native Dockerfile

2020-03-31 Thread GitBox
janhoy opened a new pull request #1393: SOLR-11245 Cloud native Dockerfile URL: https://github.com/apache/lucene-solr/pull/1393 See https://issues.apache.org/jira/browse/SOLR-11245 This is a fork of Solr's official Dockerfile, simplified for quickly building local image. Very much

[jira] [Commented] (SOLR-14371) Zk StatusHandler should know about dynamic zk config

2020-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071840#comment-17071840 ] Jan Høydahl commented on SOLR-14371: Ok, first PR draft is out

[GitHub] [lucene-solr] janhoy opened a new pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config

2020-03-31 Thread GitBox
janhoy opened a new pull request #1392: SOLR-14371 Zk StatusHandler should know about dynamic zk config URL: https://github.com/apache/lucene-solr/pull/1392 See https://issues.apache.org/jira/browse/SOLR-14371 Still draft

[jira] [Commented] (LUCENE-9280) Add ability to skip non-competitive documents on field sort

2020-03-31 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071835#comment-17071835 ] Adrien Grand commented on LUCENE-9280: -- I was just talking about it with Jim earlier today. I think

[jira] [Commented] (SOLR-9575) Initialize an empty solr-home

2020-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071811#comment-17071811 ] Jan Høydahl commented on SOLR-9575: --- So, time passes. We've worked around this both in docker-solr and

[jira] [Commented] (LUCENE-9280) Add ability to skip non-competitive documents on field sort

2020-03-31 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071799#comment-17071799 ] Mayya Sharipova commented on LUCENE-9280: - [~jpountz]  Thanks Adrien for the explanation about

[jira] [Commented] (SOLR-7871) Platform independent config file instead of solr.in.sh and solr.in.cmd

2020-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071773#comment-17071773 ] Jan Høydahl commented on SOLR-7871: --- Agree. My vision is that once we get a solr.jar with a

[jira] [Commented] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-03-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071747#comment-17071747 ] Uwe Schindler commented on SOLR-14014: -- IMHO, optionally disabling the admin UI is a good thing. Of

[jira] [Comment Edited] (LUCENE-9221) Lucene Logo Contest

2020-03-31 Thread Jeremy Novey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071718#comment-17071718 ] Jeremy Novey edited comment on LUCENE-9221 at 3/31/20, 12:10 PM: -

[jira] [Commented] (LUCENE-9221) Lucene Logo Contest

2020-03-31 Thread Jeremy Novey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071718#comment-17071718 ] Jeremy Novey commented on LUCENE-9221: -- [~DHAVER0313]- any chance you could change the bottom half

[jira] [Resolved] (LUCENE-9256) Raise Lucene Webpage's HSTS max-age to 1 year

2020-03-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9256. --- Resolution: Fixed I committed it, but used wrong issue number (LUCENE-9227):

[jira] [Commented] (SOLR-14014) Allow Solr to start with Admin UI disabled

2020-03-31 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071695#comment-17071695 ] Jason Gerlowski commented on SOLR-14014: Thanks for putting a patch together for this Marcus.

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-03-31 Thread GitBox
gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r400839031 ## File path: solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java ## @@ -33,20 +34,34

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-03-31 Thread GitBox
gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r400837339 ## File path: solr/bin/solr ## @@ -2089,6 +2089,14 @@ else SECURITY_MANAGER_OPTS=() fi +#

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag

2020-03-31 Thread GitBox
gerlowskija commented on a change in pull request #1391: SOLR-14014 Add a disable Admin UI Flag URL: https://github.com/apache/lucene-solr/pull/1391#discussion_r400834539 ## File path: solr/CHANGES.txt ## @@ -8,6 +8,13 @@

[GitHub] [lucene-solr] s1monw commented on issue #1361: LUCENE-8118: Throw exception if DWPT grows beyond it's maximum ram limit

2020-03-31 Thread GitBox
s1monw commented on issue #1361: LUCENE-8118: Throw exception if DWPT grows beyond it's maximum ram limit URL: https://github.com/apache/lucene-solr/pull/1361#issuecomment-606555768 > Another thing we could consider is changing DWPT's postings addressing from int to long so we don't need

[jira] [Commented] (SOLR-7871) Platform independent config file instead of solr.in.sh and solr.in.cmd

2020-03-31 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071676#comment-17071676 ] Jason Gerlowski commented on SOLR-7871: --- The scripts/include files are a huge testing gap, source of

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400816894 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400814597 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400803187 ## File path: .github/workflows/gradle-precommit.yml ## @@ -19,5 +19,8 @@ jobs:

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400800461 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400788511 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400780360 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400780360 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[jira] [Commented] (SOLR-14365) CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values

2020-03-31 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071619#comment-17071619 ] Cao Manh Dat commented on SOLR-14365: - [~jbernste] [~shalin] please take a look at the patch. >

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400739959 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400736631 ## File path: lucene/core/src/java/org/apache/lucene/search/ConstantScoreQuery.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400741063 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-03-31 Thread GitBox
jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r400739533 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400756154 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[jira] [Commented] (SOLR-14365) CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values

2020-03-31 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071610#comment-17071610 ] Cao Manh Dat commented on SOLR-14365: - Attached a WIP patch that includes * seperate out the logic

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400751491 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[jira] [Updated] (SOLR-14365) CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values

2020-03-31 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao Manh Dat updated SOLR-14365: Attachment: SOLR-14365.patch > CollapsingQParser - Avoiding always allocate int[] and float[] with

[GitHub] [lucene-solr] dweiss commented on issue #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on issue #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#issuecomment-606473807 I like the direction, Mike. If we can keep gradle wrapper jar in the repository (see that comment on legal jira) then this patch

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400724627 ## File path: gradlew.bat ## @@ -81,6 +81,12 @@ set CMD_LINE_ARGS=%* set

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400723323 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400721876 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400719401 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400721515 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1390: LUCENE-9266 remove gradle wrapper jar from source URL: https://github.com/apache/lucene-solr/pull/1390#discussion_r400718042 ## File path: buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java ## @@

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400716712 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400715656 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-31 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400712704 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-31 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400712562 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperReadTest.java ##

[jira] [Commented] (LUCENE-9280) Add ability to skip non-competitive documents on field sort

2020-03-31 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071550#comment-17071550 ] Adrien Grand commented on LUCENE-9280: -- Woohoo. I can try to give a little more background about

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-31 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400704740 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-31 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400704943 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZookeeperRead.java ## @@

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-03-31 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r400704740 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400699833 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-03-31 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r400682318 ## File path: gradle/render-javadoc.gradle ## @@ -15,93